Bug#631639: __unused in libbsd. workaround for #522773 (linux) and #522774 (libc)
El 2 de gener de 2012 4:27, Guillem Jover guil...@debian.org ha escrit: I think this crosses my threshold of something acceptable for libbsd. What I've done instead is prepare and send patches to Linux and glibc upstream, which is the correct fix on this issue IMO: The Linux patch is submitted and in ignore queue since 2009: https://bugzilla.kernel.org/show_bug.cgi?id=14186 If you're lucky, maybe your retry gets Linux fixed. I wouldn't hold my breath with Drepper though. Anyway, no harm in retrying, it can't get any worse than http://sourceware.org/bugzilla/show_bug.cgi?id=4980 Maybe aiming at EGLIBC would be better? -- Robert Millan -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caofdtxmpqrn2tenlbjudi6jcduxnqtd12qkawyoas66smx7...@mail.gmail.com
Bug#631639: __unused in libbsd. workaround for #522773 (linux) and #522774 (libc)
Robert Millan wrote: The Linux patch is submitted and in ignore queue since 2009: https://bugzilla.kernel.org/show_bug.cgi?id=14186 I don't see a patch there. Anyway, using kernel bugzilla is not a way to get anyone to actually do anything. The best you can hope for is that someone will eventually forward your report as an email. A better strategy is generally to write a patch, find the relevant maintainers in the MAINTAINERS file or changelog and cc them (see “6) Select your CC (e-mail carbon copy) list” in Documentation/SubmittingPatches), resend as appropriate if they forget about it, and act on their comments. For the case at hand: upstream seems interested: http://thread.gmane.org/gmane.linux.kernel/1234225/focus=2410 If someone wants to chisel away at this (e.g., starting with icmp.h and sysctl.h, then x86 or mips) following Sam's advice, I'll be happy. Glad to see this doesn't seem to be stalled any more. Jonathan -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120103185755.gl21...@elie.hsd1.il.comcast.net
Bug#631639: __unused in libbsd. workaround for #522773 (linux) and #522774 (libc)
Robert Millan dixit: Maybe aiming at EGLIBC would be better? EGLIBC refused this because it would distance them from GLIBC. Even when I suggested to run this as ed/sed/perl -pie/whatever during header installation time. *sigh*, //mirabilos -- 22:20⎜asarch The crazy that persists in his craziness becomes a master 22:21⎜asarch And the distance between the craziness and geniality is only measured by the success 18:35⎜asarch Psychotics are consistently inconsistent. The essence of sanity is to be inconsistently inconsistent -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/pine.bsm.4.64l.1201031850230.16...@herc.mirbsd.org
Bug#631639: __unused in libbsd. workaround for #522773 (linux) and #522774 (libc)
Guillem Jover dixit: What I've done instead is prepare and send patches to Linux and glibc upstream, which is the correct fix on this issue IMO: I’ve sent suggestions like these years ago. Let’s hope they’ll accept it this time. Thanks, //mirabilos -- “Having a smoking section in a restaurant is like having a peeing section in a swimming pool.” -- Edward Burr -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/pine.bsm.4.64l.1201021032250@herc.mirbsd.org
Bug#631639: __unused in libbsd. workaround for #522773 (linux) and #522774 (libc)
On Mon, 2012-01-02 at 04:27:54 +0100, Guillem Jover wrote: On Sat, 2011-06-25 at 19:06:48 +0200, Robert Millan wrote: Package: libbsd-dev Version: 0.3.0-1 Severity: wishlist Tags: patch User: debian-bsd@lists.debian.org Usertags: kfreebsd This patch implements a workaround for __unused name collision with Linux and Glibc. The trick is to define __unused only when in overlay mode, and then provide replacements for broken headers using the overlay. I think this crosses my threshold of something acceptable for libbsd. What I've done instead is prepare and send patches to Linux and glibc upstream, which is the correct fix on this issue IMO: http://marc.info/?l=linux-kernelm=132547276312101w=2 http://www.cygwin.com/ml/libc-ports/2012-01/msg0.html The one on libc-alpha is not yet visible though. Let's see how these go. Now visible at: http://sourceware.org/ml/libc-alpha/2012-01/msg1.html thanks, guillem -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120102213143.ga5...@gaara.hadrons.org
Bug#631639: __unused in libbsd. workaround for #522773 (linux) and #522774 (libc)
Hi! On Sat, 2011-06-25 at 19:06:48 +0200, Robert Millan wrote: Package: libbsd-dev Version: 0.3.0-1 Severity: wishlist Tags: patch User: debian-bsd@lists.debian.org Usertags: kfreebsd This patch implements a workaround for __unused name collision with Linux and Glibc. The trick is to define __unused only when in overlay mode, and then provide replacements for broken headers using the overlay. I think this crosses my threshold of something acceptable for libbsd. What I've done instead is prepare and send patches to Linux and glibc upstream, which is the correct fix on this issue IMO: http://marc.info/?l=linux-kernelm=132547276312101w=2 http://www.cygwin.com/ml/libc-ports/2012-01/msg0.html The one on libc-alpha is not yet visible though. Let's see how these go. thanks, guillem -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120102032754.ga11...@gaara.hadrons.org
Re: Bug#631639: __unused in libbsd. workaround for #522773 (linux) and #522774 (libc)
El 31 de desembre de 2011 4:40, Thorsten Glaser t...@mirbsd.de ha escrit: Yes, but (a) not for their own stuff but to replace the GNU one which has a bootstrapping issue wrt. libglib nowadays (BSD ports start from a base OS system and compile everything from source on each installation), and (b) my MirCoDeveloper says it doesn’t work right anyway. How does any of this help with solving #631639? Maybe someone could comment on the patch I sent 6 months ago? I couldn't care less about pkg-config. I'd rather have this problem solved so we can get rid of that 2337-line patch in freebsd-utils. -- Robert Millan -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caofdtxmfxwdpt-+iw6wnjwvrntyc3c3hol4mn2hyngwuty3...@mail.gmail.com
Bug#631639: __unused in libbsd. workaround for #522773 (linux) and #522774 (libc)
On Sat, 2011-06-25 at 17:24:00 +, Thorsten Glaser wrote: That won’t help. The overlay mode uses pkg-config which no BSD thing touches. Well, even OpenBSD has its own re-implementation: http://www.openbsd.org/cgi-bin/man.cgi?query=pkg-configsektion=1format=html regards, guillem -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20111231013742.ga23...@gaara.hadrons.org
Bug#631639: __unused in libbsd. workaround for #522773 (linux) and #522774 (libc)
Package: libbsd-dev Version: 0.3.0-1 Severity: wishlist Tags: patch User: debian-bsd@lists.debian.org Usertags: kfreebsd This patch implements a workaround for __unused name collision with Linux and Glibc. The trick is to define __unused only when in overlay mode, and then provide replacements for broken headers using the overlay. -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: kfreebsd-amd64 (x86_64) Kernel: kFreeBSD 8.2-1-amd64 Locale: LANG=ca_AD.UTF-8, LC_CTYPE=ca_AD.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages libbsd-dev depends on: ii libbsd0 0.3.0-1utility functions from BSD systems libbsd-dev recommends no packages. libbsd-dev suggests no packages. -- no debconf information diff -Nur libbsd-0.3.0/include/bsd/aio.h libbsd-0.3.0.new/include/bsd/aio.h --- libbsd-0.3.0/include/bsd/aio.h 1970-01-01 01:00:00.0 +0100 +++ libbsd-0.3.0.new/include/bsd/aio.h 2011-06-25 18:54:20.398388435 +0200 @@ -0,0 +1,3 @@ +#undef __unused +#include_next aio.h +#include sys/cdefs.h diff -Nur libbsd-0.3.0/include/bsd/asm/stat.h libbsd-0.3.0.new/include/bsd/asm/stat.h --- libbsd-0.3.0/include/bsd/asm/stat.h 1970-01-01 01:00:00.0 +0100 +++ libbsd-0.3.0.new/include/bsd/asm/stat.h 2011-06-25 18:58:50.515051926 +0200 @@ -0,0 +1,3 @@ +#undef __unused +#include_next asm/stat.h +#include sys/cdefs.h diff -Nur libbsd-0.3.0/include/bsd/bits/stat.h libbsd-0.3.0.new/include/bsd/bits/stat.h --- libbsd-0.3.0/include/bsd/bits/stat.h 1970-01-01 01:00:00.0 +0100 +++ libbsd-0.3.0.new/include/bsd/bits/stat.h 2011-06-25 18:54:20.398388435 +0200 @@ -0,0 +1,3 @@ +#undef __unused +#include_next bits/stat.h +#include sys/cdefs.h diff -Nur libbsd-0.3.0/include/bsd/bits/utmp.h libbsd-0.3.0.new/include/bsd/bits/utmp.h --- libbsd-0.3.0/include/bsd/bits/utmp.h 1970-01-01 01:00:00.0 +0100 +++ libbsd-0.3.0.new/include/bsd/bits/utmp.h 2011-06-25 18:54:20.398388435 +0200 @@ -0,0 +1,3 @@ +#undef __unused +#include_next bits/utmp.h +#include sys/cdefs.h diff -Nur libbsd-0.3.0/include/bsd/bits/utmpx.h libbsd-0.3.0.new/include/bsd/bits/utmpx.h --- libbsd-0.3.0/include/bsd/bits/utmpx.h 1970-01-01 01:00:00.0 +0100 +++ libbsd-0.3.0.new/include/bsd/bits/utmpx.h 2011-06-25 18:54:20.398388435 +0200 @@ -0,0 +1,3 @@ +#undef __unused +#include_next bits/utmpx.h +#include sys/cdefs.h diff -Nur libbsd-0.3.0/include/bsd/linux/icmp.h libbsd-0.3.0.new/include/bsd/linux/icmp.h --- libbsd-0.3.0/include/bsd/linux/icmp.h 1970-01-01 01:00:00.0 +0100 +++ libbsd-0.3.0.new/include/bsd/linux/icmp.h 2011-06-25 18:58:53.870548764 +0200 @@ -0,0 +1,3 @@ +#undef __unused +#include_next linux/icmp.h +#include sys/cdefs.h diff -Nur libbsd-0.3.0/include/bsd/linux/sysctl.h libbsd-0.3.0.new/include/bsd/linux/sysctl.h --- libbsd-0.3.0/include/bsd/linux/sysctl.h 1970-01-01 01:00:00.0 +0100 +++ libbsd-0.3.0.new/include/bsd/linux/sysctl.h 2011-06-25 18:58:58.855057851 +0200 @@ -0,0 +1,3 @@ +#undef __unused +#include_next linux/sysctl.h +#include sys/cdefs.h diff -Nur libbsd-0.3.0/include/bsd/netdb.h libbsd-0.3.0.new/include/bsd/netdb.h --- libbsd-0.3.0/include/bsd/netdb.h 1970-01-01 01:00:00.0 +0100 +++ libbsd-0.3.0.new/include/bsd/netdb.h 2011-06-25 18:54:20.398388435 +0200 @@ -0,0 +1,3 @@ +#undef __unused +#include_next netdb.h +#include sys/cdefs.h diff -Nur libbsd-0.3.0/include/bsd/sys/cdefs.h libbsd-0.3.0.new/include/bsd/sys/cdefs.h --- libbsd-0.3.0/include/bsd/sys/cdefs.h 2011-05-28 10:58:26.0 +0200 +++ libbsd-0.3.0.new/include/bsd/sys/cdefs.h 2011-06-25 19:01:26.494054843 +0200 @@ -24,9 +24,6 @@ * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#ifndef LIBBSD_SYS_CDEFS_H -#define LIBBSD_SYS_CDEFS_H - #ifdef LIBBSD_OVERLAY #include_next sys/cdefs.h #else @@ -43,11 +40,13 @@ #define _SYS_CDEFS_H #endif +#ifndef LIBBSD_GCC_VERSION #ifdef __GNUC__ #define LIBBSD_GCC_VERSION (__GNUC__ 8 | __GNUC_MINOR__) #else #define LIBBSD_GCC_VERSION 0 #endif +#endif #ifndef __dead2 # if LIBBSD_GCC_VERSION = 0x0207 @@ -83,8 +82,8 @@ /* Linux headers define a struct with a member names __unused. * Debian bugs: #522773 (linux), #522774 (libc). - * Disable for now. */ -#if 0 + * Enable only in overlay mode, where this can be worked around. */ +#ifdef LIBBSD_OVERLAY #ifndef __unused # if LIBBSD_GCC_VERSION = 0x0300 # define __unused __attribute__((unused)) @@ -137,5 +136,3 @@ #ifndef __COPYRIGHT # define __COPYRIGHT(x) #endif - -#endif
Bug#631639: __unused in libbsd. workaround for #522773 (linux) and #522774 (libc)
Robert Millan dixit: This patch implements a workaround for __unused name collision with Linux and Glibc. The trick is to define __unused only when in overlay mode, and then That won’t help. The overlay mode uses pkg-config which no BSD thing touches. bye, //mirabilos -- Support mksh as /bin/sh and RoQA dash NOW! ‣ src:bash (256 (275) bugs: 0 RC, 177 (192) IN, 79 (83) MW, 0 FP) ‣ src:dash (81 (89) bugs: 3 RC, 43 (46) IN, 35 (40) MW, 0 FP) ‣ src:mksh (2 bugs: 0 RC, 0 IN, 2 MW, 0 FP) -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/pine.bsm.4.64l.1106251723290.32...@herc.mirbsd.org
Bug#631639: __unused in libbsd. workaround for #522773 (linux) and #522774 (libc)
2011/6/25 Thorsten Glaser t...@mirbsd.de: That won’t help. The overlay mode uses pkg-config which no BSD thing touches. pkg-config can be invoked from debian/rules. It's already used in freebsd-libs and freebsd-utils. It's trivial and non-intrusive, see: http://anonscm.debian.org/viewvc/glibc-bsd/trunk/freebsd-libs/debian/rules?r1=3368r2=3429 -- Robert Millan -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/banlktimdsrf3tiamhp+gqs2dus4vgxl...@mail.gmail.com
