Processed: Bug#653929: Bug #696119 probably has the fix to this bug
Processing commands for cont...@bugs.debian.org: > found 653929 zfsutils/10.1~svn271683-1 Bug #653929 [libzfs1] "zpool status" reports bogus string for RAID-Z (breaks GRUB) Bug #696119 [libzfs1] `zpool status` incorrectly names raidz vdevs Marked as found in versions zfsutils/10.1~svn271683-1. Marked as found in versions zfsutils/10.1~svn271683-1. > thanks Stopping processing here. Please contact me if you need assistance. -- 653929: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653929 696119: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696119 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.c.141116376618527.transcr...@bugs.debian.org
Bug#653929: Bug #696119 probably has the fix to this bug
found zfsutils/10.1~svn271683-1 thanks Wow, we still didn't fix this yet. Regards, -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/541ca543.4000...@pyro.eu.org
Bug#653929: Bug #696119 probably has the fix to this bug
On Mon, Dec 17, 2012 at 02:24:42AM +, Steven Chamberlain wrote: > Originally in #653929 it was said that this bug breaks GRUB in some way, > and could prevent use of RAID-Z as a root filesystem; do you know if > that is true? Unfortunately, I don't know the answer to this. I am booting from a mirrored pool and storing most of my data on a raidz pool. (in part because I thought raidz booting was not supported) I have never tried to boot from a raidz pool in freebsd or with grub. However, I note that booting from raidz is in the NEWS file for grub2 2.00-7 (sid) but not 1.99-23 (squeeze), so I think that trouble booting from raidz probably stems from grub, not from this problem in zpool / libzfs. To the original poster I'd suggest seeing whether grub2 2.00-7 from sid enables booting from raidz... Jeff -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121217033042.gc18...@unpythonic.net
Processed: Re: Bug#653929: Bug #696119 probably has the fix to this bug
Processing commands for cont...@bugs.debian.org: > # sorry, almost there... > reassign 653929 libzfs1 Bug #653929 [zfsutils] "zpool status" reports bogus string for RAID-Z (breaks GRUB) Bug reassigned from package 'zfsutils' to 'libzfs1'. No longer marked as found in versions zfsutils/8.3~svn226546-6. Ignoring request to alter fixed versions of bug #653929 to the same values previously set > found 696119 8.3~svn226546-6 Bug #696119 [libzfs1] `zpool status` incorrectly names raidz vdevs Marked as found in versions zfsutils/8.3~svn226546-6. > forcemerge 696119 653929 Bug #696119 [libzfs1] `zpool status` incorrectly names raidz vdevs Bug #653929 [libzfs1] "zpool status" reports bogus string for RAID-Z (breaks GRUB) Marked as found in versions zfsutils/9.0-3 and zfsutils/8.3~svn226546-6. Added tag(s) patch. Merged 653929 696119 > thanks Stopping processing here. Please contact me if you need assistance. -- 653929: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653929 696119: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696119 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.135571259829445.transcr...@bugs.debian.org
Re: Bug#653929: Bug #696119 probably has the fix to this bug
# sorry, almost there... reassign 653929 libzfs1 found 696119 8.3~svn226546-6 forcemerge 696119 653929 thanks -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/50ce884d.3080...@pyro.eu.org
Processed (with 2 errors): Re: Bug#653929: Bug #696119 probably has the fix to this bug
Processing commands for cont...@bugs.debian.org:
> # reassigning bugs to the same package and trying again...
> reassign 653929 libzfs1/8.3~svn226546-6
Unknown command or malformed arguments to command.
> forcemerge 696119 653929
Bug #696119 [libzfs1] `zpool status` incorrectly names raidz vdevs
Unable to merge bugs because:
package of #653929 is 'zfsutils' not 'libzfs1'
Failed to forcibly merge 696119: Did not alter merged bugs
Debbugs::Control::set_merged('transcript', 'GLOB(0x2adb730)',
'requester', 'Steven Chamberlain ', 'request_addr',
'cont...@bugs.debian.org', 'request_msgid', '<50ce8764.3050...@pyro.eu.org>',
'request_subject', ...) called at
/usr/local/lib/site_perl/Debbugs/Control/Service.pm line 552
eval {...} called at
/usr/local/lib/site_perl/Debbugs/Control/Service.pm line 551
Debbugs::Control::Service::control_line('line', undef, 'clonebugs',
'HASH(0x2a52160)', 'limit', 'HASH(0x2a51b48)', 'common_control_options',
'ARRAY(0x2a51b90)', 'errors', ...) called at /usr/lib/debbugs/service line 474
> thanks
Stopping processing here.
Please contact me if you need assistance.
--
653929: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653929
696119: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696119
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/handler.s.c.135571236528427.transcr...@bugs.debian.org
Re: Bug#653929: Bug #696119 probably has the fix to this bug
# reassigning bugs to the same package and trying again... reassign 653929 libzfs1/8.3~svn226546-6 forcemerge 696119 653929 thanks -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/50ce8764.3050...@pyro.eu.org
Processed (with 1 errors): Re: Bug#653929: Bug #696119 probably has the fix to this bug
Processing commands for cont...@bugs.debian.org:
> severity 696119 important
Bug #696119 [libzfs1] `zpool status` incorrectly names raidz vdevs
Severity set to 'important' from 'normal'
> forcemerge 696119 653929
Bug #696119 [libzfs1] `zpool status` incorrectly names raidz vdevs
Unable to merge bugs because:
package of #653929 is 'zfsutils' not 'libzfs1'
Failed to forcibly merge 696119: Did not alter merged bugs
Debbugs::Control::set_merged('transcript', 'GLOB(0x24f6ee0)',
'requester', 'Steven Chamberlain ', 'request_addr',
'cont...@bugs.debian.org', 'request_msgid', '<50ce826a.6050...@pyro.eu.org>',
'request_subject', ...) called at
/usr/local/lib/site_perl/Debbugs/Control/Service.pm line 552
eval {...} called at
/usr/local/lib/site_perl/Debbugs/Control/Service.pm line 551
Debbugs::Control::Service::control_line('line', 'forcemerge 696119
653929', 'clonebugs', 'HASH(0x2455160)', 'limit', 'HASH(0x2454b48)',
'common_control_options', 'ARRAY(0x2454b90)', 'errors', ...) called at
/usr/lib/debbugs/service line 474
> thanks
Stopping processing here.
Please contact me if you need assistance.
--
653929: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653929
696119: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696119
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/handler.s.c.135571109720623.transcr...@bugs.debian.org
Re: Bug#653929: Bug #696119 probably has the fix to this bug
severity 696119 important forcemerge 696119 653929 thanks Hello, On 17/12/12 02:00, Jeff Epler wrote: > Today I filed a bug about this same problem, having found this earlier > report too late. I believe the patch on bug #696119 will address this > problem (which is not seen on freebsd due to libc differences). I saw this, and thought it sounded familiar. Good work finding a fix for this over at zfsonlinux. Originally in #653929 it was said that this bug breaks GRUB in some way, and could prevent use of RAID-Z as a root filesystem; do you know if that is true? > As I'm a newbie at the debian bugtracker I'm not sure how to merge the > two bugs, or even if that's how it's done here. I've Bcc:'d this mail to cont...@bugs.debian.org, with commands at the top to hopefully do this. If you're interested you can read all about it at http://www.debian.org/Bugs/server-control Thanks a lot! Regards, -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/50ce826a.6050...@pyro.eu.org
Bug#653929: Bug #696119 probably has the fix to this bug
Tags: patch
Today I filed a bug about this same problem, having found this earlier
report too late. I believe the patch on bug #696119 will address this
problem (which is not seen on freebsd due to libc differences).
As I'm a newbie at the debian bugtracker I'm not sure how to merge the
two bugs, or even if that's how it's done here. I hope I'm not doing
ill by repeating my patch here.
Index: zfsutils-9.0/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c
===
--- zfsutils-9.0.orig/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c
2012-12-16 12:15:18.0 -0600
+++ zfsutils-9.0/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c
2012-12-16 13:11:34.171723989 -0600
@@ -3087,6 +3087,8 @@
(void) ioctl(zhp->zpool_hdl->libzfs_fd, ZFS_IOC_VDEV_SETPATH, &zc);
}
+#definePATH_BUF_LEN64
+
/*
* Given a vdev, return the name to display in iostat. If the vdev has a path,
* we use that, stripping off any leading "/dev/dsk/"; if not, we use the type.
@@ -3108,7 +3110,8 @@
{
char *path, *devid;
uint64_t value;
- char buf[64];
+ char buf[PATH_BUF_LEN];
+ char tmpbuf[PATH_BUF_LEN];
vdev_stat_t *vs;
uint_t vsc;
int have_stats;
@@ -3204,6 +3207,7 @@
* If it's a raidz device, we need to stick in the parity level.
*/
if (strcmp(path, VDEV_TYPE_RAIDZ) == 0) {
+
verify(nvlist_lookup_uint64(nv, ZPOOL_CONFIG_NPARITY,
&value) == 0);
(void) snprintf(buf, sizeof (buf), "%s%llu", path,
@@ -3220,9 +3224,9 @@
verify(nvlist_lookup_uint64(nv, ZPOOL_CONFIG_ID,
&id) == 0);
- (void) snprintf(buf, sizeof (buf), "%s-%llu", path,
- (u_longlong_t)id);
- path = buf;
+ (void) snprintf(tmpbuf, sizeof (tmpbuf), "%s-%llu",
+ path, (u_longlong_t)id);
+ path = tmpbuf;
}
}
--
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121217020004.gb18...@unpythonic.net
