Re: Re: Bug#675845: adanaxisgpl: FTBFS:

2012-11-30 Thread Guillem Jover
Hi!

On Fri, 2012-11-30 at 03:26:49 +, Steven Chamberlain wrote:
 Control: found -1 1.2.5.dfsg.1-4.1
 Control: tags -1 + patch

 The problem is a '#define off_t long', which causes a problem later when
 GNU/kFreeBSD headers include sys/types.h (again), and try to redefine
 off_t for some reason.
 
 That only happens because HAVE_OFF_T isn't being set in config.h.  In
 fact it is hard-coded to 0 by default and set to 1 on certain supported
 platforms such as Mac OS X (in rubyconfigure.h).


 With the patch below, then running:
 
 $ aclocal-1.10  autoheader  autoconf
 
 implements a proper detection for off_t and it builds now on
 kfreebsd-amd64.  Also it still builds okay and runs on GNU/Linux amd64.
 
 --- a/configure.in  2007-10-25 21:38:55.0 +0100
 +++ b/configure.in  2012-11-30 02:01:34.039114307 +
 @@ -288,6 +288,8 @@
  ])
  ])
  
 +AC_CHECK_TYPES([off_t], [], [], [[#include sys/types.h]])
 +

I guess ideally the code would be using AC_TYPE_OFF_T, but as you
mention that the code depends on HAVE_OFF_T, then this might be the
smallest change to accomplish the same thing.

Thanks,
Guillem


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121130083531.ga24...@gaara.hadrons.org



Re: Re: Bug#675845: adanaxisgpl: FTBFS:

2012-11-29 Thread Steven Chamberlain
Control: found -1 1.2.5.dfsg.1-4.1
Control: tags -1 + patch

Hi,

On 14:54, Felix Geyer wrote:
 Are you sure that you have built 1.2.5.dfsg.1-4.1 and not
 1.2.5.dfsg.1-4 since the compiler command line should contain
 -fpermissive?

I could reproduce the same build failure in this version with
-fpermissive

The problem is a '#define off_t long', which causes a problem later when
GNU/kFreeBSD headers include sys/types.h (again), and try to redefine
off_t for some reason.

That only happens because HAVE_OFF_T isn't being set in config.h.  In
fact it is hard-coded to 0 by default and set to 1 on certain supported
platforms such as Mac OS X (in rubyconfigure.h).

Linux headers presumably don't redefine off_t so it doesn't usually
matter.


With the patch below, then running:

$ aclocal-1.10  autoheader  autoconf

implements a proper detection for off_t and it builds now on
kfreebsd-amd64.  Also it still builds okay and runs on GNU/Linux amd64.

--- a/configure.in  2007-10-25 21:38:55.0 +0100
+++ b/configure.in  2012-11-30 02:01:34.039114307 +
@@ -288,6 +288,8 @@
 ])
 ])
 
+AC_CHECK_TYPES([off_t], [], [], [[#include sys/types.h]])
+
 LIBS=$LIBS $SDL_EXTRA_LIBS
 
 AC_OUTPUT(Makefile src/Makefile data-adanaxis/Makefile)


Thank you!
Regards,
-- 
Steven Chamberlain
ste...@pyro.eu.org


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121130032648.ga17...@squeeze.pyro.eu.org