date:20140801

Bug#747816: Review openalpr

2014-08-01 Thread Tobias Frost

Hallo Stefan,

as promised some weeks ago, here's your review :)

Here's an (unordered) list of thing I found during checking your
package. Maybe you want to check them if they are valid and correct
them? 

I just saw that the ITP is not owned by you. Did you coordinate with the
one filing the ITP? (If so, you should document it there, if not you
should ask Matt Hill if he intends to to the packaging or not... The
bug's text is not clear here.)

- Upstream released in the meantime 1.1.1 ... Can you update your
package to the latest version?

- The tarball does not match the upstream tarball.
7585916d11fef3ea88bba3249e839524  ../openalpr_1.1.0.orig.tar.gz
d1446343788a52514e78afd33b73fe66  /home/tobi/Downloads/openalpr-1.1.0.tar.gz
(Did you directly pull from the repository -- as there was a .git
directory in it?)

- d/README.source --  I think you don't need this file, let it go... :)

- d/patches/* -- please add a dep3 header; does it make sense to send
the patch upstream?

- d/control -- as you are building a library I miss somehow a -dev
package... Also the package description of the binary package openalpr
needs to explain a little better what this package is for. Currently it
only describes the libary, not the tool(s) you could find in the
package.

- d/copyright is incomplete and should be of the machine-readable
debian/copyright file format (dep5)
(licensecheck and /usr/lib/cdbs/licensecheck2dep5 can help you here, but
you need anyway to check every file.. 

- any reason not to enable multiarch for the lib?   

- when building you should instruct cmake to be verbose (e.g show the
complete gcc commandline... (I think you just need to make VERBOSE=1)
in d/rules)

- the package does not build in a pdebuilder enviorment 
(chrpath not found; missing B-D?) Is chrpath really needed?

- symbol files for c++ libraries are IMHO a little bit fragile and after
installing chrpath it failed here. So you need to work on those or drop
the symbol file for this moment)

- you manually have a lots of manually added library dependencies on the
binary packge --- are they needed? Shouldn't be shlibs:depends enough
find the needed dependencies?

nitpicks:
- d/* -- I suggest to use wrap-and-sort to sort e.g the dependencies.

- d/control -- there are some trailing white-spaces you should remove
  (wrap-and-sort will do it for you)

- There are many could avoid a useless dependency warnings... Can you
check if a --as-needed linker option would work?

Ok, thats it for now. Thanks for working on the package, it's looks like
a quite tricky package to do :)

--
tobi


signature.asc
Description: This is a digitally signed message part

Bug#756729: [DSE-Dev] Bug#756729: selinux-policy-default: Setting SELinux to enforce results in not configured network interface at boot time

2014-08-01 Thread Mika Pflüger

Hi Andre,

most interesting is the output of semodule -l. SELinux refpolicy is
modular, so that you only have to load the policy for the programs you
actually use. Note that in your case you have loaded only some select
modules, pretty much a minimal set of modules, which will provide only
very basic functionality.
Upon installation, the selinux-policy-default package in stable tries to
guess which modules you could need and installs those. If you then
install other software afterwards, you have to enable other modules
yourself.
To enable the dhcp module (which hopefully will fix your problem), use:
# semodule -i /usr/share/selinux/default/dhcp.pp
you will find all available modules in /usr/share/selinux/default/,
just check which one sounds like you need it. You can also install all
of them and then selectively disable some using
# semodule -d dhcp
(or equivalent for other module names, see semodule(8)), which is often
easier.

Note that having loaded too many modules usually only means selinux
is not as effective in preventing acceses (if e.g. you don't have an
ftp server installed, there is no need to allow ftp access), but it
usually will not do much harm.

We recognise that this situation (minimal set of default modules enable
upon installation) is confusing for many users, which is why we changed
this already in debian unstable, such that by default a much larger set
(also including dhcp) of modules is installed.

I hope this helps you to get up and running with selinux.
Unfortunately, there is only very basic documentation about selinux on
debian (the best I know is
http://debian-handbook.info/browse/stable/sect.selinux.html from the
debian administrator's handbook), but it is mostly analogous to how it
works on RHEL and Fedora, so you can also read
https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/SELinux_Users_and_Administrators_Guide/index.html

< 1 2 3

201 - 237 of 237 matches

Mail list logo