Bug#761168: systemtap-common: procfs probes fail

2014-09-11 Thread David Manso
Package: systemtap-common
Version: 1.7-1+deb7u1
Severity: normal
Tags: patch

Dear Maintainer,

Trying a simple procfs probe like this:
---profs-read.stp-
probe procfs(readme).read {
$value = 100\n
}
---

reports an error while compiling:
-
# stap profs-read.stp
In file included from
/tmp/staphcNerS/stap_4162120524274ba06e575bd8424aaf44_1037_src.c:173:0:
/usr/share/systemtap/runtime/procfs.c: In function
‘_stp_mkdir_proc_module’:
/usr/share/systemtap/runtime/procfs.c:148:27: error: dereferencing pointer to
incomplete type
make[3]: *** [/tmp/staphcNerS/stap_4162120524274ba06e575bd8424aaf44_1037_src.o]
Error 1
make[2]: *** [_module_/tmp/staphcNerS] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2
WARNING: make exited with status: 2
Pass 4: compilation failed.  Try again with another '--vp 0001' option.
-

It seems struct vfsmount is not defined. It can be fixed adding:

#include linux/mount.h

in top of file /usr/share/systemtap/runtime/procfs.c



-- System Information:
Debian Release: 7.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

systemtap-common depends on no packages.

Versions of packages systemtap-common recommends:
ii  systemtap  1.7-1+deb7u1

systemtap-common suggests no packages.

-- no debconf information
--- /usr/share/systemtap/runtime/procfs.c.orig	2014-09-11 12:39:39.0 +0200
+++ /usr/share/systemtap/runtime/procfs.c	2014-09-11 12:39:19.0 +0200
@@ -21,6 +21,8 @@
 #include linux/pid_namespace.h
 #endif
 
+#include linux/mount.h
+
 /* The maximum number of files AND directories that can be opened.
  * It would be great if the translator would emit this based on the actual
  * number of needed files.


Bug#649249: tcpxtract: Fixed PNG header

2011-11-19 Thread David Manso
Package: tcpxtract
Version: 1.0.1-5
Severity: normal

Fixed PNG header



-- System Information:
Debian Release: 6.0.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages tcpxtract depends on:
ii  libc6 2.11.2-10  Embedded GNU C Library: Shared lib
ii  libpcap0.81.1.1-2system interface for user-level pa

tcpxtract recommends no packages.

tcpxtract suggests no packages.

-- Configuration Files:
/etc/tcpxtract.conf changed:
avi(400, RIFF\?\?\?\?);
mpg(400, \x00\x00\x01\xba, \x00\x00\x01\xb9);
mpg(400, \x00\x00\x01\xb3, \x00\x00\x01\xb7);
fws(400, FWS);
art(15, \x4a\x47\x04\x0e, \xcf\xc7\xcb);
art(15, \x4a\x47\x03\x0e, \xd0\xcb\x00\x00);
gif(300, \x47\x49\x46\x38\x37\x61, \x00\x3b);
gif(300, \x47\x49\x46\x38\x39\x61, \x00\x00\x3b);
jpg(100, \xff\xd8\xff\xe0\x00\x10, \xff\xd9);
jpg(100, \xff\xd8\xff\xe1);
png(100, \?\x50\x4e\x47, \xff\xfc\xfd\xfe);
bmp(10, BM\?\?\x00\x00\x00);
tif(2, \x49\x49\x2a\x00);
doc(1250, \xd0\xcf\x11\xe0\xa1\xb1);
pst(4, \x21\x42\x4e\xa5\x6f\xb5\xa6);
ost(4, \x21\x42\x44\x4e);
dbx(400, \xcf\xad\x12\xfe\xc5\xfd\x74\x6f);
idx(400, \x4a\x4d\x46\x39);
mbx(400, \x4a\x4d\x46\x36);
html(5, \x3chtml, \x3c\x2fhtml\x3e);
pdf(500, \x25PDF, \x25EOF\x0d);
mail(50, \x41\x4f\x4c\x56\x4d);
ra(100, \x2e\x72\x61\xfd);
ra(100, \x2eRMF);
zip(1000, PK\x03\x04, \x3c\xac);
java(100, \xca\xfe\xba\xbe);


-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#649249: tcpxtract: Fixed PNG header

2011-11-19 Thread David Manso
I'm sorry, I was in a hurry, but you are right.

Error: Bad detection of PNG files

Description:
Extracted PNG files had the first byte missing.
Configuration file had a bad detection pattern:
   \x50\x4e\x47\?
I changed it to:
   \?\x50\x4e\x47
and worked, but Wikipedia says
(http://en.m.wikipedia.org/wiki/Portable_Network_Graphics) correct pattern
is:
   89 50 4e 47 0d 0a 1a 0a

Thank you.
On Nov 19, 2011 12:53 PM, Nico Golde n...@debian.org wrote:

 Hi,
 * David Manso david.ma...@epistolae.com [2011-11-19 10:55]:
  Fixed PNG header

 Please learn how to write a proper bug report for the next time...
 Your bug will be fixed in the next upload in case I interpreted your report
 correct.

 Cheers
 Nico



Bug#398356: nstx: Patch to source package

2009-05-23 Thread David Manso
Package: nstx
Version: 1.1-beta6-5
Tags: patch
Followup-For: Bug #398356

A patch is attached. Apply to source package.

It adds a -n option to name tun device. Init.d script uses if_tun as name.

-- System Information:
Debian Release: 5.0.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-2-686 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages nstx depends on:
ii  adduser   3.110  add and remove users and groups
ii  libc6 2.7-18 GNU C Library: Shared libraries

nstx recommends no packages.

nstx suggests no packages.

-- no debconf information
diff -aur nstx-1.1-beta6.orig/debian/changelog nstx-1.1-beta6/debian/changelog
--- nstx-1.1-beta6.orig/debian/changelog	2009-05-23 13:43:05.0 +0200
+++ nstx-1.1-beta6/debian/changelog	2009-05-24 00:11:54.476099823 +0200
@@ -1,3 +1,9 @@
+nstx (1.1-beta6-5.1~dmanso) unstable; urgency=low
+
+  * Add option -n to name tun devices (Closes: #398356).
+
+ -- David Manso david.ma...@epistolae.com  Sat, 23 May 2008 15:02:03 +0200
+
 nstx (1.1-beta6-5) unstable; urgency=low
 
   * Non-maintainer upload to solve release goal.
diff -aur nstx-1.1-beta6.orig/debian/nstx.default nstx-1.1-beta6/debian/nstx.default
--- nstx-1.1-beta6.orig/debian/nstx.default	2009-05-23 14:59:47.0 +0200
+++ nstx-1.1-beta6/debian/nstx.default	2009-05-24 00:13:14.776119728 +0200
@@ -18,8 +18,8 @@
 # uncomment to start nstxcd on system startup
 #start_nstxcd=yes
 
-# uncomment to bring up tun0 automatically
-#ifup_tun=tun0
+# uncomment to bring up tun-nstx automatically
+#ifup_tun=tun-nstx
 
 # uncomment to tell nstx to bind to a specific interface
 #NSTX_IFACE=1.2.3.4
diff -aur nstx-1.1-beta6.orig/debian/nstx.nstxcd.init nstx-1.1-beta6/debian/nstx.nstxcd.init
--- nstx-1.1-beta6.orig/debian/nstx.nstxcd.init	2009-05-23 14:59:47.0 +0200
+++ nstx-1.1-beta6/debian/nstx.nstxcd.init	2009-05-24 00:11:54.480116582 +0200
@@ -39,8 +39,9 @@
   start)
   if check_start_nstxcd_option; then
 	echo -n Starting $DESC: 
+OPTIONS=${NSTX_IFACE:+-i $NSTX_IFACE} ${ifup_tun:+-n $ifup_tun} $NSTX_DOMAIN $NSTX_DNS_SERVER
 	start-stop-daemon --start -b -m --quiet --pidfile /var/run/$NAME.pid \
-		--exec $DAEMON -- $NSTX_DOMAIN $NSTX_DNS_SERVER
+		--exec $DAEMON -- $OPTIONS
 	sleep 1;
 	if [ -n $ifup_tun ]; then
 	ifup $ifup_tun
diff -aur nstx-1.1-beta6.orig/debian/nstx.nstxd.init nstx-1.1-beta6/debian/nstx.nstxd.init
--- nstx-1.1-beta6.orig/debian/nstx.nstxd.init	2009-05-23 14:59:47.0 +0200
+++ nstx-1.1-beta6/debian/nstx.nstxd.init	2009-05-24 00:11:54.480116582 +0200
@@ -38,11 +38,7 @@
   start)
   if check_start_nstxd_option; then
 	echo -n Starting $DESC: 
-	if [ -n $NSTX_IFACE ]; then
-		OPTIONS=-i $NSTX_IFACE $NSTX_OPTIONS $NSTX_DOMAIN
-	else
-		OPTIONS=$NSTX_OPTIONS $NSTX_DOMAIN
-	fi
+	OPTIONS=${NSTX_IFACE:+-i $NSTX_IFACE} ${ifup_tun:+-n $ifup_tun} $NSTX_OPTIONS $NSTX_DOMAIN
 	start-stop-daemon --start -b -m --quiet --pidfile /var/run/$NAME.pid \
 		--exec $DAEMON -- $OPTIONS 
 	sleep 1;
diff -aur nstx-1.1-beta6.orig/nstxcd.8 nstx-1.1-beta6/nstxcd.8
--- nstx-1.1-beta6.orig/nstxcd.8	2009-05-23 14:59:47.0 +0200
+++ nstx-1.1-beta6/nstxcd.8	2009-05-24 00:11:54.480116582 +0200
@@ -3,7 +3,7 @@
 nstxcd \- IP over DNS tunneling client
 
 .SH SYNOPSIS
-.B nstxcd \fIDOMAIN\fR \fIIPADDRESS\fR
+.B nstxcd \fIOPTIONS\fR \fIDOMAIN\fR \fIIPADDRESS\fR
 
 .SH DESCRIPTION
 .B nstxcd
@@ -13,6 +13,10 @@
 .SH OPTIONS
 .B nstxcd
 takes the following options:
+.IP \-d tun-device
+Use this tun device instead of /dev/net/tun
+.IP \-n tun-name
+Use this tun name instead of tun0
 .IP domain
 The domain that nstxcd will send requests to. This domain must be delegated
 to a machine that is running nstxd.
diff -aur nstx-1.1-beta6.orig/nstxcd.c nstx-1.1-beta6/nstxcd.c
--- nstx-1.1-beta6.orig/nstxcd.c	2009-05-23 14:59:47.0 +0200
+++ nstx-1.1-beta6/nstxcd.c	2009-05-24 00:11:54.480116582 +0200
@@ -55,14 +55,14 @@
 static void
 usage(const char *prog, int code)
 {
-	fprintf(stderr, Usage: %s [-d tun-device] domainname dns-server\n
+	fprintf(stderr, Usage: %s [-d tun-device] [-n tun-name] domainname dns-server\n
 	Example: %s tun.yomama.com 125.23.53.12\n, prog, prog);
 	exit(code);
 }
 
 int main (int argc, char * argv[]) {
   struct nstxmsg *msg;
-  const char	*device = NULL;
+  const char	*device = NULL, *name = NULL;
   int 		 ch;
 
   nsid = time(NULL);
@@ -70,11 +70,14 @@
   if (argc  3)
 	usage(argv[0], EX_USAGE);
 
-  while ((ch = getopt(argc, argv, hd:)) != -1) {
+  while ((ch = getopt(argc, argv, hd:n:)) != -1) {
 	switch (ch) {
 	case 'd':
 		device = optarg;
 		break;
+	case 'n':
+		name = optarg;
+		break;
 	case 'h':
 		usage(argv[0], 0);
 	default:
@@ -85,7 +88,7 @@
   dns_setsuffix(argv[optind]);
 
   qsettimeout(10);
-  open_tuntap(device);
+  open_tuntap(device, name);
   open_ns(argv

Bug#525053: open-iscsi: fails to boot with CHAP parameters

2009-04-21 Thread David Manso
Package: open-iscsi
Version: 2.0.870~rc3-0.4
Severity: normal
Tags: patch


CHAP parameters aren't treated correctly when booting from iscsi and stored in 
/etc/iscsi/iscsi.initramfs.
iscsistart options for this parameters aren't added.
Patch attached.

-- System Information:
Debian Release: 5.0.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-2-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages open-iscsi depends on:
ii  libc6 2.7-18 GNU C Library: Shared libraries

open-iscsi recommends no packages.

open-iscsi suggests no packages.

-- no debconf information
--- usr/share/initramfs-tools/scripts/local-top/iscsi.orig  2009-01-08 
19:06:00.0 +0100
+++ usr/share/initramfs-tools/scripts/local-top/iscsi   2009-04-21 
20:31:56.0 +0200
@@ -42,6 +42,22 @@
ISCSI_TARGET_GROUP=1
fi
 
+   if [ ! -z $ISCSI_USERNAME ]; then
+   ISCSI_USERNAME=-u $ISCSI_USERNAME
+   fi
+
+   if [ ! -z $ISCSI_PASSWORD ]; then
+   ISCSI_PASSWORD=-w $ISCSI_PASSWORD
+   fi
+
+   if [ ! -z $ISCSI_IN_USERNAME ]; then
+   ISCSI_IN_USERNAME=-U $ISCSI_IN_USERNAME
+   fi
+
+   if [ ! -z $ISCSI_IN_PASSWORD ]; then
+   ISCSI_IN_PASSWORD=-W $ISCSI_IN_PASSWORD
+   fi
+
iscsistart -i $ISCSI_INITIATOR -t $ISCSI_TARGET_NAME\
   -g $ISCSI_TARGET_GROUP -a $ISCSI_TARGET_IP   \
   -p $ISCSI_TARGET_PORT $ISCSI_USERNAME\
@@ -70,16 +86,16 @@
ISCSI_TARGET_GROUP=${x#iscsi_target_group=}
;;
iscsi_username=*)
-   ISCSI_USERNAME=-u ${x#iscsi_username=}
+   ISCSI_USERNAME=${x#iscsi_username=}
;;
iscsi_password=*)
-   ISCSI_PASSWORD=-w ${x#iscsi_password=}
+   ISCSI_PASSWORD=${x#iscsi_password=}
;;
iscsi_in_username=*)
-   ISCSI_IN_USERNAME=-U ${x#iscsi_in_username=}
+   ISCSI_IN_USERNAME=${x#iscsi_in_username=}
;;
iscsi_in_password=*)
-   ISCSI_IN_PASSWORD=-W ${x#iscsi_in_password=}
+   ISCSI_IN_PASSWORD=${x#iscsi_in_password=}
;;
esac
done


Bug#495297: hoz: paste doesn't sanitize filename

2008-08-15 Thread David Manso
Package: hoz
Version: 1.65-1
Severity: grave
Tags: security
Justification: user security hole


Pasting a file doesn't check whether internal filename uses a path, allowing a 
modified header to write out of output directory.

Example:
  Modified header:
?^...?../home/user/file?12387?123123?...
(internal filename: ../home/user/file)
  User executes:
hoz --paste --outpath /tmp file.0
  Result:
A new file in /home/user/, not in /tmp

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-6-k7
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8)

Versions of packages hoz depends on:
ii  libc6  2.3.6.ds1-13etch7 GNU C Library: Shared libraries

hoz recommends no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#465428: vrrpd: only restores RT_TABLE_MAIN routing table (source routing fails)

2008-02-12 Thread David Manso
Package: vrrpd
Version: 1.0-1
Severity: normal
Tags: patch

When vrrp becomes active it changes its mac address, causing all routes
with this interface to dissapear. After that it restores only routes
within the main routing table.

In configurations with source routing it's necessary to use other tables
to route packages, e.g.:

ip rule add from 10.1.1.0/24 table 201
ip route add default via 72.14.207.1 table 201

This route dissapear after vrrp comes up.

Attached is a patch that will not correct this.

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-5-xen-686
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8)

Versions of packages vrrpd depends on:
ii  libc6  2.3.6.ds1-13etch4 GNU C Library: Shared libraries

vrrpd recommends no packages.

-- no debconf information
diff -Nurb vrrpd-1.0.orig/iproute.c vrrpd-1.0/iproute.c
--- vrrpd-1.0.orig/iproute.c	2008-02-12 10:07:52.0 +
+++ vrrpd-1.0/iproute.c	2008-02-12 10:11:51.0 +
@@ -92,8 +92,8 @@
   rtarg = (struct rt_entry *)arg;
 
   /* Just lookup the Main routing table */
-  if (r-rtm_table != RT_TABLE_MAIN)
-return 0;
+//  if (r-rtm_table != RT_TABLE_MAIN)
+//return 0;
 
   /* init len value  */
   len -= NLMSG_LENGTH(sizeof(*r));
@@ -141,6 +141,7 @@
 if (tb[RTA_IIF]) entry-iif = *(int *) RTA_DATA(tb[RTA_IIF]);
 if (tb[RTA_PRIORITY]) entry-prio = *(int *) RTA_DATA(tb[RTA_PRIORITY]);
 if (tb[RTA_METRICS]) entry-metrics = *(int *) RTA_DATA(tb[RTA_METRICS]);
+entry-table = r-rtm_table;
 
 /* save this entry */
 rtarg = rt_append(rtarg, entry);
@@ -192,6 +193,7 @@
   req.n.nlmsg_len = NLMSG_LENGTH(sizeof(struct rtmsg));
   req.n.nlmsg_flags = NLM_F_REQUEST | NLM_F_CREATE;
   req.n.nlmsg_type = RTM_NEWROUTE;
+  req.r.rtm_table = r-table;
 
   memcpy(req.r, r-rtm, sizeof(struct rtmsg));
 
diff -Nurb vrrpd-1.0.orig/iproute.h vrrpd-1.0/iproute.h
--- vrrpd-1.0.orig/iproute.h	2008-02-12 10:07:52.0 +
+++ vrrpd-1.0/iproute.h	2008-02-12 10:09:22.0 +
@@ -51,6 +51,7 @@
   int oif;
   int prio;
   int metrics;
+  unsigned char table;
 
   struct rt_entry *next;
 };


Bug#406327: /etc/init.d/networking stop doesn't deactivate any interface containing lo substring

2007-01-10 Thread David Manso

Package: netbase
Version: 4.27

I have a interface called vlan-loc configured in /etc/network/interfaces, but 
when I try to stop it using:

/etc/network/interfaces stop

it deactivate all interfaces but lo and vlan-loc.

The problem is that the script uses:

ifdown -a --exclude=lo

The --exclude option is deprecated and not much documented, but in source 
package it state that --exclude match substrings.

(ifupdown version 0.6.8 in etch)




--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]