Bug#1078768: erofs-utils should be built for Architecture: any I think?
On 2024/8/16 11:49, наб wrote: On Fri, Aug 16, 2024 at 09:50:24AM +0800, Gao Xiang wrote: The problem of hurd is that even it can be compiled, I have no environment to test hurd to find out if it really works. Honestly, I just use a bookworm VM image from https://cdimage.debian.org/cdimage/ports/latest/hurd-i386/current/ and erofs-utils seems to be relatively platform-generic, so I expect any issues to be caught by the buildds (FWIW, I cursorily tested the binaries and they seemed to work). Yeah, but as a debian maintainer (rather than a DD), I'm not sure how to trigger a buildd just for self-testing without uploading an entire new version directly (if the uploaded version causes any regression, that seems annoying though). So hurd build could be easily broken since there is no CI for this as well.. That is my real concern.. so if it's possible (and you're interested in supporting hurd), could you help submit a updated debian source package diff too? Attached. Thanks, I will upload a new version with your credits and two lintian fixes together later..: https://udd.debian.org/lintian/?packages=erofs-utils Thanks, Gao Xiang Best,
Bug#1078768: erofs-utils should be built for Architecture: any I think?
Hi наб, On 2024/8/16 04:12, наб wrote: Source: erofs-utils Version: 1.8.1-1 Severity: wishlist Dear Maintainer, I noticed that erofs-utils is Architecture: linux-any. It should probably not be; the ability to make/check/dump erofs filesystems is also useful on the hurd (&c.). I tried building erofs-utils as Architecture: any, and failed because of a PATH_MAX user that didn't include internal.h (patch for attached (I'll rebase and forward it upstream) that's the only build issue AFAICT, and the artifacts seem to work). Building it like this will help detect this type of issue earlier. The problem of hurd is that even it can be compiled, I have no environment to test hurd to find out if it really works. so if it's possible (and you're interested in supporting hurd), could you help submit a updated debian source package diff too? OTOH, the FUSE bit is likely untenable on the Hurd. Yes, so in that way, only mkfs/fsck are useful for now.. Thanks, Gao Xiang Best, -- System Information: Debian Release: 12.4 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable-debug'), (500, 'stable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 6.1.0-12-amd64 (SMP w/24 CPU threads; PREEMPT) Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_FIRMWARE_WORKAROUND, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled
Bug#1076570: Request for enabling more EROFS compression algorithms
On 2024/7/26 14:11, Salvatore Bonaccorso wrote: Hi, On Fri, Jul 19, 2024 at 01:11:42PM +0800, Gao Xiang wrote: Package: src:linux Version: 6.9.9-1 Severity: wishlist Dear Debian kernel maintainers, Could you help enable the following additional algorithms for EROFS, thanks! CONFIG_EROFS_FS_ZIP_LZMA=y CONFIG_EROFS_FS_ZIP_DEFLATE=y And I do hope CONFIG_EROFS_FS_ZIP_ZSTD=y could be enabled on linux 6.10+ too. Made a MR for kernel-team comments: https://salsa.debian.org/kernel-team/linux/-/merge_requests/1142 Many thanks for your efforts and consideration! Thanks, Gao Xiang Regards, Salvatore
Bug#1076570: Request for enabling more EROFS compression algorithms
Package: src:linux Version: 6.9.9-1 Severity: wishlist Dear Debian kernel maintainers, Could you help enable the following additional algorithms for EROFS, thanks! CONFIG_EROFS_FS_ZIP_LZMA=y CONFIG_EROFS_FS_ZIP_DEFLATE=y And I do hope CONFIG_EROFS_FS_ZIP_ZSTD=y could be enabled on linux 6.10+ too. Thanks, Gao Xiang
Bug#1036901: provide the erofsfuse binary as package
Hi! On 2023/5/29 05:51, Norbert Lange wrote: Package: erofs-utils Version: 1.6-1 Severity: normal Tags: patch X-Debbugs-Cc: nolang...@gmail.com Hello, this tool is quite usefull, but it should be its own package. I added a patch implementing this -- System Information: Debian Release: 12.0 APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 6.1.0-9-amd64 (SMP w/8 CPU threads; PREEMPT) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages erofs-utils depends on: ii libc62.36-9 ii liblz4-1 1.9.4-1 ii liblzma5 5.4.1-0.2 ii libselinux1 3.4-1+b5 ii libuuid1 2.38.1-5+b1 erofs-utils recommends no packages. erofs-utils suggests no packages. Thanks, I think we could upload it after new release is done. Thanks, Gao Xiang -- no debconf information
Bug#946569: Request for CONFIG_EROFS_FS=m on 5.4+
Hi Salvatore, On Wed, Jan 01, 2020 at 08:42:51PM +0100, Salvatore Bonaccorso wrote: > Control: tags -1 + pending > > Hi, > > On Wed, Dec 11, 2019 at 10:12:23AM +0800, Gao Xiang wrote: > > Source: linux > > Version: 5.4.2-1~exp1 > > Severity: normal > > > > Hi Debian kernel maintainers, > > > > Could you consider enabling EROFS filesystem support as a module > > from 5.4 for end users now? It has been out of staging. > > > > It has much better dynamic performance than squashfs for such > > like LIVECD use. I'd suggest the following configuration: > > > > CONFIG_EROFS_FS=m > > # CONFIG_EROFS_FS_DEBUG is not set > > CONFIG_EROFS_FS_XATTR=y > > CONFIG_EROFS_FS_POSIX_ACL=y > > CONFIG_EROFS_FS_SECURITY=y > > CONFIG_EROFS_FS_ZIP=y > > CONFIG_EROFS_FS_CLUSTER_PAGE_LIMIT=1 > > > > erofs-utils package has been available in testing branch as well, > > https://packages.debian.org/source/bullseye/erofs-utils > > Done in > https://salsa.debian.org/kernel-team/linux/commit/33639568475c399acc9cd9d45e9b06a3a2df6e75 > with the suggested configuration. Got it. Thanks for considering this. Thanks, Gao Xiang > > Regards, > Salvatore
Bug#946569: Request for CONFIG_EROFS_FS=m on 5.4+
Ping... Some hints about this request? On Wed, Dec 11, 2019 at 10:12:23AM +0800, Gao Xiang wrote: > Source: linux > Version: 5.4.2-1~exp1 > Severity: normal > > Hi Debian kernel maintainers, > > Could you consider enabling EROFS filesystem support as a module > from 5.4 for end users now? It has been out of staging. > > It has much better dynamic performance than squashfs for such > like LIVECD use. I'd suggest the following configuration: > > CONFIG_EROFS_FS=m > # CONFIG_EROFS_FS_DEBUG is not set > CONFIG_EROFS_FS_XATTR=y > CONFIG_EROFS_FS_POSIX_ACL=y > CONFIG_EROFS_FS_SECURITY=y > CONFIG_EROFS_FS_ZIP=y > CONFIG_EROFS_FS_CLUSTER_PAGE_LIMIT=1 > > erofs-utils package has been available in testing branch as well, > https://packages.debian.org/source/bullseye/erofs-utils > > Thanks, > Gao Xiang
Bug#946569: Request for CONFIG_EROFS_FS=m on 5.4+
Source: linux Version: 5.4.2-1~exp1 Severity: normal Hi Debian kernel maintainers, Could you consider enabling EROFS filesystem support as a module from 5.4 for end users now? It has been out of staging. It has much better dynamic performance than squashfs for such like LIVECD use. I'd suggest the following configuration: CONFIG_EROFS_FS=m # CONFIG_EROFS_FS_DEBUG is not set CONFIG_EROFS_FS_XATTR=y CONFIG_EROFS_FS_POSIX_ACL=y CONFIG_EROFS_FS_SECURITY=y CONFIG_EROFS_FS_ZIP=y CONFIG_EROFS_FS_CLUSTER_PAGE_LIMIT=1 erofs-utils package has been available in testing branch as well, https://packages.debian.org/source/bullseye/erofs-utils Thanks, Gao Xiang
Bug#943948: ITP: erofs-utils -- Utilities for EROFS File System
Hi Emfox and folks, I've uploaded erofs-utils package to mentors.debian.net https://mentors.debian.net/package/erofs-utils with a RFS request #944153 , please kindly take some time helping on this package (and new filesystem) it will of great help. Thanks in advance! https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944153 Best regards, Gao Xiang On Mon, Nov 04, 2019 at 11:25:02AM +0800, Gao Xiang wrote: > Hi Emfox, > > On Mon, Nov 04, 2019 at 09:13:33AM +0800, Emfox Zhou wrote: > > Hello, have you put your packaging work online anywhere, so that people > > interested can help checking it? > > Thanks for your kind reply. > > I just worked out a manual page for mkfs.erofs since I noticed it's a > requirement for a debian package. I think I can upload the whole package to > a github repo or mentors.debian.net website then in a few day. > > Could you help take time checking it as well? :-) > > > And if the issues is critical, I am afraid we should not upload erofs-utils > > until lz4 is fixed. > > I think it's not critical (it only crashes with some given binary > sequences), so I can limit srcsize as a workaround if LZ4 compressor > isn't fixed. > > By the way, LZ4HC compressor is not affected at all and it's also > recommended to use LZ4HC rather than LZ4. > > However, I'd like to know if some priority to resolve debian LZ4 > compressor though. It seems much better than do some workaround on > my side. > > Thanks, > Gao Xiang > > > > > On Fri, Nov 1, 2019 at 9:33 PM Gao Xiang wrote: > > > > > Package: wnpp > > > Severity: wishlist > > > Owner: Gao Xiang > > > > > > * Package name: erofs-utils > > > Version : 1.0 > > > Upstream Author : Li Guifu , Miao Xie < > > > miao...@huawei.com>, Gao Xiang > > > * URL : > > > https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git > > > * License : GPL-2+ > > > Programming Lang: C > > > Description : Utilities for EROFS File System > > > > > > EROFS [1] [2] is a new enhanced lightweight linux upstreamed in-kernel > > > read-only filesystem with modern designs (eg. no buffer head, reduced > > > metadata, inline xattrs/data, etc.) for scenarios which need > > > high-performance > > > read-only requirements, e.g. Android OS for smartphones and LIVECDs. > > > > > > It also provides fixed-sized output compression support, which improves > > > storage density, keeps relatively higher compression ratios, which is more > > > useful to achieve high performance for embedded devices with limited > > > memory > > > since it has unnoticable memory overhead and page cache thrashing. > > > > > > erofs-utils 1.0 [3] was released weeks ago, I'm trying to request for > > > debian inclusion (also consider security issues [4] for lz4 package). > > > > > > I made a usable debian package just now although I have limited knowledge > > > about the whole debian packaging stuff. I'd like and will take time to be > > > the package maintainer if no one have interest or enough time on this. > > > > > > Please kindly consider my request. > > > > > > Thanks, > > > Gao Xiang > > > > > > [1] > > > https://kccncosschn19eng.sched.com/event/Nru2/erofs-an-introduction-and-our-smartphone-practice-xiang-gao-huawei > > > [2] https://www.usenix.org/conference/atc19/presentation/gao > > > [3] > > > https://lore.kernel.org/r/20191024033259.GA2513@hsiangkao-HP-ZHAN-66-Pro-G1 > > > [4] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943751 > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943680 > > > > > > > > > -- > > Emfox Zhou > > > > GnuPG Public Key: 0x1DEB >
Bug#944153: RFS: erofs-utils/1.0-1 [ITP] -- Utilities for EROFS File System
Package: sponsorship-requests Severity: wishlist X-Debbugs-CC: filesystems-de...@alioth-lists.debian.net, em...@debian.org Dear mentors, I am looking for a sponsor for my package "erofs-utils" * Package name: erofs-utils Version : 1.0-1 Upstream Author : Gao Xiang * URL : http://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git * License : GPL-2+ * Vcs : None Section : admin It builds those binary packages: erofs-utils - Utilities for EROFS File System To access further information about this package, please visit the following URL: https://mentors.debian.net/package/erofs-utils Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/e/erofs-utils/erofs-utils_1.0-1.dsc Changes since the last upload: * Initial release. Closes: #943948 Regards, -- Gao Xiang
Bug#943948: ITP: erofs-utils -- Utilities for EROFS File System
Hi Emfox, On Mon, Nov 04, 2019 at 09:13:33AM +0800, Emfox Zhou wrote: > Hello, have you put your packaging work online anywhere, so that people > interested can help checking it? Thanks for your kind reply. I just worked out a manual page for mkfs.erofs since I noticed it's a requirement for a debian package. I think I can upload the whole package to a github repo or mentors.debian.net website then in a few day. Could you help take time checking it as well? :-) > And if the issues is critical, I am afraid we should not upload erofs-utils > until lz4 is fixed. I think it's not critical (it only crashes with some given binary sequences), so I can limit srcsize as a workaround if LZ4 compressor isn't fixed. By the way, LZ4HC compressor is not affected at all and it's also recommended to use LZ4HC rather than LZ4. However, I'd like to know if some priority to resolve debian LZ4 compressor though. It seems much better than do some workaround on my side. Thanks, Gao Xiang > > On Fri, Nov 1, 2019 at 9:33 PM Gao Xiang wrote: > > > Package: wnpp > > Severity: wishlist > > Owner: Gao Xiang > > > > * Package name: erofs-utils > > Version : 1.0 > > Upstream Author : Li Guifu , Miao Xie < > > miao...@huawei.com>, Gao Xiang > > * URL : > > https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git > > * License : GPL-2+ > > Programming Lang: C > > Description : Utilities for EROFS File System > > > > EROFS [1] [2] is a new enhanced lightweight linux upstreamed in-kernel > > read-only filesystem with modern designs (eg. no buffer head, reduced > > metadata, inline xattrs/data, etc.) for scenarios which need > > high-performance > > read-only requirements, e.g. Android OS for smartphones and LIVECDs. > > > > It also provides fixed-sized output compression support, which improves > > storage density, keeps relatively higher compression ratios, which is more > > useful to achieve high performance for embedded devices with limited memory > > since it has unnoticable memory overhead and page cache thrashing. > > > > erofs-utils 1.0 [3] was released weeks ago, I'm trying to request for > > debian inclusion (also consider security issues [4] for lz4 package). > > > > I made a usable debian package just now although I have limited knowledge > > about the whole debian packaging stuff. I'd like and will take time to be > > the package maintainer if no one have interest or enough time on this. > > > > Please kindly consider my request. > > > > Thanks, > > Gao Xiang > > > > [1] > > https://kccncosschn19eng.sched.com/event/Nru2/erofs-an-introduction-and-our-smartphone-practice-xiang-gao-huawei > > [2] https://www.usenix.org/conference/atc19/presentation/gao > > [3] > > https://lore.kernel.org/r/20191024033259.GA2513@hsiangkao-HP-ZHAN-66-Pro-G1 > > [4] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943751 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943680 > > > > > -- > Emfox Zhou > > GnuPG Public Key: 0x1DEB
Bug#943948: ITP: erofs-utils -- Utilities for EROFS File System
Package: wnpp Severity: wishlist Owner: Gao Xiang * Package name: erofs-utils Version : 1.0 Upstream Author : Li Guifu , Miao Xie , Gao Xiang * URL : https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git * License : GPL-2+ Programming Lang: C Description : Utilities for EROFS File System EROFS [1] [2] is a new enhanced lightweight linux upstreamed in-kernel read-only filesystem with modern designs (eg. no buffer head, reduced metadata, inline xattrs/data, etc.) for scenarios which need high-performance read-only requirements, e.g. Android OS for smartphones and LIVECDs. It also provides fixed-sized output compression support, which improves storage density, keeps relatively higher compression ratios, which is more useful to achieve high performance for embedded devices with limited memory since it has unnoticable memory overhead and page cache thrashing. erofs-utils 1.0 [3] was released weeks ago, I'm trying to request for debian inclusion (also consider security issues [4] for lz4 package). I made a usable debian package just now although I have limited knowledge about the whole debian packaging stuff. I'd like and will take time to be the package maintainer if no one have interest or enough time on this. Please kindly consider my request. Thanks, Gao Xiang [1] https://kccncosschn19eng.sched.com/event/Nru2/erofs-an-introduction-and-our-smartphone-practice-xiang-gao-huawei [2] https://www.usenix.org/conference/atc19/presentation/gao [3] https://lore.kernel.org/r/20191024033259.GA2513@hsiangkao-HP-ZHAN-66-Pro-G1 [4] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943751 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943680
Bug#943751: lz4: LZ4_*_destSize() fix for debian lz4 stable versions
Here is a bug reproducer for this issue, please consider backporting
them... It has real affect on *_destSize lz4 users.
bug.c (crash if liblz4 < 1.9.2)
#include
#include
#include
#include
#include
#define SRCSIZE 1045934
int main(void)
{
int SrcSize = SRCSIZE;
char buf[SRCSIZE] = {0};
char dst[4096];
int compressed;
compressed = LZ4_compress_destSize(buf, dst, &SrcSize, 4096);
printf("compressed: %d SrcSize: %d", compressed, SrcSize);
return 0;
}
Bug#943751: lz4: LZ4_*_destSize() fix for debian lz4 stable versions
Package: lz4 Version: 1.8.3-1 Hi maintainer, I'd like to use LZ4 LZ4_*_destSize() apis in debian. In particular, I'd like to introduce erofs-utils package to debian, (erofs is a read-only compression file system providing high performance [1]), which relies on LZ4_*_destSize(), but there are some stable fixes for these apis in lz4 1.9.0 and 1.9.2, and lz4 upstream doesn't have stable branch for old versions. Could you kindly considering backporting them to debian lz4 stable versions for erofs userspace stuffs to use? merged in lz4-1.9.0 lz4hc.c: change (length >> 8) to (length / 255) https://github.com/lz4/lz4/commit/660d21272e4c8a0f49db5fc1e6853f08713dff82 merged in lz4-1.9.2 [LZ4_compress_destSize] Allow 2 more bytes of match length https://github.com/lz4/lz4/commit/690009e2c2f9e5dcb0d40e7c0c40610ce6006eda [LZ4_compress_destSize] Fix rare data corruption bug https://github.com/lz4/lz4/commit/6bc6f836a18d1f8fd05c8fc2b42f1d800bc25de1 [LZ4_compress_destSize] Fix overflow condition https://github.com/lz4/lz4/commit/13a2d9e34ffc4170720ce417c73e396d0ac1471a [LZ4_compress_destSize] Fix off-by-one error in fix https://github.com/lz4/lz4/commit/7c32101c655d93b61fc212dcd512b87119dd7333 [LZ4_compress_destSize] Fix off-by-one error https://github.com/lz4/lz4/commit/d7cad81093cd805110291f84d64d385557d0ffba since there are some new reports (as follows) for lz4 1.9.2 so I'm not sure lz4 1.9.2 is stable enough so I think backporting the above fixes is better. https://github.com/lz4/lz4/issues/783 Here is our unoffical branch merged above patches based on lz4 1.8.3: https://github.com/erofs/lz4 [1] https://lore.kernel.org/r/20191024033259.GA2513@hsiangkao-HP-ZHAN-66-Pro-G1/ Thanks, Gao Xiang
