Bug#527216: Manual Gnudb Search delivers results but cant open them
This patch solves the problem
Regards,
Jerôme
Jochen Bauer wrote, the 29/05/2009 13:14 :
Hi
im using EAsytag 2.15. un Ubuntu 9.04, Everytime i do a manual search on
gnudb, the search delivers the results but if I click on them, a message
appears: .HTTP/1.1 301 Moved Permanently
The Problem is mentioned at few places in the web but theres no solution.
Greez
Jochen
--
EasyTAG - Tag editor for MP3 and Ogg Vorbis files
http://easytag.sourceforge.net
--
Jerome COUDERC easy...@gmail.com
diff -ruN easytag-2.1.6.orig/src/cddb.c easytag-2.1.6/src/cddb.c
--- easytag-2.1.6.orig/src/cddb.c 2008-03-22 22:57:29.0 +0100
+++ easytag-2.1.6/src/cddb.c2009-08-25 23:16:35.0 +0200
@@ -2158,10 +2158,12 @@
*/
gboolean Cddb_Search_Album_List_From_String (void)
{
-if ( strstr(CDDB_SERVER_NAME_MANUAL_SEARCH,freedb) != NULL )
-return Cddb_Search_Album_List_From_String_Freedb();
-else
+if ( strstr(CDDB_SERVER_NAME_MANUAL_SEARCH,gnudb) != NULL )
+ // Use of gnudb
return Cddb_Search_Album_List_From_String_Gnudb();
+else
+ // Use of freedb
+return Cddb_Search_Album_List_From_String_Freedb();
}
@@ -2255,7 +2257,7 @@
g_free(string);
g_free(tmp);
g_free(proxy_auth);
-//g_print(Request : '%s'\n, cddb_in);
+//g_print(Request Cddb_Search_Album_List_From_String_Freedb : '%s'\n,
cddb_in);
// Send the request
gtk_statusbar_push(GTK_STATUSBAR(CddbStatusBar),CddbStatusBarContext,_(Sending
request ...));
@@ -2574,7 +2576,7 @@
);
next_page_found = FALSE;
g_free(proxy_auth);
-//g_print(Request : '%s'\n, cddb_in);
+//g_print(Request Cddb_Search_Album_List_From_String_Gnudb : '%s'\n,
cddb_in);
// Send the request
gtk_statusbar_push(GTK_STATUSBAR(CddbStatusBar),CddbStatusBarContext,_(Sending
request ...));
@@ -3130,7 +3132,7 @@
(proxy_auth=Cddb_Format_Proxy_Authentification())
);
g_free(proxy_auth);
-//g_print(Request : '%s'\n, cddb_in);
+//g_print(Request Cddb_Search_Album_From_Selected_Files :
'%s'\n, cddb_in);
msg = g_strdup_printf(_(Sending request (CddbId: %s, #tracks: %d,
Disc length: %d) ...),
cddb_discid,num_tracks,disc_length);
@@ -3394,24 +3396,47 @@
CDDB_USE_PROXY?CDDB_PROXY_PORT:cddb_server_port)) = 0 )
return FALSE;
-// CDDB Request (ex: GET
/~cddb/cddb.cgi?cmd=cddb+read+jazz+0200a401hello=noname+localhost+EasyTAG+0.31proto=1
HTTP/1.1\r\nHost: freedb.freedb.org:80\r\nConnection: close)
-// Without proxy : GET /~cddb/cddb.cgi?... but doesn't work with a
proxy.
-// With proxy: GET http://freedb.freedb.org/~cddb/cddb.cgi?...;
-cddb_in = g_strdup_printf(GET %s%s%s?cmd=cddb+read+
- %s+%s
- hello=noname+localhost+%s+%s
- proto=6 HTTP/1.1\r\n
- Host: %s:%d\r\n
- %s
- Connection: close\r\n\r\n,
-
CDDB_USE_PROXY?http://:,CDDB_USE_PROXY?cddb_server_name:;,
cddb_server_cgi_path,
- cddbalbum-category,cddbalbum-id,
- APPNAME,VERSION,
- cddb_server_name,cddb_server_port,
-
(proxy_auth=Cddb_Format_Proxy_Authentification())
- );
-g_free(proxy_auth);
-//g_print(Request : '%s'\n, cddb_in);
+ if ( strstr(cddb_server_name,gnudb) != NULL )
+ {
+ // For gnudb
+ // New version of gnudb doesn't use a cddb request, but
a http request
+ cddb_in = g_strdup_printf(GET %s%s/gnudb/
+ %s/%s
+ HTTP/1.1\r\n
+ Host: %s:%d\r\n
+ User-Agent: %s %s\r\n
+ %s
+ Connection: close\r\n
+ \r\n,
+ CDDB_USE_PROXY?http://:;,
CDDB_USE_PROXY?cddb_server_name:, // Needed when using proxy
+ cddbalbum-category,cddbalbum-id,
+ cddb_server_name,cddb_server_port,
+ APPNAME,VERSION,
+
(proxy_auth=Cddb_Format_Proxy_Authentification())
+
Bug#460247: easytag destroys existing ogg vorbis tags without any notice
Hi, Also, the patch is also included in the last version 2.1.6 (but not yet available on debian) Regards, Jérôme Christian Hammers wrote, the 26/08/2008 23:42 : Hello Sebastian What do you think of the latest patch proposal for this bug? Currently there is NO version of easytag in testing/lenny due to this bug although there would be a freeze exception otherwise (if I understand the package tracking page correctly). bye, -christian- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#445333: easytag: segfault, crash when reloading directory
Do you have also a gdb backtrace? Regards, Jerome Emilio Scalise wrote, the 15/12/2007 22:16 : Yes, it's still crashing with some directories. I've attached another valgrind output with 2.1.4. Please note that I'm using a backport. Later I'll try with lenny/sid on my other pc. Easytag 2.1.4 doesn't compile against libflac 1.1.2 (the etch version), so I'm using also a libflac backport. But this is another issue, I'll send another bugreport. I should also try to compile easytag without stripping it, and ran gdb against it, so I can give you (and perhaps upstream) some more informations about the segmentation fault. Also valgrind could be more useful with debug symbols.. Bye Emilio -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#445333: easytag: segfault, crash when reloading directory
Hi, Does the crash still appear in version 2.1.4? Regards, Jerome -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#445333: easytag: segfault, crash when reloading directory tree (ctrl-shift-r)
Humm... Strange bug At the present time I didn't succeeded to reproduce the problem, but note that in the next version I've made some change to managed renamed directories. I hop this will fix the problem... Regards, Jerome -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#432257: easytag is unable to find any .mp3's
Hi,
In the version 2.1.1, there is a small mistake in the configure script
that may cause the problem of detection of MP3 support. This will be
fixed in the 2.1.2 version
In attachment, a patch from Thomas Klausner
Regards,
Jerome
--
EasyTAG - Tag editor for MP3 and Ogg Vorbis files
http://easytag.sourceforge.net
--
Jerome COUDERC [EMAIL PROTECTED]
$NetBSD: patch-aa,v 1.1.1.1 2007/07/07 07:47:51 wiz Exp $
--- configure.orig 2007-07-04 18:50:16.0 +
+++ configure
@@ -21294,7 +21294,7 @@ _ACEOF
fi
-if test x$enable_id3v23 == xyes; then
+if test x$enable_id3v23 = xyes; then
echo $as_me:$LINENO: checking for library containing
ID3Tag_Link 5
echo $ECHO_N checking for library containing ID3Tag_Link... $ECHO_C 6
if test ${ac_cv_search_ID3Tag_Link+set} = set; then
Bug#401523: easytag: add support for speex files
Hi, The support of speex files was added in version 2.1.1 Regards, Jerome -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#422215: easytag: Manual cddb-lookup fails
Hi Stefan, Since Freedb.org was acquired by MAGIX the format of the HTTP search was changed... ...and doesn't work with the previous version of the application. So I strongly recommand you to update to the version 2.0.2 of EasyTAG which uses gnudb.org Regards, Jerome -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#422215: easytag: Manual cddb-lookup fails
Note that the gnudb.org server can be used only with easytag = 1.99.13 JErome -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#350414: easytag: too verbose
Hi Adrian, In the coming version 2.0.1, all the messages will be displayed in a Log view. Regards, Jerome Adrian Bunk wrote, the 29/03/2007 23:27 : On Thu, Mar 29, 2007 at 08:21:55AM +0200, Jérôme COUDERC wrote: Hi Adrian, Hi Jérôme, In the future version 2.0.1, all messages will be displayed in a log area in the main window, to avoid to send them to the output (console,...) thanks a lot. :-) Regards, Jerome cu Adrian -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#350414: easytag: too verbose
Hi Adrian, In the future version 2.0.1, all messages will be displayed in a log area in the main window, to avoid to send them to the output (console,...) Regards, Jerome Adrian Bunk wrote, the 29.01.2006 17:08 : Package: easytag Version: 1.99.11-1 Severity: normal easytag outputs everything it does (including the reading of files) either to the shell it was started from, or (if it was started from a window manager menu) to ~/.xsession-errors without a good reason. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#292188: easytag: The CDDB bug is still present
Hi, This bug cddb hangs was fixed in the last version 1.99.13 Regards, Jerome Francesco Palermo wrote, the 11/05/2006 13:21 : Package: easytag Version: 1.99.12-1 Followup-For: Bug #292188 I found it while I was searching the CDDB entry of the album 'Cabo Verde' by Cesaria Evora. Bye, Francesco -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#363315: easytag: Musicbrainz lookup function
Hi, Note that in the last version 1.99.13, the cddb automatic search request also MusicBrainz using the CddbMusicBrainz gateway... This doesn't work exactly like picard but can be interesting... Jerome -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#292188: easytag: Check for apostrophes
Hi, With the last version 1.99.13, there is no problem when searching for example Guns n' Roses ;-) Regards, Jerome Tobias Wolter wrote, the 24/05/2006 14:17 : Package: easytag Version: 1.99.12-1 Followup-For: Bug #292188 Apostrophes seem to foul up the check. Searching for Guns n' Roses on CDDB locks the application, searching for Guns Roses doesn't. -towo -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#381709: easytag: Show all files, ignoring extensions
Hi Simon, EasyTAG needs the extension to identify quickly the files to load and the kind of tag used. So it recognizes only the supported extension like : .mp3 .mp2 .ogg .flac .fla .mpc .mp+ .mpp .ape .mac .ofr .ofs .mp4 .m4a .m4p Jerome Simon Ward wrote, the 06/08/2006 19:16 : Package: easytag Version: 1.99.12-1 Severity: wishlist When searching a directory for files, easytag appears to only recognise files with extensions (such as .mp3, and .ogg). An option to search all files, or specify a custom filter for file searching would be useful in some cases (an example would be renaming/tagging files from lost+found after disk corruption). -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.17-1-k7 Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Versions of packages easytag depends on: ii libatk1.0-0 1.12.1-1 The ATK accessibility toolkit ii libc6 2.3.6-18 GNU C Library: Shared libraries ii libcairo2 1.2.0-5 The Cairo 2D vecFrom - Wed Aug 09 23:51:57 2006 X-Account-Key: account7 X-UIDL: GmailId10ce4ef87a16645d X-Mozilla-Status: X-Mozilla-Status2: X-Gmail-Received: 851ed0f9ef947e7d8ea0d3a4d1f09f1917449555 Delivered-To: [EMAIL PROTECTED] Received: by 10.49.39.16 with SMTP id r16cs206722nfj; Sun, 6 Aug 2006 12:22:18 -0700 (PDT) Received: by 10.65.185.3 with SMTP id m3mr7433470qbp; Sun, 06 Aug 2006 12:22:18 -0700 (PDT) Return-Path: [EMAIL PROTECTED] Received: from master.debian.org (master.debian.org [70.103.162.30]) by mx.gmail.com with ESMTP id e1si2116399nzd.2006.08.06.12.22.17; Sun, 06 Aug 2006 12:22:18 -0700 (PDT) Received-SPF: pass (gmail.com: domain of [EMAIL PROTECTED] designates 70.103.162.30 as permitted sender) Received: from qa by master.debian.org with local (Exim 4.50) id 1G9oCX-0002yw-E8; Sun, 06 Aug 2006 14:22:17 -0500 Received: from spohr.debian.org ([140.211.166.43] ident=Debian-exim) by master.debian.org with esmtp (Exim 4.50) id 1G9nlR-0004V0-Gw for [EMAIL PROTECTED]; Sun, 06 Aug 2006 13:54:17 -0500 Received: from debbugs by spohr.debian.org with local (Exim 4.50) id 1G9mGO-0005N8-PW; Sun, 06 Aug 2006 10:18:08 -0700 X-Loop: [EMAIL PROTECTED] Subject: Bug#381709: easytag: Show all files, ignoring extensions Reply-To: Simon Ward [EMAIL PROTECTED], [EMAIL PROTECTED] Resent-From: Simon Ward [EMAIL PROTECTED] Resent-To: debian-bugs-dist@lists.debian.org Resent-CC: Sebastien Bacher [EMAIL PROTECTED] Resent-Date: Sun, 06 Aug 2006 17:18:05 UTC Resent-Message-Id: [EMAIL PROTECTED] X-Debian-PR-Message: report 381709 X-Debian-PR-Package: easytag X-Debian-PR-Keywords: X-Debian-PR-Source: easytag Received: via spool by [EMAIL PROTECTED] id=B.115488462220377 (code B ref -1); Sun, 06 Aug 2006 17:18:05 UTC Received: (at submit) by bugs.debian.org; 6 Aug 2006 17:17:02 + Received: from tallyho.bytemark.co.uk ([80.68.81.166]) by spohr.debian.org with esmtp (Exim 4.50) id 1G9mFK-0005Hm-5z for [EMAIL PROTECTED]; Sun, 06 Aug 2006 10:17:02 -0700 Received: from [80.68.82.82] (helo=bleah.onomatopoeia.lan) by tallyho.bytemark.co.uk with esmtp (Exim 4.52) id 1G9mFH-0002pE-G2; Sun, 06 Aug 2006 17:16:59 + Received: from simon by bleah.onomatopoeia.lan with local (Exim 4.62) (envelope-from [EMAIL PROTECTED]) id 1G9mFH-0006HR-3E; Sun, 06 Aug 2006 18:16:59 +0100 Content-Type: text/plain; charset=us-ascii MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Simon Ward [EMAIL PROTECTED] To: Debian Bug Tracking System [EMAIL PROTECTED] Message-Id: [EMAIL PROTECTED] X-Mailer: reportbug 3.21.2 Date: Sun, 06 Aug 2006 18:16:59 +0100 Delivered-To: [EMAIL PROTECTED] X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on spohr.debian.org X-Spam-Level: X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE autolearn=no version=2.60-bugs.debian.org_2005_01_02 Resent-Sender: Debian BTS [EMAIL PROTECTED] Resent-Date: Sun, 06 Aug 2006 10:18:08 -0700 Delivered-To: [EMAIL PROTECTED] Precedence: list X-Loop: [EMAIL PROTECTED] X-PTS-Package: easytag X-PTS-Keyword: bts X-Unsubscribe: echo 'unsubscribe easytag' | mail [EMAIL PROTECTED] Package: easytag Version: 1.99.12-1 Severity: wishlist When searching a directory for files, easytag appears to only recognise files with extensions (such as .mp3, and .ogg). An option to search all files, or specify a custom filter for file searching would be useful in some cases (an example would be renaming/tagging files from lost+found after disk corruption). -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.17-1-k7 Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Versions of
Bug#343826: easytag: Cannot save some characters into ID3v2 tag
Hi,
This problem is due to id3lib which contains a bug when writing some
characters to Unicode. The initial bug description is on :
http://sourceforge.net/tracker/index.php?func=detailaid=1016290group_id=979atid=300979
In the last version 1.99.12 of id3lib, was added a check when writing
the tag, to detect if your version of id3lib wasn't patched.
Here is attached the recommended patch.
Regards,
Jerome
Javier Kohen wrote, the 18/12/2005 01:17 :
Package: easytag
Version: 1.99.10-1
Severity: normal
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I just hit a bug with some Czech songs. For instance, character � (composed
with 'y) cannot be saved properly by EasyTAG when using the recommended
encoding setting (ISO-8859-1, or UNICODE fallback). The character shows up in
the ID3v2 tag as FFFD (invalid UTF-16 sequence).
This might be related to bugs #281255 and #246856, but I'm not sure. There is
some background information there. I guess that the cause behind the bug is
that Debian still lacks an UTF-8-clean libid3, as mentioned elsewhere by Jerome
and me. If this is not the case, I'd be happy to check this bug.
--
EasyTAG - Tag editor for MP3 and Ogg Vorbis files
http://easytag.sourceforge.net
--
Jerome COUDERC [EMAIL PROTECTED]
diff -ruN id3lib-3.8.3.orig/ChangeLog id3lib-3.8.3/ChangeLog
--- id3lib-3.8.3.orig/ChangeLog 2003-03-02 01:23:00.0 +0100
+++ id3lib-3.8.3/ChangeLog 2006-02-22 00:33:59.946214472 +0100
@@ -1,3 +1,8 @@
+2006-02-17 Jerome Couderc
+
+* Patch from Spoon to fix UTF-16 writing bug
+
http://sourceforge.net/tracker/index.php?func=detailaid=1016290group_id=979atid=300979
+
2003-03-02 Sunday 17:38 Thijmen Klok [EMAIL PROTECTED]
* THANKS (1.20): added more people
diff -ruN id3lib-3.8.3.orig/src/io_helpers.cpp id3lib-3.8.3/src/io_helpers.cpp
--- id3lib-3.8.3.orig/src/io_helpers.cpp2003-03-02 01:23:00.0
+0100
+++ id3lib-3.8.3/src/io_helpers.cpp 2006-02-22 00:35:02.926639992 +0100
@@ -363,11 +363,22 @@
// Write the BOM: 0xFEFF
unicode_t BOM = 0xFEFF;
writer.writeChars((const unsigned char*) BOM, 2);
+// Patch from Spoon : 2004-08-25 14:17
+//
http://sourceforge.net/tracker/index.php?func=detailaid=1016290group_id=979atid=300979
+// Wrong code
+//for (size_t i = 0; i size; i += 2)
+//{
+// unicode_t ch = (data[i] 8) | data[i+1];
+// writer.writeChars((const unsigned char*) ch, 2);
+//}
+// Right code
+unsigned char *pdata = (unsigned char *) data.c_str();
for (size_t i = 0; i size; i += 2)
{
- unicode_t ch = (data[i] 8) | data[i+1];
+ unicode_t ch = (pdata[i] 8) | pdata[i+1];
writer.writeChars((const unsigned char*) ch, 2);
}
+// End patch
}
return writer.getCur() - beg;
}
Bug#363312: easytag: Tabular view for quick checking of tags
Hi Eric, Just an advise for this request : you can view all tag information on one time by using the search window. Enter no word and press the search button. All files of the list will be displayed ;-) Jerome Erich Schubert wrote, the 18/04/2006 13:58 : Package: easytag Version: 1.99.12-1 Severity: wishlist It would be helpful to have a tabular view, especially for checking that both album and artist are written in a consistent way (caps, special chars...) You can do it somewhat for the artist (using the artist-album-view) but you can't easily do it for VA-albums or even a series of them (e.g. the Hôtel Costes series, or Café del Mar). iTunes has such a view, and apparently people like it a lot (I've never used it, but it seems useful to me): http://www1.cs.columbia.edu/~paley/spring03/assignments/HW1/jeffrey/Interfaces.html Note that font size is a key factor here, it might be useful to allow the user to reduce the font size (I have 135 dpi, so my fonts are rather large in pixels, so I could still read them at ~70% of their size, just not as comfortable for regular work use) -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/dash Kernel: Linux 2.6.16.5 Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=UTF-8) Versions of packages easytag depends on: ii libatk1.0-0 1.11.4-1 The ATK accessibility toolkit ii libc6 2.3.6-7GNU C Library: Shared libraries ii libcairo2 1.0.4-1+b1 The Cairo 2D vector graphics libra ii libflac7 1.1.2-3.1 Free Lossless Audio Codec - runtim ii libfontconfig12.3.2-5.1 generic font configuration library ii libfreetype6 2.1.10-3 FreeType 2 font engine, shared lib ii libgcc1 1:4.1.0-1 GCC support library ii libglib2.0-0 2.10.2-1 The GLib library of C routines ii libgtk2.0-0 2.8.17-1 The GTK+ graphical user interface ii libid3-3.8.3c2a 3.8.3-5Library for manipulating ID3v1 and ii libogg0 1.1.3-2Ogg Bitstream Library ii libpango1.0-0 1.12.1-2 Layout and rendering of internatio ii libpng12-01.2.8rel-5.1 PNG library - runtime ii libstdc++64.1.0-1The GNU Standard C++ Library v3 ii libvorbis0a 1.1.2-1The Vorbis General Audio Compressi ii libvorbisfile31.1.2-1The Vorbis General Audio Compressi ii libx11-6 2:1.0.0-6 X11 client-side library ii libxcursor1 1.1.5.2-3 X cursor management library ii libxext6 1:1.0.0-3 X11 miscellaneous extension librar ii libxfixes31:3.0.1.2-2+b1 X11 miscellaneous 'fixes' extensio ii libxi61:1.0.0-3 X11 Input extension library ii libxinerama1 1:1.0.1-2 X11 Xinerama extension library ii libxrandr22:1.1.0.2-3X11 RandR extension library ii libxrender1 1:0.9.0.2-3X Rendering Extension client libra ii zlib1g1:1.2.3-11 compression library - runtime easytag recommends no packages. -- no debconf information -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#342122: easytag: Forgets order of files in explorer
Hi, This bug was fixed in version 1.99.11 Jerome -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#342122: easytag: Forgets order of files in explorer
Hi,
Indeed, there is a problem when saving the configuration, fixed in the
attached patch
Jerome
Javier Kohen wrote, the 05.12.2005 16:13 :
Package: easytag
Version: 1.99.10-1
Severity: minor
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Since I upgraded from version 1.99.9, EasyTag started forgetting the order of the files in the
explorer. Changing the setting takes effect for the current session, but after restarting the
application the setting switches back to descending, by name. Before the upgrade the
option was set to ascending, by track number.
I'm cc'ing upstream in this report.
--
EasyTAG - Tag editor for MP3 and Ogg Vorbis files
http://easytag.sourceforge.net
--
Jerome COUDERC [EMAIL PROTECTED]
diff -ruN easytag-1.99.10.orig/src/setting.c easytag-1.99.10/src/setting.c
--- easytag-1.99.10.orig/src/setting.c 2005-11-25 23:23:25.0 +0100
+++ easytag-1.99.10/src/setting.c 2005-12-06 23:27:57.579884512 +0100
@@ -132,7 +132,7 @@
{ogg_tag_write_xmms_comment, CV_TYPE_BOOL,OGG_TAG_WRITE_XMMS_COMMENT },
{set_focus_to_same_tag_field, CV_TYPE_BOOL,SET_FOCUS_TO_SAME_TAG_FIELD },
{set_focus_to_first_tag_field, CV_TYPE_BOOL,SET_FOCUS_TO_FIRST_TAG_FIELD },
-{sorting_file_mode,CV_TYPE_BOOL,SORTING_FILE_MODE},
+{sorting_file_mode,CV_TYPE_INT, SORTING_FILE_MODE},
{sorting_file_case_sensitive, CV_TYPE_BOOL,SORTING_FILE_CASE_SENSITIVE },
{replace_illegal_character_in_filename,CV_TYPE_BOOL,REPLACE_ILLEGAL_CHARACTERS_IN_FILENAME },
@@ -168,7 +168,7 @@
{audio_file_player, CV_TYPE_STRING,AUDIO_FILE_PLAYER },
-{scanner_type, CV_TYPE_BOOL,SCANNER_TYPE },
+{scanner_type, CV_TYPE_INT, SCANNER_TYPE },
{fts_convert_underscore_and_p20_into_space,CV_TYPE_BOOL,FTS_CONVERT_UNDERSCORE_AND_P20_INTO_SPACE},
{fts_convert_space_into_underscore,CV_TYPE_BOOL,FTS_CONVERT_SPACE_INTO_UNDERSCORE},
{rfs_convert_underscore_and_p20_into_space,CV_TYPE_BOOL,RFS_CONVERT_UNDERSCORE_AND_P20_INTO_SPACE},
Bug#324046: Crashes when I click on any directory in the left panel
Hi, This problem was fixed in the version 1.99.10. Regards, Jerome Jérôme COUDERC wrote, the 19/11/2005 23:47 : Thanks for the patch, I'll include it in the next version Jerome -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#341277: [Fwd: Log for successful build of easytag_1.99.10-1 (dist=unstable)]
Sorry for the problem, I've also just noted it. Jerome dann frazier wrote, the 29.11.2005 20:19 : Package: easytag Version: 1.99.10-1 Severity: important Tags: patch Our automated buildd log filter[1] detected a problem that will cause your package to segfault on architectures where the size of a pointer is greater than the size of an integer, such as ia64. [1]http://people.debian.org/~dannf/check-implicit-pointer-functions --- easytag-1.99.10.orig/src/flac_tag.c 2005-11-28 14:49:17.0 -0700 +++ easytag-1.99.10/src/flac_tag.c 2005-11-29 11:26:22.0 -0700 @@ -40,7 +40,7 @@ #include misc.h #include setting.h #include charset.h - +#include picture.h /*** * Declaration * Subject: Log for successful build of easytag_1.99.10-1 (dist=unstable) From: Debian/IA64 non-US Build Daemon [EMAIL PROTECTED] Date: Tue, 29 Nov 2005 14:06:55 + To: undisclosed-recipients: ; To: undisclosed-recipients: ; Function `Picture_Copy' implicitly converted to pointer at flac_tag.c:639 -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#341277: [Fwd: Log for successful build of easytag_1.99.10-1 (dist=unstable)]
One other warning can be displayed due to a missing prototype into et_core.h Here is the patch fixing the two problems Jerome Jérôme COUDERC wrote, the 29.11.2005 22:39 : Sorry for the problem, I've also just noted it. Jerome -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] diff -ruN easytag-1.99.10.orig/src/et_core.h easytag-1.99.10/src/et_core.h --- easytag-1.99.10.orig/src/et_core.h 2005-09-08 00:04:05.0 +0200 +++ easytag-1.99.10/src/et_core.h 2005-11-29 23:11:09.986322520 +0100 @@ -358,6 +358,7 @@ ET_File *ET_File_Item_New (void); File_Name *ET_File_Name_Item_New (void); File_Tag *ET_File_Tag_Item_New (void); +gboolean ET_Free_File_Tag_Item (File_Tag *FileTag); gboolean ET_Free_File_List_Item (ET_File *ETFile); gboolean ET_Copy_File_Tag_Item (ET_File *ETFile, File_Tag *FileTag); diff -ruN easytag-1.99.10.orig/src/flac_tag.c easytag-1.99.10/src/flac_tag.c --- easytag-1.99.10.orig/src/flac_tag.c 2005-11-28 22:49:17.0 +0100 +++ easytag-1.99.10/src/flac_tag.c 2005-11-29 23:11:35.567433600 +0100 @@ -39,6 +39,7 @@ #include id3_tag.h #include misc.h #include setting.h +#include picture.h #include charset.h
Bug#324046: Crashes when I click on any directory in the left panel
Hi,
Could you try is the attached patch have also an effect for this problem?
Jerome
--
EasyTAG - Tag editor for MP3 and Ogg Vorbis files
http://easytag.sourceforge.net
--
Jerome COUDERC [EMAIL PROTECTED]
diff -ruN easytag-1.99.9.orig/src/browser.c easytag-1.99.9/src/browser.c
--- easytag-1.99.9.orig/src/browser.c 2005-10-22 23:29:54.0 +0200
+++ easytag-1.99.9/src/browser.c2005-11-07 19:57:58.0 +0100
@@ -279,6 +279,8 @@
GtkTreeIter selectedIter;
gchar *path;
+if (!BrowserTree) return NULL;
+
selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(BrowserTree));
if (gtk_tree_selection_get_selected(selection, NULL, selectedIter))
{
@@ -325,7 +327,7 @@
*/
void Browser_Reload_Directory (void)
{
-if (BrowserCurrentPath != NULL)
+if (BrowserTree BrowserCurrentPath != NULL)
{
// Unselect files, to automatically reload the file of the directory
gtk_tree_selection_unselect_all(gtk_tree_view_get_selection(GTK_TREE_VIEW(BrowserTree)));
@@ -410,6 +412,8 @@
GtkTreeSelection *treeSelection;
GtkTreePath *treePath;
+if (!tree) return FALSE;
+
treeSelection = gtk_tree_view_get_selection(GTK_TREE_VIEW(tree));
if (event event-type==GDK_KEY_PRESS)
@@ -470,7 +474,6 @@
*/
gboolean Browser_List_Key_Press (GtkWidget *list, GdkEvent *event, gpointer
data)
{
-
gchar *string, *current_filename = NULL, *current_filename_copy = NULL,
*temp;
static gchar *key_string = NULL;
gint key_string_length;
@@ -480,12 +483,15 @@
GdkEventKey *kevent;
GtkTreePath *currentPath = NULL;
-GtkTreeIter currentIter;
-ET_File *currentETFile;
+GtkTreeIter currentIter;
+ET_File *currentETFile;
-GtkTreeModel *fileListModel;
+GtkTreeModel *fileListModel;
GtkTreeSelection *fileSelection;
+
+if (!list) return FALSE;
+
fileListModel = gtk_tree_view_get_model(GTK_TREE_VIEW(list));
fileSelection = gtk_tree_view_get_selection(GTK_TREE_VIEW(list));
@@ -623,6 +629,8 @@
{
GtkTreePath *rootPath;
+if (!BrowserTree) return;
+
gtk_tree_view_collapse_all(GTK_TREE_VIEW(BrowserTree));
/* But keep the main directory opened */
rootPath = gtk_tree_path_new_first();
@@ -636,6 +644,8 @@
*/
void Browser_Tree_Set_Node_Visible (GtkWidget *directoryView, GtkTreePath *
path)
{
+if (!directoryView) return;
+
gtk_tree_view_scroll_to_cell(GTK_TREE_VIEW(directoryView), path, NULL,
TRUE, 0.5, 0.0);
}
@@ -651,6 +661,9 @@
* See function gtk_tree_view_get_visible_rect() ??
*/
GtkTreePath *rowPath;
+
+if (!treeModel) return;
+
rowPath = gtk_tree_model_get_path(treeModel, rowIter);
gtk_tree_view_scroll_to_cell(GTK_TREE_VIEW(BrowserList), rowPath, NULL,
FALSE, 0, 0);
gtk_tree_path_free(rowPath);
@@ -756,6 +769,8 @@
gchar *nodeName;
gchar *temp;
+if (!BrowserTree) return FALSE;
+
// Expand root node
rootPath = gtk_tree_path_new_first();
gtk_tree_view_expand_to_path(GTK_TREE_VIEW(BrowserTree), rootPath);
@@ -1295,6 +1310,8 @@
*/
void Browser_List_Select_File_By_Iter (GtkTreeIter *rowIter, gboolean
select_it)
{
+if (!BrowserList) return;
+
if (select_it)
{
GtkTreeSelection *selection =
gtk_tree_view_get_selection(GTK_TREE_VIEW(BrowserList));
@@ -1314,6 +1331,8 @@
{
GtkTreeIter iter;
+if (!fileListModel || !BrowserList) return;
+
if(gtk_tree_model_get_iter_from_string(GTK_TREE_MODEL(fileListModel),
iter, stringIter))
{
if(select_it)
@@ -1341,6 +1360,8 @@
gchar *current_filename = NULL, *current_title = NULL;
int max = 0, this;
+if (!fileListModel || !BrowserList) return NULL;
+
if (gtk_tree_model_get_iter_first(GTK_TREE_MODEL(fileListModel), iter))
{
do
@@ -1406,8 +1427,11 @@
*/
void Browser_List_Unselect_File_By_Iter (GtkTreeIter *rowIter)
{
-GtkTreeSelection *selection =
gtk_tree_view_get_selection(GTK_TREE_VIEW(BrowserList));
+GtkTreeSelection *selection;
+
+if (!BrowserList) return;
+selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(BrowserList));
g_signal_handlers_block_by_func(G_OBJECT(selection),G_CALLBACK(Browser_List_Row_Selected),NULL);
gtk_tree_selection_unselect_iter(selection, rowIter);
g_signal_handlers_unblock_by_func(G_OBJECT(selection),G_CALLBACK(Browser_List_Row_Selected),NULL);
@@ -1592,8 +1616,11 @@
*/
void Browser_List_Select_All_Files (void)
{
-GtkTreeSelection *selection =
gtk_tree_view_get_selection(GTK_TREE_VIEW(BrowserList));
+GtkTreeSelection *selection;
+
+if (!BrowserList) return;
+selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(BrowserList));
// Must block the select signal to avoid the selecting, one by one, of all
files in the main files list
g_signal_handlers_block_by_func(G_OBJECT(selection),G_CALLBACK(Browser_List_Row_Selected),NULL);
Bug#324046: Crashes when I click on any directory in the left panel
Thanks for the patch, I'll include it in the next version Jerome Falk Hueffner wrote, the 19.11.2005 20:36 : No, it doesn't. This patch does fix it. -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#336465: easytag: mp4/m4a tag editing does not work
You have probably installed mpeg4ip-1.2 which doesn't contains the fuctions MP4DeleteMetadataX... In fact : - EasyTAG 1.99.8 needs mpeg4ip-1.3 - EasyTAG 1.99.9 needs at least mpeg4ip-1.2 If you want to compile 1.99.8 for example with meg4ip-1.2 (and not 1.99.9), you can copy the source file mp4_tag.c from version 1.99.9 to version 1.99.8. Of course it recommend you to use EasyTAG 1.99.9 Jerome Adam Rosi-Kessel wrote, the 06/11/2005 19:04 : Yes, that looks like the problem. It would be great if the Debian package could support MP4/AAC, but I don't think the necessary libraries are in Debian. When I tried to rebuild the Debian package with the third party mpeg4ip DEBs from rarewares, it fails to build with this error: mp4_tag.o: In function `Mp4tag_Write_File_Tag': /usr/src/easytag-1.99.8/src/mp4_tag.c:357: undefined reference to `MP4DeleteMetadataGenre' /usr/src/easytag-1.99.8/src/mp4_tag.c:399: undefined reference to `MP4DeleteMetadataCoverArt' /usr/src/easytag-1.99.8/src/mp4_tag.c:254: undefined reference to `MP4DeleteMetadataName' /usr/src/easytag-1.99.8/src/mp4_tag.c:276: undefined reference to `MP4DeleteMetadataAlbum' /usr/src/easytag-1.99.8/src/mp4_tag.c:265: undefined reference to `MP4DeleteMetadataArtist' /usr/src/easytag-1.99.8/src/mp4_tag.c:328: undefined reference to `MP4DeleteMetadataYear' /usr/src/easytag-1.99.8/src/mp4_tag.c:346: undefined reference to `MP4DeleteMetadataTrack' /usr/src/easytag-1.99.8/src/mp4_tag.c:390: undefined reference to `MP4DeleteMetadataTool' /usr/src/easytag-1.99.8/src/mp4_tag.c:379: undefined reference to `MP4DeleteMetadataWriter' /usr/src/easytag-1.99.8/src/mp4_tag.c:368: undefined reference to `MP4DeleteMetadataComment' /usr/src/easytag-1.99.8/src/mp4_tag.c:317: undefined reference to `MP4DeleteMetadataDisk' collect2: ld returned 1 exit status I suppose that this bug should perhaps be re-classified as a wishlist bug to include MP4/AAC support and/or the documentation should be clarified that there is not currently MP4/AAC support in Debian. -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#336465: easytag: mp4/m4a tag editing does not work
Hi Adam, May be the MP4 support was disabled when compiling your binary (./configure --disable-mp4). In this case, the message (MP4/AAC file support disabled) must appears in the about window. Regards, Jerome Adam Kessel wrote, the 30.10.2005 14:43 : Package: easytag Version: 1.99.8-1 Severity: normal Despite the changelog entries indicating that mp4 tags can now be editing, easytag never shows any information or allows editing of any mp4 files that I have tested. I've tried setting the extension to both mp4 and m4a with no change in the results. It also appears to expect mpeg4ip to be installed, which is not in Debian at all. I installed the rarewares package, but it did not change the result--still no mp4 tagging. -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.13-swsus Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1) Versions of packages easytag depends on: ii libatk1.0-0 1.10.3-1 The ATK accessibility toolkit ii libc6 2.3.5-7 GNU C Library: Shared libraries an ii libflac71.1.2+cvs20050302.20-0.1 Free Lossless Audio Codec - runtim ii libglib2.0-02.8.3-1 The GLib library of C routines ii libgtk2.0-0 2.6.10-1 The GTK+ graphical user interface ii libid3-3.8.3c2 3.8.3-4.2Library for manipulating ID3v1 and ii libogg0 1.1.2-1 Ogg Bitstream Library ii libpango1.0-0 1.8.2-3 Layout and rendering of internatio ii libstdc++6 4.0.2-3 The GNU Standard C++ Library v3 ii libvorbis0a 1.1.0-1 The Vorbis General Audio Compressi ii libvorbisfile3 1.1.0-1 The Vorbis General Audio Compressi ii zlib1g 1:1.2.3-6compression library - runtime easytag recommends no packages. -- no debconf information -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#281255: easytag: Character Set for ID3 tags still broken
This was fixed in the new version 1.99.9 released today Jerome Javier Kohen wrote, the 14/11/2004 20:06 : Package: easytag Version: 1.0-1 Severity: normal Version 1.0 of easytag attempted to fix the writing of ID3 tags on UTF-8 systems and provide a few options to fix tags that were previously incorrectly encoded. Unfortunately the recommended option, despite being labeled as Use standard ISO-8859-1 character set for ID3 tags, writes the tags as UTF-8 within an ISO-8859-1 frame. See my report #246856 for more information on that problem. Simultaneously, the feature that in theory allows to fix characters sets in ID3 tags seems to be broken. Strictly speaking, it seems to be doing nothing at all; the tags are still written as in old versions, i.e., as depicted above. I set my options to UTF-8/UTF-8/UTF-8 and UTF-8/UTF-8/UTF-16BE and the results were always the same (for instance, it's easy to see with a binary editor that UTF-16BE wasn't used to write the tags). Thanks, -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#246856: easytag: Wrong encoding used for tags
This was fixed in the new version 1.99.9 released today Jerome Javier Kohen wrote, the 01/05/2004 22:40 : Package: easytag Version: 0.30-4 Severity: normal Hi, I found that there's either a bug in easytag or the underlying libid3 library, but all tags are being saved with an encoding byte of 0x00, which means ISO-8859-1 encoding. Now, my locale is set to use UTF-8, and so the contents which are being actually written are UTF-8, but as the tag is marked with a different encoding, programs like rhythmbox show incorrect values. I edited a tag by hand and modified its encoding byte to 0x03 (UTF-8) and that solved the problem, for that tag only, of course. For what it's worth, I don't have the charset transcoding setting enabled, whatever it's called in English. I use Easytag in Spanish, and if I try to set LANG to empty or English, all I see are empty boxes instead of characters, so I don't know what the name of this setting in English is. Ogg files seem to work fine. I guess I'll have to retag all/most my MP3 files, any suggestion? I guess I could write a custom application to fix them. -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Kernel: Linux 2.6.4 Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 Versions of packages easytag depends on: hi libc6 2.3.2.ds1-11 GNU C Library: Shared libraries an hi libflac41.1.0-4 Free Lossless Audio Codec - runtim ii libglib1.2 1.2.10-9 The GLib library of C routines ii libgtk1.2 1.2.10-16The GIMP Toolkit set of widgets fo hi libid3-3.8.33.8.3-3 Library for manipulating ID3v1 and ii libogg0 1.1.0-1 Ogg Bitstream Library hi libstdc++5 1:3.3.3-1The GNU Standard C++ Library v3 ii libvorbis0a 1.0.1-1 The Vorbis General Audio Compressi ii libvorbisfile3 1.0.1-1 The Vorbis General Audio Compressi hi libx11-64.3.0-5 X Window System protocol client li hi libxext64.3.0-5 X Window System miscellaneous exte hi libxi6 4.3.0-5 X Window System Input extension li hi xlibs 4.3.0-3 X Window System client libraries m hi zlib1g 1:1.2.1-4compression library - runtime -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#281292: - libid3-3.8.3: Missing function in C wrapper
Robert Woodcock wrote, the 15/09/2005 02:56 : Let me get this straight. EasyTAG will expect users of other distributions (or people who wish to compile it themselves) to compile id3lib themselves, with their patch, to be able to compile and use EasyTAG? Of course, this will be an ideal world ;-) Don't worry, EasyTAG will be compatible with the current id3lib version, but without Unicode support, as presently (it is a real shame)... We are waiting for this patch since one year, but it seems that there is no activity on this project... Regards, Jerome -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#281292: - libid3-3.8.3: Missing function in C wrapper
Hi Robert, As in the next version of EasyTAG, I will include the patch from Javier to enable/fix UTF-16 reading with C wrapper, I wanted to know if you intend to apply to patch id3lib+c_wrapper_encoding.diff http://bugs.debian.org/cgi-bin/bugreport.cgi/id3lib%252Bc_wrapper_encoding.diff?bug=281292;msg=15;att=1 supplied by Javier? This patch couldn't break the library as it adds only some C wrappers. So there is no risk. Moreover it will be necessary to allow compilation of future EasyTAG versions... Thanks in advance, Jerome -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#324046: Crashes when I click on any directory in the left panel
This message may appears if some lines are displayed in red. Because sometimes it does automatical changes (strip spaces, check if both tags are present, ...) Whatever... still a strange bug... But I assume that the first time il load files in the defaut directory Jerome Falk Hueffner wrote, the 08.09.2005 23:55 : I get a slightly better backtrace: Program received signal SIGSEGV, Segmentation fault. 0x026f2d18 in g_type_fundamental () from /usr/lib/libgobject-2.0.so.0 (gdb) vr Undefined command: vr. Try help. (gdb) bt #0 0x026f2d18 in g_type_fundamental () from /usr/lib/libgobject-2.0.so.0 #1 0x026d9778 in g_object_new () from /usr/lib/libgobject-2.0.so.0 #2 0x00012005e9f0 in msg_box_new (title=0x120093528 Confirm..., message=0x120093533 Some files have been modified but not saved...\nDo you want to save them before changing the directory?, stock_id=0x12009359a gtk-dialog-question) at msgbox.c:133 #3 0x00012001eebc in Browser_Tree_Node_Selected (selection=Variable selection is not available. ) at browser.c:679 So it crashes when creating a dialog box. Looks like heap corruption, because the parameters to msg_box_new look OK. (BTW, why does it want to show this dialog box? I didn't change anything, it just displayed the list of mp3s. Is this the normal behavior?) -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#324046: Crashes when I click on any directory in the left panel
Hum... strange bug... The crash occurs for *all* directories in the left panel? There are special characters in the directories name? Have you tried to define [EMAIL PROTECTED] instead of LANG=C ? Regards, Jerome Falk Hueffner wrote, the 20/08/2005 20:09 : Sebastien Bacher [EMAIL PROTECTED] writes: Thanks for your bug. Can you get a backtrace with gdb? Program received signal SIGSEGV, Segmentation fault. 0x026efca8 in g_type_fundamental () from /usr/lib/libgobject-2.0.so.0 (gdb) bt #0 0x026efca8 in g_type_fundamental () from /usr/lib/libgobject-2.0.so.0 #1 0x026d6038 in g_object_new () from /usr/lib/libgobject-2.0.so.0 #2 0x00012005fd4c in ?? () #3 0x000120014734 in ?? () #4 0x026de144 in g_cclosure_marshal_VOID__VOID () from /usr/lib/libgobject-2.0.so.0 #5 0x026cd084 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 #6 0x026e2cd4 in g_signal_stop_emission () from /usr/lib/libgobject-2.0.so.0 #7 0x026e4b0c in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 #8 0x026e4fd4 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 #9 0x022ba73c in _gtk_tree_selection_internal_select_node () from /usr/lib/libgtk-x11-2.0.so.0 #10 0x022d299c in gtk_tree_view_scroll_to_cell () from /usr/lib/libgtk-x11-2.0.so.0 #11 0x022de1ac in gtk_tree_view_set_model () from /usr/lib/libgtk-x11-2.0.so.0 #12 0x021bb96c in _gtk_marshal_BOOLEAN__BOXED () from /usr/lib/libgtk-x11-2.0.so.0 #13 0x026cc950 in g_cclosure_new_swap () from /usr/lib/libgobject-2.0.so.0 #14 0x026cd084 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 #15 0x026e2e80 in g_signal_stop_emission () from /usr/lib/libgobject-2.0.so.0 #16 0x026e4724 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 #17 0x026e4fd4 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 #18 0x022f7554 in gtk_widget_activate () from /usr/lib/libgtk-x11-2.0.so.0 #19 0x021b9034 in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0 #20 0x021b96b4 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0 #21 0x02484d6c in _gdk_events_queue () from /usr/lib/libgdk-x11-2.0.so.0 #22 0x02780c94 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 #23 0x027852b8 in g_main_context_check () from /usr/lib/libglib-2.0.so.0 #24 0x02785814 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0 #25 0x021b828c in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 #26 0x000120041dd0 in ?? () #27 0x02ad1988 in __libc_start_main () from /lib/libc.so.6.1 #28 0x00012000d108 in ?? () Previous frame inner to this frame (corrupt stack?) (gdb) -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#324046: Crashes when I click on any directory in the left panel
It is the first time I heard a such problem... Just to test : could you compile EasyTAG from sources and send me again a back trace if the crash occurs, please? Because may be, this could solve the problem on your system. Regards, Jerome Falk Hueffner wrote, the 07.09.2005 21:16 : Jérôme COUDERC [EMAIL PROTECTED] writes: Hum... strange bug... The crash occurs for *all* directories in the left panel? Yes. I noticed though that there is no crash as long as not at least one mp3 is found. -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED]
Bug#292188: easytag sometimes hangs when checking CDDB database
Hi,
Here is attached a patch for EasyTAG 1.99.7 which should solve the
problem (thanks to Paul Giordano)
Regards,
Jerome
Rogério Brito wrote, the 25.01.2005 17:27 :
Package: easytag
Version: 1.99.3-1
Severity: normal
Hi, Seb.
This is something that I've seen since the 1.0 version (when I seriously
started using easytag for managing my MP3 collection).
Sometimes, when I select all the files in a directory and ask the CDDB
(actually FreeDB) database for the information regarding a given album, it
hangs in the connection and nothing else can be done with easytag.
It still accepts the -TERM signal, though. This is not easy to reproduce
and it seems to have gone away when I switched the FreeDB server that I use
to the US one, but I'm still not sure if it has indeed gone away for good.
Anyway, thank you very much for packaging easytag. It's really amazing.
Thanks, Rogério.
--
EasyTAG - Tag editor for MP3 and Ogg Vorbis files
http://easytag.sourceforge.net
--
Jerome COUDERC [EMAIL PROTECTED]
diff -ruN easytag-1.99.7.orig/src/cddb.c easytag-1.99.7/src/cddb.c
--- easytag-1.99.7.orig/src/cddb.c 2005-07-01 23:54:36.0 +0200
+++ easytag-1.99.7/src/cddb.c 2005-08-22 23:02:27.0 +0200
@@ -1861,6 +1861,7 @@
gchar *art_alb_tmp = NULL;
gboolean use_art_alb = FALSE;
gchar *end_str;
+gchar *html_end_str;
gchar buffer[CDDB_ANSWER_LINE_SIZE+1];
gint bytes_written;
gint bytes_read;
@@ -1964,10 +1965,11 @@
// Read other lines,and get list of matching albums
// Composition of a line :
// a href=http://www.freedb.org/freedb_search_fmt.php?cat=rockid=8c0f0a0b;Bob Dylan / MTV Unplugged/abr
-cat_str = g_strdup(http://www.freedb.org/freedb_search_fmt.php?cat=;);
-id_str = g_strdup(id=);
-art_alb_str = g_strdup(\);
-end_str = g_strdup(/a); ///abr);
+cat_str = g_strdup(http://www.freedb.org/freedb_search_fmt.php?cat=;);
+id_str = g_strdup(id=);
+art_alb_str = g_strdup(\);
+end_str = g_strdup(/a); ///abr);
+html_end_str = g_strdup(/body); // To avoid the cddb lookups to hang
while ( CddbWindow !CddbStopSearch (bytes_read=Cddb_Read_Line(socket_id,cddb_out)) 0 )
{
gchar *size_str;
@@ -2063,7 +2065,7 @@
cddbalbum-artist_album = valid;
-if(use_art_alb)
+if (use_art_alb)
{
art_alb_tmp = valid;
use_art_alb = FALSE;
@@ -2074,8 +2076,18 @@
CddbAlbumList = g_list_append(CddbAlbumList,cddbalbum);
}
+
+// To avoid the cddb lookups to hang (Patch from Paul Giordano)
+/* It appears that on some systems that cddb lookups continue to attempt
+ * to get data from the socket even though the other system has completed
+ * sending. Here we see if the actual end of data is in the last block read.
+ * In the case of the html scan, the /body tag is used because there's
+ * no crlf followint the /html tag.
+ */
+if (strstr(cddb_out_tmp,html_end_str)!=NULL)
+break;
}
-g_free(cat_str); g_free(id_str); g_free(art_alb_str); g_free(end_str);
+g_free(cat_str); g_free(id_str); g_free(art_alb_str); g_free(end_str); g_free(html_end_str);
gtk_widget_set_sensitive(GTK_WIDGET(CddbStopSearchButton),FALSE);
gtk_widget_set_sensitive(GTK_WIDGET(CddbStopSearchAutoButton),FALSE);
@@ -2120,6 +2132,7 @@
gchar *tmp;
gchar *query_string;
gchar *cddb_discid;
+gchar *cddb_end_str;
guint total_frames = 150; /* First offset is (almost) always 150 */
guint disc_length = 2; /* and 2s elapsed before first track */
@@ -2296,6 +2309,7 @@
return FALSE;
}
bytes_read_total = bytes_read;
+cddb_end_str = g_strdup(.);
while ( CddbWindow !CddbStopSearch (bytes_read=Cddb_Read_Line(socket_id,cddb_out)) 0 )
{
@@ -2312,6 +2326,16 @@
cddb_out_tmp = cddb_out;
//g_print(%s\n,cddb_out);
+// To avoid the cddb lookups to hang (Patch from Paul Giordano)
+/* It appears that on some systems that cddb lookups continue to attempt
+ * to get data from the socket even though the other system has completed
+ * sending. The fix adds one check to the loops to see if the actual
+ * end of data is in the last block read. In this case, the last line
+ * will be a single '.'
+ */
+if ( bytes_read=3 strstr(cddb_out_tmp,cddb_end_str)!=NULL )
+break;
+
// Reading of lines with albums (skiping return code lines : 211 Found inexact matches, list follows (until terminating `.'))
if (cddb_out != NULL strstr(cddb_out_tmp,/) != NULL)
{
@@ -2360,6 +2384,7 @@
CddbAlbumList = g_list_append(CddbAlbumList,cddbalbum);
}
}
+g_free(cddb_end_str);
Bug#292033: easytag: Wrong tab order in ID3 label editor
Hi Javier, I'm not sure to understand what is your problem with the tab key, because the entry field get the focus before the apply to all button... And if you want to jump from an entry field, to another one, just press the enter key... So the order seems right for me... Could you give more information? Jerome Javier Kohen wrote, the 24.01.2005 18:45 : The tab order for the widgets in the ID3 label editor is, in my opinion, incorrect, as it takes you first to the apply to all selected files checkbox first rather than the associated field. In other words, if the title text field has focus and you hit tab the focus is transferred to the artist field's checkbox. The way I use EasyTag is editing one field and then applying the changes to all files (if appropriate), which is how 1.0 and previous versions worked. Thanks, -- EasyTAG - Tag editor for MP3 and Ogg Vorbis files http://easytag.sourceforge.net -- Jerome COUDERC [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
