Bug#863154: dbconfig-common: dbc_sql_substitution should be evaluated on upgrades, not only on installations
Hi Paul, On 23.05.2017 at 20:27 wrote Paul Gevers: > On 23-05-17 11:04, Joerg Steffens wrote: >>> Great. Except that because dbconfig is implemented in sh, you need to >>> check the exit value of every command line (and no, set -e doesn't >>> guarantee that already; that is why all these "|| return $?" are there). >> >> I see. However, the only lines where this might make sense are: >> tsubstfile=$(dbc_mktemp) >> /usr/sbin/dbconfig-generate-include -f template -o >> template_infile=$sqlfile $dbc_packageconfig > $tsubstfile > > Indeed. > >> I can add it there, however, similar lines at other places of the code >> are also without "|| return $?". > > Hmm, than that may be a bug. Which lines do you have in mind? These lines are used 4 times in dpkg/postinst: 2 times for install, 2 times added by me for updates. None of them have the "|| return $?". Once more it is used in dpkg/prerm (not affected by my patch). >> Should I add these lines and sent the patch again? > > Trivial of course, not needed. Thanks. regards, Jörg -- Jörg Steffens joerg.steff...@bareos.com Bareos GmbH & Co. KGPhone: +49 221 630693-91 http://www.bareos.com Fax: +49 221 630693-10 Sitz der Gesellschaft: Köln | Amtsgericht Köln: HRA 29646 Komplementär: Bareos Verwaltungs-GmbH Geschäftsführer: S. Dühr, M. Außendorf, Jörg Steffens, P. Storz signature.asc Description: OpenPGP digital signature
Bug#863154: dbconfig-common: dbc_sql_substitution should be evaluated on upgrades, not only on installations
Hi Paul, On 22.05.2017 at 21:43 wrote Paul Gevers: [...] >> A patch for this functionality is included. > > Great. Except that because dbconfig is implemented in sh, you need to > check the exit value of every command line (and no, set -e doesn't > guarantee that already; that is why all these "|| return $?" are there). I see. However, the only lines where this might make sense are: tsubstfile=$(dbc_mktemp) /usr/sbin/dbconfig-generate-include -f template -o template_infile=$sqlfile $dbc_packageconfig > $tsubstfile I can add it there, however, similar lines at other places of the code are also without "|| return $?". Should I add these lines and sent the patch again? >> If you decide *NOT* to include it, please update the documentation for >> dbc_sql_substitution, so people get aware, that this behavior is intended. > > Will do, but I expect that won't be needed. > >> My current workaround is to run scripts/upgrade/NUMBER, which uses dbconfig- >> generate-include to create data/upgrade-dbadmin/NUMBER. > > Looks ugly. Indeed. >> Of course, this requires that dbconfig-common continues to executes upgrades >> in >> this order (scripts/upgrade, data/upgrade-dbadmin, data/upgrade), which is >> not >> guranteed. Please consider to keep this order, as we use build Bareos also >> for >> older distributions (Debian 7, Ubuntu 12.04). > > I should probably document the order. Excellent. One other question: is there a mailing list to discuss about dbconfig-common? Jörg -- Jörg Steffens joerg.steff...@bareos.com Bareos GmbH & Co. KGPhone: +49 221 630693-91 http://www.bareos.com Fax: +49 221 630693-10 Sitz der Gesellschaft: Köln | Amtsgericht Köln: HRA 29646 Komplementär: Bareos Verwaltungs-GmbH Geschäftsführer: S. Dühr, M. Außendorf, Jörg Steffens, P. Storz signature.asc Description: OpenPGP digital signature
Bug#767819: bareos-*: modifies conffiles (policy 10.7.3): /etc/bareos/bareos-*.conf
I would upload in my lunch-break if you do not object ;) Certainly. Please go ahead. regards, Jörg -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
