Package: multipath-tools
Version: 0.9.4-3
Severity: important
Tags: patch

Dear Maintainer,

Since verison 0.9.4-1, the multipath.rules udev file is no longer included in
the Debian package. Upstream changed from shipping a static file to a
file generated at build time (multipath.rules.in), and the debian packaging
didn't account for this change. I've come up with something that works, but
it might not be the best/correct solution according to packaging policy
and such.

The missing rules file results in missing udev device properties, such as
DM_MULTIPATH_DEVICE_PATH. This, at the very least, has the effect of:

1) Not skipping LVM device scanning on multipath path devices, which could
   result in a failure to bring up a multipath device. (or worse --
   I wouldn't be surprised if concurrently operating on a dm-multipath device
   and one or more of its child devices could cause data loss, if unlucky.)

2) Not removing partition table entries for multipath child devices.
   (the del-part-nodes rules apply if DM_MULTIPATH_DEVICE_PATH is set.)

If you need any more information, happy to provide it!

-- Package-specific info:
/etc/multipath.conf does not exist.


-- System Information:
Debian Release: 12.0
  APT prefers stable-security
  APT policy: (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-9-amd64 (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages multipath-tools depends on:
ii  init-system-helpers        1.65.2
ii  kpartx                     0.9.4-3
ii  libaio1                    0.3.113-4
ii  libc6                      2.36-9
ii  libdevmapper1.02.1         2:1.02.185-2
ii  libedit2                   3.1-20221030-2
ii  libjson-c5                 0.16-2
ii  libsystemd0                252.6-1
ii  libudev1                   252.6-1
ii  liburcu8                   0.13.2-1
ii  sg3-utils-udev             1.46-3
ii  sysvinit-utils [lsb-base]  3.06-4
ii  udev                       252.6-1

multipath-tools recommends no packages.

Versions of packages multipath-tools suggests:
pn  multipath-tools-boot  <none>

-- no debconf information

*** fix-missing-multipath-udev-rules.patch
commit 81d3e7e0a23bf7b384accd65d85070008ac7142a (HEAD -> master)
Author: Joshua Huber <jhu...@blockbridge.com>
Date:   Tue Jun 13 14:15:30 2023 -0400

    account for upstream multipath.rules changing to a generated file

diff --git a/debian/rules b/debian/rules
index 28839b67..e56419ae 100755
--- a/debian/rules
+++ b/debian/rules
@@ -47,9 +47,10 @@ override_dh_auto_install:
        [ ! -f kpartx/del-part-nodes.rules ] || cp kpartx/del-part-nodes.rules 
debian/kpartx.del-part-nodes.udev
        [ ! -f kpartx/dm-parts.rules ] || cp kpartx/dm-parts.rules 
debian/kpartx.dm-parts.udev
        [ ! -f kpartx/kpartx.rules ] || cp kpartx/kpartx.rules 
debian/kpartx.udev
-       [ ! -f multipath/multipath.rules ] || cp multipath/multipath.rules 
debian/multipath.udev
        [ ! -f multipath/11-dm-mpath.rules ] || cp multipath/11-dm-mpath.rules 
debian/dm-mpath.udev

+       cp -v debian/build-deb/multipath/multipath.rules 
debian/multipath-tools.multipath.udev
+
        dh_auto_install --sourcedirectory=debian/build-deb -- 
DESTDIR=$(CURDIR)/debian/tmp
        dh_auto_install --sourcedirectory=debian/build-udeb -- 
DESTDIR=$(CURDIR)/debian/tmp-multipath-udeb

Reply via email to