Bug#849249: fldigi: Icon improvements

[Kamal Mostafa]

Hi Jeremy-

Thanks for these fldigi patches -- I'm applying 0001 to fix the icons, but
not applying 0002 (the debian/rules cleanups), because this packaging is
still debian/compat==7 so it really does need the special dpkg-buildflags
handling to get build hardening.  Moving up to debhelper 9 is surely a good
idea, but lets handle that under separate cover -- I'll look at applying
your 0002 patch again whenever I or you or someone else gets to that work.

Thanks again for the icon fix!

 -Kamal

On Fri, Dec 23, 2016 at 10:15 PM, Jeremy Bicha  wrote:

> Package: fldigi
> Version: 3.23.14-1
> Tags: patch
>
> .xpm app icons are not necessary any more. If a package contains .xpm
> icons, it triggers an error in appstream. This means that fldigi does
> not show up in the GNOME Software app which is installed by default in
> the GNOME desktop in Debian stretch.
>
> https://appstream.debian.org/sid/main/issues/fldigi.html
> https://wiki.debian.org/AppStream/Guidelines#Icon_best_practices
>
> The .png app icons are installed in the wrong directory. They should
> be installed in a two-number directory like 64x64/ instead of a
> one-number directory like 64/
>
> There's some extra line in debian/rules. The dh_installdocs override
> isn't needed since there's only one binary package.
> --disable-silent-rules is the default as of debhelper 9.20150501. And
> dpkg-buildflags should be passed automatically without you having to
> do anything.
>
> I'm attaching patches for these.
>
> Thanks,
> Jeremy
>
>

Bug#850867: awscli now depends on python3-botocore >= 1.4

[Kamal Mostafa]

Package: awscli
Version: 1.11.13-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu zesty ubuntu-patch



*** /tmp/tmpjfIKJo/bug_body

In Ubuntu, the attached patch was applied to achieve the following:


awscli 1.11.? fails if installed with python3-botocore(<1.4), as reported
in https://bugs.launchpad.net/ubuntu/+source/awscli/+bug/1654315 .
Bumping the versioned dep to "python3-botocore(>=1.4.70)" resolves the glitch.


  * debian/control: awscli 1.11.? requires python3-botocore(>=1.4.?)
 - Depend on python3-botocore(>=1.4.70) (LP: #1654315)


Thanks for considering the patch.
diff -Nru awscli-1.11.13/debian/control awscli-1.11.13/debian/control
--- awscli-1.11.13/debian/control	2016-11-10 02:50:29.0 -0800
+++ awscli-1.11.13/debian/control	2017-01-10 11:24:55.0 -0800
@@ -22,7 +22,7 @@
 
 Package: awscli
 Architecture: all
-Depends: python3, python3-botocore(>=1.3.9), ${python3:Depends}, ${misc:Depends}
+Depends: python3, python3-botocore(>=1.4.70), ${python3:Depends}, ${misc:Depends}
 Description: Universal Command Line Environment for AWS
  This package provides a unified command line interface to many
  Amazon Web Services.

Bug#828580: trustedqsl: FTBFS with openssl 1.1.0

[Kamal Mostafa]

This is now fixed in upstream's repo:
https://sourceforge.net/p/trustedqsl/tqsl/ci/42ac55f0fd8a79fb7d72d82808b63244547b59ce/
so will be resolved by the next upstream release.

On Sun, Jun 26, 2016 at 3:24 AM, Kurt Roeckx  wrote:

> Source: trustedqsl
> Version: 2.2.1-1
> Severity: important
> Control: block 827061 by -1
>
> Hi,
>
> OpenSSL 1.1.0 is about to released.  During a rebuild of all packages using
> OpenSSL this package fail to build.  A log of that build can be found at:
>
> https://breakpoint.cc/openssl-1.1-rebuild-2016-05-29/Attempted/trustedqsl_2.2.1-1_amd64-20160529-1546
>
> On https://wiki.openssl.org/index.php/1.1_API_Changes you can see various
> of the
> reasons why it might fail.  There are also updated man pages at
> https://www.openssl.org/docs/manmaster/ that should contain useful
> information.
>
> There is a libssl-dev package available in experimental that contains a
> recent
> snapshot, I suggest you try building against that to see if everything
> works.
>
> If you have problems making things work, feel free to contact us.
>
>
> Kurt
>
>

Bug#813344: wx3.0-i18n and trustedqsl: error when trying to install together

[Kamal Mostafa]

Agreed: clearly trustedqsl's fault (they're in the upstream tarball for
some reason!).  I'll fix it post-haste.

 -Kamal

Bug#797021: ITP: midicsv -- translate MIDI file to CSV

[Kamal Mostafa]

Hi Santiago-

Santiago Vila wrote:

 I can't believe this is just a coincidence
 What kind of strange package hijacking is this?


Wow, that is quite a coincidence!  (But that's all it is...)


​On Sat, Aug 29, 2015 at 04:46:05PM -0400, Scott Kitterman wrote:

 Was there a previous ITP bug?


​
On Sat, Aug 29, 2015 at 11:24:12PM +0200, Santiago Vila wrote:

  Everything boils down to an ITP bug?


​
​
On Sat, Aug 29, 2015 at 2:52 PM, Paul Tagliamonte paul...@debian.org
 wrote:

 In the case of a dispite, well, yeah, that's clearly why they exist.

  I think this clearly shows my intent to package it:

 Sure, *your* intent, but that's not you getting the global mutex. If I
 want to package something, I'll search for a RFP or ITP, and use that.
 If I don't see anything, I put it in NEW.


​Yup, that's exactly what I did​ (as usual).
I discovered midicsv last week -- its just what I needed for a project I'm
working on, and seemed like a generally useful tool.

Finding no existing Debian package, no ITP, and no google hits for debian
midicsv, I filed an ITP, packaged it, and uploaded it to the new queue.


Santiago Vila wrote:

  https://people.debian.org/~sanvila/wip/

​
Paul Tagliamonte paul...@debian.org wrote:

  ... I surely don't look at every DD's people.d.o for a .dsc


​Of course.  Neither did I.  Because that's what ITP's are for.  I'm not
sure, Santiago, how you imagine that I or anyone else might have known of
your intent to package this.
​

​Paul Tagliamonte paul...@debian.org wrote:

 When two threads do work without both checking the mutex, you end up with
 a race condition when both try to write data back out.

 Live and learn. This is literally why ITPs exist.

 Frankly, you're assuming malice. That's out of line, Why not be friendly
 and create something positive out of this.


​Well said, Paul.​

Santiago, it is disappointing that you'd jump to the (wholly incorrect)
conclusion that I had somehow hijacked your package or your work.  Its
just a coincidence that we both happened to package this on the same day
(but I followed proper ITP upload procedures, whereas you didn't).

 -Kamal

Bug#797021: ITP: midicsv -- translate MIDI file to CSV

[Kamal Mostafa]

Package: wnpp
Severity: wishlist
Owner: Kamal Mostafa ka...@debian.org

* Package name: midicsv
  Version : 1.1
  Upstream Author : John Walker @ http://www.fourmilab.ch/
* URL : http://www.fourmilab.ch/webtools/midicsv/
* License : public-domain
  Programming Lang: C
  Description : translate MIDI file to CSV

Midicsv reads a standard MIDI file and decodes it into a CSV
(Comma-Separated Value) file which preserves all the information in the
MIDI file.  The ASCII CSV file may be loaded into a spreadsheet or database
application, or processed by a program to transform the MIDI data (for
example, to key transpose a composition or extract a track from a
multi-track sequence).  A CSV file in the format created by midicsv may be
converted back into a standard MIDI file with the csvmidi program.

Bug#784285: fix for morse: pa_simple_write failed

[Kamal Mostafa]

The bug in 'morse':

morse.d/beepPA.c opens a two-channel (stereo) PulseAudio stream, but then
mis-handles it as if it was just one channel of audio data, including
trying to write a non-mulitple of the (stereo) PulseAudio frame size via
pa_simple_write().  Earlier versions of PulseAudio silently ignored the
discrepancy, but newer versions rightly return a PulseAudio Invalid
argument error.

Attached patch to morse.d/beepPA.c fixes the bug.

 -Kamal
Author: Kamal Mostafa ka...@whence.com
Bug-Debian: https://bugs.debian.org/784285
Description: fix pa_simple_write error with mono output
Bug-Debian: https://bugs.debian.org/784285
Bug-Ubuntu: https://launchpad.net/bugs/1461755

   * Open a mono (not stereo) PulseAudio output stream and hence avoid
 improperly passing non-multiples of the frame size to pa_simple_write
 (Closes: #784285, LP: #1461755).

--- morse-2.4.orig/morse.d/beepPA.c
+++ morse-2.4/morse.d/beepPA.c
@@ -33,7 +33,7 @@ static pthread_cond_t beep_cv = PTHREAD_
 static const pa_sample_spec sample_format = {
 .format = PA_SAMPLE_S16LE,
 .rate = 44100,
-.channels = 2
+.channels = 1
 };
 
 static pa_simple *snddev;
@@ -47,7 +47,7 @@ static struct {
 static void play_tone()
 {
 int c;
-int len = (int)(sample_format.rate*beep_info.time/1000.0*2);
+int len = (int)(sample_format.rate*beep_info.time/1000.0);
 double t, tt;
 double v;
 int16_t *sample;
@@ -61,7 +61,7 @@ static void play_tone()
 } else {
 	tt = beep_info.time/1000.0;
 	for (c=0; clen; c+=2) {
-	t = c/((double)sample_format.rate*2.0); /* Time in s from start */
+	t = c/((double)sample_format.rate); /* Time in s from start */
 	v = (beep_info.volume/100.0) * sin(M_PI * 2 * t * beep_info.pitch);
 	if (t  0.01) {
 		/* Fade in softly over the first 10 ms */

Bug#593354: fldigi vs. xmonad: still a problem in fldigi 3.22.x?

[Kamal Mostafa]

Hi Mike and other fldigi+xmonad users:

Please test this bug (again!) with fldigi version 3.22.10-1, which contains
a possibly-relevant fix.  This start-up crash bug[0] resulted the fixing of
a long-standing bug in the fldigi window start-up order code, which might
affect the behavior reported here.

Thanks in advance!

 -Kamal

[0] https://bugs.launchpad.net/ubuntu/+source/fldigi/+bug/1448188

On Mon, Feb 9, 2015 at 9:47 AM, Mike Magin mma...@lowerarchy.com wrote:

 Hi Kamal and maintainers,

 I'm on jessie on amd64, fldigi 3.22.01-1 and xmonad 0.11-9.

 It is pretty easy for me to reproduce the bug.  All I need to do
 is have a workspace in the Tall mode, have a couple other apps
 windows open, position fldigi in the large space to the left,
 open the Signal Browser from the menu, and it's stuck.

 Making xmonad float all the windows of class Fldigi seems to
 prevent the problem, as previously mentioned.

 Nearly all of my Linux programming experience is non-GUI,
 so I'm not sure I'm in a position to fix this myself, but
 I am perfectly happy to help test fixes, etc.

 Thanks,
 Mike, AG6ET


 --
 To UNSUBSCRIBE, email to debian-hams-requ...@lists.debian.org
 with a subject of unsubscribe. Trouble? Contact
 listmas...@lists.debian.org
 Archive:
 https://lists.debian.org/20150209174746.gb29...@bob.lowerarchy.com

Bug#785745: ITP: flxmlrpc -- fldigi suite XmlRpc library

[Kamal Mostafa]

Package: wnpp
Severity: wishlist
Owner: Kamal Mostafa ka...@debian.org

* Package name: flxmlrpc
  Version : 0.1.4
  Upstream Author : Dave Freese iam_w1...@w1hkj.com
* URL : http://www.w1hkj.com/downloads/flxmlrpc/
* License : LGPL-3.0+
  Programming Lang: C++
  Description : fldigi suite XmlRpc library

 This package contains libflxmlrpc -- an customized implementation of the
 XmlRpc protocol -- used by fldigi, flrig, flnet, flmsg, flarq, flamp, fllog;
 a suite of programs written for amateur radio emergency communications.

---

 This library has been factored out by upstream, from the fl* suite of
 ham radio applications that use it, some of which are existing Debian
 packages.  After this libary package lands in Debian, those application
 packages will be changed to use this as a dependency.  Upstream intends
 to remove the bundled copy of this library from the applications at
 some point in the future.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#782515: [PATCH stable 3.10-3.16] tcp: Fix crash in TCP Fast Open

[Kamal Mostafa]

On Wed, 2015-04-15 at 19:00 +0100, Ben Hutchings wrote:
 Commit 355a901e6cf1 (tcp: make connect() mem charging friendly)
 changed tcp_send_syn_data() to perform an open-coded copy of the 'syn'
 skb rather than using skb_copy_expand().
 
 The open-coded copy does not cover the skb_shared_info::gso_segs
 field, so in the new skb it is left set to 0.  When this commit was
 backported into stable branches between 3.10.y and 3.16.7-ckty
 inclusive, it triggered the BUG() in tcp_transmit_skb().
 
 Since Linux 3.18 the GSO segment count is kept in the
 tcp_skb_cb::tcp_gso_segs field and tcp_send_syn_data() does copy the
 tcp_skb_cb structure to the new skb, so mainline and newer stable
 branches are not affected.
 
 Set skb_shared_info::gso_segs to the correct value of 1.
 
 Signed-off-by: Ben Hutchings b...@decadent.org.uk


Queued for 3.13-stable.  Thanks very much, Ben!

 -Kamal


 ---
  net/ipv4/tcp_output.c | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
 index d5457e4..1ea0a07 100644
 --- a/net/ipv4/tcp_output.c
 +++ b/net/ipv4/tcp_output.c
 @@ -2992,6 +2992,7 @@ static int tcp_send_syn_data(struct sock *sk, struct 
 sk_buff *syn)
   goto fallback;
   syn_data-ip_summed = CHECKSUM_PARTIAL;
   memcpy(syn_data-cb, syn-cb, sizeof(syn-cb));
 + skb_shinfo(syn_data)-gso_segs = 1;
   if (unlikely(memcpy_fromiovecend(skb_put(syn_data, space),
fo-data-msg_iov, 0, space))) {
   kfree_skb(syn_data);
 


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#752514: libfftw3 SIGILL on armhf

[Kamal Mostafa]

I'm investigating an armhf FTBFS of my package 'minimodem'[0], which I now
suspect might be caused by this libfftw3 bug in unstable:

#767138 fftw3: runtime detection of NEON is perhaps broken
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767138

There, Edmund points out that #752514 ruby-fftw3: FTBFS on armhf [1] is
possibly caused by that fftw3 bug.  But Cédric notes that he was unable to
reproduce the ruby failure on harris.debian.org.  I am seeing exactly the
same issues with minimodem:  On the armhf buildd builders (only), minimodem
compiles fine but then all its test cases fail.  But when I try it on
harris.d.o (or asachi.d.o), I cannot reproduce any problem.

But I've just discovered that I *can* reproduce the minimodem crash on
abel.debian.org, and it points to libfftw3:

Linux abel 3.16-0.bpo.2-armmp-lpae #1 SMP Debian 3.16.3-2~bpo70+1
(2014-09-21) armv7l GNU/Linux
(sid_armhf-dchroot)

Program received signal SIGILL, Illegal instruction.

0xb6f47e9a in ?? () from /usr/lib/arm-linux-gnueabihf/libfftw3f.so.3


For comparison, harris and asachi (where no problem occurs) are:

Linux harris 3.2.0-4-mx5 #1 Debian 3.2.63-2+deb7u1 armv7l GNU/Linux
(sid_armhf-dchroot)

Linux asachi 3.16-2-arm64 #1 SMP Debian 3.16.3-2 (2014-09-20) armv8l
GNU/Linux
(sid_armhf-dchroot)



Edmund et al., I would appreciate your expertise here... Does it also
appear to you that my minimodem (0.20-1) failure[0] could be caused by the
fftw3 NEON is perhaps broken bug?   Does it make sense that abel.d.o
would be affected by it, but harris and asachi would not?

Cédric, you might want to re-try your ruby-fftw3 build test on
abel.debian.org and consider re-opening #752514 [1].

Hector, could this situation result in a possible inconsistency among the
armhf buildd's? (Or at least, among the porterbox armhf chroots)?

All: Should the severity of the libfftw3 bug #767138 be elevated to
serious?

Thanks in advance for your help,

 -Kamal


[0] #769974 minimodem: FTBFS on armhf
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769974


 To replicate the minimodem failure for debugging:

(sid_armhf-dchroot)$ echo hello | src/minimodem --tx -f /tmp/foo.wav 1200
 # this does not call libfftw3

(sid_armhf-dchroot)$ gdb  --args  src/minimodem --rx -f /tmp/foo.wav 1200
...
Program received signal SIGILL, Illegal instruction.
0xb6f47e9a in ?? () from /usr/lib/arm-linux-gnueabihf/libfftw3f.so.3


[1] #752514 ruby-fftw3: FTBFS on armhf
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=752514

Bug#766797: ITP: flamp -- ham radio Amateur Multicast Protocol application

[Kamal Mostafa]

Package: wnpp
Severity: wishlist
Owner: Kamal Mostafa ka...@debian.org

* Package name: flamp
  Version : 2.1.02
  Upstream Author : Dave Freese w1...@w1hkj.com
* URL : http://www.w1hkj.com/flamp2.1-help/index.html
* License : GPL, LGPL
  Programming Lang: C++
  Description : ham radio Amateur Multicast Protocol application

Flamp is a editor / file management tool for transferring files using
Amp-2.0 protocol (Amateur Multicast Protocol). 


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#593354: fldigi vs. xmonad: still a problem in fldigi 3.22.x?

[Kamal Mostafa]

Hi John, et. al-

Does anyone know if this very old fldigi vs. xmonad bug is still
reproducible with fldigi versions 3.22.x and whatever is the most
recent version of xmonad?

Thanks and 73 de KA6MAL

 -Kamal


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#750861: ITP: flrig -- ham radio transceiver control program

[Kamal Mostafa]

Package: wnpp
Severity: wishlist
Owner: Kamal Mostafa ka...@debian.org

* Package name: flrig
  Version : 1.3.15
  Upstream Author : Dave Freese w1...@w1hkj.com
* URL : http://www.w1hkj.com/flrig-help/index.html
* License : GPL
  Programming Lang: C++
  Description : ham radio transceiver control program

Flrig is a graphical ham radio transceiver control program designed
to be used either stand-alone or as an adjunct to fldigi. 


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#737060: qsstv: please add qsstv.desktop file

[Kamal Mostafa]

Package: qsstv
Version: 7.1.7-3
Severity: minor
Tags: patch

As noted in https://bugs.launchpad.net/ubuntu/+source/qsstv/+bug/1274212
The qsstv application does not appear in desktop launcher menus.

Attached patch adds a /usr/share/applications/qsstv.desktop file to fix that.

Please consider adding it to qsstv package.
diff -Nru qsstv-7.1.7/debian/qsstv.desktop qsstv-7.1.7/debian/qsstv.desktop
--- qsstv-7.1.7/debian/qsstv.desktop	1969-12-31 16:00:00.0 -0800
+++ qsstv-7.1.7/debian/qsstv.desktop	2014-01-29 12:12:56.0 -0800
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=QSSTV
+GenericName=Qt-based slow-scan TV and fax
+Comment=Qt-based slow-scan TV and fax
+Exec=qsstv
+Icon=qsstv
+Terminal=false
+Type=Application
+Categories=Network;HamRadio;
diff -Nru qsstv-7.1.7/debian/rules qsstv-7.1.7/debian/rules
--- qsstv-7.1.7/debian/rules	2012-06-01 10:26:34.0 -0700
+++ qsstv-7.1.7/debian/rules	2014-01-29 12:01:25.0 -0800
@@ -87,6 +87,7 @@
 		 ln -s ../../../javascript/jquery/jquery.js .
 	dh_installexamples debian/templates/*.templ
 	dh_install debian/qsstv.xpm usr/share/pixmaps
+	dh_install debian/qsstv.desktop usr/share/applications
 	dh_installmenu
 	dh_installman debian/qsstv.1
 	dh_link

Bug#737060: qsstv: please add qsstv.desktop file

[Kamal Mostafa]

On Wed, 2014-01-29 at 20:44 +, Colin Tuckley wrote:
 You need to add a Keywords=... line to your desktop file. See
 http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html

That spec indicates that Keywords is not required, and most .desktop
files seem not to include it.   Of course, feel free to submit another
version of the qsstv.desktop file with some keywords, if you like!

 -Kamal


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#731014: ITP: hershey-fonts -- Hershey vector fonts library, tools, and glyph data

[Kamal Mostafa]

Package: wnpp
Severity: wishlist
Owner: Kamal Mostafa ka...@debian.org

* Package name: hershey-fonts
  Version : 0.1
  Upstream Author : Kamal Mostafa ka...@whence.com
* URL : http://www.whence.com/hershey-fonts/
* License : GPL
  Programming Lang: C
  Description : Hershey vector fonts library, tools, and glyph data

The Hershey fonts are a collection of vector fonts developed circa 1967
by Dr. A. V. Hershey.

This source package includes:

 - The Hershey fonts: Latin, Greek, Cyrilic, Japanese, and various symbol
   glyph sets encoded as .jhf format Hershey font files.

 - libhersheyfont: a library of C routines for loading Hershey font files.

 - hershey-font-gnuplot: a program to render Hershey vector font text in
   the form of a gnuplot input file.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#719523: fldigi: segfault on start-up (active_modem == NULL)

[Kamal Mostafa]

Package: fldigi
Version: 3.21.72-1
Severity: important
Tags: upstream

After updating fldigi to 3.21.72 (or maybe this first appeared in .71) with
my $HOME/.fldigi/ dir from the previous version still present, fldigi
segfaults at start-up.  The Fldigi configuration wizard dialog pops up,
then the following crash occurs when the waterfall init code tries to
dereference global 'active_modem' before it's been set.

The segfault doesn't happen when starting with no $HOME/.flgidi/ dir;  It's
likely that it only occurs with (some particular?) rig controls configured.


Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffe773e700 (LWP 21724)]
0x0064a9a3 in modem::set_reverse (this=0x0, on=false)
at trx/modem.cxx:264
264 reverse = on ^ (!wf-USB());

(gdb) bt
#0  0x0064a9a3 in modem::set_reverse (this=0x0, on=false)
at trx/modem.cxx:264
#1  0x0065c8ae in waterfall::USB (this=0xb607b0, b=false)
at waterfall/waterfall.cxx:1548
#2  0x005d5589 in rigCAT_loop (args=0x0) at rigcontrol/rigio.cxx:1283
#3  0x77995f8e in start_thread (arg=0x7fffe773e700)
at pthread_create.c:311
#4  0x755c1e1d in clone ()
at ../sysdeps/unix/sysv/linux/x86_64/clone.S:113

(gdb) up
#1  0x0065c8ae in waterfall::USB (this=0xb607b0, b=false)
at waterfall/waterfall.cxx:1548
1548active_modem-set_reverse(reverse);

(gdb) l
1543
1544void waterfall::USB(bool b) {
1545if (wfdisp-USB() == b)
1546return;
1547wfdisp-USB(b);
1548active_modem-set_reverse(reverse);
1549REQ(viewer_redraw);
1550}
1551
1552bool waterfall::USB() {

(gdb) p active_modem
$1 = (modem *) 0x0


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#719523: [PATCH] Fix start-up segfault (active_modem == NULL)

[Kamal Mostafa]

BugLink: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=719523

Do not let the waterfall init code dereference global 'active_modem' before
it's been set.  Note though, there are plenty of other suspicious blind
dereferences of active_modem in waterfall.cxx and probably elsewhere.  :-(
---
 src/waterfall/waterfall.cxx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/waterfall/waterfall.cxx b/src/waterfall/waterfall.cxx
index 1ae0bd2..eaf3113 100644
--- a/src/waterfall/waterfall.cxx
+++ b/src/waterfall/waterfall.cxx
@@ -1545,7 +1545,8 @@ void waterfall::USB(bool b) {
if (wfdisp-USB() == b)
return;
wfdisp-USB(b);
-   active_modem-set_reverse(reverse);
+   if (likely(active_modem))
+   active_modem-set_reverse(reverse);
REQ(viewer_redraw);
 }
 
-- 
1.8.1.2


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#672318: chirp version 0.3.1

[Kamal Mostafa]

Re: chirp in Debian
http://packages.qa.debian.org/c/chirp.html


On Fri, 2013-08-02 at 12:20 -0600, Bdale Garbee wrote:
 It appears that upstream released 0.3.1 in April.  I just stumbled over
 the ancient version currently in Debian not including support for the
 new radio I'm thinking about buying.
 
 Any objection to my adding myself as an uploader and using Chris' work
 to package and upload 0.3.1 ASAP?
 
 73 - Bdale, KB0G


That's just fine Bdale, and thanks for the help.

73 de KA6MAL

 -Kamal



signature.asc
Description: This is a digitally signed message part

Bug#718653: RM: tqsllib -- ROM; obsolete and abandoned upstream

[Kamal Mostafa]

Package: ftp.debian.org
Severity: normal

The TrustedQSL upstream devs recently released a new version of tqsl
(1.14.x), now deployed in Debian testing.

Previous to this new release, the tqsl app (src pkg 'trustedqsl') relied
on a core functionality library supplied by another src pkg: 'tqsllib'
which supplied a proper API in the forms of a versioned .so package and
a -dev package.

The tqsllib API, however, was never directly used by any (known) ham
apps besides tqsl itself -- other apps have all used the tqsl command
line interface instead.  For this reason, the upstream tqsl team has
abandoned maintenance of the separate tqsllib API.  The new tqsl 1.14.x
versions are now bundled with a newer version of tqsllib, which is not
API-compatible with the old tqsllib and is not recommended for use by
other apps.  Upstream now only supports the command line interface, and
agrees that the old library package is no longer useful. 

Since no other known software depends on the old 'tqsllib' library
package, and since upstream now recommends that it no longer be used,
please remove 'tqslllib' from unstable.

Thanks,

 -Kamal Mostafa (Debian maintainer for 'trustedqsl' and 'tqsllib')


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#709647: [PATCH 046/145] genirq: Fix can_request_irq() for IRQs without an action

[Kamal Mostafa]

3.8.13.5 -stable review patch.  If anyone has any objections, please let me 
know.

--

From: Ben Hutchings b...@decadent.org.uk

commit 2779db8d37d4b542d9ca2575f5f178dbeaca6c86 upstream.

Commit 02725e7471b8 ('genirq: Use irq_get/put functions'),
inadvertently changed can_request_irq() to return 0 for IRQs that have
no action.  This causes pcibios_lookup_irq() to select only IRQs that
already have an action with IRQF_SHARED set, or to fail if there are
none.  Change can_request_irq() to return 1 for IRQs that have no
action (if the first two conditions are met).

Reported-by: Bjarni Ingi Gislason bjarn...@rhi.hi.is
Tested-by: Bjarni Ingi Gislason bjarn...@rhi.hi.is (against 3.2)
Signed-off-by: Ben Hutchings b...@decadent.org.uk
Cc: 709...@bugs.debian.org
Link: http://bugs.debian.org/709647
Link: 
http://lkml.kernel.org/r/1372383630.23847.40.ca...@deadeye.wl.decadent.org.uk
Signed-off-by: Thomas Gleixner t...@linutronix.de
Signed-off-by: Luis Henriques luis.henriq...@canonical.com
---
 kernel/irq/manage.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index e49a288..a9302d0 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -554,9 +554,9 @@ int can_request_irq(unsigned int irq, unsigned long 
irqflags)
return 0;
 
if (irq_settings_can_request(desc)) {
-   if (desc-action)
-   if (irqflags  desc-action-flags  IRQF_SHARED)
-   canrequest =1;
+   if (!desc-action ||
+   irqflags  desc-action-flags  IRQF_SHARED)
+   canrequest = 1;
}
irq_put_desc_unlock(desc, flags);
return canrequest;
-- 
1.8.1.2


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#707386: grig: diff for NMU version 0.8.0-1.1

[Kamal Mostafa]

On Tue, 2013-05-21 at 18:19 +0200, Sebastian Ramacher wrote:
 Control: tags -1 + patch pending
 
 Dear maintainer,
 
 I've prepared an NMU for grig (versioned as 0.8.0-1.1) and
 uploaded it to DELAYED/2. Please feel free to tell me if I
 should delay it longer.
 
 Regards


Thanks, Sebastian!  Your help is very much appreciated!

 -Kamal


signature.asc
Description: This is a digitally signed message part

Bug#672318: chirp 0.3.0-0.1 Debian package available

[Kamal Mostafa]

On Thu, 2013-04-04 at 23:04 -0400, Chris Knadle wrote:
 Greetings.
 
 I recently got a new rig, a small HT, and needed chirp to program it.  
 Unfortunately the version of the packge in Debian now doesn't work for the 
 rig, and I found the year-old wishlist bug #672318 requesting a new version.  
 I've prepared a new 0.3.0-0.1 package (currently as an NMU) and made several 
 other changes -- the debian/rules file now uses dh.
 
 If someone has time to take a peek and review this source package, I'd 
 appreciate it.  ;-)
 
http://debian-packages.coredump.us/debian/pool/main/c/chirp/

Thanks Chris, your work is much appreciated.  I'll see that this gets
reviewed by myself and/or Steve Conklin (the chirp Debian maintainers)
as soon as possible.

 Thanks.
 
   -- Chris, KB2IQN


On Fri, 2013-04-05 at 02:46 -0400, David A Aitcheson wrote:
 [...]
 PS - A fork similar to this is what caused all the problems with NODE.
 Did we not learn anything from that drawn out over more than a decade mess?

As has been pointed out, Chris's proposed package is not any sort of a
fork -- nor is it duplicated work with respect to the chirp-daily PPA.
Chris's package is aimed at bringing a newer official release of chirp
to Debian (where it will then make its way into stock Ubuntu and many
other distros), whereas the purpose of the Ubuntu PPA is to deliver the
bleeding-edge version to more advanced Ubuntu users.  Chris's package is
(potentially) suitable for inclusion in Debian and its derivatives, but
the daily build package is not.

73 de KA6MAL

 -Kamal


signature.asc
Description: This is a digitally signed message part

Bug#702830: fldigi: Does not even launch under MINT

[Kamal Mostafa]

Hi Sam-

You've filed a bug against fldigi in Debian, but the subject line Does
not even launch under MINT suggests that perhaps you're running a Linux
Mint distribution, not Debian.  Is that correct?

If indeed you are running Mint, then you'll need to file a bug with the
Mint bug tracker[0], not this Debian bug tracker (even if it is the Mint
Debian Edition).

If I misunderstand and you actually are running Debian not Mint, then
please confirm that and also describe the failure in more detail;
specifically, paste the text output that occurs when you try to run
fldigi from a terminal window command-line prompt.

73 de KA6MAL

 -Kamal

[0] https://bugs.launchpad.net/linuxmint/



On Mon, 2013-03-11 at 20:09 -0400, Sam wrote:
 Package: fldigi
 Version: 3.21.48-1
 Severity: important
 
 Dear Maintainer,
 *** Please consider answering these questions, where appropriate ***
 
* What led up to the situation?
* What exactly did you do (or not do) that was effective (or
  ineffective)?
* What was the outcome of this action?
* What outcome did you expect instead?
 
 *** End of the template - remove these lines ***
 
 
 
 -- System Information:
 Debian Release: 7.0
   APT prefers testing-updates
   APT policy: (500, 'testing-updates'), (500, 'testing')
 Architecture: powerpc (ppc)
 
 Kernel: Linux 3.2.0-4-powerpc
 Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
 Shell: /bin/sh linked to /bin/dash
 
 Versions of packages fldigi depends on:
 ii  libasound2 1.0.25-4
 ii  libc6  2.13-38
 ii  libfltk-images1.3  1.3.0-8
 ii  libfltk1.3 1.3.0-8
 ii  libgcc11:4.7.2-5
 ii  libhamlib2 1.2.15.1-1
 ii  libpng12-0 1.2.49-1
 ii  libportaudio2  19+svn2021-1
 ii  libpulse0  2.0-6
 ii  librpc-xml-perl0.76-3
 ii  libsamplerate0 0.1.8-5
 ii  libsndfile11.0.25-5
 ii  libstdc++6 4.7.2-5
 ii  libx11-6   2:1.5.0-1
 ii  libxmlrpc-c++4 1.16.33-3.2
 ii  libxmlrpc-core-c3  1.16.33-3.2
 
 Versions of packages fldigi recommends:
 ii  extra-xdg-menus  1.0-4
 
 Versions of packages fldigi suggests:
 pn  libterm-readline-gnu-perl | libterm-readline-perl-perl  none
 
 -- no debconf information
 
 



signature.asc
Description: This is a digitally signed message part

Bug#680401: unblock: powerstat/0.01.17-1

[Kamal Mostafa]

 I request a freeze exception for powerstat/0.01.17-1

In case this matters...  As the upload sponsor, I also agree with this
request.

 -Kamal


signature.asc
Description: This is a digitally signed message part

Bug#679952: unblock: fldigi/3.21.48-1

[Kamal Mostafa]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: freeze-exception

Please unblock package fldigi

I request a freeze exception for fldigi/3.21.48-1 which I have uploaded to
unstable.  The delta for this version includes only the two bug fixes noted in
the changelog entry here:

fldigi (3.21.48-1) unstable; urgency=low

   * New upstream release, includes these changes only:
 - Tango Icon Library updated public domain version (Closes: #679792)
 - Retry session ID after session time out (Closes: #679797)

The Tango Icons issue is a DFSG-non-compliance problem (more details in the bug
report #679792).  The fix involves no functional change, just a replacement of
the icon pixmaps.  But as this results in a 1-line diff of just C-language
xpm pixmap data, I shall omit the diff from this report.

The Retry session ID (#679797) fix is a small functional change which corrects
a moderately serious malfunction of the application; that diff is attached for
reference.

Thanks!


unblock fldigi/3.21.48-1



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#679952: for reference: diff for #679797

[Kamal Mostafa]

From e94e2f2c17e81fa4bc114c31110916dfe02540f7 Mon Sep 17 00:00:00 2001
From: David Freese w1...@w1hkj.com
Date: Sat, 30 Jun 2012 12:57:59 -0500
Subject: [PATCH 1/3] HAMQTH Session ID

  * Retry session ID after session time out
  * Correct error string extraction
---
 src/logbook/lookupcall.cxx |   23 +--
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/src/logbook/lookupcall.cxx b/src/logbook/lookupcall.cxx
index 6a3aa2c..2f35dc0 100644
--- a/src/logbook/lookupcall.cxx
+++ b/src/logbook/lookupcall.cxx
@@ -751,20 +751,22 @@ bool HAMQTH_get_session_id()
if (!fetch_http(url, retstr, 5.0)) {
return false;
}
-   if ((p1 = retstr.find(error)) != string::npos) {
+   p1 = retstr.find(error);
+   if (p1 != string::npos) {
p2 = retstr.find(/error);
-   lookup_notes = retstr.substr(p1 + 7, p2 - p1 - 7);
+   if (p2 != string::npos) {
+   p1 += 7;
+   lookup_notes = retstr.substr(p1, p2 - p1);
+   }
return false;
}
-   if ((p1 = retstr.find(session_id)) == string::npos) {
+   p1 = retstr.find(session_id);
+   if (p1 == string::npos) {
lookup_notes = HamQTH not available;
return false;
}
p2 = retstr.find(/session_id);
HAMQTH_session_id = retstr.substr(p1 + 12, p2 - p1 - 12);
-//#ifdef HAMQTH_DEBUG
-// printf(session id = %s\n, HAMQTH_session_id.c_str());
-//#endif
return true;
 }
 
@@ -885,12 +887,13 @@ bool HAMQTHget(string htmlpage)
url.append(prg=FLDIGI);
 
ret = fetch_http(url, htmlpage, 5.0);
-   if (htmlpage.find(error) != string::npos ) {
-   size_t p = htmlpage.find(error) + 7;
-   size_t p1 = htmlpage.find(/error);
+   size_t p = htmlpage.find(error);
+   if (p != string::npos ) {
+   size_t p1 = htmlpage.find(/error, p);
if (p1 != string::npos) {
string tempstr;
-   tempstr.assign(htmlpage.substr(p1, p1 - p));
+   p += 7;
+   tempstr.assign(htmlpage.substr(p, p1 - p));
LOG_WARN(HAMQTH error: %s, tempstr.c_str());
}
htmlpage.clear();
-- 
1.7.9.5




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#679792: fldigi bundles Tango Icon Library pixmaps licensed CC-BY-SA-2.5

[Kamal Mostafa]

Package: fldigi
Version: 3.21.45-1
Severity: serious
Tags: upstream
Justification: Policy 2.1

Fldigi (src/misc/pixmaps.cxx) bundles pixmaps converted from an old version
of the Tango Icon Library which indicates its license as CC-BY-SA-2.5, a
license which is not suitable for Debian main.

Note that this has been fixed in fldigi 3.21.48 upstream (the old pixmaps are
replaced by new ones from a more recent version Tango Icon Library that was
released into the public domain).



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#679797: fldigi: HamQTH does not reconnect after session timeout

[Kamal Mostafa]

Package: fldigi
Version: 3.21.45-1
Severity: important
Tags: upstream

After a HamQTH session timeout, callsign lookups stop working.

Note: this is fixed in fldigi 3.21.48 upstream.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#677945: ITP: flmsg -- amateur radio forms management editor

[Kamal Mostafa]

Package: wnpp
Severity: wishlist
Owner: Kamal Mostafa ka...@whence.com

* Package name: flmsg
  Version : 1.1.20
  Upstream Author : Dave Freese w1...@w1hkj.com
* URL : http://www.w1hkj.com/
* License : GPL-2
  Programming Lang: C++
  Description : amateur radio forms management editor

 Flmsg is a simple forms management editor for the amateur radio supported
 standard message formats, including ICS, HICS, MARS, IARU, Radiogram NTS,
 Red Cross, and plaintext.  It's data files are pure ASCII text that can
 be sent from point to point using the internet, amateur radio, or other
 electronic link.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#677946: ITP: flwrap -- amateur radio file encapsulation/compression utility

[Kamal Mostafa]

Package: wnpp
Severity: wishlist
Owner: Kamal Mostafa ka...@whence.com

* Package name: flwrap
  Version : 1.3.4
  Upstream Author : Dave Freese w1...@w1hkj.com
* URL : http://www.w1hkj.com/
* License : GPL-2
  Programming Lang: C++
  Description : amateur radio file encapsulation/compression utility

 Flwrap is a small desktop application that encapsulates a text file,
 an image file, or a binary file within a set of identifier blocks.
 Flwrap is designed to be used to best advantage with fldigi but can
 be used with any digital modem program.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#656142: ITP: duff -- Duplicate file finder

[Kamal Mostafa]

 On Mon, Jan 16, 2012 at 12:58:13PM -0800, Kamal Mostafa wrote:
  * Package name: duff
  * URL : http://duff.sourceforge.net/

On Tue, 2012-01-17 at 09:56 +0100, Simon Josefsson wrote:
 If there aren't warnings about use of SHA1 in the tool, there should
 be. While I don't recall any published SHA1 collisions, SHA1 is
 considered broken and shouldn't be used if you want to trust your
 comparisons.  I'm assuming the tool supports SHA256 and other SHA2
 hashes as well?  It might be useful to make sure the defaults are
 non-SHA1.

Duff supports SHA1, SHA256, SHA384 and SHA512 hashes.  The default is
SHA1.  For comparison, rdfind supports MD5 but only SHA1 hashes.  Thanks
for the note Simon -- I'll bring it to the attention of the upstream
author, Camilla Berglund.  

On Tue, 2012-01-17 at 09:12 +, Lars Wirzenius wrote:
 rdfind seems to be quickest one, but duff compares well with hardlink,
 which (see http://liw.fi/dupfiles/) was the fastest one I knew of in
 Debian so far.
 
 This was done using my benchmark-cmd utility in my extrautils
 collection (not in Debian): http://liw.fi/extrautils/ for source.

Thanks for the pointer to your benchmark-cmd tool, Lars.  Very handy!
My results with it mirrored yours -- of the similar tools, duff appears
to lag only rdfind in performance (for my particular dataset, at least).

I looked into duff's methods a bit and discovered a few easy performance
optimizations that may speed it up a bit more.  The author is reviewing
my proposed patch now, and seems very open to collaboration.

 Personally, I would be wary of using checksums for file comparisons,
 since comparing files byte-by-byte isn't slow (you only need to
 do it to files that are identical in size, and you need to read
 all the files anyway).

Byte-by-byte might well be slower then checksums, if you end up faced
with N2 very large (uncacheable) files of identical size but unique
contents.  They all need to be checked against each other so each of the
N files would need to be read N-1 times.   Anyway, duff actually *does*
offer byte-by-byte comparison as an option (rdfind does not).

 I also think we've now got enough of duplicate file finders in
 Debian that it's time to consider whether we need so many. It's
 too bad they all have incompatible command line syntaxes, or it
 would be possible to drop some. (We should accept a new one if
 it is better than the existing ones, of course. Evidence required.)

To me, the premise that a new package must be better than existing
similar ones (evidence required, no less) seems pretty questionable.
It may not be so easy to establish just what better than means, and it
puts us in a position of making value judgments for our users that they
should be able to make for themselves.

While I do think it is productive to compare performance of these
similar tools to each other, I don't see much value in pitting them
against each other in benchmark wars as criteria of acceptance into
Debian.

Here we have a good quality DFSG-compliant package with an active
upstream and a willing DD maintainer.  While similar tools do exist
already in Debian, they do not offer identical feature sets or user
interfaces, and only one of them has been shown to outperform duff in
quick spot checks.  Some users have expressed a preference for duff over
the others.  Does that make it better than the existing ones?  My
answer: Who cares? Nobody is making us choose only one.

In my view, its not really a problem if carry multiple duplicate file
detectors in Debian, and that we will best serve our users by letting
them choose their preferred tool for the job.  And by allowing such
packages into Debian we encourage their improvement, to everyone's
benefit.

 -Kamal



signature.asc
Description: This is a digitally signed message part

Bug#656142: ITP: duff -- Duplicate file finder

[Kamal Mostafa]

Package: wnpp
Severity: wishlist
Owner: Kamal Mostafa ka...@whence.com


* Package name: duff
  Version : 0.5
  Upstream Author : Camilla Berglund elmindr...@elmindreda.org
* URL : http://duff.sourceforge.net/
* License : Zlib
  Programming Lang: C
  Description : Duplicate file finder

Duff is a command-line utility for identifying duplicates in a given set of
files.  It attempts to be usably fast and uses the SHA family of message
digests as a part of the comparisons.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#656142: ITP: duff -- Duplicate file finder

[Kamal Mostafa]

On Mon, 2012-01-16 at 23:07 +0100, Joerg Jaspert wrote:
  What is it the benefit over fdupes, rdfind, ...?
  ..., hardlink, ...
 finddup from perforate

After a quick evaluation of the various find dupe files tools, I was
attracted to try duff because:

1. It looked easier to use than the others.
2. This quote from its website[1] was exactly what I was looking for:
Note that duff itself never modifies any files, but it's designed to
play nice with tools that do.  The other dupe cleaner utilities left me
worried that they might trash something important if I got my command
line options wrong or forgot a --dry-run flag.


  Was thinking about packaging it myself already, so I may also sponsor
  Kamal's package when it's ready.

Thanks Axel, but I'm a DD myself, so won't need a sponsor.


 You just listed the third duplicate (and me no. 4), and still go blind
 right on ohoh, i sponsor it. Why? I hope its conditional on it being
 vastly better than any of the others (speed, functionality, ...)

In my humble opinion, that would be an unreasonable pre-condition for
inclusion in Debian.  Our standard for inclusion should not be that a
new package must be vastly better than other similar packages.  That
would deny a new package the opportunity to build a user base and
possibly someday evolve to become the vastly better alternative
itself.

 -Kamal

ka...@whence.com
ka...@debian.org

[1] http://duff.sourceforge.net/



signature.asc
Description: This is a digitally signed message part

Bug#653411: cw: Upgrade from 2.3-13 fails

[Kamal Mostafa]

Thanks for your ongoing help with this, Bob.

On Sun, 2012-01-01 at 18:01 -0700, Bob Proulx wrote:
 reopen 653411
  [...] The problem is a symlink left behind by the previous package version.
 
   $ ls -l /usr/share/doc/cw
   lrwxrwxrwx 1 root root 6 Dec 25  2009 /usr/share/doc/cw - unixcw

And the same problem happens for the packages 'cwcp' and 'xcwcp' too.
I've applied Bob's preinst script fix to {cw,cwcp,xcwcp} and will upload
a new unixcw (3.0-5) shortly.

 -Kamal


signature.asc
Description: This is a digitally signed message part

Bug#653411: cw: Upgrade from 2.3-13 fails

[Kamal Mostafa]

Thanks for reporting this Bob.

On Thu, 2011-12-29 at 00:30 +0100, Kamil Ignacak wrote:
 On -10.01.-28163 20:59, Bob Proulx wrote:
 Unpacking libcw3 (from .../libcw3_3.0-2_amd64.deb) ...
 dpkg: error processing /var/cache/apt/archives/libcw3_3.0-2_amd64.deb 
  (--unpack):
  trying to overwrite '/usr/share/man/man7/cw.7.gz', which is also in 
  package unixcw 2.3-13
 configured to not write apport reports
 To Kamal Mostafa: looks like we should revert the latest change in 
 debian/control (patch attached). Would you agree?

Yes, I now see the error of my ways in removing the Replaces, and
furthermore I think we also need a Conflicts: for both of those.  I'll
upload a new unixcw package shortly, which I think fixes the problem.
Bob, please advise if you find otherwise.

  I am on the outside looking in and am surprised by this break.  It
  appears that you are renaming the unixcw package to cw and that the
  package renaming has failed due to missing Conflicts, Replaces, Breaks
  headers and missing transition dummy package for the old unixcw but I
  haven't examined the problem in detail at this moment.  What is the
  intention?
 unixcw(-dev) has been renamed to libcw3(-dev) for consistency reasons 
 and to avoid using name of project/source code package as Debian package 
 name. Considerable changes in lib's API and functionality made the 
 switch to new name even more needed (IMHO).
 
 Initially debian/control contained Replaces: unixcw(-dev) lines, but 
 the line has been removed for some (minor?) reason. It seems that the 
 change needs to be reverted.

And...  Since the new libcw3 doesn't provide a compatible API with the
old unixcw library, I don't think we can provide a transition dummy
unixcw package.  We've fixed the one package that we know was dependent
on unixcw (cwdaemon) to now use the new libcw3, but any other users of
the library will unfortunately be broken by the API change.

 -Kamal



signature.asc
Description: This is a digitally signed message part

Bug#652526: [ITR] templates://unixcw/{cwcp.templates,cw.templates}

[Kamal Mostafa]

On Thu, 2011-12-22 at 07:08 +0100, Christian PERRIER wrote:
 The Debian internationalisation team and the Debian English
 localisation team will soon begin the review of the debconf
 templates used in unixcw.
[...]
 If you approve this process, please let us know by replying to this
 mail.

Yes, I think now(-ish) is a fine time to begin this review.  Thanks in
advance for your help and oversight with this process Christian.

 -Kamal




signature.asc
Description: This is a digitally signed message part

Bug#652618: cwdaemon: FTBFS, build-depends can no longer be fullfilled

[Kamal Mostafa]

owner ka...@whence.com
thanks


[ adding Kamil Ignacak, the new upstream author/maintainer of
unixcw/libcw ]

Hi Alexander-

Thank you very much for noticing the breakage.  This does indeed result
from problems with the newly refurbished 'unixcw' source package that I
recently uploaded for Kamil ...

On Mon, 2011-12-19 at 14:26 +0100, Alexander Reichle-Schmehl wrote:
 tags 652618 +patch
 thanks
 
 [ adding the unixcw maintainer to the loop ]
 [ also adding Michael as Cc, as last NMUer of the package he might have
   interest in it ]
 
 Hi!
 
 * Alexander Reichle-Schmehl toli...@debian.org [111219 11:09]:
 
  I'm sorry, but I fear your package will FTBFS starting with the next
  dinstall run.  Background is that unixcw dropped to build the package
  unixcw-dev on which cwdaemon build-depends.  And well... I cruft-removed
  said package by mistake just now.
  
  I guess that the new build-dependency should be libcw3-dev, but I haven't
  checked.
 
 The good news is that I kind of fixed it.  The bad news is, that I can't
 test the resulting package.  Also just replacing the build-depens on
 unixcw-dev with libcw3-dev didn't solved the issue, I guess that means
 that the Provides: unixcw-dev of libcw3-dev is not true.

You're correct.  the renamed libcw3{-dev} packages don't properly
Provide unixcw{-dev}, but they should.  We'll fix that.


 I had to do some further changes (see attached debdiff).  To my
 understanding the calls cw_set_soundcard_sound and cw_set_console_sound
 are no longer necessary, as libcw automatically picks the right one?

Lets ask the new upstream author/maintainer...  Kamil, can you comment
on that?  Did you eliminate those routines from the new libcw?


 Well, at least with the attached changes it builds again.  So far, so
 good, however I couldn't actually check the resulting package.
 
 
 That being said, here are a couple of questions:
 
 1) Is this package actually being used? Orphaned since two years, no
reverde depends (only one suggests by xlog), pretty low popcon (but a
special package), no upstream development.
 2) Is the patch correct? Anyone can test it?
 
 And for the Debian Hamradio Maintainers:
 3) Shouldn't libcw3-dev have a dependency on libasound2-dev?  Apparently
that's needed for successfull linking.
 4) Are libcw's pc files correct?  As you can see, I also had to add also
to the CFLAGS and lib calls.
 5) Wouldn't you like to adopt cwdaemon, if it's worth to be kept?

I do think cwdaemon is worth keeping, and I will adopt it.

Kamil and I will fix unixcw/libcw3 and then I will apply whatever
remaining bits of your patch to cwdaemon are still necessary.

 
 Best Regards,
   Alexander

Thanks again!

 -Kamal



signature.asc
Description: This is a digitally signed message part

Bug#652176: cqrlog: FTBFS: unsatisfiable build-dependencies: lazarus-0.9.30, lcl-0.9.30

[Kamal Mostafa]

On Thu, 2011-12-15 at 12:14 +0100, Mònica Ramírez Arceda wrote:
 Source: cqrlog
 Version: 1.2.1-1
 Severity: serious
 Tags: wheezy sid
 User: debian...@lists.debian.org
 Usertags: qa-ftbfs-20111210 qa-ftbfs
 Justification: FTBFS on amd64
 
 Hi,
 
 During a rebuild of all packages in sid, your package failed to build on
 amd64.

I cannot reproduce this build failure of cqrlog-1.2.1-1.

  The following packages have unmet dependencies:
   sbuild-build-depends-cqrlog-dummy : Depends: lazarus-0.9.30 but it is not 
  installable
   Depends: lcl-0.9.30 but it is not 
  installable
  E: Broken packages

cqrlog-1.2.1-1 builds fine in my amd64 sid pbuilder.

Note that the package 'lazarus-0.9.30' has indeed been renamed
'lazarus-0.9.30.2' and likewise for 'lcl-0.9.30'.  But cqrlog's
build-deps are satisfiable because cqrlog's Build-Depends includes:
lazarus-0.9.30 | lazarus (= 0.9.29), lcl-0.9.30 | lcl (= 0.9.30)
which get satisfied by these packages currently in sid:
lazarus (0.9.30.2-1)
lcl (0.9.30.2-1)

I'll mark this bug 'done'.  Please re-open and advise if my analysis is
incorrect.

 -Kamal


signature.asc
Description: This is a digitally signed message part

Bug#649506: nickle 2.71-1 fixes _FORTIFY_SOURCE crash

[Kamal Mostafa]

The crash is resolved by nickle 2.71-1 (it works fine even with
_FORTIFY_SOURCE).

Michael Terry's strncpy patch is still probably a good idea though, so
leaving this bug open for maintainer review.

 -Kamal



signature.asc
Description: This is a digitally signed message part

Bug#648258: ITP: twclock -- World clock for ham radio operators

[Kamal Mostafa]

Package: wnpp
Severity: wishlist
Owner: Kamal Mostafa ka...@whence.com

This package was removed from Debian due to lack of maintenance.  Recently
the upstream has released fresh versions, which I will package and maintain
for Debian.

* Package name: twclock
  Version : 3.1
  Upstream Author : Ted Williams WA0EIR wa0...@mchsi.com
* URL : http://wa0eir.home.mchsi.com/
* License : GPL-2+
  Programming Lang: C++
  Description : World clock for ham radio operators

 It also has an ID timer to generate a CW ID via your soundcard and
 pulseaudio.  Connect the output of your soundcard to the audio-in pin
 of your rig's accessory jack to have it transmitted.
 .
 This program is a clock designed for ham radio operators, anyone who
 needs the time of day someplace else in the world, or anyone tired of
 the same old look of their clock.  It can display the current time and
 date in hundreds of cities around the world.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#648259: ITP: twpsk -- Soundcard-based X program for operating PSK31

[Kamal Mostafa]

Package: wnpp
Severity: wishlist
Owner: Kamal Mostafa ka...@whence.com


This package was removed from Debian due to lack of maintenance.  Recently
the upstream has released fresh versions, which I will package and maintain
for Debian.

* Package name: twpsk
  Version : 4.0
  Upstream Author : Ted Williams WA0EIR wa0...@mchsi.com
* URL : http://wa0eir.home.mchsi.com/
* License : GPL-2+
  Programming Lang: C++
  Description : Soundcard-based X program for operating PSK31

 Twpsk uses a soundcard to receive and transmit PSK31, an extremely
 narrow band HF-mode. PSK31 is a mode for keyboard QSO's.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#280561: tqsllib-bin: Command-line programs lack documentation

[Kamal Mostafa]

Tags: wontfix

 From: John Mock kd6...@qsl.net
 To: Debian Bug Tracking System sub...@bugs.debian.org
 Subject: tqsllib-bin: Command-line programs lack documentation
 Date: Wed, 10 Nov 2004 00:46:38 -0800


Since the tqsllib package no longer ships any of the 'test' programs
referred to, I'm closing this bug report.

73 de KA6MAL

 -Kamal


signature.asc
Description: This is a digitally signed message part

Bug#631341: ITP: minimodem -- software audio Bell-type or RTTY FSK modem

[Kamal Mostafa]

Package: wnpp
Severity: wishlist
Owner: Kamal Mostafa ka...@whence.com


* Package name: minimodem
  Version : 0.5
  Upstream Author : Kamal Mostafa ka...@whence.com
* URL : http://www.whence.com/minimodem/
* License : GPL
  Programming Lang: C
  Description : software audio Bell-type or RTTY FSK modem

Minimodem is a command-line program which generates (or decodes) audio
modem tones, emulating an old Bell-type or radio-teletype FSK modem.
The tones are played to (or recorded from) the default system audio
device or a file.

Minimodem can be used to transfer data between nearby computers using an
audio cable (or just via sound waves), or between remote computers using
radio, telephone, or another audio communications medium.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#621247: hamlib: diff for NMU version 1.2.13.1-1.1

[Kamal Mostafa]

On Mon, 2011-06-13 at 15:45 +0200, Luk Claes wrote:
 Dear maintainer,
 
 I've prepared an NMU for hamlib (versioned as 1.2.13.1-1.1) and
 uploaded it to DELAYED/5. Please feel free to tell me if I
 should delay it longer.

Thanks for taking care of this, Luk.  Your NMU is appreciated!

 -Kamal


signature.asc
Description: This is a digitally signed message part

Bug#628864: Seg fault on get_menu_item / Debian Bug#628864: Fldigi fails to start, gives getMenuItem error

[Kamal Mostafa]

I can reproduce the problem on Debian sid, and am investigating now.

Interesting finding:  As a test, I tried installing an old fldigi 3.21.4
binary package onto Debian sid: it works fine.  Then I tried rebuilding
3.21.4 from source on the same Debian sid machine -- the resulting
fldigi 3.21.4 binary then exhibits the exact same Countries message and
crash as we're seeing with the 3.21.10 binary package.

Therefore:
 - the problem is tied to the build environment, not the
  fldigi version (but the bug might still be in fldigi).
 - the problem is not related to my 3.21.9 timeframe nls.cxx
  PATH_MAX patch.

I will continue to investigate.

 -Kamal


On Sat, 2011-06-11 at 07:48 -0500, Nate Bargmann wrote:
 * On 2011 11 Jun 05:10 -0500, w1hkj wrote:
  Nate wrote:
  I was able to get a working Fldigi on my Debian Sid (Unstable) box with
  the --disable-nls switch to configure.
  Rik reported:
  
Pre 3.21.10 build did not fail.
  
  The only change between 3.21.9 and 3.21.10/11 in the NLS arena was a
  patch sent in by Kamal
 
 Dave, I had the same sort of crash back on May 8 with 3.21.9.  I posted
 a message to the list about it:
 
 https://lists.berlios.de/pipermail/fldigi-alpha/2011-May/001817.html
 
 I think you may have had other issues to contend with at that time.
 
 I just examined the crash report in that message and it shows that
 Fldigi was compiled with GCC 4.5.3.
 



signature.asc
Description: This is a digitally signed message part

Bug#628864: Seg fault on get_menu_item / Debian Bug#628864: Fldigi fails to start, gives getMenuItem error

[Kamal Mostafa]

Small patch (attached) fixes the problem.

In a nutshell, the 'menu_' array in dialogs/fl_digi.cxx gets prematurely
terminated, because 'mode_info[MODE_ANALYSIS].name' ends up as an empty
string in the menu_ table.  That happens because the 'mode_info' array
in globals/globals.cxx uses an internationalized string to fill that
value _(Freq Analysis).  Something about the internationalization
runtime string juggling breaks down, leaving menu_ broken.

Simply using a regular string for Freq Analysis fixes all the damage.
For the record, I do not understand why this problem is only manifesting
now, however that fix seems easy and appropriate.

I'll apply this to fldigi 3.21.10 in Debian unstable.  Dave, if you
would be so kind, please apply it to your main tree as well.

73 de KA6MAL

 -Kamal
Description: Do not use NLS in mode_info table
Author: Kamal Mostafa ka...@whence.com
Bug-Debian: http://bugs.debian.org/628864

   * Fix failure to start up due to NLS problem (Closes: #628864)
 - do-not-use-nls-in-mode-info-table.patch

--- fldigi-3.21.10.orig/src/globals/globals.cxx
+++ fldigi-3.21.10/src/globals/globals.cxx
@@ -112,7 +112,9 @@ const struct mode_info_t mode_info[NUM_M
 
 	{ MODE_SSB, ssb_modem, SSB, SSB, , SSB,  },
 	{ MODE_WWV, wwv_modem, WWV, WWV, , ,  },
-{ MODE_ANALYSIS, anal_modem, ANALYSIS, _(Freq Analysis), , ,  }
+	// N.B. it is not valid to use an _(NLS) string in this table!!
+	// ... doing so will break the Fl_menu_item table 'menu_'.  -Kamal
+{ MODE_ANALYSIS, anal_modem, ANALYSIS, Freq Analysis, , ,  }
 };
 
 std::ostream operator(std::ostream s, const qrg_mode_t m)


signature.asc
Description: This is a digitally signed message part

Bug#628864: Seg fault on get_menu_item / Debian Bug#628864: Fldigi fails to start, gives getMenuItem error

[Kamal Mostafa]

On Sat, 2011-06-11 at 20:13 -0500, w1hkj wrote:
 Yes a very good bit of detective work.  My question is why this did
 not create a problem on earlier gcc's.  What has changed in the
 compiler / linker?

I do not think the problem was caused by a compiler or linker change,
but more likely a change in the implementation of the _(string) macro
and the NLS system.  (I'm not positive about this though).

 -Kamal


signature.asc
Description: This is a digitally signed message part

Bug#593354: fldigi: Hangs when used with xmonad

[Kamal Mostafa]

John, could you check whether this still occurs with fldigi 3.21.4-1
(unstable)?

FWIW, I was unsuccessful in my attempt to replicate (something like) the
problem in the new 3.21.4 or the old 3.20.23...  I tried externally
changing the main fldigi window  geometry with the program
'xlayout' (built from google-located source) but could not make any
problem occur.  The fldigi window responds to the the external geometry
changes; it limits the minimum window height and width to some apparent
internal minimum values but never hangs or crashes.  Maybe xmonad
changes the window geometry some other way (?).

Does the problem still occur if you have *only* the main fldigi window
running (i.e. no other fldigi windows)?

73 de KA6MAL

 -Kamal




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#559814: hamlib: stable-security fix CVE-2009-3736

[Kamal Mostafa]

Dear security team-

I'm the DM maintainer for the package 'hamlib' (I am also currently working
through the of becoming a DD).  Regarding this bug (a mass-filed CVE against
libtool):

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=559814
CVE-2009-3736 local privilege escalation

I fixed this problem for hamlib in unstable (and upstream) some time ago.
I have now constructed a fix package for hamlib in stable, for which I ask
permission to upload to stable-security.  The fix package has been
reviewed by Gunnar Wolf, who has kindly agreed to upload it pending
approval.

The affected package in stable (lenny) is

hamlib (1.2.7.1-1)

My fix package bears the following changelog entry, which explains the
changes.  Note also that I updated the Maintainer/Uploaders/DM-Upload-Allowed
fields to reflect the current maintainer status for this package.

hamlib (1.2.7.1-1+lenny1) stable-security; urgency=high

  * Fix CVE-2009-3736 local privilege escalation (Closes: #559814):
- Use system libltdl not old internal copy
- Build-depend on libltdl3-dev
- configure, Makefile.am: skip internal libltdl build
  * New maintainer: Kamal Mostafa ka...@whence.com (Closes: #556098).

I have built and tested this fix on a fresh lenny system.

For your review, here is the debdiff (minus the re-generated files configure
and Makefile.in):

http://www.whence.com/debian/proposed/hamlib+lenny1/hamlib+lenny1.patch

My fix packages are available here:

http://www.whence.com/debian/proposed/hamlib+lenny1

Thanks,

 -Kamal



signature.asc
Description: This is a digitally signed message part

Bug#602978: man pages for aprsd, aprspass

[Kamal Mostafa]

Package: aprsd
Version: 1:2.2.5-13-5.1ubuntu1
Severity: minor
Tags: patch


The aprsd package doesn't supply man pages for its executbles: aprsd, aprspass

I've constructed simple man pages for them, attached.

73 de KA6MAL

 -Kamal
.TH APRSD 8
.SH NAME
aprsd \- amateur radio APRS Internet server
.SH SYNOPSIS
.B aprsd
[ -d ]
[
.I aprsd.conf-file
]
.SH DESCRIPTION
.B aprsd
is a server daemon that provides Internet gateway and client access
to amateur radio APRS packet data.
.PP
The complete documentation for this program is available in the file
\fI/usr/share/doc/aprsd/aprsddoc.html\fR.
.SH OPTIONS
.B aprsd
is controlled by a configuration file
(ordinarily \fI/etc/aprsd/aprsd.conf\fR)
which must be edited before use.
Detailed configuration and usage documentation is available in the file
\fI/usr/share/doc/aprsd/aprsddoc.html\fR.
.TP
.B \-d
Start
.B aprsd
as a daemon.
.TP
\fIaprsd.conf-file\fR
Optional alternate configuration file to be used instead of the
default \fI/etc/aprsd/aprsd.conf\fR.
.SH FILES
.br
.nf
.\ set tabstop to longest possible filename, plus a wee bit
.ta \w'/usr/lib/perl/getopts.pl   'u
\fI/etc/aprsd/aprsd.conf\fR	default configuration file
.SH AUTHORS
Dale A. Heatherington WA4DSY,
Chuck Byam KG4IJB,
Alan Crosswell N2YGK (original MIC-E code),
Brian D Heaton N5VFF,
Hamish Moffatt VK3SB,
Steve Dimse K4HG.
.SH COPYRIGHT
aprsd, Automatic Packet Reporting System Daemon
.br
Copyright (C) 1997,2002 Dale A. Heatherington, WA4DSY
.br
Copyright (C) 2001-2002 aprsd Dev Team
.PP
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License
as published by the Free Software Foundation; either version 2
of the License, or (at your option) any later version.
.PP
APRS is trademarked by Bob Bruninga.
.SH SEE ALSO
.BR aprspass (1).

Bug#602978: man page for aprspass

[Kamal Mostafa]

man page for aprspass
.TH APRSPASS 8
.SH NAME
aprspass \- APRS passcode generator for aprsd
.SH SYNOPSIS
.B aprspass
.I callsign
.SH DESCRIPTION
.B aprspass
computes the APRS passcode
from the provided amateur radio callsign,
for use with the
.B aprsd
APRS server daemon.
.PP
The complete documentation for this program is available in the file
\fI/usr/share/doc/aprsd/aprsddoc.html\fR.
.SH AUTHORS
Dale A. Heatherington WA4DSY,
Chuck Byam KG4IJB,
Alan Crosswell N2YGK (original MIC-E code),
Brian D Heaton N5VFF,
Hamish Moffatt VK3SB,
Steve Dimse K4HG.
.SH COPYRIGHT
aprsd, Automatic Packet Reporting System Daemon
.br
Copyright (C) 1997,2002 Dale A. Heatherington, WA4DSY
.br
Copyright (C) 2001-2002 aprsd Dev Team
.PP
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License
as published by the Free Software Foundation; either version 2
of the License, or (at your option) any later version.
.PP
APRS is trademarked by Bob Bruninga.
.SH SEE ALSO
.BR aprsd (8).

Bug#602978: corrected man page for aprspass

[Kamal Mostafa]

corrected man page for aprspass (fixed section number).

.TH APRSPASS 1
.SH NAME
aprspass \- APRS passcode generator for aprsd
.SH SYNOPSIS
.B aprspass
.I callsign
.SH DESCRIPTION
.B aprspass
computes the APRS passcode
from the provided amateur radio callsign,
for use with the
.B aprsd
APRS server daemon.
.PP
The complete documentation for this program is available in the file
\fI/usr/share/doc/aprsd/aprsddoc.html\fR.
.SH AUTHORS
Dale A. Heatherington WA4DSY,
Chuck Byam KG4IJB,
Alan Crosswell N2YGK (original MIC-E code),
Brian D Heaton N5VFF,
Hamish Moffatt VK3SB,
Steve Dimse K4HG.
.SH COPYRIGHT
aprsd, Automatic Packet Reporting System Daemon
.br
Copyright (C) 1997,2002 Dale A. Heatherington, WA4DSY
.br
Copyright (C) 2001-2002 aprsd Dev Team
.PP
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License
as published by the Free Software Foundation; either version 2
of the License, or (at your option) any later version.
.PP
APRS is trademarked by Bob Bruninga.
.SH SEE ALSO
.BR aprsd (8).

Bug#595525: libhamlib2: hamlib requires sudo for USB kit radios

[Kamal Mostafa]

Package: libhamlib2
Version: 1.2.11-1
Severity: normal
Tags: patch


Hamlib-based apps require the use of sudo for the USB kit radios
(elektor507, si570avrusb, dwt) which have an embedded generic
USB serial converter (FTDI, AVR USBasp):

  $ rigctl -m 2507
  rig_open: error = IO error 
  $ sudo rigctl -m 2507
  Rig command: 

Specifically, hamlib's attempt to usb_detach_kernel_driver_np()
fails because of root-ownership of the USB device node (e.g.
/dev/bus/usb/005/004).

Attached udev rules file enables ACL for the node when the device
is attached so that sudo is no longer required.
#
# Enable ACL_MANAGE for common embedded USB-serial converters so that
# applications which call usb_detach_kernel_driver_np() won't need sudo.
#
# This file was installed by the package 'libhamlib2'

# FTDI USB Serial Device converter
ACTION==add, SUBSYSTEM==usb, ATTR{idVendor}==0403, 
ATTR{idProduct}==6001, ENV{ACL_MANAGE}=1

# VOTI USBasp AVR Programmer
ACTION==add, SUBSYSTEM==usb, ATTR{idVendor}==16c0, 
ATTR{idProduct}==05dc, ENV{ACL_MANAGE}=1

Bug#588388: acpica-unix: extra tools are not built: acpiexec, acpisrc

[Kamal Mostafa]

On Thu, 2010-07-08 at 21:46 +0900, Mattia Dongili wrote:
 May I ask what you use them for?  [...]  
 have you got some use case for it?).

We (the Ubuntu kernel team) use acpiexec to debug DSDT's.

We're now starting work on some automated BIOS diagnostics tools that
will use acpiexec to collect information on systems in the field, which
is why we'd like to see acpiexec packaged.

We don't have any immediate need for acpisrc.  If you'd like to enable
acpiexec but not acpisrc, that's fine.

  Also, acpiexec is probably unusable anywhere but x86.

Perhaps then, some different binary packaging scheme is warranted?...
My patch crammed the extra tools into the 'iasl' package just for the
sake of expediency.  If you'd prefer to ship acpiexec in its own
separate (x86-only) package instead, that's fine too.

Thanks for considering it!

 -Kamal



signature.asc
Description: This is a digitally signed message part

Bug#588388: acpica-unix: extra tools are not built: acpiexec, acpisrc

[Kamal Mostafa]

Package: acpica-unix
Version: 20100528-3
Severity: normal
Tags: patch


The extra tools (acpiexec and acpisrc) provided by this source package
are not built.  It would be nice to have these useful tools.

The attached patch to debian/rules builds acpiexec and acpisrc
and installs them in the binary package 'iasl' (but not acpixtract
which seems to be also provided in the acpidump package).
diff -Nru acpica-unix-20100528/debian/rules acpica-unix-20100528/debian/rules
--- acpica-unix-20100528/debian/rules	2010-07-02 05:47:19.0 -0700
+++ acpica-unix-20100528/debian/rules	2010-07-07 13:46:09.0 -0700
@@ -27,13 +27,18 @@
 
 build: build-stamp
 
-build-stamp: configure
+build-stamp: configure-stamp
 	dh_testdir
 
 	# Commands to compile the package.
-	cd compiler  \
-	$(MAKE) CFLAGS=$(CFLAGS)  \
-	cd ..
+	$(MAKE) -C compiler CFLAGS=$(CFLAGS)
+	# note: we must explicitly clean after compiler for the tools to build
+	$(MAKE) -C tools/acpiexec clean
+	$(MAKE) -C tools/acpisrc clean
+	##provided-by-acpidump## $(MAKE) -C tools/acpixtract clean
+	$(MAKE) -C tools/acpiexec CFLAGS=$(CFLAGS)
+	$(MAKE) -C tools/acpisrc CFLAGS=$(CFLAGS)
+	##provided-by-acpidump## $(MAKE) -C tools/acpixtract CFLAGS=$(CFLAGS)
 
 	touch build-stamp
 
@@ -44,9 +49,10 @@
 	rm -f debian/acpi-dsdt.test*
 
 	# Commands to clean up after the build process.
-	cd compiler  \
-	$(MAKE) clean  \
-	cd ..
+	$(MAKE) -C compiler clean
+	$(MAKE) -C tools/acpiexec clean
+	$(MAKE) -C tools/acpisrc clean
+	##provided-by-acpidump## $(MAKE) -C tools/acpixtract clean
 
 	dh_clean 
 
@@ -67,6 +73,11 @@
 	tail -n +14 debian/acpi-dsdt.test.hex  debian/acpi-dsdt.test.hex-1
 	diff -u debian/acpi-dsdt.hex debian/acpi-dsdt.test.hex-1
 
+	# Hack: install the tools into the iasl package
+	install -m 755 tools/acpiexec/acpiexec $(CURDIR)/debian/iasl/usr/bin
+	install -m 755 tools/acpisrc/acpisrc $(CURDIR)/debian/iasl/usr/bin
+	##provided-by-acpidump## install -m 755 tools/acpixtract/acpixtract $(CURDIR)/debian/iasl/usr/bin
+
 update-test-case: build
 	mv debian/acpi-dsdt.hex debian/acpi-dsdt.hex.$(shell date +%s)
 	compiler/iasl -tc -p debian/acpi-dsdt.hex debian/acpi-dsdt.dsl

Bug#578585: gpredict: Menu item Help - License doesn't do anything; missing COPYING file

[Kamal Mostafa]

Package: gpredict
Version: 1.1-5
Severity: minor
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch


https://bugs.launchpad.net/ubuntu/+source/gpredict/+bug/343430

gpredict package does not ship /usr/share/gpredict/COPYING.
Attached patch links it from /usr/share/common-licenses/GPL-2
making Help - License work properly.
diff -u gpredict-1.1/debian/rules gpredict-1.1/debian/rules
--- gpredict-1.1/debian/rules
+++ gpredict-1.1/debian/rules
@@ -28,6 +28,7 @@
 	dh_installmenu
 	dh_installman debian/gpredict.man
 	dh_installchangelogs ChangeLog
+	dh_link usr/share/common-licenses/GPL-2 usr/share/gpredict/COPYING
 	cp NEWS debian/gpredict/usr/share/doc/gpredict
 	dh_strip
 	dh_compress
diff -u gpredict-1.1/debian/changelog gpredict-1.1/debian/changelog

Bug#576395: debian-maintainers: Please add Kamal Mostafa to Debian Maintainers keyring

[Kamal Mostafa]

Package: debian-maintainers
Severity: normal


Please add Kamal Mostafa ka...@whence.com to Debian Maintainers keyring.
Jetring changeset is attached which adds new key id 0x5409E422.
This request replaces http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575350 .

Thank you,  -Kamal Mostafa
Comment: Add Kamal Mostafa ka...@whence.com as a Debian Maintainer
Date: Sat, 03 Apr 2010 21:31:54 -0700
Action: import
Recommended-By: 
  Jaime Robles ja...@robles.es
Agreement: 
  http://lists.debian.org/debian-newmaint/2010/04/msg1.html
Advocates: 
  http://lists.debian.org/debian-newmaint/2010/03/msg00036.html
Data: 
  -BEGIN PGP PUBLIC KEY BLOCK-
  Version: GnuPG v1.4.10 (GNU/Linux)
  
  mQINBEuvgo4BEACh+eg04LgIXaIbs4y3uwKyDDswyVyVZoYfWrH4nten6uApOn1v
  mWHYfRnS6UTh5EOwdb8szuQ4XjadFEuhFWRdaaRgFeSjRScIgdHhKBzFF9SrKfFW
  ktVnEPlfIrMKi9BmCXqjJX2msmWT/QCkJGd/oZiKzg6G07jbmDAa/oKj0Mo2zCr2
  Uf142goLcEKBaKrCTZQP24HchkQhuX407EDSAjgg0CI5jV3CR3UOXpM6LNP2Uwgq
  edDBwUB//CF3Snf6byUWh8Fs/7r1sqdjGhjODFsyitGUm3D2ZBj2IiGl+YW96i2t
  A+/7fop4zZl86/dryWXriBslETze1JL/HbkRQ5W6fjHX32QDwwZfsjpDh1x/N/9x
  N1orwVgpWD7g5rSPQxDVs1o/+jmx0Nd3EdPVhlI0uaEIIUI8JHGyiDMiI0ApI04u
  UBzEiqImp4IgsFWGaGaQ8vQjbFcds24CwQ7WU9tMX23n5BJJciDRoC/VtMNGS89t
  Qe3t6bUyMMXy5xCcMzgbkqsfANkUn0/XlvdohPhBPPAxRpMwXJ98e9V/xQLyzJPw
  15lELXH6qS86IGQ8mB4lyQDRpzH1kB+vSAvikdBRFanjnDJfTdAhsLBcTnBzqvyN
  ZhMfkdf6ESFYDoGKalio8VosuC+5slpLy5RegCPbnsxYh2LI97WkR9H8SwARAQAB
  tCBLYW1hbCBNb3N0YWZhIDxrYW1hbEB3aGVuY2UuY29tPokCOgQTAQgAJAIbAwUL
  CQgHAwUVCgkICwUWAgMBAAIeAQIXgAUCS6+xXwIZAQAKCRDn9xBVVAnkIl2FD/96
  OH3INLeTpU21DN5qTO/ZJ+vTQ+P2WF7xzGSK8t19t/MPzCHOvE7QwRbFBPTCz4rH
  MGolCE6TU5/qCO/wBQz+GCpwKaK+07ogNx1BIUH3vu153uUnKAJAjETCYr2aoNsl
  nTa0flGmnVSgux2QcRLADOefDJeOKg0v/S5gO2VyqO7bP3Q0OFDOm3a/dfA4ACQ2
  mG/Si+tw7iJuE2fWRvKsgUx6H+SyouHqP1som/58ZstN1bHg6XomW7FJCR7iYL27
  NdHYBR2AWvjgOwh4zEb3JFq2i/hOad/KNaXyPLOywcyUAxVhRd3Z5g2o2uECzejr
  6dh3VO82bp2qVrlXAoRZobkWuC8pJN6ljMinaixoVSa02BRom8yC917+rvSkZB2B
  4YcZG9RkTQvX9xWo6iaLCPBBzv60dtP5tRAT5OgGLgbZi6ZJUYSU0tAhIyXD1pWm
  CFBlCcsTTt2vG6jSS5SMrpE4cPHr3GkNUeVEZu2k8gnYmsOFOvfrDG1oIcRmtoU8
  SNudZ9Pq76+LSI6uIM2YHEgTbLN2srS7U34CVhTWVeWksQ+BGc7t0UDu1YTGyhA6
  qIZUOTSx8peG6V3gSXeLRrVNHxlARhJXNNGWQ4RyYw6+lXhSuN9v5OSe0taZFZKe
  alVN8xXOG6Qax1AcVRrHm7wPmrU8Bh0/XLsO8yyICIhGBBARCAAGBQJLsQoeAAoJ
  ECNOcxQsaeEPysIAn24Gh4YpNIe4biffJQdaLxGX7hRvAJ9V0bWo0Y0BxaRyB/wE
  aNGYY3v9OYicBBABCAAGBQJLtWK0AAoJEIrzk78EeS5RlbEEAIuqsGC5W1GOV4v9
  E9OUS5+Bt3eahuOp4pVNaUiybK3iRto3HbpviOnb7O75Q9lAcivQdQqUrSFt9rqh
  +ALnUbz/POYpLcxMqajPKlOF7r3g0b8rh1wMWGkNluHcYbhk2I+ligb64Cm5K3ct
  R+V4+Nbu+9t4Ny5zugQdeAuiLdhhiQIcBBABCAAGBQJLtlyfAAoJEGJoj/M6dYoe
  +LUP/iAFLT2trgILOJNHbWIUDPPq0P56aLYVowctlX/jUqI1BAzRgOrSiaTHlUOO
  4qy0tCZnCfteLxcWVbySr1juBHS/rQjSC0Tx+nj0o1W6Pp1wNIySzesn52dr5Iq4
  cjqHIv0VWlFBcYXnEFHxd7sR/a/cLwPsnsrC3Dv6wz98CrGu+qK6HDETxCdMqbdp
  /O/3KYXrNZDlfHSdzlByhRMhOZOhg2DGrYyFggffJ0qbxxBfEfhIdM6BEal9ZfXt
  zjIr1FGzWaXkwLJD4kZYXd+aT+oJPrSz7Fsg4j8t3hCJ8labNcOuNnbWplwUovPh
  qC/vl7aQypnup4SxupSc0AZ1m1vgUYuEuyvFTIIPqH1lvBErvwOyMLqNxqLj2FSR
  ZNdXzIGJsHgxLhHTfROvOhRgMMCoj+UylExEVDv+YBD1i6wOqMdExcvOsBczRnu3
  FQtUZnOTjehRkNjzq+78ubL0/7Mbbr78B4qcUkTfU305/+jpT0AY82+V6G925wAa
  YrX7OMjEzcX4eOry0lOXfMuU+CbuJFPCqC+ONpAZyNT/4tM4elJxgrpQ1vynAB0A
  zzsIsJQ58tngKgMeimZbV9AetJpbJIIH6lqAmBisseG6aYQpspyqmt4KOWrREcIU
  g6eurZ29f7M8mTF0uHDxk1oOE2/WQgXIb0rSlOxOmwA89Ad1iEYEEhEIAAYFAku3
  pV8ACgkQIblXXKfZFgLWlwCgn37bXjBqvCpfh4NgcAjqPCOWSjIAoIvu/MWrkkSI
  qVWCWzaeOmD+srbeiQIcBBIBCAAGBQJLt6UxAAoJEFHf2Ts++3nvO1QP/A/yS6T8
  PgHste3DeCZY0HRoY+KA/8IRLSap6+bwui92hlsjHk0faYWIZya2lRVgrsjNtg+B
  Tp1Ef6oHxZiLCP0Nq/4kprYcg8verkmto0TYCcBkdlcnGC6g7QREiy7pptUf3F/b
  UuEoeMtzjV707Gm8mkfZA08y1iVQsKw18h/YiMZ4EXsbwCMAmWm1XFMB+M1YalLh
  q16gSdF4MX54vhoCLjIhpA8mCSwCaaMdusp4w7S+W5Z87OfaPDGBTmPIXOLbvqRe
  gxZEWORt6qbi8enu3cRrZaX83z/F32KOIKEjcFhtqhz8QMKQO+ipQ5cS5wEOKE7r
  DxJz08jGtpfDc2A4e0Hrxnrr44JlrekZ5AwwaxNUCeB0s2bl9ZxXOEDPPe4nYNaE
  F+0pSyikLCxBTWYT1CdiKAoAAL9IbxOeGbzOkn/WIQWKa8dIPyzNnBYphYN4VD54
  2N0RY7vF2RHBTHmItkPwhNNvexPud5zGIRSx/eLA247RJy7ZEWchK0kwwYv+B6NI
  j5yEbOs+037xn5JG+aGeiTPQWKuGAATkeVuU05DX1mSzxtVJWlxcX0uYKa9bt+Ha
  Is5qjVCF884DRb/hxoXe2OdUW8kbSNsg2hxAG/o693jtjTE8oSsaZd7BL4RmMDGK
  Z3tm9/ycOLDJdkgO8vN8nGk+CTZJx6Aocc7HtCNLYW1hbCBNb3N0YWZhIDxrYW1h
  bEBjYW5vbmljYWwuY29tPokCNwQTAQgAIQIbAwULCQgHAwUVCgkICwUWAgMBAAIe
  AQIXgAUCS6+xXgAKCRDn9xBVVAnkItQED/90wZ2gcQMlIzSKeBg5+ksomj1pWZez
  iYf1ploYvFwIgYMAi4iR3FF4Zdox8vkldK/WB/yc3VspF8vhXJAEaTW6nakSBjKG
  sfolBqvj7NKOuqDWdAquk1ri2FJlwnpK7GVHjLJLR00k6r1Wx+Ru9Aari0YigWeH
  iyJBWISw9Od02B0+p1rk/HkUsl1thM6O3zgDeEC20v9xMkufbmKqtyKEsdGftZwy
  oCRCVej4vJKzQegCxeL3yfGSmo4ImqhHbVB8VcJA9uPjeCNoGb6Jz0U/NmEiphLC
  na0IdAh9Q6mZFokQNJw373aDmvyu5iTb69qr3W4+T0ICoNNjj8LzBd/lfdbeTcN0
  cH57L8dF3nCxsyeBrFPxSTeQhPzBN5KnuC5z8BQ3VxDaV9k2JIfQiGol0rjOokxe
  pVnH48o1Mc9V1YLEB+hsQP5kxtjQQh9IerhRyL5LKzknAzLbWX6GxDlJNAY8cg/9
  HuS+++iJx1vwEIIQq/3U/sukEWFklHPZkr76dXDn2mSx4xm57ie0JUwhwcQuPDp7
  3Q6RBqvKNwVr128EVh85GQ+VB5SaoCdpWn/CamJpDj1UkdUDt7TBSeMLiHMfjuQu

Bug#575350: debian-maintainers: Please add Kamal Mostafa to Debian Maintainers keyring

[Kamal Mostafa]

Package: debian-maintainers
Severity: normal


Please add Kamal Mostafa ka...@whence.com to Debian Maintainers keyring.
Jetring changeset is attached.

Thank you,

 -Kamal Mostafa
Comment: Add Kamal Mostafa ka...@whence.com as a Debian Maintainer
Date: Wed, 24 Mar 2010 21:37:17 -0700
Action: import
Recommended-By: 
  Jaime Robles ja...@robles.es
Agreement: 
  http://lists.debian.org/debian-newmaint/2010/03/msg00024.html
Advocates: 
  http://lists.debian.org/debian-newmaint/2010/03/msg00036.html
Data: 
  -BEGIN PGP PUBLIC KEY BLOCK-
  Version: GnuPG v1.4.9 (GNU/Linux)
  
  mQGiBEsxAdURBAC/MF8JPWIDGJzYVj6WC0fG3Z5yDeBW8cziyooIPtwJw7JYb7kG
  jFBvC8IKY34JwcYlht75RnIjlq4IzdmngRnQJSDiE9+FfC6pM2qqhSRGsxypk4qB
  jEHKYA1UBiaBR4MRmXDAGj+8VxsacrIBuPTMQ5dWkbDxbFm4BjYQHo3bSwCgmLsB
  ghae02f2jPADi+QdROd1CuUEAK0h9orbXd3LJIel8qHUfLhrV9VCKH5OubWB8F1W
  EzZDIsRiGA5BNyGKJYJnZR+ngU9wdaUacn2yW9cQRtw6AcE0uoWHuqWq6Czymalg
  /qsINYslH8RGwVNkseg0n13RGztPBmEMYP90m7tPztEUs0/0AXFSxGEqZVN5YpCi
  lgKEA/wL73RWWE/dzt/bdI5nSARG/egzWfSDhbIwKaXCTw23OSLx7SbGbS2uGVDt
  8sHLMbmSzk56gEUh8ck4FXUwVnJaqqVlCQnkvguJtEMWRr9P5M2CrU/VH/PJPE5M
  3/G/X8WOHGqcIons0SPN3C41TcUjk2GKsul0hglqX3eCS8hzG7QgS2FtYWwgTW9z
  dGFmYSA8a2FtYWxAd2hlbmNlLmNvbT6IYwQTEQIAIwIbAwYLCQgHAwIEFQIIAwQW
  AgMBAh4BAheABQJLqEiaAhkBAAoJECNOcxQsaeEP+lwAn3rSJBJDq0q9HAY94bVa
  ON4FPYNuAJ47U3xrOnRwR+1URetfteW3p86RQIkBHAQQAQIABgUCS58t2AAKCRA7
  1g3ckNxsF8dHCACa5c99olGVjGCRKXBiOiipWK00r0Ug11PwDPv+edycQLBxMSBH
  55NUbvn3pfp/aah9G4yAurHirgBnaUJBiWqEs3VBg10VkIT79rdbgdCL+tbd6hmj
  2NndRZL5kDf82iKX/Ih70N0Yzch5xK4qGsn0gkM6zbhxUFDwdBoiI4uAabq22/ze
  SP50qESz8IoYHBPsr8BgYN4UMXkiSZDcvljnoRW43v6z7ybQGu+NU8MHqfCUdmXB
  bVpTasOuktG4hdjCQnFVkPMfRiWXkzW2bJb0r5DxMKW01lCU6HhC9jb/9xdTRM+A
  GuI+G2/qL11MVeKP6QDe8d3tkkjIUMUmI1wliQEiBBABAgAMBQJLoDueBQMAEnUA
  AAoJEJcQuJvKV618OxgIAJ2LOgBdc3rrp3UTqhOe2kOYa32K83P4KuFTN+0129dD
  H/bp1SSgTtOIxj4AGCTJMkM6w6hWV4G8ggyP4MyB7bWYD4OYZ8zMW7P5Ft5zGBzT
  cI7TgVi6TZlmBTI237y2qjPmLy8Us1byqtRH3OsQlI71MibW3v8XffT6ar6XBT7k
  d0O8KNGhastHUV6oVzXc0iXNiB5nVB8JfQhwGG/sdvzYVkKXiNyqVSVsw7MKGSOv
  nihDlvyJj7mpxBPl/ILoKgKne/24K7HJnjk5DfdVEQRZ5XE6/++douV8B+ZXZo9g
  yc0UsTe9blfRPMa1kDvrlKE2/HQACig6p2ldOFX4YeSJAhwEEAECAAYFAkuhw1YA
  CgkQHWLpyTdtzscdNRAArjrec5jVB22J4phf2t4f4AiAL3P0sNKkQtmxtGMFkSFZ
  HOpUV/3WGKoy71TCbAmViq0lkOuJtl1usyDtqkDrLQ5Q4FxndcyYYRm4f3RxPwgU
  wpg5hetC61NppiDxdmMKkkSWY202Qer/ZuUwsq9rxf3edqcMUYIw3Wpl9f4h67bs
  vw2Gr2WQRrBwqz38mJJto7uu789l06tmoGq+NM/xXCcrCxkbNa4wCiaDTSTe3OC3
  HN9DhRmuLgpeIa9BtcestDQ/MDMP4q9qAhIPujl52/VXOc4Cncduymjl93S8UWDy
  U2Zg8YfhH5GmILrqlWLRYOlrfsttrb1f2jvIMqR/kgnTNNvM4ITf2+5BkhSOiWzb
  fE1Uvk11ffIlH8/hR3sIfRZ3tg2DZw+WRIRW7FsnEXMd5d9Lk+ozOiIDbs2ILEUM
  7MuDL4y66LhyXau3Kl62ZlPaaHwIz88bGw/KrgKQf+0hacUSUD5WmPtRnoq8rWe7
  FkWiVD2bo5eoj0XsOsf/IGHk6QivdYdltyCLF2O1c3I1/OCK5PK7LiyCbhJkX+T3
  Cgf4Qx3StQ0LDvnFu5TopneP86V4S1Xxz80J8Qiv4BgfC8fLF66yenYC79gzG2dC
  mgZK8I8AnaN3ukJ/1DHNqZVdrO2xvyB/FVeKyd5D+Z2ZHSZOnCtfQt2L4PZQEZSI
  YAQTEQIAIAUCSzEB1QIbAwYLCQgHAwIEFQIIAwQWAgMBAh4BAheAAAoJECNOcxQs
  aeEPmboAniC4sqrX7csQ4tQjy3x4W6V2YoGvAJ9MNEh+99MjUdp42kbyGoQvJywS
  tLQjS2FtYWwgTW9zdGFmYSA8a2FtYWxAY2Fub25pY2FsLmNvbT6IYAQTEQIAIAUC
  S6hIjwIbAwYLCQgHAwIEFQIIAwQWAgMBAh4BAheAAAoJECNOcxQsaeEP++cAn2i4
  SvFKxSWWKvNAFbQZBa1CDNJtAJ0eyQLR05T5HSDAl+x+N/LV9CmXvdHfkN+OARAA
  AQEAAAD/2P/gABBKRklGAAEBAAABAAEAAP/bAEMACAYGBwYFCAcH
  BwkJCAoMFA0MCwsMGRITDxQdGh8eHRocHCAkLicgIiwjHBwoNyksMDE0NDQfJzk9
  ODI8LjM0Mv/bAEMBCQkJDAsMGA0NGDIhHCEyMjIyMjIyMjIyMjIyMjIyMjIyMjIy
  MjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMv/AABEIAMAAwAMBIgACEQEDEQH/
  xAAfAAABBQEBAQEBAQAAAQIDBAUGBwgJCgv/xAC1EAACAQMDAgQDBQUE
  BX0BAgMABBEFEiExQQYTUWEHInEUMoGRoQgjQrHBFVLR8CQzYnKCCQoWFxgZ
  GiUmJygpKjQ1Njc4OTpDREVGR0hJSlNUVVZXWFlaY2RlZmdoaWpzdHV2d3h5eoOE
  hYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPExcbHyMnK0tPU1dbX
  2Nna4eLj5OXm5+jp6vHy8/T19vf4+fr/xAAfAQADAQEBAQEBAQEBAQID
  BAUGBwgJCgv/xAC1EQACAQIEBAMEBwUEBAABAncAAQIDEQQFITEGEkFRB2FxEyIy
  gQgUQpGhscEJIzNS8BVictEKFiQ04SXxFxgZGiYnKCkqNTY3ODk6Q0RFRkdISUpT
  VFVWV1hZWmNkZWZnaGlqc3R1dnd4eXqCg4SFhoeIiYqSk5SVlpeYmZqio6Slpqeo
  qaqys7S1tre4ubrCw8TFxsfIycrS09TV1tfY2dri4+Tl5ufo6ery8/T19vf4+fr/
  2gAMAwEAAhEDEQA/APJ2Xj+VMK/X8asFeRUZGB36965zvcSHAAxim4IHSpSvHXFM
  I6ZzTFysiI/A0Y+tSEHNNIAFAuUbtOBmjH4+1P6nrjNG3gYHTvSuPlT2IyMdOmad
  tGAepz09KljgeQgKAASF3E4GT7ngd6nTTp3kEawu7ucLj19P8+1DkhqBQZfx7UhH
  NdBBpIktWAdNzgAqe3zHDKccdCDn1/KSbQMxCS281QRtKuvBGBz+Jzx2wKz9tG9r
  l/V5bnNHPejb0GD+Fb8mhOofzC0ZJDDKHp1x+oqOTSiIG8l0Y8lc9QPr601WiDw0
  lqYXbr+FNPTBq++nTRoXZCAKreXtXcWUjrwa1UkzFwlsyD6fhRz9KmWRhKZSATn+
  6Mfl0qIck8/rTIaG/jxSf1p3pSHrxTJtYb9M0Y5wM0n8VHT37UDsH8X69K7fwxpY
  tYPtMg/fSjj/AGV/z/Suc0TT/tt8C4zDH8ze/oP8+leg2yjcKwrT6I1pw6nFsoxm
  omBA749qtFMDoRg1CwGP881RtKNyuy1GVyc46VMwwaYRx/XHSmZ2IyOwpO/tTscD
  kYqWGEyDCgbjzkjpQ9BpNkAGTjHNSx27tKFClmB5X0rpItOa7EaPMkkakBhDz78D
  pjqemc569a27DwzaQTsBdow27HRXGevXtx/nArCVdJG6o33Mi08PPJIkTLHGQA20
  nkA5P58V0tv4ZiS8liEiyR5/dugyFOemByPxras7WNpJo7ZpDPIRvfbjpjoRn3ye
  +e1dZaeD2AWV52R2Azjg

Bug#573759: gnuradio: FTBFS due to stale .moc files (Ubuntu Lucid)

[Kamal Mostafa]

Package: gnuradio
Version: 3.2.2.dfsg-1
Severity: important
Tags: patch
Justification: fails to build from source
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu lucid ubuntu-patch



*** /tmp/tmpJPNdra

gnuradio 3.2.2.dfsg-1 FTBFS in Ubuntu Lucid, because the newer Qt won't
accept pre-built .moc files in the source tree (version too old).  Removing
them lets them get rebuilt by Qt during the build.

In Ubuntu, we've applied the attached patch to achieve the following:

- debian/rules clean: remove pre-built Qt moc files

We thought you might be interested in doing the same. 
diff -u gnuradio-3.2.2.dfsg/debian/rules gnuradio-3.2.2.dfsg/debian/rules
--- gnuradio-3.2.2.dfsg/debian/rules
+++ gnuradio-3.2.2.dfsg/debian/rules
@@ -15,6 +15,11 @@
 	dh_testroot
 	rm -f build-stamp configure-stamp extract-stamp install-stamp
 
+	# Remove (possibly stale) pre-built Qt-generated moc files; they will
+	# be rebuilt using the current Qt moc.  Perhaps this should actually be
+	# part of 'make distclean' and these files not be distributed:
+	rm -f ./gr-qtgui/src/lib/*_moc.cc
+
 	if [ -f Makefile ]; \
 	then\
 		if [ -d .svn ]; \

Bug#566564: gnuradio: patch adds binary package dep on 'adduser'

[Kamal Mostafa]

Package: gnuradio
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch


Attached patch adds binary package dep for libusrp0, libusrp2-0: adduser
This should resolve bug #566564 and bug #566565.
diff -u gnuradio-3.2.2.dfsg/debian/control gnuradio-3.2.2.dfsg/debian/control
--- gnuradio-3.2.2.dfsg/debian/control
+++ gnuradio-3.2.2.dfsg/debian/control
@@ -110,7 +110,7 @@
 Package: libusrp0
 Section: comm
 Architecture: any
-Depends: ${shlibs:Depends}
+Depends: ${shlibs:Depends}, adduser
 Replaces: libusrp0c2a, usrp-firmware
 Conflicts: usrp-firmware
 Suggests: usrp-doc
@@ -146,7 +146,7 @@
 Package: libusrp2-0
 Section: comm
 Architecture: any
-Depends: libgruel0 (= ${binary:Version}), libgromnithread0 (= ${binary:Version}), ${shlibs:Depends}
+Depends: libgruel0 (= ${binary:Version}), libgromnithread0 (= ${binary:Version}), ${shlibs:Depends}, adduser
 Description: Client side library for the USRP2 hardware
  The Universal Software Radio Peripheral 2 (USRP2) is a GbE-connected,
  low-cost and open board. It features two high-speed analog-to-digital

Bug#571175: hamlib: Reported frequency is incorrect for Yaesu FT-767 radio

[Kamal Mostafa]

Package: hamlib
Version: 1.2.10-1
Severity: normal


https://bugs.launchpad.net/ubuntu/+source/hamlib/+bug/526749

The current version of hamlib has an error in the Yaesu FT-767GX back end which 
causes the frequency to be reported as 1/10 of the actual frequency. This has 
been fixed in the upstream repository but a releas has not been made of hamlib 
since the change was committed.

It is a trivial change with no risk to any other model of radio.

Could a patch be added to make this change?



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#571180: modules missing from 1.2.10-1 package: hamlib-rs.so, hamlib-spid.so

[Kamal Mostafa]

Package: hamlib
Version: 1.2.10-1
Severity: important


Debian's hamlib 1.2.10-1 package accidentally omits two hamlib modules:
hamlib-rs.so and hamlib-spid.so.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#517801: please close unreproducible bug

[Kamal Mostafa]

Following up on Joop's message (02 Dec 2009)...  Please close this bug,
which is holding up 'soundmodem' from entering testing.  The reported
problem cannot be reproduced by the submitter nor by other testers
(including myself).

Thanks,

 -Kamal Mostafa KA6MAL



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#559814: ITA: hamlib / new version for upload

[Kamal Mostafa]

After discussion with Steve Conklin (who filed an ITA for 'hamlib' a few
months ago) we have determined that I will volunteer to adopt and
maintain 'hamlib' instead of him.

For reference, I am a ham radio operator (KA6MAL), I do use hamlib
regularly, and I have developed applications which use the library.  

I have packaged the new upstream release (hamlib 1.2.10) which I propose
for review and upload by a kindly DD:

http://www.whence.com/debian/proposed/hamlib_1.2.10-1.dsc

This package includes my fix for bug 559814 (CVE-2009-3736 local libltdl
privilege escalation), and minor Python 2.6 changes from Ubuntu.

I wasn't sure what to do with the debian/control Uploaders: field.  As
a placeholder, I set it to the debian-h...@lists.debian.org list address
-- I expect that it will be changed by the actual uploader:

  Uploaders: Debian Hamradio Maintainers debian-h...@lists.debian.org

This is my first experience with maintenance of a package at Debian, so
I am not at all sure that I'm following the proper procedures here.  Any
guidance will be much appreciated.

Thanks,

 -Kamal Mostafa ka...@whence.com



signature.asc
Description: This is a digitally signed message part

Bug#569610: omhacks FTBFS: open O_CREAT needs 3 arguments

[Kamal Mostafa]

Package: omhacks
Version: 0.8-1
Severity: important
Tags: patch
Justification: fails to build from source
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch


https://bugs.launchpad.net/ubuntu/+source/omhacks/+bug/521164

http://launchpadlibrarian.net/39017735/buildlog_ubuntu-lucid-i386.omhacks_0.8-1_FAILEDTOBUILD.txt.gz

cd /build/buildd/omhacks-0.8/obj-i486-linux-gnu/omhacks  /usr/bin/gcc 
-Domhacks_EXPORTS -g -O2 -fPIC -I/build/buildd/omhacks-0.8/omhacks/.. -Wall 
-Werror -o CMakeFiles/omhacks.dir/sysfs.c.o -c 
/build/buildd/omhacks-0.8/omhacks/sysfs.c
In file included from /usr/include/fcntl.h:205,
 from /build/buildd/omhacks-0.8/omhacks/sysfs.c:28:
In function 'open',
inlined from 'om_sysfs_writefile' at 
/build/buildd/omhacks-0.8/omhacks/sysfs.c:194:
/usr/include/bits/fcntl2.h:51: error: call to '__open_missing_mode' declared 
with attribute error: open with O_CREAT in second argument needs 3 arguments
make[3]: *** [omhacks/CMakeFiles/omhacks.dir/sysfs.c.o] Error 1

---

In Ubuntu, we've applied the attached patch to achieve the following:

  * Fix FTBFS: sysfs.c open with O_CREAT needs 3 arguments (LP: #521164)

We thought you might be interested in doing the same. 
--- omhacks-0.8.orig/omhacks/sysfs.c
+++ omhacks-0.8/omhacks/sysfs.c
@@ -191,7 +191,8 @@
size_t ssize = strlen(str);
ssize_t count;
int fd = -1;
-   fd = open(pathname, O_WRONLY | O_CREAT);
+   fd = open(pathname, O_WRONLY | O_CREAT,
+   S_IRUSR|S_IRGRP|S_IROTH|S_IWUSR|S_IWGRP|S_IWOTH);
if (fd  0) return fd;
count = write(fd, str, ssize);
if (count != ssize)

Bug#569626: nauty FTBFS: conflicting types for 'getline'

[Kamal Mostafa]

Package: nauty
Version: 2.4~b7-2
Severity: important
Tags: patch
Justification: fails to build from source
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch


https://bugs.launchpad.net/ubuntu/+source/nauty/+bug/521190

http://launchpadlibrarian.net/39035800/buildlog_ubuntu-lucid-i386.nauty_2.4~b7-2_FAILEDTOBUILD.txt.gz

gcc -c -g -O2 gtools.c
In file included from gtools.c:6:
gtools.h:159: error: conflicting types for 'getline'
/usr/include/stdio.h:651: note: previous declaration of 'getline' was here
gtools.c:375: error: conflicting types for 'getline'
/usr/include/stdio.h:651: note: previous declaration of 'getline' was here
gtools.c: In function 'gt_abort':
gtools.c:1835: warning: format not a string literal and no format arguments
make[2]: *** [gtools.o] Error 1


-

In Ubuntu, we've applied the attached patch to achieve the following:

  * Fix FTBFS: gtools.c getline renamed to gtools_getline. (LP: #521190)

We thought you might be interested in doing the same. 
diff -u nauty-2.4~b7/debian/patches/series nauty-2.4~b7/debian/patches/series
--- nauty-2.4~b7/debian/patches/series
+++ nauty-2.4~b7/debian/patches/series
@@ -1,0 +2 @@
+gtools_getline.diff
only in patch2:
unchanged:
--- nauty-2.4~b7.orig/debian/patches/gtools_getline.diff
+++ nauty-2.4~b7/debian/patches/gtools_getline.diff
@@ -0,0 +1,113 @@
+Index: nauty/checks6.c
+===
+--- nauty.orig/checks6.c	2010-02-12 13:50:52.0 -0800
 nauty/checks6.c	2010-02-12 14:00:56.0 -0800
+@@ -211,7 +211,7 @@
+ 	elsemaxin = pval2 - pval1 + 1;
+ 	while (nin  maxin || maxin == NOLIMIT)
+ 	{
+-	if ((s = getline(infile)) == NULL) break;
++	if ((s = gtools_getline(infile)) == NULL) break;
+ 	++nin;
+ 
+ 	if (seemsbad(s)) ++nerr;
+Index: nauty/gtools-h.in
+===
+--- nauty.orig/gtools-h.in	2010-02-12 13:50:52.0 -0800
 nauty/gtools-h.in	2010-02-12 14:00:56.0 -0800
+@@ -156,7 +156,7 @@
+ extern void gtools_check(int,int,int,int);
+ extern FILE *opengraphfile(char*,int*,boolean,long);
+ extern void writeline(FILE*,char*);
+-extern char *getline(FILE*);
++extern char *gtools_getline(FILE*);
+ extern int graphsize(char*);
+ extern void stringcounts(char*,int*,size_t*);
+ extern void stringtograph(char*,graph*,int);
+Index: nauty/gtools.c
+===
+--- nauty.orig/gtools.c	2010-02-12 13:50:52.0 -0800
 nauty/gtools.c	2010-02-12 14:00:56.0 -0800
+@@ -370,23 +370,26 @@
+changed at compile time to avoid conflict with the GNU function of
+that name.
+ */
++/* Changed name to gtools_getline to avoid this name conflict, as nothing
++   in the build system does so.
++ */
+ 
+ char*
+-getline(FILE *f) /* read a line with error checking */
++gtools_getline(FILE *f) /* read a line with error checking */
+ /* includes \n (if present) and \0.  Immediate EOF causes NULL return. */
+ {
+ DYNALLSTAT(char,s,s_sz);
+ int c;
+ long i;
+ 
+-DYNALLOC1(char,s,s_sz,5000,getline);
++DYNALLOC1(char,s,s_sz,5000,gtools_getline);
+ 
+ FLOCKFILE(f);
+ i = 0;
+ while ((c = GETC(f)) != EOF  c != '\n')
+ {
+ if (i == s_sz-2)
+-DYNREALLOC(char,s,s_sz,3*(s_sz/2)+1,getline);
++DYNREALLOC(char,s,s_sz,3*(s_sz/2)+1,gtools_getline);
+ s[i++] = c;
+ }
+ FUNLOCKFILE(f);
+@@ -735,7 +738,7 @@
+ char *s,*p;
+ int m,n;
+ 
+-if ((readg_line = getline(f)) == NULL) return NULL;
++if ((readg_line = gtools_getline(f)) == NULL) return NULL;
+ 
+ s = readg_line;
+ if (s[0] == ':')
+@@ -1018,7 +1021,7 @@
+ char *s,*p;
+ int n,loops;
+ 
+-if ((readg_line = getline(f)) == NULL) return NULL;
++if ((readg_line = gtools_getline(f)) == NULL) return NULL;
+ 
+ s = readg_line;
+ if (s[0] == ':')
+@@ -1652,7 +1655,7 @@
+ 
+ void
+ writelast(FILE *f)
+-/* write last graph read by readg() assuming no intervening getline() */
++/* write last graph read by readg() assuming no intervening gtools_getline() */
+ {
+ writeline(f,readg_line);
+ }
+Index: nauty/shortg.c
+===
+--- nauty.orig/shortg.c	2010-02-12 13:50:52.0 -0800
 nauty/shortg.c	2010-02-12 14:00:56.0 -0800
+@@ -218,7 +218,7 @@
+ int j;
+ char *s;
+ 
+-	if ((s = getline(f)) == NULL) return FALSE;
++	if ((s = gtools_getline(f)) == NULL) return FALSE;
+ 
+ 	*cdstr = s;
+ for (j = 0; s[j] != ' '  s[j] != '\t'  s[j] != '\n'; ++j) {}
+Index: nauty/debian/libnauty0d.symbols
+===
+--- nauty.orig/debian/libnauty0d.symbols	2010-02-12 14:01:23.0 -0800
 nauty/debian/libnauty0d.symbols	2010-02-12 14:01:32.0 -0800
+@@ -55,7 +55,7 @@
+  

Bug#569644: antennavis TkAnt crashes if no GW lines present in antenna file

[Kamal Mostafa]

Package: antennavis
Version: 0.3-6
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch


Originally reported by [jsef...@gmail.com] as
https://bugs.launchpad.net/ubuntu/+source/antennavis/+bug/120923

Loading an antenna file (or any file) which contains no GW geometry
tube lines causes antennavis TkAnt to crash with segmentation fault.

Easy to reproduce:
1. $ touch /tmp/empty.nec
2. $ antennavis
3. Load File /tmp/empty.nec -- TkAnt: Segmentation fault

Attached patch fixes the bug.
--- antennavis-0.3.orig/pcard.c
+++ antennavis-0.3/pcard.c
@@ -564,6 +564,13 @@
 }  /**  For each card  **/
 fclose(fin);
 
+/**  Check whether we read any tubes at all before proceeding. **/
+if ( antData-first_tube == NULL ) {
+  fprintf(stderr, No geometry tubes (GW lines) specified in file %s\n,
+  file_name);
+  return;
+}
+
 /**  Traverse list of elements to find dynamic range  **/
 /**  We will need to scale things to accomodate all   **/
 /**  sizes of antennas.   **/

Bug#569246: gcin FTBFS: undefined GTK_WIDGET_APP_PAINTABLE

[Kamal Mostafa]

Package: gcin
Version: 1.4.6-1
Severity: important
Tags: patch
Justification: fails to build from source
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch


Package fails to build due to use of deprecated Gtk+ macro 
GTK_WIDGET_APP_PAINTABLE. (Also uses deprecated GTK_WIDGET_NO_WINDOW).

http://launchpadlibrarian.net/38892602/buildlog_ubuntu-lucid-i386.gcin_1.4.6-1_FAILEDTOBUILD.txt.gz

gcc -o gcin gcin.o eve.o util.o gcin-conf.o gcin-settings.o locale.o 
gcin-icon.o gcin-switch.o gcin-exec-script.o pho-play.o cache.o gtk_bug_fix.o 
intcode.o win-int.o win-message.o win-sym.o win-inmd-switch.o pinyin.o 
win-pho-near.o win-kbm.o tsin-char.o anthy.o win-pho.o pho.o pho-util.o 
pho-sym.o table-update.o pho-dbg.o gtab.o win-gtab.o gtab-util.o gtab-list.o 
gtab-buf.o gcin-common.o phrase.o t2s-lookup.o gtab-use-count.o IC.o tray.o 
eggtrayicon.o tray-win32.o tsin.o tsin-util.o win0.o win1.o tsin-parse.o gcb.o 
IMdkit/lib/libXimd.a im-addr.o im-dispatch.o im-srv.o gcin-crypt.o -lXtst 
-Wl,--as-needed -pthread -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lpangoft2-1.0 
-lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lgio-2.0 -lcairo -lpango-1.0 -lfreetype 
-lfontconfig -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lglib-2.0 -lX11 
-Wl,-rpath,/usr/lib/gcin -ldl -L/usr/X11R6/lib
eggtrayicon.o: In function `make_transparent':
/build/buildd/gcin-1.4.6/eggtrayicon.cpp:401: undefined reference to 
`GTK_WIDGET_APP_PAINTABLE'

-

In Ubuntu, we've applied the attached patch to achieve the following:

  * debian/patches/fix_gtk_deprecations.diff
- Fix FTBFS due to deprecated Gtk+ macros GTK_WIDGET_APP_PAINTABLE and
  GTK_WIDGET_NO_WINDOW. (LP: #520148)

We thought you might be interested in doing the same. 
--- gcin-1.4.6/debian/patches/fix_gtk_deprecations.diff 1969-12-31 
16:00:00.0 -0800
+++ gcin-1.4.6/debian/patches/fix_gtk_deprecations.diff 2010-02-10 
14:57:18.0 -0800
@@ -0,0 +1,13 @@
+Index: gcin-1.4.6/eggtrayicon.cpp
+===
+--- gcin-1.4.6.orig/eggtrayicon.cpp2010-02-10 14:52:19.0 -0800
 gcin-1.4.6/eggtrayicon.cpp 2010-02-10 14:55:40.0 -0800
+@@ -398,7 +398,7 @@
+ static void
+ make_transparent (GtkWidget *widget, gpointer user_data)
+ {
+-  if (GTK_WIDGET_NO_WINDOW (widget) || GTK_WIDGET_APP_PAINTABLE (widget))
++  if (!gtk_widget_get_has_window (widget) || gtk_widget_get_app_paintable 
(widget))
+   return;
+ 
+   gtk_widget_set_app_paintable (widget, TRUE);
diff -Nru gcin-1.4.6/debian/patches/series gcin-1.4.6/debian/patches/series
--- gcin-1.4.6/debian/patches/series2010-01-28 02:14:10.0 -0800
+++ gcin-1.4.6/debian/patches/series2010-02-10 14:51:40.0 -0800
@@ -4,3 +4,4 @@
 fix_install_paths.diff
 ld_only_link_needed.diff
 fix_anthy_error_message.diff
+fix_gtk_deprecations.diff

Bug#568648: grig crashes on mouse click between freq display digits

[Kamal Mostafa]

Package: grig
Version: 0.7.2-3
Severity: important
Tags: patch


We have applied the attached patch in Ubuntu Lucid, to fix the following bug.
This change has also been applied upstream at Sourceforge.  Perhaps Debian
would like to apply the change as well:

https://bugs.launchpad.net/ubuntu/+source/grig/+bug/517816

grig 0.7.2 Ubuntu Karmic

TESTCASE:
(Reproducible on amd64 but not i386)
1. Run grig
2. Mouse click in the space *between* the 145 and the 000 (not on any
digit).
grig crashes with Segmentation fault.
=== modified file 'src/rig-gui-lcd.c'
--- old/src/rig-gui-lcd.c	2006-07-25 00:03:43 +
+++ new/src/rig-gui-lcd.c	2010-02-05 22:36:18 +
@@ -810,7 +810,7 @@
 rig_gui_lcd_get_event_object (GdkEvent *event)
 {
 	guint x,y;/* coordinates */
-	guint i;
+	gint i;
 
 	x = (guint) ((GdkEventButton*)event)-x;
 	y = (guint) ((GdkEventButton*)event)-y;

Bug#568649: FTBFS: python LOCALMODLIBS causes -lssl link failure

[Kamal Mostafa]

Package: gwp
Version: 0.4.0-1.2
Severity: important
Tags: patch
Justification: fails to build from source
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch


This package's configure script improperly refers to python's LOCALMODLIBS, 
which should not be referenced by programs linking with python.

http://launchpadlibrarian.net/38666414/buildlog_ubuntu-lucid-i386.gwp_0.4.0-1.2build1_FAILEDTOBUILD.txt.gz

i486-linux-gnu-gcc -Wall -Wimplicit -Wreturn-type -Wunused -Wswitch -Wcomment 
-Wuninitialized -Wparentheses -Wpointer-arith -Wmissing-prototypes 
-DPREFIX=\/usr\ -DSYSCONFDIR=\/usr/etc\ -DLIBDIR=\/usr/lib\ 
-DDATADIR=\/usr/share\ -D_GNU_SOURCE -O1 -g -Wall -g -O2 
-Wl,-Bsymbolic-functions -o gwp [...] -L/usr/lib/python2.6/config -lssl [...]
/usr/bin/ld: cannot find -lssl
collect2: ld returned 1 exit status

--

In Ubuntu, we've applied the attached patch to achieve the following:

  * Remove invalid reference to python's LOCALMODLIBS to fix -lssl FTBFS
(LP: #517918)

We thought you might be interested in doing the same. 
--- gwp-0.4.0.orig/configure.in
+++ gwp-0.4.0/configure.in
@@ -100,10 +100,11 @@
PY_LIB_LOC=-L$PY_EXEC_PREFIX/lib/python$PY_VERSION/config
PY_CFLAGS=-I$PY_PREFIX/include/python$PY_VERSION

PY_MAKEFILE=$PY_EXEC_PREFIX/lib/python$PY_VERSION/config/Makefile
-   PY_LOCALMODLIBS=`sed -n -e 's/^LOCALMODLIBS=\(.*\)/\1/p' 
$PY_MAKEFILE`
+   # Only python itself should reference python's LOCALMODLIBS
+   # PY_LOCALMODLIBS=`sed -n -e 's/^LOCALMODLIBS=\(.*\)/\1/p' 
$PY_MAKEFILE`
PY_BASEMODLIBS=`sed -n -e 's/^BASEMODLIBS=\(.*\)/\1/p' 
$PY_MAKEFILE`
PY_OTHER_LIBS=`sed -n -e 's/^LIBS=\(.*\)/\1/p' $PY_MAKEFILE`
-   PY_EXTRA_LIBS=$PY_LOCALMODLIBS $PY_BASEMODLIBS $PY_OTHER_LIBS
+   PY_EXTRA_LIBS=$PY_BASEMODLIBS $PY_OTHER_LIBS
AC_SUBST(PY_LIBS)
AC_SUBST(PY_LIB_LOC)
AC_SUBST(PY_CFLAGS)


--- gwp-0.4.0.orig/configure
+++ gwp-0.4.0/configure
@@ -20136,10 +20136,11 @@
PY_LIB_LOC=-L$PY_EXEC_PREFIX/lib/python$PY_VERSION/config
PY_CFLAGS=-I$PY_PREFIX/include/python$PY_VERSION

PY_MAKEFILE=$PY_EXEC_PREFIX/lib/python$PY_VERSION/config/Makefile
-   PY_LOCALMODLIBS=`sed -n -e 's/^LOCALMODLIBS=\(.*\)/\1/p' 
$PY_MAKEFILE`
+   # Only python itself should reference python's LOCALMODLIBS
+   # PY_LOCALMODLIBS=`sed -n -e 's/^LOCALMODLIBS=\(.*\)/\1/p' 
$PY_MAKEFILE`
PY_BASEMODLIBS=`sed -n -e 's/^BASEMODLIBS=\(.*\)/\1/p' 
$PY_MAKEFILE`
PY_OTHER_LIBS=`sed -n -e 's/^LIBS=\(.*\)/\1/p' $PY_MAKEFILE`
-   PY_EXTRA_LIBS=$PY_LOCALMODLIBS $PY_BASEMODLIBS $PY_OTHER_LIBS
+   PY_EXTRA_LIBS=$PY_BASEMODLIBS $PY_OTHER_LIBS
 
 
 

Bug#568484: mailutils FTBFS: undefined macro: AM_GNU_RADIUS, and python2.6 install paths

[Kamal Mostafa]

Package: mailutils
Version: 1:2.1+dfsg1-4
Severity: important
Tags: patch
Justification: fails to build from source
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch


In Ubuntu, I have submitted the attached patch to achieve the following:

  * Fix FTBFS in Ubuntu Lucid (LP: #517366)
- configure.ac: Disable AM_GNU_RADIUS check (breaks internal autoconf)
- python-mailutils.install: python2.6 needs dist-packages not site-packages
diff -u mailutils-2.1+dfsg1/debian/python-mailutils.install mailutils-2.1+dfsg1/debian/python-mailutils.install
--- mailutils-2.1+dfsg1/debian/python-mailutils.install
+++ mailutils-2.1+dfsg1/debian/python-mailutils.install
@@ -1 +1 @@
-debian/tmp/usr/lib/python*/site-packages/mailutils/*.py
+debian/tmp/usr/lib/python*/dist-packages/mailutils/*.py
diff -u mailutils-2.1+dfsg1/debian/patches/series mailutils-2.1+dfsg1/debian/patches/series
--- mailutils-2.1+dfsg1/debian/patches/series
+++ mailutils-2.1+dfsg1/debian/patches/series
@@ -6,0 +7 @@
+disable_am_gnu_radius.diff
only in patch2:
unchanged:
--- mailutils-2.1+dfsg1.orig/debian/patches/disable_am_gnu_radius.diff
+++ mailutils-2.1+dfsg1/debian/patches/disable_am_gnu_radius.diff
@@ -0,0 +1,25 @@
+Index: mailutils/configure.ac
+===
+--- mailutils.orig/configure.ac	2010-02-04 17:52:33.0 -0800
 mailutils/configure.ac	2010-02-04 17:52:40.0 -0800
+@@ -814,12 +814,14 @@
+ 
+ MU_ENABLE_SUPPORT(maildir)
+ 
+-# FIXME: Should be --with-radius 
+-MU_ENABLE_SUPPORT(radius,
+-  [AM_GNU_RADIUS(1.6,
+-		 [MU_AUTHLIBS=$MU_AUTHLIBS -lgnuradius
+-  mu_cv_enable_radius=yes],
+- [mu_cv_enable_radius=no])]) 
++## Disabled to avoid FTBFS in Ubuntu Lucid (LP: #nn):
++##
++## # FIXME: Should be --with-radius 
++## MU_ENABLE_SUPPORT(radius,
++##   [AM_GNU_RADIUS(1.6,
++## 		 [MU_AUTHLIBS=$MU_AUTHLIBS -lgnuradius
++##   mu_cv_enable_radius=yes],
++##  [mu_cv_enable_radius=no])]) 
+ 
+ AC_ARG_ENABLE([experimental],
+   AC_HELP_STRING([--enable-experimental],

Bug#568290: ax25-tools: beacon crashes if the length of the destination exceeds 20

[Kamal Mostafa]

Package: ax25-tools
Version: 0.0.8-13.1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch



In Ubuntu, we've applied the attached patch to achieve the following:

  * Fix beacon -d longstring crash (LP: #353219):
- Cherry-pick fix from upstream ax25_tools_0_0_10_rc1 (www.linux-ax25.org):
  ax25/beacon.c (CVS rev 1.2): important security fix:
char addr[20] was static and strcpy(addr,.argv[n]) of variable length.

We thought you might be interested in doing the same. 
--- ax25-tools-0.0.8.orig/ax25/beacon.c
+++ ax25-tools-0.0.8/ax25/beacon.c
@@ -43,7 +43,7 @@
 	struct full_sockaddr_ax25 dest;
 	struct full_sockaddr_ax25 src;
 	int s, n, dlen, len, interval = 30;
-	char addr[20], *port, *message, *portcall;
+	char *addr, *port, *message, *portcall;
 	char *srccall = NULL, *destcall = NULL;
 	
 	while ((n = getopt(argc, argv, c:d:lmst:v)) != -1) {
@@ -100,27 +100,36 @@
 		return 1;
 	}
 
+	addr = NULL;
 	if (mail)
-		strcpy(addr, MAIL);
+		addr = strdup(MAIL);
 	else if (destcall != NULL)
-		strcpy(addr, destcall);
+		addr = strdup(destcall);
 	else
-		strcpy(addr, IDENT);
+		addr = strdup(IDENT);
+	if (addr == NULL)
+	  return 1;
 
 	if ((dlen = ax25_aton(addr, dest)) == -1) {
 		fprintf(stderr, beacon: unable to convert callsign '%s'\n, addr);
 		return 1;
 	}
+	if (addr != NULL) free(addr); addr = NULL;
 
-	if (srccall != NULL  strcmp(srccall, portcall) != 0)
+	if (srccall != NULL  strcmp(srccall, portcall) != 0) {
+		if ((addr = (char *) malloc(strlen(srccall) + 1 + strlen(portcall) + 1)) == NULL)
+			return 1;
 		sprintf(addr, %s %s, srccall, portcall);
-	else
-		strcpy(addr, portcall);
+	} else {
+		if ((addr = strdup(portcall)) == NULL)
+			return 1;
+	}
 
 	if ((len = ax25_aton(addr, src)) == -1) {
 		fprintf(stderr, beacon: unable to convert callsign '%s'\n, addr);
 		return 1;
 	}
+	if (addr != NULL) free(addr); addr = NULL;
 
 	if (!single) {
 		if (!daemon_start(FALSE)) {

Bug#567392: unixcw sends incorrect characters

[Kamal Mostafa]

Package: unixcw
Version: 2.3-13
Severity: important
Tags: patch


https://bugs.launchpad.net/ubuntu/+source/unixcw/+bug/511676

-

[N7DR]
The unixcw program sends incorrect characters at the default speed (12 wpm).

Starting the program simply with the command cw (i.e., with no parameters), 
the program generates CW sounds, but the sounds do not match the characters 
typed on the keyboard, and in fact mostly do not match *any* letter or number.

For example, typing T generates a sound that sounds rather like an R. 
Typing h creates a kind of N with a very long dash.

-

[KA6MAL]
This bug in 'cwlib' is caused by the invalid use of a mixer ioctl on the 
soundcard audio device. For most audio devices, the invalid ioctl is harmless, 
but for some audio devices it prevents cwlib from properly switching the volume 
on and off (which is how it generates Morse code).

Attached patch fixes the problem by not trying invalid ioctl.
#
#  * Fix invalid ioctl which breaks CW output on some devices (LP: #511676).
#- src/cwlib/cwlib.c: do not try to use mixer volume ioctl on audio device.
#
# -- Kamal Mostafa ka...@whence.com  Wed, 27 Jan 2010 19:40:14 -0800
#

=== modified file 'src/cwlib/cwlib.c'
--- a/src/cwlib/cwlib.c 2006-12-18 09:45:19 +
+++ b/src/cwlib/cwlib.c 2010-01-28 03:43:46 +
@@ -2138,6 +2138,18 @@
 {
   int read_volume, mixer, device_mask;
 
+/*
+ * [Kamal Mostafa ka...@whence.com]
+ * This attempt to use a mixer ioctl on the audio device is invalid!  I do not
+ * think that this ioctl could ever have worked.  Most audio devices will
+ * just return an error, allowing this routine to proceed to try the volume
+ * control methods on the (proper) mixer device.  However, some audio devices
+ * actually *do* have an ioctl (unrelated to volume control) corresponding to
+ * this ioctl number -- if they return 0, then this routine is tricked into
+ * thinking that it has set the volume when in fact it has not.
+ * https://bugs.launchpad.net/ubuntu/+source/unixcw/+bug/511676
+ */
+#if 0
   /* Try to use the main /dev/audio device for ioctls first. */
   if (ioctl (cw_sound_descriptor,
  MIXER_READ (SOUND_MIXER_PCM), read_volume) == 0)
@@ -2145,6 +2157,7 @@
   *volume = read_volume;
   return RC_SUCCESS;
 }
+#endif
 
   /* Volume not found; try the mixer PCM channel volume instead. */
   mixer = open (cw_mixer_device, O_RDONLY | O_NONBLOCK);
@@ -2174,6 +2187,8 @@
 
   *volume = read_volume;
   close (mixer);
+  if (cw_is_debugging_internal (CW_DEBUG_KEYING))
+fprintf(stderr, cw: volume control is SOUND_MIXER_PCM\n);
   return RC_SUCCESS;
 }
   else
@@ -2191,6 +2206,8 @@
 
   *volume = read_volume;
   close (mixer);
+  if (cw_is_debugging_internal (CW_DEBUG_KEYING))
+fprintf(stderr, cw: volume control is SOUND_MIXER_VOLUME\n);
   return RC_SUCCESS;
 }
 }
@@ -2216,11 +2233,19 @@
 {
   int mixer, device_mask;
 
+/*
+ * [Kamal Mostafa ka...@whence.com]
+ * This attempt to use a mixer ioctl on the audio device is invalid!
+ * (see above).
+ */
+#if 0
   /* Try to use the main /dev/audio device for ioctls first. */
   if (ioctl (cw_sound_descriptor,
  MIXER_WRITE (SOUND_MIXER_PCM), volume) == 0)
 return RC_SUCCESS;
 
+#endif
+
   /* Try the mixer PCM channel volume instead. */
   mixer = open (cw_mixer_device, O_RDWR | O_NONBLOCK);
   if (mixer == -1)

Bug#567394: unixcw leaves audio device volume muted on exit

[Kamal Mostafa]

Package: unixcw
Version: 2.3-13
Severity: normal
Tags: patch


https://bugs.launchpad.net/ubuntu/+source/unixcw/+bug/513576

The programs 'cw' or 'cwcp' accidentally leave the system audio device (mixer) 
volume muted when they exit.

TESTCASE:
1. Ensure that the system audio volume is not muted (e.g. with the gnome volume 
control applet).
2. In a terminal, run
  echo KA6MAL | cw
While listening to the Morse code audio output, notice the gnome volume control 
applet flashing its muted status along with the dits and dahs.
3. After the command returns to the shell prompt, notice that the gnome volume 
control applet has been left muted. The volume should have been restored.

Note: If the Morse code output is completely garbled (just long continuous 
tones) then you're experiencing bug LP: #511676 unixcw sends incorrect 
characters.

ANALYSIS:
unixcw's 'cwlib' library works by manipulating the audio device (mixer) volume 
control -- switching the volume on and off to generate Morse code. This is the 
normal behavior of the 'cwlib' library.

The library does actually preserve the initial volume setting, but fails to 
restore it in some scenarios -- specifically, when it exits during it 10 second 
keep the soundcard held termination phase as occurs when piping input into 
'cw' and when quitting 'cwcp' with F12. These programs just need to call 
cw_complete_reset() in all exit paths.

I think its possible that some systems' audio devices may *not* indicate a 
flashing volume control applet because 'cwlib' might find and uses a different 
volume mixer -- this bug is probably not reproducible on such systems.

-

Attached patch fixes the problem.
#
#  * Restore audio device volume on exit (LP: #513576)
#- src/cw/cw.c, src/cwcp/cwcp.c: call cw_complete_reset() at exit.
#
# -- Kamal Mostafa ka...@whence.com  Wed, 27 Jan 2010 19:40:14 -0800
#

=== modified file 'src/cw/cw.c'
--- a/src/cw/cw.c	2006-11-19 19:52:38 +
+++ b/src/cw/cw.c	2010-01-28 02:51:12 +
@@ -922,5 +922,9 @@
 
   /* Await final tone completion before exiting. */
   cw_wait_for_tone_queue ();
+
+  /* Reset to ensure that the mixer volume gets restored. */
+  cw_complete_reset();
+
   return EXIT_SUCCESS;
 }

=== modified file 'src/cwcp/cwcp.c'
--- a/src/cwcp/cwcp.c	2006-11-19 19:52:38 +
+++ b/src/cwcp/cwcp.c	2010-01-28 02:53:25 +
@@ -1625,6 +1625,9 @@
   /* Attempt to wrestle the screen back from curses. */
   interface_destroy ();
 
+  /* Reset to ensure that the mixer volume gets restored. */
+  cw_complete_reset();
+
   /* Show the signal caught, and exit. */
   fprintf (stderr, _(\nCaught signal %d, exiting...\n), signal_number);
   exit (EXIT_SUCCESS);
@@ -1685,5 +1688,9 @@
   /* Clean up and return. */
   interface_destroy ();
   cw_wait_for_tone_queue ();
+
+  /* Reset to ensure that the mixer volume gets restored. */
+  cw_complete_reset();
+
   return EXIT_SUCCESS;
 }

Bug#567395: unixcw: truncated CW dah's on some audio devices

[Kamal Mostafa]

Package: unixcw
Version: 2.3-13
Severity: normal


https://bugs.launchpad.net/ubuntu/+source/unixcw/+bug/513942

For some audio devices (soundcards) the 'cwlib' library generates truncated 
Morse code elements (dah's and dit's) due to audio buffer underruns.

'cwlib' works by assuming that it will be able to store at least one second of 
audio in the audio card fragment buffers (given the 8192 Hz DSP rate and 128 
byte fragment size that it tries to set up). Audio devices which do offer 
enough buffers to satisfy this condition do not exhibit this bug.

But some audio devices do not offer enough buffers (at that particular rate 
anyway) to hold that much audio data, or even enough for a whole Morse code 
dah at the default 12 WPM Morse output speed. On such devices, all the dah's 
get truncated when the audio buffer underruns.

Setting the Morse WPM speed to a higher rate alleviates the problem (because 
the dit's and dah's are shorter so cwlib refills the audio buffers frequently 
enough to keep up). Likewise setting the Morse WPM speed to a lower rate 
exacerbates the problem.

TESTCASE:
A Morse code K should sound like -.- (dah-dit-dah)
echo K | cw # 12 WPM underruns: sounds like - .-
echo K | cw -w 20 # 20 WPM is fine: sounds -.-
echo K | cw -w 4 # 4 WPM underruns: sounds like . . .

-

Running with the environment variable CWLIB_DEBUG=0xFFFE makes cwlib emit 
interesting debug info. These two lines hint at the problem:

cwlib tries to set the fragment size to 2^7 == 128, but on one soundcard with 
the problem, I get:

 cw: dsp fragment size not set, 131

Then when cwlib tries to write about 1 second of audio, it only manages to 
write 2096 bytes (~ 1/4 second) before the audio fragment buffers are full:

 cw: dsp data buffered, 800 Hz, 2096

By fiddling with the DSP rate setting code and/or the fragment size setting 
code, I am able to resolve the fragment size not set issue, but even with 
valid fragment sizes I still can only get about 1/4 second of audio into the 
buffer.

Note: On soundcards which don't show this cwlib problem, the fragment size does 
get set to 128, and the data buffered in the first write is 8192 bytes (one 
second of audio).



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#567397: unixcw: CW output tone is ringy on some audio devices

[Kamal Mostafa]

Package: unixcw
Version: 2.3-13
Severity: normal


For some audio devices (soundcards) the Morse code 800 Hz output tone generated 
by cwlib is ringy (sounds as if it is being modulated by another tone).

The 'cwlib' library tries to set the DSP sample rate to 8192 Hz and the 
fragment size to 2^7 == 128. On audio devices where a different fragment size 
is returned for that rate, the audio output sounds ringy:

TESTCASE:
$ echo T | CWLIB_DEBUG=0x4 cw -w 4 21 | grep fragment
cw: dsp fragment size not set, 131

(For audio devices which accept that fragment size and rate, the fragment size 
not set line will not appear and the tone will sound fine).



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#567144: libavg FTBFS: python LOCALMODLIBS causes -lssl link failure

[Kamal Mostafa]

Package: libavg
Version: 0.8.0-5
Severity: important
Tags: patch
Justification: fails to build from source


https://bugs.launchpad.net/ubuntu/+source/libavg/+bug/512861

-

http://launchpadlibrarian.net/38108616/buildlog_ubuntu-lucid-i386.libavg_0.8.0-5ubuntu3_FAILEDTOBUILD.txt.gz

g++ -Wno-invalid-offsetof -g -O2 -Wl,-Bsymbolic-functions -o checktracker 
checktracker.o /usr/lib/libxml2.so -lboost_thread-mt -lGLU -lGL -lm -L/usr/lib 
/usr/lib/libSDL.so -lXxf86vm -lGraphicsMagick++ -lGraphicsMagick 
-L/usr/lib/python2.6/config ./.libs/libplayer.a -lboost_python-mt-py26 
-lpython2.6 -lssl -lcrypto -lz -lpthread -ldl -lutil ../video/.libs/libvideo.a 
../audio/.libs/libaudio.a ../imaging/.libs/libimaging.a 
../graphics/.libs/libgraphics.a ../base/.libs/libbase.a 
../lmfit/.libs/liblmfit.a
/usr/bin/ld: cannot find -lssl
collect2: ld returned 1 exit status

-

This package's m4/python_dev.m4 script improperly refers to Python's 
LOCALMODLIBS which contains a link reference to -lssl (and other libs):

  py_localmodlibs=`sed -n -e 's/^LOCALMODLIBS=\(.*\)/\1/p' $py_makefile`

libavg does not build-depend on libssl-dev (nor should it as it does not 
actually need to link with -lssl) so that library is not installed and 
therefore causes libavg to FTB when $py_localmodlibs tries to link with it 
anyway.

-

[Matthias Klose]
libavg must not link with LOCALMODLIBS (this is the list of libs which the 
python executable must be linked with, not arbitrary extensions).

-

Attached debdiff adds quilt patch - debian/patches/no_py_localmodlibs.diff - 
which comments out the line referencing of python's LOCALMODLIBS from the 
configure script and its source m4 file.

With this patch in place, libavg's binaries no longer try to link with -lssl 
and the package builds successfully.
diff -u libavg-0.8.0/debian/changelog libavg-0.8.0/debian/changelog
--- libavg-0.8.0/debian/changelog
+++ libavg-0.8.0/debian/changelog
@@ -1,3 +1,10 @@
+libavg (0.8.0-5ubuntu4) lucid; urgency=low
+
+  * configure, m4/python_dev.m4: Do not reference $py_makefile's LOCALMODLIBS
+to avoid undesired linking with -lssl (LP: #512861).
+
+ -- Kamal Mostafa ka...@whence.com  Tue, 26 Jan 2010 08:13:10 -0800
+
 libavg (0.8.0-5ubuntu3) lucid; urgency=low
 
   * rebuild for ffmpeg versioned symbols
diff -u libavg-0.8.0/debian/patches/series libavg-0.8.0/debian/patches/series
--- libavg-0.8.0/debian/patches/series
+++ libavg-0.8.0/debian/patches/series
@@ -3,0 +4 @@
+no_py_localmodlibs.diff
only in patch2:
unchanged:
--- libavg-0.8.0.orig/debian/patches/no_py_localmodlibs.diff
+++ libavg-0.8.0/debian/patches/no_py_localmodlibs.diff
@@ -0,0 +1,28 @@
+--- libavg-0.8.0.orig/configure
 libavg-0.8.0/configure
+@@ -22159,7 +22159,10 @@
+ py_config_dir=${py_exec_prefix}/lib/python${PYTHON_VERSION}/config
+ py_makefile=${py_config_dir}/Makefile
+ if test -f $py_makefile; then
+-  py_localmodlibs=`sed -n -e 's/^LOCALMODLIBS=\(.*\)/\1/p' $py_makefile`
++  # Do not reference LOCALMODLIBS, else it will add libraries to our
++  # link line (e.g -lssl) which are not necessarily installed.
++  # py_localmodlibs=`sed -n -e 's/^LOCALMODLIBS=\(.*\)/\1/p' $py_makefile`
++  py_localmodlibs=
+   py_basemodlibs=`sed -n -e 's/^BASEMODLIBS=\(.*\)/\1/p' $py_makefile`
+   py_other_libs=`sed -n -e 's/^LIBS=\(.*\)/\1/p' $py_makefile`
+ 
+--- libavg-0.8.0.orig/m4/python_dev.m4
 libavg-0.8.0/m4/python_dev.m4
+@@ -33,7 +33,10 @@
+ py_makefile=${py_config_dir}/Makefile
+ if test -f $py_makefile; then
+ dnl extra required libs
+-  py_localmodlibs=`sed -n -e 's/^LOCALMODLIBS=\(.*\)/\1/p' $py_makefile`
++  # Do not reference LOCALMODLIBS, else it will add libraries to our
++  # link line (e.g -lssl) which are not necessarily installed.
++  # py_localmodlibs=`sed -n -e 's/^LOCALMODLIBS=\(.*\)/\1/p' $py_makefile`
++  py_localmodlibs=
+   py_basemodlibs=`sed -n -e 's/^BASEMODLIBS=\(.*\)/\1/p' $py_makefile`
+   py_other_libs=`sed -n -e 's/^LIBS=\(.*\)/\1/p' $py_makefile`
+ 

Bug#565917: guymager tries to build on architectures not supported by libguytools1

[Kamal Mostafa]

Package: guymager
Version: 0.4.2-1
Severity: minor


Since guymager cannot build on architectures not supported by libguytools1,
it should be restricted to just those architectures (i386 and amd64, for
the current release of libguytools1)...

debian/control:   Architecture: i386 amd64

Originally reported by Ilya Barygin:

  From: Ilya Barygin bary...@gmail.com
  To: 565...@bugs.debian.org
  Cc: Kamal Mostafa ka...@whence.com
  Subject: build architectures
  Date: Tue, 19 Jan 2010 16:04:21 +0300

  On a related note, guymager source package (arch: any) build-depends on
  libguytools1-dev binary (arch: amd64 i386) and thus can't be built on
  any architecture other than amd64 or i386. Either guymager should be
  restricted to these two arches, or libguytools1 should be build for all
  arches.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#565859: libguytools1: libguytoolsysinfo.so fails to build: sprintf not declared

[Kamal Mostafa]

Package: libguytools1
Version: 1.0.4-1
Severity: important
Tags: patch
Justification: fails to build from source


https://bugs.launchpad.net/ubuntu/+source/libguytools1/+bug/509450


Binary package hint: libguytools1

libguytoolsysinfo.so (one of the libraries built by this package) fails to 
build:

make[1]: Entering directory `/tmp/buildd/libguytools1-1.0.4/sysinfo'
g++ -c -pipe -O2 -O3 -D_REENTRANT -Wall -W -fmessage-length=0 -fPIC 
-DLIBGUYTOOLS_VERSION=\1.0.4\ -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_CORE_LIB 
-DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore 
-I/usr/include/qt4/QtGui -I/usr/include/qt4 -I../include -I. -o toolsysinfo.o 
toolsysinfo.cpp
toolsysinfo.cpp: In function 'APIRET 
ToolSysInfoGetMacAddr(t_ToolSysInfoMacAddr*)':
toolsysinfo.cpp:90: error: 'sprintf' was not declared in this scope
make[1]: *** [toolsysinfo.o] Error 1
make[1]: Leaving directory `/tmp/buildd/libguytools1-1.0.4/sysinfo'

However, this qmake-qt4-based build continues anyway and completes 
successfully, just omitting the broken libguytoolsysinfo.so library. Packages 
which depend on libguytools1 for this library will therefore FTBFS, e.g. 
package 'guymager' 
http://launchpadlibrarian.net/35999162/buildlog_ubuntu-lucid-amd64.guymager_0.4.2-1_FAILEDTOBUILD.txt.gz
 :

   [guymager...FAILEDTOBUILD.txt.gz]: /usr/bin/ld: cannot find -lguytoolsysinfo


Attached patch adds the missing #include stdio.h to fix the problem.
# libguytools1 (1.0.4-1ubuntu1) lucid; urgency=low
#
#  * sysinfo/toolsysinfo.cpp: added #include stdio for sprintf (LP: #509450).
#
# -- Kamal Mostafa ka...@whence.com  Mon, 18 Jan 2010 14:10:57 -0800
#
=== modified file 'sysinfo/toolsysinfo.cpp'
--- a/sysinfo/toolsysinfo.cpp	2009-08-19 11:09:24 +
+++ b/sysinfo/toolsysinfo.cpp	2010-01-19 02:58:16 +
@@ -9,6 +9,7 @@
 //  Module: System information
 // 
 
+#include stdio.h
 #include limits.h
 #include math.h
 #include cstdarg

Bug#560644:

[Kamal Mostafa]

Simply removing the x_map line from the libclxclient3.symbols.* files
fixes the build on Ubuntu Lucid -- the attached patch applies that
change.
=== modified file 'debian/libclxclient3.symbols.amd64'
--- debian/libclxclient3.symbols.amd64	2009-03-14 00:55:50 +
+++ debian/libclxclient3.symbols.amd64	2010-01-17 15:36:32 +
@@ -296,7 +296,6 @@
  _znk8x_window12x_set_attribemp20xsetwindowattribu...@base 3.6.1-1~
  _znk8x_window17x_set_bit_gravit...@base 3.6.1-1~
  _znk8x_window17x_set_win_gravit...@base 3.6.1-1~
- _znk8x_window5x_ma...@base 3.6.1-1~
  _znk8x_window6x_move...@base 3.6.1-1~
  _znk8x_window8x_resize...@base 3.6.1-1~
  _zti10x_callb...@base 3.6.1-1~

=== modified file 'debian/libclxclient3.symbols.i386'
--- debian/libclxclient3.symbols.i386	2009-03-14 00:55:50 +
+++ debian/libclxclient3.symbols.i386	2010-01-17 15:36:34 +
@@ -296,7 +296,6 @@
  _znk8x_window12x_set_attribemp20xsetwindowattribu...@base 3.6.1-1~
  _znk8x_window17x_set_bit_gravit...@base 3.6.1-1~
  _znk8x_window17x_set_win_gravit...@base 3.6.1-1~
- _znk8x_window5x_ma...@base 3.6.1-1~
  _znk8x_window6x_move...@base 3.6.1-1~
  _znk8x_window8x_resize...@base 3.6.1-1~
  _zti10x_callb...@base 3.6.1-1~

Bug#565460: aprsd crashes when someone logs in from network amd64

[Kamal Mostafa]

Package: aprsd
Version: 1:2.2.5-13-5.1
Severity: important
Tags: patch


https://bugs.launchpad.net/ubuntu/+source/aprsd/+bug/208913

aprsd on 64-bit system crashes with segfault while trying to
process the user login line on any of its incoming user ports.

To reproduce, simply connect to aprsd on port 14500 (e.g. with
'telnet hostname 14500') and type user fooENTER.  Aprsd
crashes with segfault.

Note that this allows for a denial-of-service exposure in that
any user (even remote users) can crash aprsd easily, as well as
making aprsd unusable in conjunction with local clients e.g. xastir.

The attached patch fixes the problem.
# 0001.fix-user-login-crash.patch
#
# Author: Kamal Mostafa ka...@whence.com
#
# * Fix user login crash on 64-bit platforms. (LP: #208913)
# * Fix socklen_t compiler warnings (and possible failure) on 64-bit platforms.
#

=== modified file 'src/aprsString.cpp'
--- a/src/aprsString.cpp	2003-06-20 22:30:49 +
+++ b/src/aprsString.cpp	2009-12-26 08:35:38 +
@@ -905,9 +905,9 @@
 //Returns index of path element if match found
 // or npos is not found.
 
-unsigned aprsString::queryPath(const string s, int start, int stop  , unsigned n)
+size_t aprsString::queryPath(const string s, int start, int stop  , size_t n)
 {
-unsigned  rc = npos;
+size_t  rc = npos;
   
 if (valid_ax25 == false) 
 return rc;

=== modified file 'src/aprsString.h'
--- a/src/aprsString.h	2006-05-25 18:22:50 +
+++ b/src/aprsString.h	2009-12-26 08:35:24 +
@@ -204,7 +204,7 @@
void setEchoMask(echomask_t m);
 
//Tells if char string cp is in the ax25 path
-   unsigned queryPath(const string s, int start = 0, int stop = -1, unsigned n = npos);
+   size_t queryPath(const string s, int start = 0, int stop = -1, size_t n = npos);
 
bool changePath(const char* newPath, const char* oldPath); //Change one path element
bool addPath(const char* cp, char c = ' ');

=== modified file 'src/servers.cpp'
--- a/src/servers.cpp	2008-03-21 13:02:55 +
+++ b/src/servers.cpp	2009-12-26 08:28:20 +
@@ -963,11 +963,11 @@
 }  // End loop detect #1
 
 // Loop detector #2, Reject if user login call seen after qA but not last path element
-unsigned rc = abuff-queryPath(abuff-call,abuff-IjpIdx + 1);
+size_t rc = abuff-queryPath(abuff-call,abuff-IjpIdx + 1);
 if (( rc != string::npos)
  (abuff-aprsType != APRSREJECT)){
 
-if (rc != (unsigned)(abuff-pathSize - 1)){
+if (rc != (size_t)(abuff-pathSize - 1)){
 abuff-aprsType = APRSREJECT;//Looped packet, REJECT
 string log_str = abuff-srcHeader + *abuff;
 WriteLog(log_str, LOGPATH + LOOPLOG);   //Write offending packet to loop.log
@@ -982,7 +982,7 @@
  (abuff-sourceSock != SRC_INTERNAL)){
 
 if (abuff-EchoMask  srcUSERVALID){  //From validated connection?
-unsigned rc = abuff-queryPath(abuff-call,abuff-IjpIdx + 1);
+size_t rc = abuff-queryPath(abuff-call,abuff-IjpIdx + 1);
 if(rc == string::npos)
 abuff-addPath(abuff-call); //Add user login call if not present in path.
 }
@@ -1373,7 +1373,7 @@
 unsigned char c;
 char star = '*';
 
-unsigned adr_size = sizeof(peer_adr);
+socklen_t adr_size = sizeof(peer_adr);
 int n, rc,data;
 bool verified = false, loggedon = false;
 ULONG State = BASE;
@@ -1825,7 +1825,7 @@
 }
 
 string vd;
-unsigned idxInvalid=0;
+size_t idxInvalid=0;
 if (atemp.aprsType == APRSLOGON) {
 loggedon = true;
 verified = false;
@@ -2111,7 +2111,7 @@
 szPass[15] = '\0';
 
 bool verified_tnc = false;
-unsigned idxInvalid=0;
+size_t idxInvalid=0;
 
 int valid = -1;
 
@@ -2239,7 +2239,7 @@
 void *TCPServerThread(void *p)
 {
 int s = 0, rc = 0;
-unsigned i;
+socklen_t client_address_size;
 SessionParams* session;
 pthread_t SessionThread;
 int backlog = 5;// Backlog of pending connections
@@ -2285,9 +2285,9 @@
 listen(s, backlog);
 
 for(;;) {
-i = sizeof(client);
+client_address_size = sizeof(client);
 session = new SessionParams;
-session-Socket = accept(s, (struct sockaddr *)client, i);
+session-Socket = accept(s, (struct sockaddr *)client, client_address_size);
 session-EchoMask = sp-EchoMask;
 session-ServerPort = sp-ServerPort;
 if (ShutDownServer) {
@@ -2334,7 +2334,7 @@
 {
 #define UDPSIZE 256
 int s

Bug#565197: qtoctave: FTBFS in Ubuntu Lucid: build requires Qt version 4.5

[Kamal Mostafa]

Package: qtoctave
Version: 0.8.2+dfsg-2
Severity: important
Tags: patch
Justification: fails to build from source


This package FTBFS in Ubuntu Lucid

http://launchpadlibrarian.net/37681442/buildlog_ubuntu-lucid-i386.qtoctave_0.8.2%2Bdfsg-2_FAILEDTOBUILD.txt.gz

CMake Error at CMakeLists.txt:32 (MESSAGE):
  Qt version 4.5 required.

  Qt version installed is: 4.6


However, it does appear to actually build fine with Qt version 4.6.
The attached patch changes the CMakeLists.txt script to accept any
version of Qt = 4.5 instead of just == 4.5.

revno: 7
committer: Kamal Mostafa ka...@whence.com
branch nick: qtoctave
timestamp: Wed 2010-01-13 12:21:17 -0800
message:
  * CMakeLists.txt: allow build with Qt version = 4.5 (not just == 4.5).
diff:
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt  2009-10-04 10:08:00 +
+++ CMakeLists.txt  2010-01-13 20:21:17 +
@@ -28,13 +28,13 @@
 
 include(UseQt4)
 
-if( NOT ${QT_VERSION_MAJOR} EQUAL 4 OR NOT ${QT_VERSION_MINOR} EQUAL 5   )
+if( NOT ${QT_VERSION_MAJOR} EQUAL 4 OR NOT ${QT_VERSION_MINOR} GREATER 4   )
MESSAGE (FATAL_ERROR 
-   Qt version 4.5 required.\n
+   Qt version 4.5 or greater is required.\n
Qt version installed is: 
${QT_VERSION_MAJOR}.${QT_VERSION_MINOR}\n
Please install required version.\n
)
-endif( NOT ${QT_VERSION_MAJOR} EQUAL 4 OR NOT ${QT_VERSION_MINOR} EQUAL 5   )
+endif( NOT ${QT_VERSION_MAJOR} EQUAL 4 OR NOT ${QT_VERSION_MINOR} GREATER 4   )
 
 
 

=== modified file 'debian/changelog'
--- debian/changelog2009-10-11 16:29:55 +
+++ debian/changelog2010-01-13 20:21:17 +
@@ -1,3 +1,9 @@
+qtoctave (0.8.2+dfsg-2ubuntu1) lucid; urgency=low
+
+  * CMakeLists.txt: allow build with Qt version = 4.5 (not just == 4.5).
+
+ -- Kamal Mostafa ka...@whence.com  Wed, 13 Jan 2010 12:20:45 -0800
+
 qtoctave (0.8.2+dfsg-2) unstable; urgency=low
 
   * Fix build failure for GCC 4.4 via use_cstdio_header (closes: #550264)

Bug#565111: leptonlib FTBFS: -Werror vs. multiple warn_unused_result's

[Kamal Mostafa]

Package: leptonlib
Version: 1.62-1.1
Severity: important
Tags: patch
Justification: fails to build from source


This package tries to build with -Werror but triggers multiple
warn_unused_result warnings (e.g. fread, fscanf, system, etc.) and a
handful of other warnings as well, causing the package to FTBFS on
Ubuntu Lucid with gcc 4.4.

https://bugs.launchpad.net/ubuntu/+source/leptonlib/+bug/506757

http://launchpadlibrarian.net/36726967/buildlog_ubuntu-lucid-i386.leptonlib_1.62-1.1_FAILEDTOBUILD.txt.gz
=== modified file 'debian/changelog'
--- a/debian/changelog  2009-12-04 16:22:14 +
+++ b/debian/changelog  2010-01-13 02:44:35 +
@@ -1,3 +1,10 @@
+leptonlib (1.62-1.1ubuntu1~kamalmostafa~ppa0~lucid) lucid; urgency=low
+
+  * {src,prog}/makefile: Turn off -Werror; too many warn_unused_result's
+with gcc 4.4.
+
+ -- Kamal Mostafa ka...@whence.com  Tue, 12 Jan 2010 18:34:03 -0800
+
 leptonlib (1.62-1.1) unstable; urgency=low
 
   * Non-maintainer upload.

=== modified file 'debian/control'
--- a/debian/control2007-06-01 15:56:49 +
+++ b/debian/control2010-01-13 02:39:44 +
@@ -1,6 +1,7 @@
 Source: leptonlib
 Priority: optional
-Maintainer: Jeff Breidenbach j...@debian.org
+Maintainer: Ubuntu Developers ubuntu-devel-disc...@lists.ubuntu.com
+XSBC-Original-Maintainer: Jeff Breidenbach j...@debian.org
 Build-Depends: debhelper (= 4.0.0), libtiff4-dev (= 3.7.4), libpng12-dev
 Standards-Version: 3.7.2
 Section: graphics

=== modified file 'prog/makefile'
--- a/prog/makefile 2009-12-04 16:22:14 +
+++ b/prog/makefile 2010-01-13 02:43:34 +
@@ -79,7 +79,8 @@
 IMAGELIB_INCL =$(ROOT_DIR)/src
 
 
-CC =   gcc -ansi -Werror -DANSI -fPIC
+CC =   gcc -ansi -DANSI -fPIC
+#CC =  gcc -ansi -Werror -DANSI -fPIC
 #CC =g++ -Werror -fPIC
 
 

=== modified file 'src/makefile'
--- a/src/makefile  2009-07-28 15:10:11 +
+++ b/src/makefile  2010-01-13 02:33:54 +
@@ -100,7 +100,8 @@
 #ERROR_* logging, and to remove all DEBUG information dependent
 #on whether or not NO_CONSOLE_IO has been defined.
 # use -D_CYGWIN_ENVIRON (and without -fPIC) for cygwin
-CC =   gcc -ansi -Werror -D_BSD_SOURCE -DANSI -fPIC
+CC =   gcc -ansi -D_BSD_SOURCE -DANSI -fPIC
+#CC =  gcc -ansi -Werror -D_BSD_SOURCE -DANSI -fPIC
 #CC =  gcc -ansi -Werror -D_CYGWIN_ENVIRON -DANSI
 #CC =  gcc -ansi -Werror -DNO_CONSOLE_IO -D_BSD_SOURCE -DANSI -fPIC
 #CC =  g++ -Werror -D_BSD_SOURCE -fPIC

Bug#564319: micropolis-activity: FTBFS on Lucid sparc: duplicate case value

[Kamal Mostafa]

Package: micropolis-activity
Version: 0.0.20071228-4
Severity: important
Tags: patch
Justification: fails to build from source


This package fails to build on sparc in Ubuntu Lucid:


http://launchpadlibrarian.net/37608066/buildlog_ubuntu-lucid-sparc.micropolis-activity_0.0.20071228-4_FAILEDTOBUILD.txt.gz

gcc -Wall -g -O2 -I. -DTCL_LIBRARY=\/usr/local/lib/tcl\ -DIS_LINUX -c -o 
tclunxst.o tclunxst.c
tclunxst.c: In function 'Tcl_SignalId':
tclunxst.c:546: error: duplicate case value
tclunxst.c:534: error: previously used here
tclunxst.c: In function 'Tcl_SignalMsg':
tclunxst.c:678: error: duplicate case value
tclunxst.c:666: error: previously used here


On Sparc, SIGLOST == SIGPWR, so the attached patch guards against that
condition.
# Author: Kamal Mostafa ka...@whence.com
# * Avoid SIGLOST==SIGPWR namespace collision on sparc (LP: #505080).

=== modified file 'src/tcl/tclunxst.c'
--- a/src/tcl/tclunxst.c2008-12-28 00:18:24 +
+++ b/src/tcl/tclunxst.c2010-01-09 08:29:56 +
@@ -530,7 +530,7 @@
 #ifdef SIGKILL
case SIGKILL: return SIGKILL;
 #endif
-#if defined(SIGLOST)  (!defined(SIGIOT) || (SIGLOST != SIGIOT))
+#if defined(SIGLOST)  (!defined(SIGIOT) || (SIGLOST != SIGIOT))  
(!defined(SIGPWR) || (SIGLOST != SIGPWR))
case SIGLOST: return SIGLOST;
 #endif
 #ifdef SIGPIPE
@@ -662,7 +662,7 @@
 #ifdef SIGKILL
case SIGKILL: return kill signal;
 #endif
-#if defined(SIGLOST)  (!defined(SIGIOT) || (SIGLOST != SIGIOT))
+#if defined(SIGLOST)  (!defined(SIGIOT) || (SIGLOST != SIGIOT))  
(!defined(SIGPWR) || (SIGLOST != SIGPWR))
case SIGLOST: return resource lost;
 #endif
 #ifdef SIGPIPE

Bug#564273: pdp: FTBFS on Ubuntu Lucid: open() needs 3 arguments

[Kamal Mostafa]

Package: pdp
Version: 1:0.12.5-1
Severity: important
Tags: patch
Justification: fails to build from source


http://launchpadlibrarian.net/37442322/buildlog_ubuntu-lucid-i386.pdp_1%3A0.12.5-1_FAILEDTOBUILD.txt.gz

inlined from 'rawout_thread' at pdp_rawout.c:141:
/usr/include/bits/fcntl2.h:51: error: call to '__open_missing_mode' declared 
with attribute error: open with O_CREAT in second argument needs 3 arguments
=== modified file 'modules/generic/pdp_rawout.c'
--- a/modules/generic/pdp_rawout.c	2009-12-10 10:20:53 +
+++ b/modules/generic/pdp_rawout.c	2010-01-08 20:47:34 +
@@ -138,7 +138,8 @@
 
 /* open pipe */
 if (-1 == (pipefd = open(x-x_pipe-s_name, O_WRONLY|O_NONBLOCK|O_APPEND))){
-	if (-1 == (pipefd = open(x-x_pipe-s_name, O_WRONLY|O_CREAT))){
+	if (-1 == (pipefd = open(x-x_pipe-s_name, O_WRONLY|O_CREAT,
+			S_IRUSR|S_IRGRP|S_IROTH|S_IWUSR|S_IWGRP|S_IWOTH))){
 	perror(me);
 	goto exit;
 	}

Bug#560544: debian/patches/02-fix-ftbfs-and-hrdiagram.dpatch

[Kamal Mostafa]

My previous patch (02-fix_set_item_calls.dpatch) for this problem fixed
the FTBFS but included a subtle regression (thanks James Westby for
noticing).

This new patch (02-fix-ftbfs-and-hrdiagram-opts.dpatch) REPLACES the
previous patch.

It fixes the problem, and has been more carefully tested -- it fixes the
regression and a subsequent race condition bug, both necessary to
implement the intended functionality.


The subtle regression:
The checks in set_{label,diameter}_item e.g.
 if (globals::chart_rules.StarLabels == l) return;
need to be pushed down a few lines -- past the program_hr stuff.

The race condition bug:
The set_{label,diameter}_item() accessor routines were checking
globals::hr_program_viewer to determine whether the HR Diagram window had
been started or not -- but that global doesn't get set until the configure
event (maybe a race condition even, for other call stacks).  The set routines
need to check globals::hr_program_window instead, and the hr_quit() routine
needs to stomp that global when the window goes down.




02-fix-ftbfs-and-hrdiagram-opts.dpatch
Description: application/shellscript

Bug#563991: libtexttools: FTBFS on Ubuntu Lucid: open needs 3 arguments

[Kamal Mostafa]

Package: libtexttools
Version: 2.0.5-2
Severity: important
Tags: patch
Justification: fails to build from source


https://bugs.launchpad.net/ubuntu/+source/libtexttools/+bug/503972

[...]
cc -c -g -O2 -g -O2 -D_Bool=char C_code/system.c -o shared-obj/system.o -fPIC
In file included from /usr/include/fcntl.h:205,
 from C_code/system.c:4:
In function 'open',
inlined from 'CRunItForStdErr' at C_code/system.c:431:
/usr/include/bits/fcntl2.h:51: error: call to '__open_missing_mode' declared 
with attribute error: open with O_CREAT in second argument needs 3 arguments
In function 'open',
inlined from 'CRunIt' at C_code/system.c:389:
/usr/include/bits/fcntl2.h:51: error: call to '__open_missing_mode' declared 
with attribute error: open with O_CREAT in second argument needs 3 arguments
make[1]: *** [shared-obj/system.o] Error 1
Author: Kamal Mostafa ka...@whence.com

=== modified file 'C_code/system.c'
--- a/C_code/system.c   2004-03-23 08:05:13 +
+++ b/C_code/system.c   2010-01-06 21:17:00 +
@@ -386,7 +386,8 @@
  close( i );
  fd0 = open( /dev/null, O_RDONLY ); 
  if (fd0  0 ) exit( 110 );
- fd1 = open( outfile, O_WRONLY | O_CREAT | O_TRUNC ); 
+ fd1 = open( outfile, O_WRONLY | O_CREAT | O_TRUNC,
+ S_IRUSR | S_IRGRP | S_IROTH | S_IWUSR | S_IWGRP | S_IWOTH );
  if (fd1  0 ) exit( 111 );
  fd2 = dup( 1 );
  if (param1[0]=='\0') {
@@ -428,7 +429,8 @@
  if (fd0  0 ) exit( 110 );
  fd1 = open( /dev/null, O_WRONLY );
  if (fd1  0 ) exit( 111 );
- fd2 = open( outfile, O_WRONLY | O_CREAT | O_TRUNC ); 
+ fd2 = open( outfile, O_WRONLY | O_CREAT | O_TRUNC,
+ S_IRUSR | S_IRGRP | S_IROTH | S_IWUSR | S_IWGRP | S_IWOTH );
  if (fd2  0 ) exit( 111 );
  if (param1[0]=='\0') {
  execlp( path, path, NULL );

Bug#560544: debian/patches/02-fix_set_item_calls.dpatch

[Kamal Mostafa]

#! /bin/sh /usr/share/dpatch/dpatch-run
## 02-fix_set_item_calls.dpatch by Kamal Mostafa ka...@whence.com
##
## DP: Fix FTBFS: call set_*_item() accessors functions, not set_item() template
##
## License: This patch is licensed under terms of GPL2, or (at your option)
## any later version.

@DPATCH@
=== modified file 'src/gui/hrdiagram.cc'
--- a/src/gui/hrdiagram.cc  2008-05-17 11:52:11 +
+++ b/src/gui/hrdiagram.cc  2010-01-07 02:53:57 +
@@ -254,8 +254,7 @@
 hr_options_label_widgets[i] = item;
 
 if ((GTK_CHECK_MENU_ITEM (options_label_widgets[i]))-active)
-  set_item(globals::chart_rules.StarLabels,
-  globals::chart_rules.StarLabels, item, false);
+  set_label_item(globals::chart_rules.StarLabels, false);
   }
 
   for (unsigned int i = 0; i  OPTIONS_DIAMETER_MENU_SIZE; i++) {
@@ -265,8 +264,7 @@
 hr_options_diameter_widgets[i] = item;
 
 if ((GTK_CHECK_MENU_ITEM (options_diameter_widgets[i]))-active)
-  set_item(globals::chart_rules.StarDiameters,
-  globals::chart_rules.StarDiameters, item, false);
+  set_diameter_item(globals::chart_rules.StarDiameters, false);
   }
 
   if (menubar) {




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#560459:

[Kamal Mostafa]

Attached debian/patches/50-remove-invalid-const.dpatch fixes the FTBFS:
scan.ll:791 problem.


50-remove-invalid-const.dpatch
Description: application/shellscript

Bug#563537: gpsim-logic: FTBFS on powerpc: missing automake-1.10

[Kamal Mostafa]

Package: gpsim-logic
Version: 0.22.0~rc3-2.2
Severity: important
Justification: fails to build from source


FTBFS on powerpc in Ubuntu Karmic, apparently missing dependency on
automake1.10

  
http://launchpadlibrarian.net/33007994/buildlog_ubuntu-karmic-powerpc.gpsim-logic_0.22.0~rc3-2.2_FAILEDTOBUILD.txt.gz

  ...
/usr/bin/make distclean
make[1]: Entering directory `/build/buildd/gpsim-logic-0.22.0~rc3'
 cd .  automake-1.10 --gnu 
/bin/bash: line 4: automake-1.10: command not found
make[1]: *** [Makefile.in] Error 1



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#563537:

[Kamal Mostafa]

Should fix FTBFS for powerpc:

  * Add missing build-dep on automake1.10

 -- Kamal Mostafa ka...@whence.com  Sun, 03 Jan 2010 07:59:40 -0800

=== modified file 'debian/control'
--- a/debian/control	2009-06-28 01:41:45 +
+++ b/debian/control	2010-01-03 17:34:04 +
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Steffen Joeris steffen.joe...@skolelinux.de
 Standards-Version: 3.7.2
-Build-Depends: debhelper (= 5), libgtk2.0-dev, libglib2.0-dev, flex, gpsim-dev (= 0.22.0~rc3), libtool, autotools-dev, autoconf
+Build-Depends: debhelper (= 5), libgtk2.0-dev, libglib2.0-dev, flex, gpsim-dev (= 0.22.0~rc3), libtool, autotools-dev, autoconf, automake1.10
 
 Package: gpsim-logic
 Architecture: any