Bug#898297: ufraw/ufraw-batch: segfault during ufraw_close (program shutdown)

[Lauro Moura]

Package: ufraw
Version: 0.22-3
Followup-For: Bug #898297
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu cosmic ubuntu-patch

*** /tmp/tmp3CJ0Wh/bug_body

In Ubuntu I had to add checks to both ld_modifier_destroy calls. It
fixes the segfault on exit.


-- System Information:
Debian Release: buster/sid
  APT prefers bionic-updates
  APT policy: (500, 'bionic-updates'), (500, 'bionic-security'), (500, 
'bionic'), (100, 'bionic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-34-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru ufraw-0.22/debian/patches/05_lensfun_destroy_cleanup.patch 
ufraw-0.22/debian/patches/05_lensfun_destroy_cleanup.patch
--- ufraw-0.22/debian/patches/05_lensfun_destroy_cleanup.patch  1969-12-31 
21:00:00.0 -0300
+++ ufraw-0.22/debian/patches/05_lensfun_destroy_cleanup.patch  2018-10-15 
19:43:41.0 -0300
@@ -0,0 +1,20 @@
+Fix cleanup of lensfun, as suggested in
+
+https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898297
+Index: ufraw-0.22/ufraw_ufraw.c
+===
+--- ufraw-0.22.orig/ufraw_ufraw.c
 ufraw-0.22/ufraw_ufraw.c
+@@ -767,8 +767,10 @@ void ufraw_close(ufraw_data *uf)
+ g_free(uf->displayProfile);
+ g_free(uf->RawHistogram);
+ #ifdef HAVE_LENSFUN
+-lf_modifier_destroy(uf->TCAmodifier);
+-lf_modifier_destroy(uf->modifier);
++if (uf->TCAmodifier != NULL)
++lf_modifier_destroy(uf->TCAmodifier);
++if (uf->modifier != NULL)
++lf_modifier_destroy(uf->modifier);
+ #endif
+ ufobject_delete(uf->conf->ufobject);
+ g_free(uf->conf);
diff -Nru ufraw-0.22/debian/patches/series ufraw-0.22/debian/patches/series
--- ufraw-0.22/debian/patches/series2017-10-20 22:37:33.0 -0300
+++ ufraw-0.22/debian/patches/series2018-10-15 19:44:42.0 -0300
@@ -2,3 +2,4 @@
 02_CVE-2015-8366.patch
 03_fix-unsigned-char.patch
 04_fix-abs-gcc-7.patch
+05_lensfun_destroy_cleanup.patch

Bug#577143:

[Lauro Moura]

I think the problem is related with the commit e9fe40 (Use
package-specific build targets and avoid ifeq constructs.), which
replaced the
ifeq statements with for loops in the build step.

the $buildver shell variable isn't evaluated when the call to
cdbs_python_binary is made, so it is always returning the versioned
python interpreter, instead of the
default one for the default python version.

»···for buildver in $(build_versions); do \
»···»···echo  calling $(call cdbs_python_binary,python$$buildver) ; \
»···done


-- 
Lauro Moura
INdT - Instituto Nokia de Tecnologia



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#577143:

[Lauro Moura]

 /usr/bin/cython has a #!/usr/bin/python2.6 shebang (consequently, cython
 depends on python2.6).

The source script has the correct, unversioned, shebang but it is
replaced by distutils during build time.

A potential fix is making python-distutils.mk in cdbs add the option
--executable=path to unversioned python to the build step when
using the unversioned interpreter.

-- 
Lauro Moura
INdT - Instituto Nokia de Tecnologia



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org