Bug#849506: RFS: niceshaper/1.2.4-1 -- Dynamic Traffic Shaper

2016-12-27 Thread Mariusz Jedwabny
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "niceshaper"

* Package name    : niceshaper
  Version : 1.2.4-1
  Upstream Author : Mariusz Jedwabny <mari...@jedwabny.net>
* URL :http://niceshaper.jedwabny.net
* License : GPL-2
  Section : net

It builds those binary packages:

   niceshaper - Dynamic Traffic Shaper

To access further information about this package, please visit the
following URL:

   https://mentors.debian.net/package/niceshaper


Alternatively, one can download the package with dget using this
command:

   dget -x https://mentors.debian.net/debian/pool/main/n/niceshaper/nic
eshaper_1.2.4-1.dsc

More information about niceshaper can be obtained from http://niceshape
r.jedwabny.net.

Changes since the last upload:

niceshaper (1.2.4-1) unstable; urgency=medium
  * New upstream release.
    - Auto Hosts feature added.
    - Status, show, and stop commands work even if errors in global
section
      configuration are found.
    - Fix a bug where the commands status and show with --remote
parameter
      don't work if NiceShaper is not running locally.
    - Allow additional dashes within the iface directive.
    - Language fixes and updates introduced into the English
translation
      of documentation.  
  * Fix watch file to check for stable releases only.

 -- Mariusz Jedwabny <mari...@jedwabny.net>  Tue, 27 Dec 2016 23:52:52
+0100


Regards,
  Mariusz Jedwabny

Bug#827641: RFS: niceshaper/1.2.3-1 -- Dynamic Traffic Shaper

2016-06-18 Thread Mariusz Jedwabny

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "niceshaper"

* Package name: niceshaper
  Version : 1.2.3-1
  Upstream Author : Mariusz Jedwabny <mari...@jedwabny.net>
* URL :http://niceshaper.jedwabny.net
* License : GPL-2
  Section : net

It builds those binary packages:

  niceshaper - Dynamic Traffic Shaper

To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/niceshaper


Alternatively, one can download the package with dget using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/n/niceshaper/niceshaper_1.2.3-1.dsc

More information about niceshaper can be obtained 
fromhttp://niceshaper.jedwabny.net.

Changes since the last upload:

niceshaper (1.2.3-1) unstable; urgency=low

  * New upstream release.

 -- Mariusz Jedwabny <mari...@jedwabny.net>  Tue, 07 Jun 2016 23:14:29 +0200


Regards,
 Mariusz Jedwabny



Bug#817949: RFS: niceshaper/1.2.2-1 [ITP]

2016-04-19 Thread Mariusz Jedwabny

Hello,

I've just uploaded 1.2.2-2 version.

Changes since the last upload:

niceshaper (1.2.2-2) unstable; urgency=low

  * Move iptables from Depends to Recommends.
  * debian/copyright: point out that src/libnetlink.* is GPL-2+ (not GPL-2).
  * Bump Standards-Version to 3.9.8, no changes needed.

 -- Mariusz Jedwabny <mari...@jedwabny.net>  Sun, 17 Apr 2016 20:59:23 +0200


On 15.04.2016 15:29, Gianfranco Costamagna wrote:

Hi again,


niceshaper (1.2.2-1) unstable; urgency=low


*one* single entry.
niceshaper (1.2.2-1) unstable; urgency=low


* Initial foo release closes: bar

signature.

that's all.


This signature is already there in the changelog, it was added to 
initial 1.0.0-2 version.


now it seems to be 3.9.8 :)


True:)

Bumped.



I would like, at least for now, to stay with exactly GPLv2 - without
option of v2.2 or v3.x or whatever.


licensecheck * -r |grep GPL |grep -v debian

src/libnetlink.h: *No copyright* GPL (v2 or later)
src/libnetlink.cc: *No copyright* GPL (v2 or later)


so your sources are wrong.
(at least they are missing from copyright file)




I've added paragraph about src/libnetlink.* files to debian/copyright, 
to inform that these are licensed under GPL-2+

and who are the authors.

Just to explain. These two files are originated from iproute2, wrapped 
into a C++ class by another author and, at the end,

adapted to NiceShaper needs by me.
Unfortunately, there was never "Copyright" clause in these files, only 
GPL-2+ license header text and Author fields.

There is still no such clause in original iproute2 source.
So, I hope I made the best what I could.

Regards
Mariusz Jedwabny



Bug#817949: RFS: niceshaper/1.2.2-1 [ITP]

2016-04-11 Thread Mariusz Jedwabny

Hello,

I've just uploaded a new version to mentors.
Below are the changelog and answers to your review.

Changes since the last upload:

niceshaper (1.2.2-1) unstable; urgency=low

  * New upstream release.
- Introduce overwritable BINDIR variable to Makefile.
- Example configuration files are copied during main installation.
- Make install command doesn't enforce owner nor group of files.
  * Drop override_dh_auto_install from debian/rules, export BINDIR instead.
  * Drop, no longer needed, debian/niceshaper.install file.

 -- Mariusz Jedwabny <mari...@jedwabny.net>  Sun, 10 Apr 2016 22:54:45 +0200



On 06.04.2016 11:06, Gianfranco Costamagna wrote:


hi, lets review again


"make DESTDIR=debian/niceshaper PREFIX=debian/niceshaper/usr 
BINDIR=debian/niceshaper/usr/bin install"

please let dh_auto_install do its job, and maybe use
something like "DESTDIR?=/usr" or similar to avoid forcing a wrong value.

dh_auto_install should already know about DESTDIR and PREFIX values, in case it 
doesn't, just export them in

the rules file.


Done. New version of upstream (1.2.2) was created.
Overwritable BINDIR variable is introduced to Makefile, thus the BINDIR 
is exported from debian/rules.

The install file is dropped as well, the Makefile makes his work.

std-version is 3.9.7

Standards version was already bumped to 3.9.7 in 1.2.1-2.
Also, in 1.2.1-2, the manual page was rewritten to be more useful.


dh-systemd the version constraint seems already satisfied even in 
old-oldstable-bpo


I'm not sure if it is good or not? I couldn't find any concrete requirement.



check-all-the-things review:
$ codespell --quiet-level=3

$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open 
any of the paths given.'

These problems was fixed in 1.2.1-1 version.
The only language problems reported are placed in Polish documents - 
these document are for sure proper.

flawfinder -Q -c .

Interesting tool. I will work to try fix some of messages, if possible, 
in future versions of upstream.



license is wrong (missing a "+")

the other stuff LGTM, but I didn't check lintian and to build the package
BTW no build system is usually bad ;)


I would like, at least for now, to stay with exactly GPLv2 - without 
option of v2.2 or v3.x or whatever.


Thank you for review.

Ciao,

Mariusz



Bug#817949: RFS: niceshaper/1.2.1-2 [ITP]

2016-03-24 Thread Mariusz Jedwabny

Changes since the last upload:

niceshaper (1.2.1-2) unstable; urgency=low

  * Remove, no longer needed, customized debian/postinst script.
  * The /var/lib/niceshaper directory is always removed on package purge.
  * Revise manual page.
  * Bump Standards-Version to 3.9.7, no changes needed.

 -- Mariusz Jedwabny <mari...@jedwabny.net>  Thu, 24 Mar 2016 21:27:50 
+0100


Regards,
  Mariusz Jedwabny



Bug#817949: RFS: niceshaper/1.2.0-1 [ITP]

2016-03-14 Thread Mariusz Jedwabny

Thank you for the review.

I've just uploaded new version which fixes important lintian warnings and typos 
in documentation documents.

* Package name: niceshaper
  Version : 1.2.1-1

Changes since the last upload:
 
niceshaper (1.2.1-1) unstable; urgency=low
 
  * New upstream release.

- Fix Typos in documentation.
- Fix source code as required by lintian.

 -- Mariusz Jedwabny <mari...@jedwabny.net>  Mon, 14 Mar 2016 18:47:24 +



I really dislike manual pages that tell the me that documentation is 
somewhere else. I'd prefer if they didn't exist; then I wouldn't waste 
my time for quitting the manual pager...





It's frequent that developers of packages, that include complex 
documentation, create only such simplified manual pages. Just because 
it's good habit and also because some manual page for package should be 
created (Debian Policy Manual).
I'm going to create a manual pages for configuration files and develop 
the main manual page with some basics about runtime commands.
In my opinion, it's better to be precisely pointed out from manual page 
than waste time if searching for project homepage on the Internet.


Regards,
  Mariusz Jedwabny



Bug#817949: RFS: niceshaper/1.2.0-1 [ITP]

2016-03-11 Thread Mariusz Jedwabny

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "niceshaper"

* Package name: niceshaper
  Version : 1.2.0-1
  Upstream Author : Mariusz Jedwabny <mari...@jedwabny.net>
* URL : http://niceshaper.jedwabny.net
* License : GPL-2
  Section : net

It builds those binary packages:

  niceshaper - Dynamic Traffic Shaper

To access further information about this package, please visit the following 
URL:

  http://mentors.debian.net/package/niceshaper


Alternatively, one can download the package with dget using this command:

  dget -x 
http://mentors.debian.net/debian/pool/main/n/niceshaper/niceshaper_1.2.0-1.dsc

More information about niceshaper can be obtained from 
http://niceshaper.jedwabny.net.

Changes since the last upload:

niceshaper (1.2.0-1) unstable; urgency=low

  * New upstream release.

 -- Mariusz Jedwabny <mari...@jedwabny.net>  Wed, 09 Mar 2016 20:35:56 +0000


Regards,
 Mariusz Jedwabny



Bug#717360: Review for RFS: niceshaper/1.0.0-2 [ITP]

2013-10-02 Thread Mariusz Jedwabny

Hi Johann.

Thank you for reviewing of my package.

Yesterday i uploaded new version to mentors according to your 
suggestions.



W dniu 2013-09-29 19:30, Johann Felix Soden napisał(a):

Hi Mariusz,

here a short review of your niceshaper package on mentors.d.n (might
not be complete):

- COPYING and debian/copyright do not match: Is your software GPL-2
or GPL-2+, which means GPL v2 or later?



Fixed: NiceShaper is GPL-2.

- remove trailing whitespaces in debian/ files (use egrep '\s$'  
debian/*).


- remove the comments at the beginning of debian/rules about its 
dh-make origin.


Both fixed.



- fix lintian warnings:

  W: niceshaper source: out-of-date-standards-version 3.9.3 (current 
is 3.9.4)


Bumped to 3.9.4


  W: niceshaper: hardening-no-relro usr/bin/niceshaper
  I: niceshaper: hardening-no-fortify-functions usr/bin/niceshaper
  - Enable hardening: switch to debian/compat 9 and adapt the
makefiles accordingly: they should append to
 the build flags. The code does not compile with
-Werror=format-security so you need either overwrite this flag or
 fix your code.


I made a patch introduce_hardening.patch as it was faster than makeing 
new upstream release.

Binary is these warnings free and of course compile properly now.



 - As it seems that the configuration of niceshaper needs to be
adapted nearly everywhere,
   it does not make much sense to start it automatically with some
example settings.
   Therefore I recommend you to disable it by default (add a
commented /etc/default/niceshaper
   file with something like NICESHAPER_ENABLE=false and check it in
the init.d script).
   Add a README.Debian which describe what the user needs to do to 
enable it.


   But maybe you have a better idea, how to improve the usage for 
normal user.




In previous version i put dh_installinit --no-start in debian/rules but 
it was not the full solution what i realized.

Your suggestion is great addition.
I added /etc/default/niceshaper and README.Debian with explanation and 
introduce NICESHAPER_ENABLE option to initscript.
When some one try to run niceshaper and NICESHAPER_ENABLE is no they 
get warning with hint:


NiceShaper not enabled in /etc/default/niceshaper



 - bonus (optional): support vim-addon-manager (add
/usr/share/vim/registry/niceshaper.yaml, see
   /usr/share/doc/vim-addon-manager/addons-proposal.txt for details).




I didn't know vim-addon-manager, sounds interesting. But for now can i 
omit implementing this feature as it is bonus?

I will come back to this feature in the future.

Best regards
Mariusz Jedwabny


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#717124: ITP: niceshaper -- Dynamic traffic shaper

2013-07-21 Thread Mariusz Jedwabny

On 07/17/2013 12:03 PM, Jonas Smedegaard wrote:

Sounds promising.

Does it make use of CoDel when available?

http://www.bufferbloat.net/projects/codel/wiki/Wiki




I don't know CoDel, i will look on it in future.
Thanks for suggestion.


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#717360: RFS: niceshaper/1.0.0-2 [ITP]

2013-07-19 Thread Mariusz Jedwabny
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package niceshaper

* Package name: niceshaper
  Version : 1.0.0-2
  Upstream Author : Mariusz Jedwabny mari...@jedwabny.net
* URL : http://niceshaper.jedwabny.net/
* License : GPLv2+
  Section : net

It builds those binary packages:

  niceshaper - Dynamic traffic shaper

To access further information about this package, please visit the following 
URL:

  http://mentors.debian.net/package/niceshaper


Alternatively, one can download the package with dget using this command:

  dget -x 
http://mentors.debian.net/debian/pool/main/n/niceshaper/niceshaper_1.0.0-2.dsc

More information about niceshaper can be obtained from 
http://niceshaper.jedwabny.net.

Changes since the last upload:

niceshaper (1.0.0-2) unstable; urgency=low

  * Initial release. (Closes: #717124)

 -- Mariusz Jedwabny mari...@jedwabny.net  Tue, 16 Jul 2013 21:05:16 +0200


Regards,
 Mariusz Jedwabny


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#717124: ITP: niceshaper -- Dynamic traffic shaper

2013-07-16 Thread Mariusz Jedwabny
Package: wnpp
Severity: wishlist
Owner: Mariusz Jedwabny mari...@jedwabny.net

* Package name: niceshaper
  Version : 1.0.0
  Upstream Author : Mariusz Jedwabny mari...@jedwabny.net
* URL : http://niceshaper.jedwabny.net/
* License : (GPL2)
  Programming Lang: (C++)
  Description : Dynamic traffic shaper

NiceShaper is a program working in a Linux router environment.
It uses a proven HTB QOS algorithm. Provides dynamic traffic shaping
which is more effective than traditional, static shaping.
By constantly monitoring packets flowing through the router in response to
changing load dynamically adjusts the bandwidth of acting classes to a level
enabling the fullest possible usage of a internet access.
At the same time does not allow for creation of congestion,
ensuring complete convenience of interactive services.

NiceShaper takes care of download when upload stops up.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org