Bug#944757: endless-sky: please package Endless Sky 0.9.10

[Michael Zahniser]

I have not been working on Endless Sky in a few years - it would make sense
to switch the maintainer to someone on the current development team
. I've CCed Zitchas on this
email.

-Michael


On Fri, Nov 11, 2022 at 1:24 AM Damyan Ivanov  wrote:

> (resent with the correct games team address; sorry for the duplicate)
>
> -=| Job Bautista, 01.08.2020 08:13:08 + |=-
> > Just in case someone wonders if this is being worked on, MZ uploaded a
> 0.9.12-1 package at mentors.debian.net[1]. He's just waiting for a
> sponsor to upload it to the main archive. If you want, you can dget the dsc
> file and build the package yourself.
> >
> > Regards,
> >
> > Job Bautista
> >
> > [1]: https://mentors.debian.net/package/endless-sky/
>
> Two years later, this is no longer available and endless-sky is at
> version 0.9.16.1.
>
> I have taken the liberty to upgrade the package (locally) from
> 0.9.8-1.2 to 0.9.16.1 and started a salsa project to track the
> changes. The result is at .
> It is not 100% ready yet, but looks quite nice. At this point I wonder
> how to proceed.
>
> Michael, would you like a co-maintainer for the Debian package?
> Perhaps even a group-maintenance under the Debian Games Team (cc-ed)?
> Either should help timely upgrades in Debian.
>
> Thanks for the great additions to the storyline :)
>
>
> -- Damyan
>

Bug#813076: ITP: endless-sky-high-dpi -- high resolution graphics for Endless Sky

[Michael Zahniser]

Package: wnpp
Severity: wishlist
Owner: Michael Zahniser <mzahni...@gmail.com>

* Package name: endless-sky-high-dpi
  Version : 0.8.10
  Upstream Author : Michael Zahniser <mzahni...@gmail.com>
* URL : http://endless-sky.github.io
* License : GPL-3+, CC-BY-SA-4.0
  Description : High resolution graphics for Endless Sky.

This package contains high-resolution graphics for the game Endless Sky. 
These images will only be used if you either have a high-DPI monitor, or 
have set the zoom level higher than 100%.

Bug#782847: RFS: endless-sky/0.8.0-1 [ITP]

[Michael Zahniser]

Sorry Adam, I hadn't been checking the bug page, so I didn't see your
message from July. (I'm on the debian-devel-games mailing list, but not on
debian-mentors.)

The issue with libjpeg is that I'm relying on the JCS_EXT_BGRA extention in
libjpeg-turbo to decode JPEGs in the proper byte order for on-screen
display. The ordinary libjpeg does not provide that extension. But, I
suppose I could switch to putting the Debian-specific option first, since I
don't think Ubuntu / Launchpad has issues with the "|" syntax. Or I could
just use plain libjpeg-dev and trust that everyone building the package is
on an OS where that means libjpeg-turbo, but that seems risky.

The other changes sound easy, so if you let me know what you think is a
good approach for libjpeg, I can upload a fixed package.

Bug#782847: RFS: endless-sky/0.8.0-1 [ITP]

[Michael Zahniser]

Package: sponsorship-requests
Severity: wishlist

  Dear mentors,

  I am looking for a sponsor for my package endless-sky. Endless Sky 
is a 2D space trading and combat game similar to the classic Escape 
Velocity series. The game has gone through three months of beta testing 
since my last email to this list, and I have now released a stable 
version. All packaging issues that were raised by the mentors the first 
time around have been fixed.


 * Package name: endless-sky
   Version : 0.8.0-1
   Upstream Author : Michael Zahniser mzahni...@gmail.com
 * URL : https://endless-sky.github.io
 * License : GPL-3+, CC-BY-SA-3.0, CC-BY-SA-4.0
   Section : games

  It builds these binary packages:

endless-sky - space exploration and combat game
endless-sky-data - data files for Endless Sky

  To access further information about this package, please visit the 
following URL:


  http://mentors.debian.net/package/endless-sky


  Alternatively, one can download the package with dget using this command:

dget -x 
http://mentors.debian.net/debian/pool/main/e/endless-sky/endless-sky_0.8.0-1.dsc


  More information about Endless Sky can be obtained from 
https://endless-sky.github.io.


  Changes since the first upload include:
  * Build system imports environment variables, e.g. for hardening.
  * Creative Commons licenses are now included.
  * Updated standards version to 3.9.6.
  * No longer requires SSE support.
  * Ran wrap-and-sort on the debian files.
  * Links switched from http to https whenever possible.
  * Added a README.sources giving a link to the artwork sources.
  * Moved the source code files into a separate source/ directory.
  * Errors are now shown in a message box, not just the terminal.
  * Made the OpenGL 3.0 requirement explicit in the package description.
  * Addressed codespell, cppcheck, flawfinder, and scan-build warnings.
  * Dependencies now list multiple options for libpng and libjpeg-turbo.

  Regards,
   Michael Zahniser


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#782847: RFS: endless-sky/0.7.9-1 [ITP]

[Michael Zahniser]

On 04/19/2015 01:40 AM, Paul Wise wrote:

I don't intend to sponsor this but here are some further comments:


I've addressed most of the comments on the initial package, and uploaded 
a new version.  To access further information about this package, please 
visit the following URL:


  http://mentors.debian.net/package/endless-sky

Alternatively, one can download the package with dget using this command:

  dget -x 
http://mentors.debian.net/debian/pool/main/e/endless-sky/endless-sky_0.7.10-1.dsc


More information about Endless Sky can be obtained from 
https://endless-sky.github.io.


Changes since the last upload:
  * Build system should now import environment variables, e.g. for 
hardening.

  * Creative Commons licenses are now included.
  * Updated standards version to 3.9.6.
  * No longer requires SSE support.
  * Ran wrap-and-sort on the debian files.
  * Links switched from http to https whenever possible.
  * Added a README.sources giving a link to the source files for artwork.
  * Moved the source code files into a separate source/ directory.
  * When run, shows errors in a message box, not just the terminal.
  * Made the OpenGL 3.0 requirement explicit in the package description.
  * Addressed warnings from codespell, cppcheck, flawfinder, and 
scan-build.

  * Dependencies now list multiple options for libpng and libjpeg-turbo.
  * Various bug fixes and usability improvements.


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#782847: RFS: endless-sky/0.7.9-1 [ITP]

[Michael Zahniser]

Thanks for the feedback, Paul! That codespell program is a really 
helpful tool that I had not known about before.


The build process does print all the build commands, and would also 
print compiler warnings (at the -Wall level) if there were any. Is that 
sufficient, or are you saying I need the g++ -v option that prints 
dozens of lines of information for each file that it compiles?


I agree that having the source for all the graphics available for 
anyone to view or modify is important. But I can't just export from 
Blender files: for the 3D images, I touched them up by hand in GIMP 
after rendering them, adding texture, scuff marks, color variation, and 
random shadows and highlights. That was to make them look dirty and worn 
rather than pristine and artificial. Similarly, a lot of the photos have 
been retouched, e.g. shifting the colors to make them look more like 
alien landscapes.


That means that the source files include many large GIMP files, and 
add up to over 3 GB. That's large enough that I think it's better for 
the image source files to be available separately rather than including 
them in the main source distribution. (I could add a line to the read-me 
giving a link to the current location (Google drive) of those files.)


-Michael



On 04/19/2015 01:40 AM, Paul Wise wrote:

On Sun, Apr 19, 2015 at 4:33 AM, James Cowgill wrote:

On Sat, 2015-04-18 at 14:31 -0400, Michael Zahniser wrote:

Dear mentors,

I am looking for a sponsor for my package endless-sky.


Here are some comments:


I don't intend to sponsor this but here are some further comments:

As you are upstream too, please read through these documents:

https://wiki.debian.org/UpstreamGuide
http://www.freedesktop.org/wiki/Games/Upstream/

Personally I would choose any build system other than scons; I would
recommend autotools or cmake.

The debian/endless-sky.install files can be reduced to this:

debian/endless-sky.install
usr/games
usr/share/applications
usr/share/man
usr/share/icons

debian/control:

I'd suggest running `wrap-and-sort -sa` so that diffs of
debian/control are more readable.

Firefox/Iceweasel say the homepage is insecure as it mixes http
content into a http page. If you change the links to images to https
instead of http that should fix it.

images/asteroid/ images/outfit/ images/planet/station*.png images/ship
endless-sky.iconset/ look like they were automatically rendered from
3D models. It would be a good idea to include the 3D models in the
source code. Bonus points for removing the automatically rendered
images from the VCS and source code zip file and having them rendered
from the 3D model at build time.

images/font/ubuntu*r.png, images/_menu/title.png and images/label look
like they are text rendered from fonts. It would be much better to
render these from TrueType/OpenType fonts at runtime, as this would
enable translators to convert the user-interface to their language. If
you don't want to do that, then these images should be rendered at
build time. If the fonts are in Debian you should depend (or
build-depend) on them, if they are not then they should be packaged
separately.

Personally I would have done the cropping/editing for images/land/*
and images/scene automatically at build time, in case you want to
adjust the cropping/effects in the future or make them higher
resolution.

Some files in images/ui/ say they were produced in Inkscape. If you
didn't throw away the SVG files, please include them in the source.
Bonus points for removing the automatically rendered images from the
VCS and source code zip file and having them rendered from the SVG
files at build time.

Some files in images/land/ say they were produced in the GIMP. If you
didn't throw away the XCF files, please include them in the source.
Bonus points for removing the automatically rendered images from the
VCS and source code zip file and having them rendered from the XCF
files at build time.

You might want to move the *.cpp files to a src/ or source/ directory.

I'd suggest using https in URLs where possible. Everything except the
libjpeg-turbo and sourceforge links and probably the URLs in the plist
files should work with https.

The build process should be verbose (print all the commands and
compiler output) but is not.

The game crashes on my system:

$ endless-sky
#version 120
uniform vec2 scale;
uniform vec2 position;
uniform int glyph;
in vec2 vert;
in vec2 corner;
out vec2 texCoord;
void main() {
   texCoord = vec2((glyph + corner.x) / 96.f, corner.y);
   gl_Position = vec4((vert + position) * scale, 0, 1);
}
0:5(1): error: `in' qualifier in declaration of `vert' only valid for
function parameters in GLSL 1.20
0:6(1): error: `in' qualifier in declaration of `corner' only valid
for function parameters in GLSL 1.20
0:7(1): error: `out' qualifier in declaration of `texCoord' only valid
for function parameters in GLSL 1.20
Shader compilation failed.
terminate called without an active exception
Aborted (core

Bug#782846: ITP: endless-sky - space trading and combat game

[Michael Zahniser]

Package: wnpp
Severity: wishlist
Owner: Michael Zahniser mzahni...@gmail.com

* Package name: endless-sky
  Version : 0.7.9
  Upstream Author : Michael Zahniser mzahni...@gmail.com
* URL : http://endless-sky.github.io
* License : GPL-3+
  Programming Lang: C++
  Description : A 2D space trading and combat game.

Explore other star systems. Earn money by trading, carrying passengers, or
completing missions. Use your earnings to buy a better ship or to upgrade
the weapons and engines on your current one. Blow up pirates. Take sides in
a civil war. Or leave human space behind and hope to find some friendly
aliens whose culture is more civilized than your own...


* Package name: endless-sky-data
  Version : 0.7.9
  Upstream Author : Michael Zahniser mzahni...@gmail.com
* URL : http://endless-sky.github.io
* License : GPL-3+, CC-BY-SA-3.0, CC-BY-SA-4.0
  Description : Data files for endless-sky.


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#782847: RFS: endless-sky/0.7.9-1 [ITP]

[Michael Zahniser]

Package: sponsorship-requests
Severity: wishlist

  Dear mentors,

  I am looking for a sponsor for my package endless-sky.

 * Package name: endless-sky
   Version : 0.7.9-1
   Upstream Author : Michael Zahniser mzahni...@gmail.com
 * URL : http://endless-sky.github.io
 * License : GPL-3+, CC-BY-SA-3.0, CC-BY-SA-4.0
   Section : games

  It builds these binary packages:

endless-sky - Space exploration and combat game.
endless-sky-data - Data files for Endless Sky.

  To access further information about this package, please visit the 
following URL:


  http://mentors.debian.net/package/endless-sky


  Alternatively, one can download the package with dget using this command:

dget -x 
http://mentors.debian.net/debian/pool/main/e/endless-sky/endless-sky_0.7.9-1.dsc


  More information about endless-sky can be obtained from 
http://endless-sky.github.io .


  Changes since the last upload:

  * Initial release. (Closes: #782846)


  Regards,
   Michael Zahniser


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#782847: RFS: endless-sky/0.7.9-1 [ITP]

[Michael Zahniser]

Thanks for the quick feedback!

If SSE 4.1 is not acceptable, is it possible to at least depend on SSE 
3? I use some SSE intrinsics to optimize geometric calculations. Should 
I modify the code so those instructions are used only if a special 
command line option is given? That would mean all the official packages 
would be un-optimized, even though all i386 and amd64 processors from 
the last decade support SSE 3.


For libjpeg, right now I use the JCS_EXT_BGRA option (converting to 
32-bit BGRA color when decoding JPEGs). The reason I specified 
libpeg-turbo is because other libjpeg implementations may not include 
that extension. (But, I see that libjpeg-turbo is the default 
implementation of libjpeg on Debian, anyway.) Is it safe to just specify 
plain libjpeg as the dependency?


-Michael



On 04/18/2015 04:33 PM, James Cowgill wrote:

On Sat, 2015-04-18 at 14:31 -0400, Michael Zahniser wrote:

Dear mentors,

I am looking for a sponsor for my package endless-sky.


Here are some comments:

build:
The build passes -msse4.1 to g++. This will fail on non-x86 arches and
produce binaries which don't work without sse 4.1 processors on x86
arches.

debian/control:
libjpeg-turbo8-dev does not exist in debian, try libjpeg-dev
Latest standards version is 3.9.6

debian/copyright:
You need copies of CC-BY-SA-3.0 and CC-BY-3.0

debian/rules:
You should not hardcode -j4 in the rules file. Use the value given in
DEB_BUILD_OPTIONS 'parallel' instead (see policy 4.9.1).

Lintian output:
W: endless-sky: hardening-no-relro usr/games/endless-sky
I: endless-sky: hardening-no-fortify-functions usr/games/endless-sky
I: endless-sky: description-synopsis-might-not-be-phrased-properly
I: endless-sky: hyphen-used-as-minus-sign usr/share/man/man6/endless-sky.6.gz:7
I: endless-sky: desktop-entry-lacks-keywords-entry 
usr/share/applications/endless-sky.desktop
I: endless-sky-data: description-synopsis-might-not-be-phrased-properly
P: endless-sky: no-upstream-changelog
P: endless-sky-data: no-upstream-changelog

The warning should be fixed. That one is usually caused by the build
system ignoring custom CFLAGS/CXXFLAGS/etc. The others would be nice to
fix as well but are not essential.

Otherwise, the package looks good - I'm not a DD though so I can't
upload the package for you when it's done.

Thanks,
James




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org