Bug#1066055: re: rust-symphonia-core: FTBFS on i386 units::tests::verify_timebase panic
On Tue, 12 Mar 2024 17:55:42 + Peter Green wrote: > 2. Is it worth expending effort on getting symphonia available on > i386? to me that depends on what software is using or planning > to use it. For a port in it's twilight years, keeping existing > software working seems more important than making new software > available. Speaking as a user, if this package simply doesn't support i386 I'd be ok with that outcome. The main reason I noticed this is because I work on a project that does clean internal rebuilds of Debian packages, and if this packages simply shouldn't support i386 any more that resolves it from my perspective.
Bug#1066062: libmath-int128-perl: FTBFS on i386 "your compiler doesn't support a 128-bit integer type"
Source: libmath-int128-perl Version: 0.22-5 Severity: important Tags: ftbfs libmath-int128-perl appears unable to build on i386 on my machine using sbuild and the latest buildd result[1] seems the same. This indirectly affects the i386 build of libmaxmind-db-writer-perl and probably a few other packages. Checking for int __attribute__ ((__mode__ (TI)))... It looks like your compiler doesn't support a 128-bit integer type (one of "int __attribute__ ((__mode__ (TI)))" or "__int128"). One of these types is necessary to compile the Math::Int128 module. [1]: https://buildd.debian.org/status/fetch.php?pkg=libmath-int128-perl=i386=0.22-5=1705861163=0
Bug#1066055: rust-symphonia-core: FTBFS on i386 units::tests::verify_timebase panic
Source: rust-symphonia-core
Version: 0.5.2-1
Severity: important
Tags: ftbfs
rust-symphonia-core appears to FTBFS from an i386 sbuild chroot with a
test 'units::tests::verify_timebase' panicking
units::tests::verify_timebase stdout
thread 'units::tests::verify_timebase' panicked at 'assertion failed:
`(left == right)`
left: `4503599627370496`,
right: `4503599627370497`', src/units.rs:257:9
stack backtrace:
0: rust_begin_unwind
at /usr/src/rustc-1.70.0/library/std/src/panicking.rs:578:5
1: core::panicking::panic_fmt
at /usr/src/rustc-1.70.0/library/core/src/panicking.rs:67:14
2: core::panicking::assert_failed_inner
3: core::panicking::assert_failed
at /usr/src/rustc-1.70.0/library/core/src/panicking.rs:228:5
4: symphonia_core::units::tests::verify_timebase
at
/usr/share/cargo/registry/symphonia-core-0.5.2/src/units.rs:257:9
5: symphonia_core::units::tests::verify_timebase::{{closure}}
at
/usr/share/cargo/registry/symphonia-core-0.5.2/src/units.rs:236:26
6: core::ops::function::FnOnce::call_once
at /usr/src/rustc-1.70.0/library/core/src/ops/function.rs:250:5
7: core::ops::function::FnOnce::call_once
at /usr/src/rustc-1.70.0/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a
verbose backtrace.
This failure also seems present on the latest attempt from buildd[1].
[1]:
https://buildd.debian.org/status/fetch.php?pkg=rust-symphonia-core=i386=0.5.2-1%2Bb1=170585=0
Bug#1033680: linux: Consider enabling CONFIG_ANON_VMA_NAME=y
Source: linux Version: 6.1.15-1 Severity: wishlist X-Debbugs-Cc: ge...@google.com X-Debbugs-Cc: jko...@google.com Recent Ubuntu kernels support this. It's useful for analyzing memory usage for applications in addition to other things.
Bug#1019526: gnome-control-center: color management broken after update, segfault
tags 1019526 patch thanks Looks like the issue has been addressed upstream https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1640 with 2893f8e3f9cc94f969a7f2062585aef4161df235 which I'm guessing should show up when 44 is released. That said, the patch applies cleanly to 43, so this could be pulled forward early to address the segfault. Patch attached. From 2893f8e3f9cc94f969a7f2062585aef4161df235 Mon Sep 17 00:00:00 2001 From: Mohammed Sadiq Date: Tue, 15 Nov 2022 16:01:43 +0530 Subject: [PATCH] color: Select first device row only if non-NULL Otherwise we might read some invalid memory resulting in a crash --- panels/color/cc-color-panel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/panels/color/cc-color-panel.c b/panels/color/cc-color-panel.c index f55fcf93b..42820c798 100644 --- a/panels/color/cc-color-panel.c +++ b/panels/color/cc-color-panel.c @@ -1642,7 +1642,8 @@ gcm_prefs_update_device_list_extra_entry (CcColorPanel *prefs) gtk_widget_set_visible (prefs->box_devices, first_row != NULL); /* if we have only one device expand it by default */ - if (gtk_list_box_get_row_at_index (prefs->list_box, 1) == NULL) + if (first_row != NULL && + gtk_list_box_get_row_at_index (prefs->list_box, 1) == NULL) cc_color_device_set_expanded (CC_COLOR_DEVICE (first_row), TRUE); } -- 2.39.0.314.g84b9a713c41-goog
Bug#1026425: polkitd.postinst removes directories created by new install of polkitd-pkla
Package: polkitd Version: 122-1 Severity: important X-Debbugs-Cc: ge...@google.com If I install polkitd-pkla from a fresh unstable chroot it seems that polkitd.postinst ends up removing the /etc/polkit-1/localauthority.conf.d and /etc/polkit-1/nullbackend.conf.d directories due to these lines in debian/polkitd.postinst: # Clean up old directories after dpkg-maintscript-helper has removed the # conffiles. if dpkg --compare-versions "$2" lt "0.109-1"; then if [ -d /etc/polkit-1/localauthority.conf.d/ ]; then rmdir --ignore-fail-on-non-empty /etc/polkit-1/localauthority.conf.d/ fi if [ -d /etc/polkit-1/nullbackend.conf.d/ ]; then rmdir --ignore-fail-on-non-empty /etc/polkit-1/nullbackend.conf.d/ fi fi These are the same directories that polkitd-pkla explicitly creates. Is this the intended behavior when installing polkitd-pkla? I'm currently trying to make use of polkitd-pkla to support some (now legacy) pkla configs. I'll probably end up converting them to javascript anyway since it seems that's the direction upstream has headed, but I'm filing this since it seems like it might affect others. -- System Information: Debian Release: bookworm/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 5.19.11-1rodete1-amd64 (SMP w/4 CPU threads; PREEMPT) Locale: LANG=en_US.UTF-8, LC_CTYPE=C.UTF-8 (charmap=locale: Cannot set LC_MESSAGES to default locale: No such file or directory locale: Cannot set LC_ALL to default locale: No such file or directory UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: unable to detect Versions of packages polkitd-pkla depends on: ii libc6 2.36-6 ii libglib2.0-0 2.74.3-1 ii libpolkit-gobject-1-0 122-1 ii polkitd122-1 polkitd-pkla recommends no packages. polkitd-pkla suggests no packages. Versions of packages polkitd depends on: ii adduser 3.129 ii dbus [default-dbus-system-bus] 1.14.4-1 ii libc6 2.36-6 ii libduktape207 2.7.0-1+b1 ii libexpat1 2.5.0-1 ii libglib2.0-02.74.3-1 ii libpam-systemd [logind] 252.3-2 ii libpam0g1.5.2-5 ii libpolkit-agent-1-0 122-1 ii libpolkit-gobject-1-0 122-1 ii libsystemd0 252.3-2 ii systemd [systemd-sysusers] 252.3-2 ii xml-core0.18+nmu1 polkitd suggests no packages. -- debconf information excluded
Bug#1019554: Stamp files are not updated
On Mon, 19 Sep 2022 12:59:59 + Lance Lin wrote: > > Thank you for tracking this down. I did make the change in -33. > > Yes, I made the change to remove dangling symlinks on uninstall. I > > didn't realize this was called on upgrades, so I've moved the logic > > inside the "purge" case. > > I propose to make the following change to anacron.postrm: > > #!/bin/sh > > set -e > > if [ "$1" = "purge" ]; then > # here for historical reasons > rm -f /var/log/anacron /var/log/anacron.[0-9]* > rm -rf /var/spool/anacron > > # Close bug #993348 > rm /etc/systemd/system/multi-user.target.wants/anacron.service > rm /etc/systemd/system/timers.target.wants/anacron.timer > fi > > #DEBHELPER# > > Do you agree with this change? Yes, that seems like it should prevent future upgrades from disabling the service and the timer. Users that upgraded from -33 or -34 will still need to manually re-enable the service and the timer, of course. I'm capable of doing that with my systems, but I'll leave whether that's acceptable in general up to you.
Bug#995475:
And as expected the 5.1-3.1 NMU fixed this by triggering a rebuild.
Bug#995475: bash-static: segfault on startup when running with glibc 2.32
Package: bash-static Version: 5.1-3+b1 Severity: grave Justification: renders package unusable X-Debbugs-Cc: ge...@google.com ``` $ bash-static Segmentation fault (core dumped) ``` A simple rebuild of the package against the new glibc version seems to fix the issue for me. -- System Information: Debian Release: bookworm/sid APT prefers unstable-debug APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 5.13.0-trunk-amd64 (SMP w/8 CPU threads) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages bash-static depends on: ii passwd 1:4.8.1-1 bash-static recommends no packages. Versions of packages bash-static suggests: pn bash-doc -- no debconf information
Bug#914297: apache2: getrandom call blocks on first startup, systemd kills with timeout
Package: apache2
Version: 2.4.37-1
Severity: important
Recently apache2 has been failing to come up on initial startup, ultimately
hitting systemd's timeout and getting killed. After startup, though, I was able
to manually start apache2 with "systemctl start apache2". Poking strace in
there I noticed it seemed to be blocking on a call to getrandom:
697 getpid() = 697
697 openat(AT_FDCWD, "/dev/urandom", O_RDONLY) = 10
697 fstat(10, {st_mode=S_IFCHR|0666, st_rdev=makedev(1, 9), ...}) = 0
697 openat(AT_FDCWD, "/dev/random", O_RDONLY) = 11
697 fstat(11, {st_mode=S_IFCHR|0666, st_rdev=makedev(1, 8), ...}) = 0
697 openat(AT_FDCWD, "/dev/srandom", O_RDONLY) = -1 ENOENT (No such file or
directory)
697 futex(0x7f52ad56c928, FUTEX_WAKE_PRIVATE, 2147483647) = 0
697 getrandom(
587 <... wait4 resumed> 0x7ffe3ecf748c, 0, NULL) = ? ERESTARTSYS (To be
restarted if SA_RESTART is set)
697 <... getrandom resumed> 0x5577627046e0, 32, 0) = ? ERESTARTSYS (To be
restarted if SA_RESTART is set)
587 --- SIGTERM {si_signo=SIGTERM, si_code=SI_USER, si_pid=1, si_uid=0} ---
697 --- SIGTERM {si_signo=SIGTERM, si_code=SI_USER, si_pid=1, si_uid=0} ---
587 +++ killed by SIGTERM +++
697 +++ killed by SIGTERM +++
Which I'd suspect has something to do with apache or some library it depends on
moving to getrandom, which (I believe) blocks of the entropy pool isn't good
enough yet. It looks like openssh is affected by something similar:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912087
The difference with openssh, though, is that it eventually does come up as its
systemd config allows it to be retried. apache2, on the other hand, does not
allow this. Which means on systems that have poor entropy sources (like virtual
machines) the machine will start, but apache2 will never come up until it's
manually started.
I'm not certain where the actual bug is here, maybe this is something systemd
should be able to block on, but in either case I wouldn't be surprised if this
starts affecting users of apache in virtual environments specifically.
-- Package-specific info:
-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 4.18.0-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages apache2 depends on:
ii apache2-bin2.4.37-1
ii apache2-data 2.4.37-1
ii apache2-utils 2.4.37-1
ii dpkg 1.19.2
ii lsb-base 9.20170808
ii mime-support 3.61
ii perl 5.28.0-3
ii procps 2:3.3.15-2
Versions of packages apache2 recommends:
ii ssl-cert 1.0.39
Versions of packages apache2 suggests:
pn apache2-doc
pn apache2-suexec-pristine | apache2-suexec-custom
ii w3m [www-browser]0.5.3-36+b1
Versions of packages apache2-bin depends on:
ii libapr1 1.6.3-3
ii libaprutil1 1.6.1-3+b1
ii libaprutil1-dbd-sqlite3 1.6.1-3+b1
ii libaprutil1-ldap 1.6.1-3+b1
ii libbrotli1 1.0.7-1
ii libc62.27-8
ii libcurl4 7.61.0-1
ii libjansson4 2.11-1
ii libldap-2.4-22.4.46+dfsg-5+b1
ii liblua5.2-0 5.2.4-1.1+b2
ii libnghttp2-141.34.0-1
ii libpcre3 2:8.39-11
ii libssl1.11.1.1-2
ii libxml2 2.9.4+dfsg1-7+b2
ii perl 5.28.0-3
ii zlib1g 1:1.2.11.dfsg-1
Versions of packages apache2-bin suggests:
pn apache2-doc
pn apache2-suexec-pristine | apache2-suexec-custom
ii w3m [www-browser]0.5.3-36+b1
Versions of packages apache2 is related to:
ii apache2 2.4.37-1
ii apache2-bin 2.4.37-1
-- Configuration Files:
/etc/apache2/apache2.conf changed:
DefaultRuntimeDir ${APACHE_RUN_DIR}
PidFile ${APACHE_PID_FILE}
Timeout 300
KeepAlive On
MaxKeepAliveRequests 100
KeepAliveTimeout 5
User ${APACHE_RUN_USER}
Group ${APACHE_RUN_GROUP}
HostnameLookups Off
ErrorLog ${APACHE_LOG_DIR}/error.log
LogLevel debug
IncludeOptional mods-enabled/*.load
IncludeOptional mods-enabled/*.conf
Include ports.conf
Options FollowSymLinks
AllowOverride None
Require all denied
AllowOverride None
Require all granted
Options Indexes FollowSymLinks
AllowOverride None
Require all granted
AccessFileName .htaccess
Require all denied
LogFormat "%v:%p %h %l %u %t \"%r\" %>s %O \"%{Referer}i\" \"%{User-Agent}i\""
vhost_combined
LogFormat "%h %l %u %t \"%r\" %>s %O \"%{Referer}i\" \"%{User-Agent}i\""
combined
LogFormat "%h %l %u %t \"%r\" %>s %O" common
LogFormat "%{Referer}i -> %U"
Bug#811576: patch
Added header to patch refrencing the trousers mailing list posting. -- Mike Gerow ge...@google.com diff -Nru tpm-tools-1.3.8/debian/changelog tpm-tools-1.3.8/debian/changelog --- tpm-tools-1.3.8/debian/changelog 2015-06-28 03:15:23.0 -0700 +++ tpm-tools-1.3.8/debian/changelog 2016-07-04 07:49:41.0 -0700 @@ -1,3 +1,11 @@ +tpm-tools (1.3.8-2.1) unstable; urgency=medium + + * Non-maintainer upload. + * Fix confusing indentation in tpm_present.c that fails build with GCC 6 +(Closes: #811576). + + -- Mike Gerow <ge...@mgerow.com> Mon, 04 Jul 2016 16:49:41 +0200 + tpm-tools (1.3.8-2) unstable; urgency=medium * Add patch 03 to fix FTBFS with gcc-5 (Closes: #778147) diff -Nru tpm-tools-1.3.8/debian/patches/05-fix-FTBFS-gcc-6.patch tpm-tools-1.3.8/debian/patches/05-fix-FTBFS-gcc-6.patch --- tpm-tools-1.3.8/debian/patches/05-fix-FTBFS-gcc-6.patch 1969-12-31 16:00:00.0 -0800 +++ tpm-tools-1.3.8/debian/patches/05-fix-FTBFS-gcc-6.patch 2016-07-04 07:49:41.0 -0700 @@ -0,0 +1,24 @@ +Description: Fix FTBFS with GCC 6 due to confusing indentation +Author: Mike Gerow <ge...@mgerow.com> +Bug: https://sourceforge.net/p/trousers/mailman/message/35261553/ +--- a/src/tpm_mgmt/tpm_present.c b/src/tpm_mgmt/tpm_present.c +@@ -349,13 +349,13 @@ + } + } while (flags[++i].name); + +- out_success: ++out_success: + logSuccess(argv[0]); + iRc = 0; +- out_close: ++out_close: + contextClose(hContext); +- out: +-if (szTpmPasswd && !isWellKnown) +- shredPasswd( szTpmPasswd ); ++out: ++ if (szTpmPasswd && !isWellKnown) ++ shredPasswd( szTpmPasswd ); + return iRc; + } diff -Nru tpm-tools-1.3.8/debian/patches/series tpm-tools-1.3.8/debian/patches/series --- tpm-tools-1.3.8/debian/patches/series 2015-06-28 03:11:26.0 -0700 +++ tpm-tools-1.3.8/debian/patches/series 2016-07-04 07:49:41.0 -0700 @@ -2,3 +2,4 @@ 02-cflags-errors-unused.patch 03-fix-bool-error-parseStringWithValues.patch 04-fix-FTBFS-clang.patch +05-fix-FTBFS-gcc-6.patch signature.asc Description: Digital signature
Bug#830546: tpm-tools shouldn't depend on opencryptoki
Package: tpm-tools Version: 1.3.8-2+b1 Severity: normal Dear Maintainer, tpm-tools shouldn't depend on opencryptoki, or the package should be split into the tools that do and don't depend on opencryptoki (most of them don't). From what I can tell it seems only the tpmtoken_* commands actually depend on opencryptoki. All the rest only depend on trousers. I'm interested in this mostly because I want to be able install tools to use trousers without needing to install opencryptoki. The soltion I have in mind is to split tpm-tools into tpm-tools-tspi and tpm-tools-pkcs11, and of course have tpm-tools depend on both of those. This way I can just install tpm-tools-tspi if those are all I care about. I intend to put a patch together for this once I find the time. -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 4.5.0-2-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages tpm-tools depends on: ii libc6 2.23-1 ii libssl1.0.2 1.0.2h-1 ii libtpm-unseal1 1.3.8-2+b1 ii libtspi10.3.13-4.1 ii opencryptoki3.4.1+dfsg-1 ii trousers0.3.13-4.1 tpm-tools recommends no packages. tpm-tools suggests no packages. -- no debconf information -- Mike Gerow ge...@mgerow.com signature.asc Description: PGP signature
Bug#811604: FTBFS with GCC 6: statement indented as if it were guarded by
On Tue, 19 Jan 2016 16:10:20 -0800 Martin Michlmayr <t...@hpe.com> wrote: > Package: crash > Version: 7.1.4-1 > Severity: important > User: debian-...@lists.debian.org > Usertags: ftbfs-gcc-6 gcc-6-misleading-indentation > > This package fails to build with GCC 6. GCC 6 has not been released > yet, but it's expected that GCC 6 will become the default compiler for > stretch. > > Note that only the first error is reported; there might be more. You > can find a snapshot of GCC 6 in experimental. To build with GCC 6, > you can set CC=gcc-6 CXX=g++-6 explicitly. > > > sbuild (Debian sbuild) 0.67.0 (26 Dec 2015) on dl580gen9-02.hlinux > ... > > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I. -I. -I./../include > > -DHAVE_bfd_elf64_x86_64_vec -DHAVE_bfd_elf32_i386_vec > > -DHAVE_bfd_elf32_x86_64_vec -DHAVE_i386linux_vec -DHAVE_i386pei_vec > > -DHAVE_x86_64pei_vec -DHAVE_bfd_elf64_l1om_vec -DHAVE_bfd_elf64_k1om_vec > > -DHAVE_bfd_elf64_little_generic_vec -DHAVE_bfd_elf64_big_generic_vec > > -DHAVE_bfd_elf32_little_generic_vec -DHAVE_bfd_elf32_big_generic_vec > > -DBINDIR=\"/usr/local/bin\" -Wdate-time -D_FORTIFY_SOURCE=2 -W -Wall > > -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -g -O2 > > -fstack-protector-strong -Wformat -Werror=format-security -MT pei-i386.lo > > -MD -MP -MF .deps/pei-i386.Tpo -c pei-i386.c -o pei-i386.o > > In file included from pei-i386.c:46:0: > > coff-i386.c: In function 'coff_i386_reloc': > > coff-i386.c:144:5: error: statement is indented as if it were guarded by... > > [-Werror=misleading-indentation] > > if (diff != 0) > > ^~ > > > > coff-i386.c:135:3: note: ...this 'if' clause, but it is not > >if (reloc_entry->howto->type == R_IMAGEBASE > >^~ > > > > cc1: all warnings being treated as errors > > Makefile:1607: recipe for target 'pei-i386.lo' failed > > make[8]: *** [pei-i386.lo] Error 1 Hmm... I don't seem to be able to reproduce this error. Also the code itself doesn't actually look misleading. Maybe it was fixed in the latest 7.1.5-1 release? -- Mike Gerow ge...@mgerow.com signature.asc Description: PGP signature
Bug#811593: FTBFS with GCC 6: statement indented as if it were guarded by
tags 811593 patch
thanks
Hi,
The attached patch should fix the issue, although it's not completely
clear to me if these were hidden (until now) mistakes or not.
robertc: Are you also upstream for this? If so is the actual behavior
what you were expecting?
--
Mike Gerow
ge...@mgerow.com
diff -u libgetopt++-0.0.2-p22/debian/changelog libgetopt++-0.0.2-p22/debian/changelog
--- libgetopt++-0.0.2-p22/debian/changelog
+++ libgetopt++-0.0.2-p22/debian/changelog
@@ -1,3 +1,10 @@
+libgetopt++ (0.0.2-p22-3.2) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix misleading indentation in src/OptionSet.cc. (Closes: #811593)
+
+ -- Mike Gerow <ge...@mgerow.com> Thu, 07 Jul 2016 20:06:17 +0200
+
libgetopt++ (0.0.2-p22-3.1) unstable; urgency=medium
* Non-maintainer upload.
diff -u libgetopt++-0.0.2-p22/debian/patches/series libgetopt++-0.0.2-p22/debian/patches/series
--- libgetopt++-0.0.2-p22/debian/patches/series
+++ libgetopt++-0.0.2-p22/debian/patches/series
@@ -2,0 +3 @@
+fix_gcc6_ftbfs.diff
only in patch2:
unchanged:
--- libgetopt++-0.0.2-p22.orig/debian/patches/fix_gcc6_ftbfs.diff
+++ libgetopt++-0.0.2-p22/debian/patches/fix_gcc6_ftbfs.diff
@@ -0,0 +1,20 @@
+--- a/src/OptionSet.cc
b/src/OptionSet.cc
+@@ -126,7 +126,7 @@
+ if (!isOption(maybepos))
+ /* not an option */
+ value = argv[1];
+- argv.erase(argv.begin() + 1);
++ argv.erase(argv.begin() + 1);
+ }
+ } else {
+ /* value if present is in this argv */
+@@ -159,7 +159,7 @@
+
+ if (!isOption(maybepos))
+ value = argv[1];
+- argv.erase(argv.begin() + 1);
++ argv.erase(argv.begin() + 1);
+ }
+ }
+ }
signature.asc
Description: PGP signature
Bug#811594: [PATCH] Fix confusing indentation in src/a2crd.c
tags 811594 patch
thanks
The following patch should fix things up. Sending it upstream as well.
---
debian/changelog| 7 +
debian/patches/fix-ftbfs-in-gcc-6.patch | 51 +
debian/patches/series | 1 +
3 files changed, 59 insertions(+)
create mode 100644 debian/patches/fix-ftbfs-in-gcc-6.patch
diff --git a/debian/changelog b/debian/changelog
index 26a8e39..7ac9767 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+chordii (4.3+repack-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix confusing indentation in src/a2crd.c. (Closes: #811594)
+
+ -- Mike Gerow <ge...@mgerow.com> Thu, 07 Jul 2016 18:57:11 +0200
+
chordii (4.3+repack-2) unstable; urgency=low
[ Malcolm Locke ]
diff --git a/debian/patches/fix-ftbfs-in-gcc-6.patch
b/debian/patches/fix-ftbfs-in-gcc-6.patch
new file mode 100644
index 000..9be31cf
--- /dev/null
+++ b/debian/patches/fix-ftbfs-in-gcc-6.patch
@@ -0,0 +1,51 @@
+--- a/src/a2crd.c
b/src/a2crd.c
+@@ -353,27 +353,27 @@
+ }
+
+
+-if (optind == argc)
+-{
+-debug ("Reading stdin");
+-strcpy(source, "stdin");
+-process_file (stdin);
+-}
+-else
+-{
+-for ( ; optind < argc; optind++ )
+-{
+- sprintf (mesg, "Ready to process file \"%s\"\n",
argv[optind]);
+-debug (mesg);
+-
+-strcpy(source, argv[optind]);
+-
+- sprintf (mesg, "Calling read_input_file on \"%s\"\n",
source);
+-debug (mesg);
+-
+-read_input_file(source, source_fd);
+-}
+-}
++if (optind == argc)
++ {
++ debug ("Reading stdin");
++ strcpy(source, "stdin");
++ process_file (stdin);
++ }
++else
++ {
++ for ( ; optind < argc; optind++ )
++ {
++ sprintf (mesg, "Ready to process file \"%s\"\n", argv[optind]);
++ debug (mesg);
++
++ strcpy(source, argv[optind]);
++
++ sprintf (mesg, "Calling read_input_file on \"%s\"\n", source);
++ debug (mesg);
++
++ read_input_file(source, source_fd);
++ }
++ }
+
+ return(0);
+ }
diff --git a/debian/patches/series b/debian/patches/series
index 0f99d38..7a51209 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
fix-manpage.patch
fix-spelling-error.patch
remove-surplus-man-mans-rule.diff
+fix-ftbfs-in-gcc-6.patch
--
2.8.1
--
Mike Gerow
ge...@mgerow.com
signature.asc
Description: PGP signature
Bug#811579: FTBFS with GCC 6: statement indented as if it were guarded by
The code in question is generated by the protobuf compiler. Since humans shouldn't be reading this code anyway I think it's safe to disable the warning here. Looking to see if there's a good way to selectively disable it just for the proto bits... -- Mike Gerow ge...@mgerow.com signature.asc Description: PGP signature
Bug#811582: [PATCH] Fix misleading indentation in dtnperf_client
The below patch fixes the issue. ion.ocp.ohiou.edu doesn't appear to be
up right now, though, and I'm having a hard time finding out if there's
somewhere upstream I can send this patch as well.
---
debian/changelog | 7 +
debian/patches/0004-ftbfs-with-gcc-6.patch | 50 ++
debian/patches/series | 1 +
3 files changed, 58 insertions(+)
create mode 100644 debian/patches/0004-ftbfs-with-gcc-6.patch
diff --git a/debian/changelog b/debian/changelog
index 05c671e..dcc9140 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+ion (3.2.1+dfsg-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix misleading indentation in dtnperf_client.c (closes: #811582)
+
+ -- Mike Gerow <ge...@mgerow.com> Thu, 07 Jul 2016 16:39:04 +0200
+
ion (3.2.1+dfsg-1) unstable; urgency=medium
* New upstream release.
diff --git a/debian/patches/0004-ftbfs-with-gcc-6.patch
b/debian/patches/0004-ftbfs-with-gcc-6.patch
new file mode 100644
index 000..02124d6
--- /dev/null
+++ b/debian/patches/0004-ftbfs-with-gcc-6.patch
@@ -0,0 +1,50 @@
+--- a/contrib/dtnperf/dtnperf/src/dtnperf_modes/dtnperf_client.c
b/contrib/dtnperf/dtnperf/src/dtnperf_modes/dtnperf_client.c
+@@ -670,22 +670,22 @@
+ if(perf_opt->create_log)
+ print_final_report(log_file);
+
+- // fill the stop bundle
+- prepare_stop_bundle(_stop, mon_eid,
conn_opt->expiration, conn_opt->priority, sent_bundles);
+- al_bp_bundle_set_source(_stop, local_eid);
+-
+- // send stop bundle to monitor
+- if (debug)
+- printf("sending the stop bundle to the monitor...");
+- if ((error = al_bp_bundle_send(handle, regid, _stop)) !=
0)
+- {
+- fprintf(stderr, "[DTNperf fatal error] in sending stop
bundle: %d (%s)\n", error, al_bp_strerror(error));
+- if (create_log)
+- fprintf(log_file, "[DTNperf fatal error] in
sending stop bundle: %d (%s)\n", error, al_bp_strerror(error));
+- client_clean_exit(1);
+- }
+- if (debug)
+- printf("done.\n");
++ // fill the stop bundle
++ prepare_stop_bundle(_stop, mon_eid, conn_opt->expiration,
conn_opt->priority, sent_bundles);
++ al_bp_bundle_set_source(_stop, local_eid);
++
++ // send stop bundle to monitor
++ if (debug)
++ printf("sending the stop bundle to the monitor...");
++ if ((error = al_bp_bundle_send(handle, regid, _stop)) != 0)
++ {
++ fprintf(stderr, "[DTNperf fatal error] in sending stop bundle:
%d (%s)\n", error, al_bp_strerror(error));
++ if (create_log)
++ fprintf(log_file, "[DTNperf fatal error] in sending
stop bundle: %d (%s)\n", error, al_bp_strerror(error));
++ client_clean_exit(1);
++ }
++ if (debug)
++ printf("done.\n");
+
+ // waiting monitor stops
+ if (dedicated_monitor)
+@@ -718,7 +718,7 @@
+ fprintf(stderr, "[DTNperf fatal error] unregisted
endpoint: %s\n", strerror(errno));
+ if (create_log)
+ fprintf(log_file, "[DTNperf fatal error]
unregisted endpoint: %s\n", strerror(errno));
+- client_clean_exit(1);
++ client_clean_exit(1);
+ }
+ else
+ {
diff --git a/debian/patches/series b/debian/patches/series
index d27cf45..cd8bdcb 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@
0001-replace-gmake-with-make.patch
0002-fix-dtnperf-undefined-symbols.patch
0003-ftbfs-with-clang.patch
+0004-ftbfs-with-gcc-6.patch
--
2.8.1
--
Mike Gerow
ge...@mgerow.com
signature.asc
Description: PGP signature
Bug#811610: [PATCH] Disable the nonnull-compare flag for faketime.
Proposing this patch to just disable the warning. Not super familiar
with the general policies around this, though.
---
debian/changelog | 7 +++
debian/rules | 6 ++
2 files changed, 13 insertions(+)
diff --git a/debian/changelog b/debian/changelog
index 9cb8901..535de0c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+faketime (0.9.6-4.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Disable the nonnull-compare flag for faketime.
+
+ -- Mike Gerow <ge...@mgerow.com> Thu, 07 Jul 2016 11:36:54 +0200
+
faketime (0.9.6-4) unstable; urgency=medium
* link to libfaketime's README from faketime's doc dir (thanks, Ximin
diff --git a/debian/rules b/debian/rules
index cf3813a..1cd0399 100755
--- a/debian/rules
+++ b/debian/rules
@@ -5,6 +5,12 @@
export DEB_CFLAGS_MAINT_APPEND=-DMULTI_ARCH
+# GCC 6 includes a warning for checking if a variable nonnull if it's been
+# tagged that passing a NULL value creates undefined behavior. Ignore this for
+# faketime since the compilation units that define this for it are in libc,
+# which may or may not have these flags.
+export CFLAGS+=-Wno-nonnull-compare
+
# make sure dh_makeshlibs does not modify post{inst,rm} scripts:
# (avoids lintian's postinst-has-useless-call-to-ldconfig)
override_dh_makeshlibs:
--
2.8.1
--
Mike Gerow
ge...@mgerow.com
signature.asc
Description: PGP signature
Bug#811610: FTBFS with GCC 6: nonnull argument compared to NULL
Hmm... So the reason gcc is complaining is because of this line in /usr/include/x86_64-linux-gnu/sys/stat.h (on amd64 at least): extern int __xstat (int __ver, const char *__filename, struct stat *__stat_buf) __THROW __nonnull ((2, 3)); I'm still not sure if this is common amongst libcs or not, but this seems like a situation where disabling the warning might be the right move. -- Mike Gerow ge...@mgerow.com signature.asc Description: PGP signature
Bug#811575: FTBFS with GCC 6: statement indented as if it were guarded by
fixed 811575 2:3.23-1 thanks Actually this should be fixed in the pull from upstream 2:3.23-1, and I can confirm that building with GCC 6 now appears to succeed. -- Mike Gerow ge...@mgerow.com signature.asc Description: PGP signature
Bug#811575: FTBFS with GCC 6: statement indented as if it were guarded by
This appears to have been fixed upstream with a clang-format run: changeset: 11862:313155f1077b user:Franziskus Kiefer <franziskuskie...@gmail.com> date:Fri Feb 05 22:53:48 2016 +0100 summary: Bug 1244135 - NSS clang-format: lib/dbm, r=kaie I'll see if I can pull a reasonably sized patch out of that. -- Mike Gerow ge...@mgerow.com signature.asc Description: PGP signature
Bug#811576: patch
On Fri, 01 Jul 2016 08:27:48 +0200 Robert Bihlmeyer <ro...@orcus.priv.at> wrote: > Package: tpm-tools > Followup-For: Bug #811576 > > The indentation is wrong. Attaching a patch, if reportbug allows me to do it. Looking at the problem again the whole issue seems to be with some confusing mixing of tabs and spaces in just this one area. The attached patch just replaces these with tabs and puts it in a quilt patch. I'll go ahead and post the patch on the trousers development list too. -- Mike Gerow ge...@mgerow.com diff -Nru tpm-tools-1.3.8/debian/changelog tpm-tools-1.3.8/debian/changelog --- tpm-tools-1.3.8/debian/changelog 2015-06-28 12:15:23.0 +0200 +++ tpm-tools-1.3.8/debian/changelog 2016-07-04 17:05:26.0 +0200 @@ -1,3 +1,11 @@ +tpm-tools (1.3.8-2.1) unstable; urgency=medium + + * Non-maintainer upload. + * Fix confusing indentation in tpm_present.c that fails build with GCC 6 +(Closes: #811576). + + -- Mike Gerow <ge...@mgerow.com> Mon, 04 Jul 2016 16:49:41 +0200 + tpm-tools (1.3.8-2) unstable; urgency=medium * Add patch 03 to fix FTBFS with gcc-5 (Closes: #778147) diff -Nru tpm-tools-1.3.8/debian/patches/05-fix-FTBFS-gcc-6.patch tpm-tools-1.3.8/debian/patches/05-fix-FTBFS-gcc-6.patch --- tpm-tools-1.3.8/debian/patches/05-fix-FTBFS-gcc-6.patch 1970-01-01 02:00:00.0 +0200 +++ tpm-tools-1.3.8/debian/patches/05-fix-FTBFS-gcc-6.patch 2016-07-04 16:56:36.0 +0200 @@ -0,0 +1,21 @@ +--- a/src/tpm_mgmt/tpm_present.c b/src/tpm_mgmt/tpm_present.c +@@ -349,13 +349,13 @@ + } + } while (flags[++i].name); + +- out_success: ++out_success: + logSuccess(argv[0]); + iRc = 0; +- out_close: ++out_close: + contextClose(hContext); +- out: +-if (szTpmPasswd && !isWellKnown) +- shredPasswd( szTpmPasswd ); ++out: ++ if (szTpmPasswd && !isWellKnown) ++ shredPasswd( szTpmPasswd ); + return iRc; + } diff -Nru tpm-tools-1.3.8/debian/patches/series tpm-tools-1.3.8/debian/patches/series --- tpm-tools-1.3.8/debian/patches/series 2015-06-28 12:11:26.0 +0200 +++ tpm-tools-1.3.8/debian/patches/series 2016-07-04 16:57:31.0 +0200 @@ -2,3 +2,4 @@ 02-cflags-errors-unused.patch 03-fix-bool-error-parseStringWithValues.patch 04-fix-FTBFS-clang.patch +05-fix-FTBFS-gcc-6.patch signature.asc Description: PGP signature
Bug#805025: clonezilla: missing dependency: bc
> Thank you for the bugreport. > > The next release will fix the bug. > > Best regards, Georges. Control: fixed 805025 clonezilla/3.10.11-4 (Just saw this from the newcomer queue btw) For some reason this wasn't automatically closed with this change? clonezilla (3.10.11-4) unstable; urgency=medium * added a dependency on bc. Closes: #805025 -- Georges Khaznadar <georg...@debian.org> Sat, 14 Nov 2015 11:52:37 +0100 Anyway, the bug seems to be resolved closing. -- Mike Gerow ge...@mgerow.com signature.asc Description: PGP signature
Bug#818239: ohcount-doc: creates non-FHS /ruby directory
I think this may just be an issue with the binary package itself. I can confirm that when I install 3.0.0-8.1 from ftp.us.debian.org I do in fact get this extra /ruby dir. When 'apt-get source ohcount' and build the package manually, though, I get a binary package that _doesn't_ include this dir. -- Mike Gerow ge...@mgerow.com signature.asc Description: PGP signature
Bug#492432: aptitude: fetch and display copyright (like changelog)
On Mon, May 30, 2016 at 02:35:04PM +0200, David Kalnischkies wrote: > Ideally, this would be implemented in libapt directly. It nowadays > sports a pkgAcqChangelog which deals with most of the complexity around > changelogs including the constructing the URI (as different archives > have different storage places and such) [which from a casual look seem > not to be used by aptitude which constructs the URI on its own (for > Debian only)]. > > A good way to deal with this hence might perhaps be to fully adopt > pkgAcqChangelog in aptitude, mostly copy pkgAcqChangelog and paste as > pkgAcqCopyright in libapt (src:apt) and copy the changelog-code in > aptitude to deal with copyright [Bonuspoints if abstraction is used > instead of copy]. Alright, that makes a lot of sense. I'll take a look at libapt and see if there's a nice way add support for fetching the copyright info without too much copy/pasting. > I can't speak for the aptitude team of course, but at least for the apt > team and I would be happy to help on the apt side. If you are interested > feel free to ask me (DonKult), us (de...@lists.debian.org) and/or on IRC > (#debian-apt – where apt & aptitude people hang out together)! I'll definitely drop the irc by when I inevitably have qestions. Thanks! -- Mike Gerow ge...@mgerow.com signature.asc Description: PGP signature
Bug#492432: (no subject)
Hi folks, this bug is almost 8 (!) years old. I've started looking into the implementation to see if I can thro a patch together but wanted to make sure this is something the aptitude team would still want. -- Mike Gerow ge...@mgerow.com signature.asc Description: PGP signature
Bug#818195: [PATCH] Remove dependency on jasper
Hello! I'm new, and I saw your newcomer tag! Since this is tracked in a git repo is it appropriate to just include the git patch here? Either way I've included it below. I also removed jasper from the add_autotools.diff by stepping through it with quilt, let me know if the right thing to do here is to add a new diff instead. --- debian/changelog | 4 debian/control| 2 +- debian/patches/add_autotools.diff | 2 +- debian/patches/no_jasper.diff | 12 debian/patches/series | 1 + 5 files changed, 19 insertions(+), 2 deletions(-) create mode 100644 debian/patches/no_jasper.diff diff --git a/debian/changelog b/debian/changelog index b2d203a..2576bbd 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,7 +1,11 @@ dcraw (9.26-2) UNRELEASED; urgency=medium + [ Tobias Frost ] * dccleancrw: Patch to bail out if file cannot be opened. Closes: #715777 + [ Mike Gerow ] + * Remove libjasper-dev dependency. Closes: #818195 + -- Tobias Frost <t...@debian.org> Sat, 30 Apr 2016 23:46:28 +0200 dcraw (9.26-1) unstable; urgency=medium diff --git a/debian/control b/debian/control index c27a7b0..87c7f00 100644 --- a/debian/control +++ b/debian/control @@ -2,7 +2,7 @@ Source: dcraw Section: graphics Priority: optional Maintainer: Debian QA Group <packa...@qa.debian.org> -Build-Depends: debhelper (>= 9), dh-autoreconf, libjpeg-dev, liblcms2-dev, libjasper-dev +Build-Depends: debhelper (>= 9), dh-autoreconf, libjpeg-dev, liblcms2-dev Standards-Version: 3.9.8 Vcs-Git: https://anonscm.debian.org/git/collab-maint/dcraw.git Vcs-Browser: https://anonscm.debian.org/git/collab-maint/dcraw.git diff --git a/debian/patches/add_autotools.diff b/debian/patches/add_autotools.diff index 75095bb..1eb0157 100644 --- a/debian/patches/add_autotools.diff +++ b/debian/patches/add_autotools.diff @@ -18,7 +18,7 @@ Add configure.in and Makefile.in for a rudimentary AutoTools build system +OBJ = dcraw.o parse.o fujiturn.o fujiturn16.o fuji_green.o clean_crw.o @LIBOBJS@ + +all: $(OBJ) -+ $(CC) @LDFLAGS@ -o dcraw dcraw.o -ljpeg -llcms2 -ljasper @LIBS@ ++ $(CC) @LDFLAGS@ -o dcraw dcraw.o -ljpeg -llcms2 @LIBS@ + $(CC) @LDFLAGS@ -o dcparse parse.o @LIBS@ + $(CC) @LDFLAGS@ -o dcfujiturn fujiturn.o @LIBS@ + $(CC) @LDFLAGS@ -o dcfujiturn16 fujiturn16.o @LIBS@ diff --git a/debian/patches/no_jasper.diff b/debian/patches/no_jasper.diff new file mode 100644 index 000..afcbc36 --- /dev/null +++ b/debian/patches/no_jasper.diff @@ -0,0 +1,12 @@ +Build without jasper to fix #818195. +--- a/Makefile.in b/Makefile.in +@@ -3,7 +3,7 @@ + SHELL = /bin/sh + INSTALL= /usr/bin/install + CC = @CC@ +-CFLAGS = -I@srcdir@ @CFLAGS@ ++CFLAGS = -I@srcdir@ @CFLAGS@ -DNO_JASPER + CPPFLAGS = @CPPFLAGS@ + LDFLAGS = @LDFLAGS@ + LIBOBJS = @LIBOBJS@ diff --git a/debian/patches/series b/debian/patches/series index 2f0138b..f744910 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1,3 +1,4 @@ 715777.patch add_autotools.diff remove_LO_line_from_manpage.diff +no_jasper.diff -- 2.8.1 -- Mike Gerow ge...@mgerow.com signature.asc Description: PGP signature
Bug#825120: (no subject)
Hi there! Saw this bug was tagged 'newcomer' and thought it might be an easy one to start with, but are we really sure qemu-system-x86 /should/ be a depends? According to the policy 'The Recommends field should list packages that would be found together with this one in all but unusual installations', which seems correct for this case since gnome-boxes is still perfectly usable with remote boxes without qemu-system-x86. The only unfortunate bit is that it gives a somewhat unhelful 'Box setup failed' message when qemu isn't installed and the user tries to setup a qemu-backed box. -- Mike Gerow ge...@mgerow.com signature.asc Description: PGP signature
