Bug#849231: phpmyadmin: create/drop index shows resulting query only briefly

[Peter Roes]

Package: phpmyadmin
Version: 4:4.2.12-2+deb8u2
Severity: normal
Tags: patch

Dear Maintainer,

After I upgraded to Debian 8, I noticed create/drop index actions in phpmyadmin
only show the executed query for a brief moment. Consequently, I am not longer
able to copy these queries, e.g. for journaling purposes.

It looks like a double refresh of the underlaying page, so I took a look at the
javascript files, and comment out a couple of lines which fixed the problem for
me.

I have created diff files which I will upload with this report.

With kind regards,

Peter



-- System Information:
Debian Release: 8.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.1.0-1-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages phpmyadmin depends on:
ii  dbconfig-common1.8.47+nmu3+deb8u1
ii  debconf [debconf-2.0]  1.5.56
ii  libapache2-mod-php55.6.29+dfsg-0+deb8u1
ii  libjs-sphinxdoc1.2.3+dfsg-1
ii  perl   5.20.2-3+deb8u6
ii  php-gettext1.0.11-1
ii  php5-json  1.3.6-1
ii  php5-mcrypt5.6.29+dfsg-0+deb8u1
ii  php5-mysql 5.6.29+dfsg-0+deb8u1
ii  ucf3.0030

Versions of packages phpmyadmin recommends:
ii  apache2 [httpd]  2.4.10-10+deb8u7
ii  apache2-mpm-prefork [httpd]  2.4.10-10+deb8u7
ii  mysql-client 5.5.53-0+deb8u1
ii  mysql-client-5.5 [virtual-mysql-client]  5.5.53-0+deb8u1
ii  php-tcpdf6.0.093+dfsg-1
ii  php5-gd  5.6.29+dfsg-0+deb8u1

Versions of packages phpmyadmin suggests:
ii  epiphany-browser [www-browser]   3.14.1-1
ii  firefox-esr [www-browser]45.6.0esr-1~deb8u1
ii  iceape [www-browser] 2.7.12-1
ii  mysql-server 5.5.53-0+deb8u1
ii  mysql-server-5.5 [virtual-mysql-server]  5.5.53-0+deb8u1
ii  w3m [www-browser]0.5.3-19

-- debconf information:
  phpmyadmin/dbconfig-remove:
* phpmyadmin/reconfigure-webserver: apache2
  phpmyadmin/upgrade-backup: true
  phpmyadmin/install-error: abort
  phpmyadmin/remove-error: abort
  phpmyadmin/missing-db-package-error: abort
  phpmyadmin/remote/host:
  phpmyadmin/dbconfig-install: true
  phpmyadmin/internal/reconfiguring: false
  phpmyadmin/mysql/method: unix socket
  phpmyadmin/db/app-user: phpmyadmin
  phpmyadmin/dbconfig-reinstall: false
  phpmyadmin/internal/skip-preseed: false
  phpmyadmin/setup-username: admin
  phpmyadmin/remote/newhost:
  phpmyadmin/dbconfig-upgrade: true
  phpmyadmin/purge: false
  phpmyadmin/upgrade-error: abort
  phpmyadmin/remote/port:
  phpmyadmin/mysql/admin-user: root
  phpmyadmin/passwords-do-not-match:
--- functions.org.js	2016-12-23 22:38:47.0 +0100
+++ functions.js	2016-12-21 16:16:02.0 +0100
@@ -2987,7 +2987,7 @@
 }
 $('div.no_indexes_defined').hide();
-if (callback_success) {
-   callback_success();
-}
+//if (callback_success) {
+//   callback_success();
+//}
 PMA_reloadNavigation();
 } else {
--- indexes.org.js	2016-12-23 22:39:34.0 +0100
+++ indexes.js	2016-12-21 16:26:22.0 +0100
@@ -162,7 +162,7 @@
 PMA_highlightSQL($('#page_content'));
 }
-PMA_commonActions.refreshMain(false, function () {
-$("a.ajax[href^=#indexes]").click();
-});
+//PMA_commonActions.refreshMain(false, function () {
+//$("a.ajax[href^=#indexes]").click();
+//});
 PMA_reloadNavigation();
 } else {

Bug#759481: Digest still SHA1 even when SHA256 is default

[Peter Roes]

Hi Uli,

I started out from version 0.7.5-4. I missed that this report is against a
newer version. Sorry for the inconvenience.

The sorting fix in my diff is incomplete, as it does not provide for
selection of textual/numerical sorting.

Regards,

Peter

 Hi Peter,
 I traced the problem to the function _fill_radiobox in GUI.pm. For some
reason, the value for the digest gets changed in this function. I
swapped
 two lines, and the problem is gone. I also added a sort in the for
command. I have attached a diff file.
 I'm somewhat surprised to see this reappear as I had fixed it in version
0.7.5-5 (#724586). My patch looked exactly like yours (sans the
sorting).
 Which version of tinyca did you start from?
 Regards
 Uli


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#759481: Digest still SHA1 even when SHA256 is default

[Peter Roes]

Dear maintainer,

I have applied the patches supplied with this bug report, and still get
SHA1 in stead of SHA256. In the dialog box, SHA256 is selected by default.
If I toggle to say SHA512 and back to SHA256, I get a SHA256 digest.

I traced the problem to the function _fill_radiobox in GUI.pm. For some
reason, the value for the digest gets changed in this function. I swapped
two lines, and the problem is gone. I also added a sort in the for
command. I have attached a diff file.

With kind regards,

Peter Roes--- tinyca_org/GUI.pm	2013-03-25 09:01:53.0 +0100
+++ tinyca/GUI.pm	2015-01-14 23:27:39.0 +0100
@@ -3094,10 +3102,10 @@
 
$previous_key = undef;
-   for $value (keys %values) {
+   for $value (sort keys %values) {
   my $display_name = $values{$value};
   my $key = Gtk2::RadioButton-new($previous_key, $display_name);
-  $key-set_active(1) if(defined($$var)  $$var eq $value);
   $key-signal_connect('toggled' =
 			   sub{GUI::CALLBACK::toggle_to_var($key, $var, $value)});
+  $key-set_active(1) if(defined($$var)  $$var eq $value);
   $radiobox-add($key);
   $previous_key = $key;