Bug#890793: reportbug: when body-file is given the newbie template added to the body

2018-02-18 Thread Viktor Szépe
Package: reportbug
Version: 6.6.6
Severity: normal

Dear Maintainer,

When using these options:
reportbug --mode=novice --no-query-bts --no-config-files --no-check-available \
--no-debconf --no-check-installed --no-cc-menu --no-tags-menu --no-verify \
--subject="$REPORTBUG_SUBJECT" --body-file="$REPORTBUG_BODY" 
"$REPORTBUG_PACKAGE"
reportbug always prepends the newbie template to body-file.

I think it is an 'if' in bugreport.py
https://anonscm.debian.org/cgit/reportbug/reportbug.git/tree/reportbug/bugreport.py#n119

Please consider not adding that template when body-file is specified.
Thanks.

-- System Information:
Debian Release: 8.10
  APT prefers oldstable-updates
  APT policy: (500, 'oldstable-updates'), (500, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-0.bpo.5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: sysvinit (via /sbin/init)

Versions of packages python-reportbug depends on:
ii  apt   1.0.9.8.4
ii  file  1:5.22+15-2+deb8u3
ii  python-debian 0.1.27
ii  python-debianbts  2.6.1~bpo8+1
pn  python:any

python-reportbug suggests no packages.



Bug#890650: spamassassin: permission of /var/lib/spamassassin/compiled changes at the first update

2018-02-17 Thread Viktor Szépe
Package: spamassassin
Version: 3.4.1-8
Severity: normal

Dear Maintainer,

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?
   * What exactly did you do (or not do) that was effective (or
 ineffective)?
   * What was the outcome of this action?
   * What outcome did you expect instead?

*** End of the template - remove these template lines ***

Monit noticed that /var/lib/spamassassin/compiled changes from 0775 to 0755 at 
the first update.
Please consider sticking to one setting.
Thanks.

spamassassin v3.4.1-8

-- System Information:
Debian Release: 8.10
  APT prefers oldstable-updates
  APT policy: (500, 'oldstable-updates'), (500, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-0.bpo.5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: sysvinit (via /sbin/init)



Bug#886544: redis-server: Replacing set -e in sysvinit script

2018-01-07 Thread Viktor Szépe
Package: redis-server
Version: 2:3.2.11-1~dotdeb+8.1
Severity: important

Was https://github.com/lamby/pkg-redis/issues/14

Please consider replacing `set -e` with step-by-step error checking in SysVInit 
scripts.

> Be careful of using set -e in init.d scripts

https://www.debian.org/doc/debian-policy/#writing-the-scripts

> Conforming scripts shall not specify the "exit on error" option (i.e. set -e) 
> when sourcing this file,  
> or calling any of the commands thus made available. 

http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptfunc.html

BTW Using `/lib/init/init-d-script` produces a much nicer init script:

```bash
#!/bin/sh
# kFreeBSD do not accept scripts as interpreters, using #!/bin/sh and sourcing.
if [ true != "$INIT_D_SCRIPT_SOURCED" ] ; then
set "$0" "$@"; INIT_D_SCRIPT_SOURCED=true . /lib/init/init-d-script
fi
### BEGIN INIT INFO
# Provides:  courier
# Required-Start:courier-authdaemon $remote_fs $syslog
# Required-Stop: $remote_fs $syslog
# Default-Start: 2 3 4 5
# Default-Stop:  0 1 6
# Short-Description: courier service
### END INIT INFO

# Author: Ondřej Surý 

DAEMON="/usr/sbin/courier"
DESC="courier service"
PIDFILE="none"

DO_START=yes

do_start_cmd_override() {
DAEMON_ARGS="start $DAEMON_ARGS"
do_start_cmd
}

do_stop_cmd_override() {
DAEMON_ARGS="stop $DAEMON_ARGS"
do_start_cmd
}
```

https://anonscm.debian.org/git/collab-maint/courier.git/tree/debian/courier-mta.courier.init

Thank you.



Bug#872089: courier-mta: TLS_TRUSTCERTS default value

2017-08-14 Thread Viktor Szépe
Package: courier-mta
Severity: important

Dear Maintainer,

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?
   * What exactly did you do (or not do) that was effective (or
 ineffective)?
   * What was the outcome of this action?
   * What outcome did you expect instead?

*** End of the template - remove these template lines ***

@mwanner Hello!

We have a typo - maybe - in four config files: TLS_TRUSTCERTS=/etc/ssl/cert.pem
The value should be /etc/ssl/certs

/etc/courier  
386:courierd  
265:imapd-ssl 
263:esmtpd-ssl
239:esmtpd


-- System Information:
Debian Release: 9.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: sysvinit (via /sbin/init)