Bug#779040: fake-hwclock: does not run at shutdown

[gnubiferous]

Hi Alexandre,

I can confirm that adding Conflicts=shutdown.target resolves the problem.

Thanks for providing a solution.

(By the way, I have not added Before=systemd-journald.service as you did,
because my journal correctly starts with the fake-hwclock saved timestamp,
not with the 1970-01-01 that you saw.)


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#773966: libxine2-console: Incorrect munmap() call causes fbxine to segfault

[gnubiferous]

Package: libxine2-console
Version: 1.2.2-6+b2
Severity: normal
Tags: upstream patch

Hi,

When using fbxine in jessie on an armhf platform, I find that it always
segfaults when exiting, leaving the console inconveniently in graphics
mode.

I traced this to the fb_dispose() function in src/video_out/video_out_fb.c
which contains this line:

  munmap(0, this-mem_size);

This is surely a mistake because we wouldn't want to unmap location 0.
The intention is to undo the mmap() of the framebuffer device that was
done at startup in fb_open_plugin(), so I think the line is meant to be:

  munmap(this-video_mem_base, this-mem_size);

I've attached a patch with the above change; applying it resolved the
problem for me.

According to the xine-lib revision history the bug has been there since
the first commit in 2002. I've reported it upstream here:

https://bugs.xine-project.org/show_bug.cgi?id=555

Please could you apply the patch in Debian?

Thanks a lot.


diff -Nur a/src/video_out/video_out_fb.c b/src/video_out/video_out_fb.c
--- a/src/video_out/video_out_fb.c	2012-02-05 19:17:03.0 +
+++ b/src/video_out/video_out_fb.c	2014-12-26 10:03:27.380997448 +
@@ -681,7 +681,7 @@
 {
   fb_driver_t *this = (fb_driver_t *)this_gen;
 
-  munmap(0, this-mem_size);
+  munmap(this-video_mem_base, this-mem_size);
   close(this-fd);
 
   _x_alphablend_free(this-alphablend_extra_data);