Bug#1000471: glewlwyd FTBFS can't find functions.

2021-11-23 Thread Nicolas Mora 

Hello,

Le 2021-11-23 à 15 h 20, peter green a écrit :

Package: glewlwyd
Version: 2.5.2-3
Severity: serious
Tags: ftbfs

Unfortunately it seems that even after the cross-fetch fix, glewlwyd 
still FTBFS as a

result of changes in iddawc/rhonabwy.

Thanks, that's because the dependencies were updated lately, and some 
api was changed.


I have the package glewlwyd 2.6.0 ready to upload, as soon as 
node-i18next-http-backend 1.3.1+dfsg-3 will be available on my schroot, 
today or tomorrow.


/Nicolas

Bug#1000471: glewlwyd FTBFS can't find functions.

2021-11-23 Thread peter green 

Package: glewlwyd
Version: 2.5.2-3
Severity: serious
Tags: ftbfs

Unfortunately it seems that even after the cross-fetch fix, glewlwyd still 
FTBFS as a
result of changes in iddawc/rhonabwy.


/usr/bin/cc -D_GNU_SOURCE -Dschememodoauth2_EXPORTS -I/include -g -O2 
-ffile-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Werror -fPIC -Wextra -std=gnu99 -MD -MT 
CMakeFiles/schememodoauth2.dir/src/scheme/oauth2.c.o -MF 
CMakeFiles/schememodoauth2.dir/src/scheme/oauth2.c.o.d -o 
CMakeFiles/schememodoauth2.dir/src/scheme/oauth2.c.o -c /<>/src/scheme/oauth2.c
/<>/src/scheme/oauth2.c: In function 'complete_session_identify':
/<>/src/scheme/oauth2.c:265:32: error: implicit declaration of 
function 'i_load_userinfo'; did you mean 'i_get_userinfo'? 
[-Werror=implicit-function-declaration]
  265 | if ((res = i_load_userinfo(_session)) == I_OK && 
i_session.j_userinfo != NULL) {
  |^~~
  |i_get_userinfo
/<>/src/scheme/oauth2.c: In function 
'user_auth_scheme_module_init':
/<>/src/scheme/oauth2.c:1197:28: error: implicit declaration of 
function 'i_load_openid_config'; did you mean 'i_get_openid_config'? 
[-Werror=implicit-function-declaration]
 1197 | } else if (i_load_openid_config(_session) != I_OK) {
  |^~~~
  |i_get_openid_config
make  -f CMakeFiles/protocol_oidc.dir/build.make 
CMakeFiles/protocol_oidc.dir/depend

<---snip>

/usr/bin/cc -D_GNU_SOURCE -Dprotocol_register_EXPORTS -I/include -g -O2 
-ffile-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Werror -fPIC -Wextra -std=gnu99 -MD -MT 
CMakeFiles/protocol_register.dir/src/plugin/register.c.o -MF 
CMakeFiles/protocol_register.dir/src/plugin/register.c.o.d -o 
CMakeFiles/protocol_register.dir/src/plugin/register.c.o -c 
/<>/src/plugin/register.c
/<>/src/plugin/protocol_oidc.c: In function 'check_parameters':
/<>/src/plugin/protocol_oidc.c:272:45: error: implicit declaration 
of function 'r_jwks_import_from_str'; did you mean 'r_jwks_import_from_uri'? 
[-Werror=implicit-function-declaration]
  272 | if (r_jwks_init() != RHN_OK || r_jwks_import_from_str(jwks, 
json_string_value(json_object_get(j_params, "jwks-public"))) != RHN_OK) {
  | ^~
  | r_jwks_import_from_uri


I initially saw this on a raspbian bookworm-staging autobuilder, but I was also 
able to reproduce
it in a Debian sid chroot.

I found upstream patches fixing the above errors and applied them in raspbian 
bookworm-staging,
I also imported the cross-fetch fix into raspbian bookworm-staging from Debian 
sid. After doing
so I was able to get a successful build of glewlwyd. A debdiff should appear 
soon at
https://debdiffs.raspbian.org/main/g/glewlwyd

P.S. The cross-fetch fix also seems to be blocked from migrating to debian 
testing as a result
of an autopkgtest failure.