Bug#1001577: m17n-lib: internal vs external symbols

2022-01-08 Thread Harshula 

Hi Boyuan,

On 14/12/21 21:47, Boyuan Yang wrote:


I wasn't aware of the issue around internal & external symbols. Sorry for the
issue! Since the change was made back in 2018, I could not recall my exact
thought when I made those changes. Please feel free to correct the symbol
file.


Done. The next problem is Commit 
8c35a402074808db7355a00f4581afb4611c9abe (Modernize packaging). The 
commit dropped dh_makeshlibs directives that should have been kept.


Regards,
Harshula

Bug#1001577: m17n-lib: internal vs external symbols

2021-12-14 Thread Boyuan Yang 
Hi,

在 2021-12-12星期日的 10:04 +0100，Harshula写道：
> Source: m17n-lib
> Version: 1.8.0-3
> Severity: normal
> X-Debbugs-CC: by...@debian.org
> 
> 
> Hi Boyuan,
> 
> re: 
> https://salsa.debian.org/input-method-team/m17n-lib/-/commit/fed1505e84be88c1d21105df87763a0374693c9e
> 
> Can you please review your commit, above? The changelog entry only says 
> "Refreshed". Was it an accidental error?
> 
> My understanding is that libm17n-X.so and libm17n-gd.so are dynamically 
> loaded libraries that are used internally by the m17n library and not 
> part of the external API.
> 
> Hence, libm17n's internal dynamically loaded library symbols were 
> intentionally removed from the symbols file in Commit 
> aa08c48b1a3cafdd56749d821891859df1ca91ba .

I wasn't aware of the issue around internal & external symbols. Sorry for the
issue! Since the change was made back in 2018, I could not recall my exact
thought when I made those changes. Please feel free to correct the symbol
file.

Thanks,
Boyuan


signature.asc
Description: This is a digitally signed message part

Bug#1001577: m17n-lib: internal vs external symbols

2021-12-12 Thread Harshula 

Source: m17n-lib
Version: 1.8.0-3
Severity: normal
X-Debbugs-CC: by...@debian.org


Hi Boyuan,

re: 
https://salsa.debian.org/input-method-team/m17n-lib/-/commit/fed1505e84be88c1d21105df87763a0374693c9e


Can you please review your commit, above? The changelog entry only says 
"Refreshed". Was it an accidental error?


My understanding is that libm17n-X.so and libm17n-gd.so are dynamically 
loaded libraries that are used internally by the m17n library and not 
part of the external API.


Hence, libm17n's internal dynamically loaded library symbols were 
intentionally removed from the symbols file in Commit 
aa08c48b1a3cafdd56749d821891859df1ca91ba .


Thanks again for packaging m17n-lib 1.8.0!

Regards,
Harshula