Bug#1001657: Ball fails its autopkgtest - how to properly deal with sip files?
On 12/16/21 1:24 PM, Andreas Tille wrote: Hi Étienne, Am Wed, Dec 15, 2021 at 11:23:17PM +0100 schrieb Étienne Mollier: I pushed my changes leading to these errors, but getting the other bugs affecting ball fixed before Christmas might involve undoing the setting of SIP_LIBRARIES in d/rules. Thanks a lot for your investigations. I do not think we have a real time limit for ball - but this is a good time to do some polishing in BTW and if we delay the solution it might become forgotten again. That's why I'm asking whether the effort to solve the issue is worth doing compared to simply droping the Python3 package which I consider a valid solution of the problem. Only my opinion: Just do this, IMO i.e. drop package. I don't think it is worth spending so much time to fix this when we have no real users. There is a "possibility" that the popcon score (2) would have come from our us installing it in own machines only for testing purposes. Upstream is dead as well, so this gives me several green flags to proceed with a removal. Regards, Nilesh OpenPGP_signature Description: OpenPGP digital signature
Bug#1001657: Ball fails its autopkgtest - how to properly deal with sip files?
Hi Étienne, Am Wed, Dec 15, 2021 at 11:23:17PM +0100 schrieb Étienne Mollier: > > I pushed my changes leading to these errors, but getting the > other bugs affecting ball fixed before Christmas might involve > undoing the setting of SIP_LIBRARIES in d/rules. Thanks a lot for your investigations. I do not think we have a real time limit for ball - but this is a good time to do some polishing in BTW and if we delay the solution it might become forgotten again. That's why I'm asking whether the effort to solve the issue is worth doing compared to simply droping the Python3 package which I consider a valid solution of the problem. Kind regards Andreas. -- http://fam-tille.de
Bug#1001657: Ball fails its autopkgtest - how to properly deal with sip files?
Hi Étienne, Am Wed, Dec 15, 2021 at 09:42:00PM +0100 schrieb Étienne Mollier: > > Pushed, Thanks for the nudge. (Sorry, I couldn't push yesterday > for dumb reasons.) Thanks. :-) > > The python package is probably available for the case if you want to use > > the library itself in the python code and use it programmatically. > > The upstream wiki page seems to concur: > > > > https://github.com/BALL-Project/ball/wiki/BALLPythonScripting > > This was my perception of the situation when I tried to make > use of ballview myself, to make sure the software was operating > properly without all the python3 bindings. So what do you think is the more promising strategy: Fixing python3-ball under the now better conditions or simply droping the package? > Have a nice day, :) Same to you and thanks again Andreas. -- http://fam-tille.de
Bug#1001657: Ball fails its autopkgtest - how to properly deal with sip files?
On 15 December 2021 2:36:14 pm IST, Andreas Tille wrote: >Hi Étienne, > >Am Tue, Dec 14, 2021 at 11:13:21PM +0100 schrieb Étienne Mollier: >> Étienne Mollier, on 2021-12-14: >> > However, once the sip file is caught, the package fails to build >> > from source due to various errors in the generated code. The >> > patch also addresses one of them in its second hunk. I think I >> > was stuck on some "overrides" related errors, but they were >> > interleaved within sip output, I can send a proper log later >> > this week after an overnight build if needed. >> >> I forgot I had one other patch to address PyString issues, part >> of the ftbfs. And also forgot to mention that I had to enforce >> -DSIP_LIBRARIES=/usr/lib/python3/dist-packages from the cmake >> call in d/rules. >> >> In hope this helps, > >May be you can simply push your patches to make sure everything is >stored visibly. > >What I'm currently wondering is the following: According to popcon[1] >python3-ball has 2 votes and its only dependency ballview has 10 votes. >This makes no real sense if ballview would really need python3-ball. Based on the package description, python3-ball has the "python bindings" for the library packages. ballview does not seem to use the python bindings at all (as you'd normally expect). The python package is probably available for the case if you want to use the library itself in the python code and use it programmatically. The upstream wiki page seems to concur: https://github.com/BALL-Project/ball/wiki/BALLPythonScripting But I have no idea if these bindings are of any use. We can only know when someone who knows the software well can tell. So I'll echo the same thing you wrote below. Steffen to clarify :- >Upstream does not seem to be active any more but may be Steffen (in >CC) can clarify this.
Bug#1001657: Ball fails its autopkgtest - how to properly deal with sip files?
Hi Étienne, Am Tue, Dec 14, 2021 at 11:13:21PM +0100 schrieb Étienne Mollier: > Étienne Mollier, on 2021-12-14: > > However, once the sip file is caught, the package fails to build > > from source due to various errors in the generated code. The > > patch also addresses one of them in its second hunk. I think I > > was stuck on some "overrides" related errors, but they were > > interleaved within sip output, I can send a proper log later > > this week after an overnight build if needed. > > I forgot I had one other patch to address PyString issues, part > of the ftbfs. And also forgot to mention that I had to enforce > -DSIP_LIBRARIES=/usr/lib/python3/dist-packages from the cmake > call in d/rules. > > In hope this helps, May be you can simply push your patches to make sure everything is stored visibly. What I'm currently wondering is the following: According to popcon[1] python3-ball has 2 votes and its only dependency ballview has 10 votes. This makes no real sense if ballview would really need python3-ball. I'm wondering how we can find out whether ballview really depends the Python3 package or whether we can simply drop it. Upstream does not seem to be active any more but may be Steffen (in CC) can clarify this. Kind regards Andreas. [1] https://qa.debian.org/popcon.php?package=ball -- http://fam-tille.de
Bug#1001657: Ball fails its autopkgtest - how to properly deal with sip files?
Control: tags -1 pending I've fixed the dh_installdocs issue in Git[1] but wanted to solve the autopkgtest issue as well. At first I provided the proper module name[2] which brought me back to the old discussion here: Am Thu, Sep 23, 2021 at 11:59:50PM +0200 schrieb Étienne Mollier: > Hi Nilesh, > > Nilesh Patra, on 2021-09-23: > > The problems that I see on a quick look are: > > 1) the import name is wrong, it should be BALL instead of ball > > this is trivial to fix > > 2) This is the bigger problem. python3-ball is broken, it needed to compile > > the .sip files, to make an so lib > > and import that. This is not happening. Probably fixing this is also not > > hard, just passing SIP_LIBRARY with cmake > > might do the trick, but again no time. > > > > Also, my understanding is that it was always broken, and has got barely > > anything to do with my bug fix. > > Since I am very very short on time, @Etienne, could you please fix this and > > dput? > > Thanks for drawing my attention on this! I can have a look, > sure, although I don't guarantee this will be solved this > evening; it looks like quite the machine cycles hog. It is the > first time I hear about sip, it looks kinda similar to swig. > Will run an overnight build to see if I can manage to do > something with the SIP_LIBRARY environment variable; thanks for > the tip! For whatever reason python3-sip did not ended up in the package dependencies. Thus I added it explicitly[3]. But the autopkg issue remains[4]: autopkgtest [17:09:54]: test autodep8-python3: [--- Testing with python3.9: Traceback (most recent call last): File "", line 1, in File "/usr/lib/python3/dist-packages/BALL.py", line 5, in from BALLCore import * ModuleNotFoundError: No module named 'BALLCore' autopkgtest [17:09:55]: test autodep8-python3: ---] and we have the sip file /usr/lib/python3/dist-packages/BALL/BALLCore.sip I have no idea why this is not found. Kind regards Andreas. [1] https://salsa.debian.org/med-team/ball/-/commit/451bb880214e04c1042fabd19acef30fbf1ede78 [2] https://salsa.debian.org/med-team/ball/-/commit/129417031797d553a3f87a9de5abfd05d6e848c0 [3] https://salsa.debian.org/med-team/ball/-/commit/df9bd210dd6c172563583bc14278cf3bbc0f047b [4] https://salsa.debian.org/med-team/ball/-/jobs/2278393 -- http://fam-tille.de
