Bug#1001870: meshlab: reproducible-builds: BuildId differences triggered by RPATH

2024-03-27 Thread James Addison
Source: meshlab
Followup-For: Bug #1001870
Control: tags -1 pending



Bug#1001870: meshlab: reproducible-builds: BuildId differences triggered by RPATH

2023-12-06 Thread Vagrant Cascadian
On 2021-12-17, Ryan Pavlik wrote:
> Oh wow, thanks! I was trying to figure out why it wasn't reproducible even
> though it "should have" been. I'll apply this soon.
>
> On Fri, Dec 17, 2021, 6:09 PM Vagrant Cascadian <
> vagr...@reproducible-builds.org> wrote:
...
>> The RPATH contains the build path resulting in different buildid:
...
>> The attached patch to debian/rules passes
>> -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via a dh_auto_configure override,
>> which should use a relative path for RPATH.

I see this was committed to git over a year ago:

  
https://salsa.debian.org/science-team/meshlab/-/commit/3ceca5b00a27414fecc489cd6d55483a61fe2d80

... but a new upload has not landed in the archive!

I could sponsor an upload or perform an NMU, if that would be helpful?

live well,
  vagrant


signature.asc
Description: PGP signature


Bug#1001870: meshlab: reproducible-builds: BuildId differences triggered by RPATH

2021-12-17 Thread Ryan Pavlik
Oh wow, thanks! I was trying to figure out why it wasn't reproducible even
though it "should have" been. I'll apply this soon.

On Fri, Dec 17, 2021, 6:09 PM Vagrant Cascadian <
vagr...@reproducible-builds.org> wrote:

> Source: meshlab
> Severity: normal
> Tags: patch
> User: reproducible-bui...@lists.alioth.debian.org
> Usertags: buildpath
> X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
>
> The RPATH contains the build path resulting in different buildid:
>
>
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/meshlab.html
>
> The attached patch to debian/rules passes
> -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via a dh_auto_configure override,
> which should use a relative path for RPATH.
>
> With this patch applied, meshlab should build reproducibly on
> tests.reproducible-builds.org!
>
> Thanks for maintaining meshlab!
>
> live well,
>   vagrant
>


Bug#1001870: meshlab: reproducible-builds: BuildId differences triggered by RPATH

2021-12-17 Thread Vagrant Cascadian
Source: meshlab
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

The RPATH contains the build path resulting in different buildid:

  
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/meshlab.html

The attached patch to debian/rules passes
-DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via a dh_auto_configure override,
which should use a relative path for RPATH.

With this patch applied, meshlab should build reproducibly on
tests.reproducible-builds.org!

Thanks for maintaining meshlab!

live well,
  vagrant
From e6d836f045f54a4626cbcd3691c2eeb6f7254fec Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian 
Date: Fri, 17 Dec 2021 23:59:39 +
Subject: [PATCH] debian/rules: Pass -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via
 dh_auto_configure override.

This avoids embedding the full path in RPATH, which triggers BuildId
differences.

https://tests.reproducible-builds.org/debian/issues/unstable/cmake_rpath_contains_build_path_issue.html
---
 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index 8a7e79be..280884de 100755
--- a/debian/rules
+++ b/debian/rules
@@ -33,6 +33,7 @@ override_dh_auto_configure:
 	 -DALLOW_BUNDLED_OPENCTM=OFF \
 	 -DALLOW_BUNDLED_QHULL=OFF \
 	 -DALLOW_BUNDLED_XERCES=OFF \
+	 -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON \
 
 # Make plugins only "recommends"
 override_dh_shlibdeps:
-- 
2.34.1



signature.asc
Description: PGP signature