Bug#1002570: replace which by command -v in wrapper script

2022-01-08 Thread Carsten Schoenert

Control: tags -1 pending

Hello Jochen,

Am 24.12.21 um 13:14 schrieb Jochen Sprickerhof:

Hi Carsten,

$ thunderbird
/usr/bin/which: this version of `which' is deprecated; use `command -v' in 
scripts instead.

Can you please apply the attached patch to fix this?


thanks for the patch, applied locally and will get included within the 
next upload of an Debian Thunderbird version.


--
Regards
Carsten



Bug#1002570: replace which by command -v in wrapper script

2021-12-24 Thread Jochen Sprickerhof
Package: thunderbird
Version: 1:91.4.1-1
Severity: minor
Tags: patch
X-Debbugs-Cc: jspri...@debian.org

Hi Carsten,

$ thunderbird
/usr/bin/which: this version of `which' is deprecated; use `command -v' in 
scripts instead.

Can you please apply the attached patch to fix this?

Thanks!

Jochen

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.15.0-2-amd64 (SMP w/8 CPU threads)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages thunderbird depends on:
ii  debianutils  5.5-1
ii  fontconfig   2.13.1-4.2
ii  libatk1.0-0  2.36.0-3
ii  libbotan-2-182.18.2+dfsg-1
ii  libbz2-1.0   1.0.8-5
ii  libc62.33-1
ii  libcairo-gobject21.16.0-5
ii  libcairo21.16.0-5
ii  libdbus-1-3  1.12.20-3
ii  libdbus-glib-1-2 0.112-2
ii  libevent-2.1-7   2.1.12-stable-1
ii  libffi8  3.4.2-3
ii  libfontconfig1   2.13.1-4.2
ii  libfreetype6 2.11.0+dfsg-1
ii  libgcc-s111.2.0-13
ii  libgdk-pixbuf-2.0-0  2.42.6+dfsg-2
ii  libglib2.0-0 2.70.2-1
ii  libgtk-3-0   3.24.30-4
ii  libjson-c5   0.15-2
ii  libnspr4 2:4.32-3
ii  libnss3  2:3.73.1-1
ii  libpango-1.0-0   1.48.10+ds1-1
ii  libstdc++6   11.2.0-13
ii  libvpx7  1.11.0-2
ii  libx11-6 2:1.7.2-2+b1
ii  libx11-xcb1  2:1.7.2-2+b1
ii  libxcb-shm0  1.14-3
ii  libxcb1  1.14-3
ii  libxext6 2:1.3.4-1
ii  libxrender1  1:0.9.10-1
ii  psmisc   23.4-2
ii  x11-utils7.7+5
ii  zlib1g   1:1.2.11.dfsg-2

Versions of packages thunderbird recommends:
ii  hunspell-en-us [hunspell-dictionary]  1:2020.12.07-1

Versions of packages thunderbird suggests:
ii  apparmor  3.0.3-6
ii  fonts-lyx 2.3.6-1
ii  libgssapi-krb5-2  1.18.3-7

-- no debconf information
>From 8e004cce32987ea275677b22cfe529623fde1a39 Mon Sep 17 00:00:00 2001
From: Jochen Sprickerhof 
Date: Fri, 24 Dec 2021 13:11:51 +0100
Subject: [PATCH] Use POSIX command -v in wrapper

which is deprecated.
---
 debian/thunderbird-wrapper.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/thunderbird-wrapper.sh b/debian/thunderbird-wrapper.sh
index 13eeec1f9dc..b3f7c2e7b73 100755
--- a/debian/thunderbird-wrapper.sh
+++ b/debian/thunderbird-wrapper.sh
@@ -32,7 +32,7 @@ fi
 
 # some global variables
 MOZ_APP_NAME=thunderbird
-MOZ_APP_LAUNCHER=$(which "$0")
+MOZ_APP_LAUNCHER=$(command -v "$0")
 MOZ_LIBDIR=/usr/lib/${MOZ_APP_NAME}
 ID_PROFILE_FOLDER=${HOME}/.icedove
 TB_PROFILE_FOLDER=${HOME}/.thunderbird
-- 
2.34.1