Bug#1003233: numpy: Please move the BD needed to build the -doc package to Build-Depends-Indep
On 8/01/22 03:23, Sandro Tosi wrote: control: tags -1 +moreinfo There are a lot of build dependencies that are marked with the !nodoc profile Shouldn't all of these be moved to Build-Depends-Indep instead? what would be the advantage of complicating build dependencies setup in d/control? i'd rather optimize for developer time (mine) than for resource-constrained machines. Fair enough, but I don't think that the change here is really invasive and high maintenance, all the nodoc package are moved to BDI That should reduce the package pulled by the buildd has that caused any problem? from what i can see numpy builds just fine on all architectures (where it can build) so none of the buildds have issues building it and there's no benefit in changing how build dependencies are installed I just tried on a (amd64) schroot, currently it requires 1722 MB of build-dependencies to be pulled, versus only 433 MB when using the nodoc profile For some slow architectures, that could take a lot of time and delay the build of other packages And in general I also think this is good practice, especially here where the debian/rules contains indep targets (and also make the package easier to bootstrap on new ports) isnt that the entire purposes of build profiles? Build profiles are only applied by hand, not the buildd. And applying the nodoc profile or building only the arch:any packages is not 100% the same, with the profile, dh_installdocs is a noop and some readme are skipped in the arch:any package too. If you look at https://buildd.debian.org/status/package.php?p=numpy=unstable you would see that on the 3 architectures where numpy is not built (I hand built kfreebsd yesterday), they all complain that they require python3-matplotlib package. python3-matplotlib is only required for the -doc (arch:all) package and matplotlib has troubles on its own to build on these architectures. Moving it (with the rest) to BDI, would probably allow the package to build on these architectures. numpy is creating a build-dependency loop with cython, it means that if numpy is "late" at building (or binNMU, for example a change in python version), it might require a manual build again to break this loop. for now my answer is "there's nothing to change" and close this bug, but i want to hear more That's my take on this
Bug#1003233: numpy: Please move the BD needed to build the -doc package to Build-Depends-Indep
control: tags -1 +moreinfo > There are a lot of build dependencies that are marked with the !nodoc > profile > > Shouldn't all of these be moved to Build-Depends-Indep instead? what would be the advantage of complicating build dependencies setup in d/control? i'd rather optimize for developer time (mine) than for resource-constrained machines. > That should reduce the package pulled by the buildd has that caused any problem? from what i can see numpy builds just fine on all architectures (where it can build) so none of the buildds have issues building it and there's no benefit in changing how build dependencies are installed > (and also make the > package easier to bootstrap on new ports) isnt that the entire purposes of build profiles? for now my answer is "there's nothing to change" and close this bug, but i want to hear more Thanks, -- Sandro "morph" Tosi My website: http://sandrotosi.me/ Me at Debian: http://wiki.debian.org/SandroTosi Twitter: https://twitter.com/sandrotosi
Bug#1003233: numpy: Please move the BD needed to build the -doc package to Build-Depends-Indep
Source: numpy Version: 1:1.21.5-1 Severity: normal Tags: patch Hello, There are a lot of build dependencies that are marked with the !nodoc profile Shouldn't all of these be moved to Build-Depends-Indep instead? That should reduce the package pulled by the buildd (and also make the package easier to bootstrap on new ports) Kind regards, Laurent Bigonville -- System Information: Debian Release: bookworm/sid APT prefers unstable-debug APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 5.15.0-2-amd64 (SMP w/8 CPU threads) Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8), LANGUAGE=fr_BE:fr Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: SELinux: enabled - Mode: Permissive - Policy name: refpolicy commit 88e9936f0efa0aeebec879b4e622b7e5becb9906 Author: Laurent Bigonville Date: Thu Jan 6 18:55:48 2022 +0100 debian/control: Move all the BD marked wity !nodoc to BDI diff --git a/debian/control b/debian/control index e9acc64e..5ad36d83 100644 --- a/debian/control +++ b/debian/control @@ -10,26 +10,26 @@ Build-Depends: cython3 (>= 0.29.24), gfortran, libblas-dev [!arm !m68k], liblapack-dev [!arm !m68k], - python-imageio-doc , - python-matplotlib-doc , - python-pandas-doc , - python-scipy-doc , - python-skimage-doc , python3-all-dev, - python3-doc , python3-hypothesis (>= 5.19.1) , - python3-ipython , - python3-matplotlib , - python3-numpydoc , - python3-pydata-sphinx-theme (>= 0.7.1) , python3-pytest , python3-scipy , - python3-scipy , python3-setuptools, - python3-sphinx (>= 2) , python3-tz , - texlive-latex-base , - texlive-latex-extra , +Build-Depends-Indep: python-imageio-doc , + python-matplotlib-doc , + python-pandas-doc , + python-scipy-doc , + python-skimage-doc , + python3-doc , + python3-ipython , + python3-matplotlib , + python3-numpydoc , + python3-pydata-sphinx-theme (>= 0.7.1) , + python3-scipy , + python3-sphinx (>= 2) , + texlive-latex-base , + texlive-latex-extra , Standards-Version: 4.6.0.1 Vcs-Git: https://salsa.debian.org/python-team/packages/numpy.git Vcs-Browser: https://salsa.debian.org/python-team/packages/numpy
