Bug#1003976: RFS: xmrig/6.16.2-1 [ITP] -- High performance, open source CPU/GPU miner and RandomX benchmark.
Hello, On 5/2/23 5:41 AM, Bastian Germann wrote: Please have a closer look at the Copyright info. I have only had a look at a few files but already found the general copyright header being misrepresented in d/copyright. It has to contain the following names: > [snip] Also, please have a look at the src/backend/opencl/wrappers/AdlLib*, src/base/io/Async.*, src/base/net/http*, src/base/net/stratum/DaemonClient.*, src/base/tools/Cvt.cpp, and src/base/crypto/keccak.* files for additional Copyright info. I have gone back through the entire source and made the copyright info more accurate. Thanks, -- Ben Westover OpenPGP_signature Description: OpenPGP digital signature
Bug#1003976: RFS: xmrig/6.16.2-1 [ITP] -- High performance, open source CPU/GPU miner and RandomX benchmark.
Control: retitle -1 RFS: xmrig/6.16.2+dfsg-1 [ITP] -- High performance, open source CPU/GPU miner and RandomX benchmark. On 4/19/23 7:59 AM, Bastian Germann wrote: I have noticed this is a completely different implementation from the argon2 package in Debian. While there could be a way to patch successfully, it might influence the runtime behaviour significantly, so you can keep the argon2 as-is. Alright. What we have now looks ready to push to Mentors, so I just did. Thanks, -- Ben Westover OpenPGP_signature Description: OpenPGP digital signature
Bug#1003976: RFS: xmrig/6.16.2-1 [ITP] -- High performance, open source CPU/GPU miner and RandomX benchmark.
Am 18.04.23 um 23:48 schrieb Ben Westover: I've pushed what I have so far to Salsa; unless randomx is disabled, it won't build without argon2, and I don't know how to patch it. Can you please help me? I have noticed this is a completely different implementation from the argon2 package in Debian. While there could be a way to patch successfully, it might influence the runtime behaviour significantly, so you can keep the argon2 as-is.
Bug#1003976: RFS: xmrig/6.16.2-1 [ITP] -- High performance, open source CPU/GPU miner and RandomX benchmark.
Hello, On 4/18/23 10:18 AM, Bastian Germann wrote: I looked into this when I first started packaging xmrig. Unfortunately, for many of these third party libraries, Debian's packaging of them won't work because the version included in xmrig is specially modified and contains lots of xmrig-specific functions that aren't easy to work around. For example, many of argon2's functions directly have xmrig in the name, and work a bit differently to those of the original project. The missing thing is hugepages support: https://github.com/xmrig/xmrig/commit/b1db0803cfdcb25fd51cef1df2dba46dc63fb0f7 src/crypto/randomx/dataset.cpp relies on some private argon2 implementation details. But as far as I can see you can just have some definitions to satisfy these needs. Ah, I see. I'm very inexperienced with C(++), so I didn't understand how easy or hard it would be to replace those specifics. Either patch or build with WITH_ARGON2=OFF. I wish I knew how to patch. I would build with argon2 off, but looking at cmake/randomx.cmake it seems like randomx, essential for mining XMR, requires argon2 to be enabled. The source also directly includes headers that exist in the original source but not a packaged version, and which are also modified specifically for xmrig. If I were to get rid of all the third party libraries that don't work easily with Debian's packaged versions, there wouldn't be much xmrig functionality left. The only thing that is not easily replacable from the original list is llhttp. Just keep this one. I have done the trivial replacements for CL, fmt, and rapidjson. hwloc is built with the system library anyway and adl is only used on Windows. Okay, there's my inexperience again. When I was first packaging this, I took a look at argon2 and assumed most of the other libraries were as hard to replace as it. Thanks for showing me how easy it really was. I've pushed what I have so far to Salsa; unless randomx is disabled, it won't build without argon2, and I don't know how to patch it. Can you please help me? Thanks, -- Ben Westover OpenPGP_signature Description: OpenPGP digital signature
Bug#1003976: RFS: xmrig/6.16.2-1 [ITP] -- High performance, open source CPU/GPU miner and RandomX benchmark.
Hello, On 4/17/23 2:13 PM, Bastian Germann wrote: Please see https://salsa.debian.org/cryptocoin-team/xmrig/-/commit/fa8aaf366f7168be3d30ba9c1d7e5fdaf9bb11bb to get an idea of what is to exclude. Please use the Debian replacements for those libraries. adl and libethash are not yet available (see also #1034528), so please build with WITH_KAWPOW=OFF and WITH_ADL=OFF. I looked into this when I first started packaging xmrig. Unfortunately, for many of these third party libraries, Debian's packaging of them won't work because the version included in xmrig is specially modified and contains lots of xmrig-specific functions that aren't easy to work around. For example, many of argon2's functions directly have xmrig in the name, and work a bit differently to those of the original project. The source also directly includes headers that exist in the original source but not a packaged version, and which are also modified specifically for xmrig. If I were to get rid of all the third party libraries that don't work easily with Debian's packaged versions, there wouldn't be much xmrig functionality left. Thanks, -- Ben Westover OpenPGP_signature Description: OpenPGP digital signature
Bug#1003976: RFS: xmrig/6.16.2-1 [ITP] -- High performance, open source CPU/GPU miner and RandomX benchmark.
Hi Bastian, If you submit the package for package maintenance in the Cryptocoin Team, I would be inclined to take a look. That sounds great! I wish I would've known of that team this whole time. I've listed team+cryptoc...@tracker.debian.org as the maintainer in my d/control file, and requested access to the Salsa group. Thanks, -- Ben Westover OpenPGP_signature Description: OpenPGP digital signature
Bug#1003976: RFS: xmrig/6.16.2-1 [ITP] -- High performance, open source CPU/GPU miner and RandomX benchmark.
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "xmrig": * Package name: xmrig Version : 6.16.2-1 Upstream Author : XMRig * URL : https://xmrig.com/ * License : GPL-3 * Vcs : https://salsa.debian.org/benthetechguy/xmrig Section : utils It builds those binary packages: xmrig - High performance, open source CPU/GPU miner and RandomX benchmark. To access further information about this package, please visit the following URL: https://mentors.debian.net/package/xmrig/ Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/x/xmrig/xmrig_6.16.2-1.dsc Changes for the initial release: xmrig (6.16.2-1) unstable; urgency=medium . * Initial Package. * Closes: #1003917 Regards, -- Ben Westover OpenPGP_0xC311C5F54E89B698.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
