Package: debhelper
Version: 13.7.1
Severity: minor
Tags: patch
X-Debbugs-Cc: max-jul...@pogner.at
Dear Maintainer,
I had output of dh_testdir I had not the knowledge to interpret correctly.
Therefore i inspected the source code, among other files also
file usr/share/perl5/Debian/Debhelper/Dh_Lib.pm
there i noticed in line 1994 a "spelling" error; the line is ended with two
semi-colons instead of one.
Original line reads:
> $package_sections{$package} = _strip_spaces($field_values{'section'} //
> $source_section);;
But it shoud read:
> $package_sections{$package} = _strip_spaces($field_values{'section'} //
> $source_section);
I will attach a patch to this bug report.
I think this is a perfect opportunity for me to learn using `reportbug` without
kicking up too much dust. Please consider applying this patch, for spelling
errors are very important to be fixed! :-)
best regards,
Max
-- System Information:
Debian Release: bookworm/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 5.17.0-1-amd64 (SMP w/12 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8),
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages debhelper depends on:
ii autotools-dev 20220109.1
ii dh-autoreconf 20
ii dh-strip-nondeterminism 1.13.0-1
ii dpkg 1.21.7
ii dpkg-dev 1.21.7
ii dwz 0.14-1
ii file 1:5.41-4
ii libdebhelper-perl 13.7.1
ii libdpkg-perl 1.21.7
ii man-db 2.10.2-1
ii perl 5.34.0-4
ii po-debconf 1.0.21+nmu1
debhelper recommends no packages.
Versions of packages debhelper suggests:
pn dh-make <none>
-- no debconf information
>From 63cd06b455adc01718288635aa9350c512f02b5e Mon Sep 17 00:00:00 2001
From: Max-Julian Pogner <max-jul...@pogner.at>
Date: Thu, 5 May 2022 08:55:37 +0200
Subject: [PATCH] Dh_Lib.pm: Fix Double semi-colon in Dh_Lib.pm line 1994
---
lib/Debian/Debhelper/Dh_Lib.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Debian/Debhelper/Dh_Lib.pm b/lib/Debian/Debhelper/Dh_Lib.pm
index 76101783..11053102 100644
--- a/lib/Debian/Debhelper/Dh_Lib.pm
+++ b/lib/Debian/Debhelper/Dh_Lib.pm
@@ -1991,7 +1991,7 @@ sub _parse_debian_control {
$package_types{$package} =
_strip_spaces($field_values{'package-type'} // 'deb');
$package_arches{$package} = $arch;
$package_multiarches{$package} =
_strip_spaces($field_values{'multi-arch'} // '');
- $package_sections{$package} =
_strip_spaces($field_values{'section'} // $source_section);;
+ $package_sections{$package} =
_strip_spaces($field_values{'section'} // $source_section);
$package_cross_type{$package} = $cross_type;
push(@{$packages_by_type{'all-listed-in-control-file'}}, $package);
--
2.35.2
>From 63cd06b455adc01718288635aa9350c512f02b5e Mon Sep 17 00:00:00 2001
From: Max-Julian Pogner <max-jul...@pogner.at>
Date: Thu, 5 May 2022 08:55:37 +0200
Subject: [PATCH] Dh_Lib.pm: Fix Double semi-colon in Dh_Lib.pm line 1994
---
lib/Debian/Debhelper/Dh_Lib.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Debian/Debhelper/Dh_Lib.pm b/lib/Debian/Debhelper/Dh_Lib.pm
index 76101783..11053102 100644
--- a/lib/Debian/Debhelper/Dh_Lib.pm
+++ b/lib/Debian/Debhelper/Dh_Lib.pm
@@ -1991,7 +1991,7 @@ sub _parse_debian_control {
$package_types{$package} =
_strip_spaces($field_values{'package-type'} // 'deb');
$package_arches{$package} = $arch;
$package_multiarches{$package} =
_strip_spaces($field_values{'multi-arch'} // '');
- $package_sections{$package} =
_strip_spaces($field_values{'section'} // $source_section);;
+ $package_sections{$package} =
_strip_spaces($field_values{'section'} // $source_section);
$package_cross_type{$package} = $cross_type;
push(@{$packages_by_type{'all-listed-in-control-file'}}, $package);
--
2.35.2
