Bug#1011241: kodi: Unable to change timezone (Kodi only uses system’s timezone)

2022-05-19 Thread Vasyl Gello
>Thank you so much for your work on packaging Kodi and for dealing with this so 
>quickly

Glad to help!

>I’ll try to build it myself from salsa, but if you can share debs for Kodi 19 
>(in case I’m not able to build it), that’d be great :)

Here you go:

https://transfer.sh/NJmitK/kodi_19.4+dfsg2-2_amd64.deb
https://transfer.sh/NJmitK/kodi-addons-dev_19.4+dfsg2-2_amd64.deb
https://transfer.sh/NJmitK/kodi-addons-dev-common_19.4+dfsg2-2_all.deb
https://transfer.sh/NJmitK/kodi-bin_19.4+dfsg2-2_amd64.deb
https://transfer.sh/NJmitK/kodi-bin-dbgsym_19.4+dfsg2-2_amd64.deb
https://transfer.sh/NJmitK/kodi-data_19.4+dfsg2-2_all.deb
https://transfer.sh/NJmitK/kodi-eventclients-common_19.4+dfsg2-2_all.deb
https://transfer.sh/NJmitK/kodi-eventclients-dev_19.4+dfsg2-2_amd64.deb
https://transfer.sh/NJmitK/kodi-eventclients-dev-common_19.4+dfsg2-2_all.deb
https://transfer.sh/NJmitK/kodi-eventclients-kodi-send_19.4+dfsg2-2_amd64.deb
https://transfer.sh/NJmitK/kodi-eventclients-ps3_19.4+dfsg2-2_amd64.deb
https://transfer.sh/NJmitK/kodi-eventclients-python_19.4+dfsg2-2_amd64.deb
https://transfer.sh/NJmitK/kodi-eventclients-wiiremote_19.4+dfsg2-2_amd64.deb
https://transfer.sh/NJmitK/kodi-eventclients-wiiremote-dbgsym_19.4+dfsg2-2_amd64.deb
https://transfer.sh/NJmitK/kodi-eventclients-zeroconf_19.4+dfsg2-2_amd64.deb
https://transfer.sh/NJmitK/kodi-repository-kodi_19.4+dfsg2-2_all.deb
https://transfer.sh/NJmitK/kodi-tools-texturepacker_19.4+dfsg2-2_amd64.deb
https://transfer.sh/NJmitK/kodi-tools-texturepacker-dbgsym_19.4+dfsg2-2_amd64.deb

I hope Mattia uploads both branches soon anyway, but to double check after me, 
the build is provided.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1011241: kodi: Unable to change timezone (Kodi only uses system’s timezone)

2022-05-19 Thread Vasyl Gello
I pushed both master and experimental branch.

Please let me know if you need prebuilt Debian packages.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1011241: kodi: Unable to change timezone (Kodi only uses system’s timezone)

2022-05-19 Thread Vasyl Gello
Hi Johan!

I fixed the issue! It requires two patches to address two components of the 
same problem:

First is incompletely backported CPosixTimeZone::Init which in upstream reads 
zone.tab
from an embedded resource add-on "resource.timezone". In Debian, however, we 
use system
tzdata and supplementary files.

Second is the ultimate usage of date::current_zone in xbmc/XBDateTime.cpp.

I built Kodi v20 Alpha1 with the new patchset and now both timezone settings 
are active
and wall clock reflect the timezone change.

I am now fixing another bunch of failed tests for v20. After I complete them I 
push the fixes to Salsa
experimental branch. I can also upload v20 or v19 prebuilt for sandbox testing.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1011241: kodi: Unable to change timezone (Kodi only uses system’s timezone)

2022-05-18 Thread Johan Fleury
Hi Vasyl.

Thank you very much for this super quick answer :)

> cdatetime-std-chrono patches fix the issue where too narrow representation of 
> timepoints
> made Kodi unusable if a media item referenced a date before 1902. This 
> patchset is not
> yet merged upstream, but will be in 20.0~alpha2.
> 

> Christian's deb-multimedia builds dont have most patches I added for Kodi 
> from Debian so
> their users still experience the bug, to my knowledge.
> 


Ok, thanks for the explanation. I don’t have media from that long ago, so I 
never faced this bug.

> Let me quickly reproduce an issue and issue a test build for you.
> Are you comfortable installing packages via "dpkg -i" ?

I can run it in a test environment with no access to data, so if you have a 
patch you want me to try don’t hesitate.

You can even send me a git diff output or a patch file and I can rebuild the 
package.

--
Johan Fleury

signature.asc
Description: OpenPGP digital signature


Bug#1011241: kodi: Unable to change timezone (Kodi only uses system’s timezone)

2022-05-18 Thread Vasyl Gello
Hi Johan!

cdatetime-std-chrono patches fix the issue where too narrow representation of 
timepoints
made Kodi unusable if a media item referenced a date before 1902. This patchset 
is not
yet merged upstream, but will be in 20.0~alpha2.

Christian's deb-multimedia builds dont have most patches I added for Kodi from 
Debian so
their users still experience the bug, to my knowledge.

Let me quickly reproduce an issue and issue a test build for you.
Are you comfortable installing packages via "dpkg -i" ?
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

18 травня 2022 р. 16:33:45 UTC, Johan Fleury  написав(-ла):
>Package: kodi
>Version: 2:19.4+dfsg2-1+b1
>Severity: normal
>
>Dear Maintainer,
>
>In Debian’s build of Kodi I’m unable to change timezone and Kodi is stuck with 
>the system timezone (which is set to UTC).
>
>The timezone settings can’t be changed in the UI and the 
>`locale.timezonecountry` and `locale.timezone` settings in 
>`userdata/guisettings.xml` have no effect. I also tried setting the TZ 
>environment variable in Kodi’s systemd service with no luck (I tried multiple 
>values: America/Montreal, America/Toronto, Etc/GMT-4).
>
>I believe this is due to the `cdatetime-std-chrono`’s patches, but I can’t 
>figure what exactly is causing this. My understanding of those patches is that 
>Kodi now uses tzdata (and thus should read the TZ env), but I’m struggling to 
>understand what it actually does and why it’s needed.
>
>Also, just for information, changing timezone from the UI or in the 
>`userdata/guisettings.xml` file works well with deb-multimedia.org’s (dmo) 
>build of Kodi.
>
>-- System Information:
>Debian Release: bookworm/sid
>  APT prefers stable-updates
>  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 
> 'unstable'), (500, 'testing'), (500, 'stable')
>Architecture: amd64 (x86_64)
>
>Kernel: Linux 5.17.0-2-amd64 (SMP w/4 CPU threads; PREEMPT)
>Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
>LANGUAGE=en_US:en
>Shell: /bin/sh linked to /usr/bin/dash
>Init: systemd (via /run/systemd/system)
>LSM: AppArmor: enabled
>
>Versions of packages kodi depends on:
>ii  kodi-bin   2:19.4+dfsg2-1+b1
>ii  kodi-data  2:19.4+dfsg2-1
>
>Versions of packages kodi recommends:
>ii  kodi-repository-kodi [kodi-repository]  2:19.4+dfsg2-1
>un  kodi-visualization-spectrum 
>
>kodi suggests no packages.
>
>-- no debconf information

Bug#1011241: kodi: Unable to change timezone (Kodi only uses system’s timezone)

2022-05-18 Thread Vasyl Gello
Hi Johan!

cdatetime-std-chrono patches fix the issue where too narrow representation of 
timepoints
made Kodi unusable if a media item referenced a date before 1902. This patchset 
is not
yet merged upstream, but will be in 20.0~alpha2.

Christian's deb-multimedia builds dont have most patches I added for Kodi from 
Debian so
their users still experience the bug, to my knowledge.

Let me quickly reproduce an issue and issue a test build for you.
Are you comfortable installing packages via "dpkg -i" ?
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

18 травня 2022 р. 16:33:45 UTC, Johan Fleury  написав(-ла):
>Package: kodi
>Version: 2:19.4+dfsg2-1+b1
>Severity: normal
>
>Dear Maintainer,
>
>In Debian’s build of Kodi I’m unable to change timezone and Kodi is stuck with 
>the system timezone (which is set to UTC).
>
>The timezone settings can’t be changed in the UI and the 
>`locale.timezonecountry` and `locale.timezone` settings in 
>`userdata/guisettings.xml` have no effect. I also tried setting the TZ 
>environment variable in Kodi’s systemd service with no luck (I tried multiple 
>values: America/Montreal, America/Toronto, Etc/GMT-4).
>
>I believe this is due to the `cdatetime-std-chrono`’s patches, but I can’t 
>figure what exactly is causing this. My understanding of those patches is that 
>Kodi now uses tzdata (and thus should read the TZ env), but I’m struggling to 
>understand what it actually does and why it’s needed.
>
>Also, just for information, changing timezone from the UI or in the 
>`userdata/guisettings.xml` file works well with deb-multimedia.org’s (dmo) 
>build of Kodi.
>
>-- System Information:
>Debian Release: bookworm/sid
>  APT prefers stable-updates
>  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 
> 'unstable'), (500, 'testing'), (500, 'stable')
>Architecture: amd64 (x86_64)
>
>Kernel: Linux 5.17.0-2-amd64 (SMP w/4 CPU threads; PREEMPT)
>Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
>LANGUAGE=en_US:en
>Shell: /bin/sh linked to /usr/bin/dash
>Init: systemd (via /run/systemd/system)
>LSM: AppArmor: enabled
>
>Versions of packages kodi depends on:
>ii  kodi-bin   2:19.4+dfsg2-1+b1
>ii  kodi-data  2:19.4+dfsg2-1
>
>Versions of packages kodi recommends:
>ii  kodi-repository-kodi [kodi-repository]  2:19.4+dfsg2-1
>un  kodi-visualization-spectrum 
>
>kodi suggests no packages.
>
>-- no debconf information