Bug#1014594: muse: FTBFS on riscv64
On Fri, 2022-07-08 at 13:46 +, Ileana Dumitrescu wrote: > The attached patch fixes the issue, and I will create a merge request > on the salsa repo at https://salsa.debian.org/multimedia-team/muse. This patch introduces an embedded copy of CheckAtomic.cmake from the extra-cmake-modules package but such copies are against Debian policy. https://wiki.debian.org/EmbeddedCopies Instead the package should build-depend on extra-cmake-modules and add the relevant changes to the cmake files to load the CheckAtomic functionality installed in the extra-cmake-modules package. The ECM documentation mentions how to load the modules. https://api.kde.org/ecm/manual/ecm.7.html You can find examples of packages using ECM via Debian Code Search: https://codesearch.debian.net/search?q=find_package.*ECM=0 -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#1014594: muse: FTBFS on riscv64
Hi Ileana! On 7/8/22 15:46, Ileana Dumitrescu wrote: > The package muse, version 4.1.0-1, has a FTFBS issue for riscv. > (...) > The attached patch fixes the issue, and I will create a merge request on > the salsa repo at https://salsa.debian.org/multimedia-team/muse. Great, thanks for fixing this. Have you submitted your patch upstream as well? I'm seeing a lot of people submitting patches to this mailing list and I really hope these are all also submitted upstream so other distributions can profit from these improvements as well. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
