Bug#1014887: ir-ctl: increase the size of the buffer used to read raw files

2023-12-04 Thread Sean Young 
Hi Gregor, Joe,

On Sun, Dec 03, 2023 at 10:03:05PM +0100, Gregor Jasny wrote:
> Hello Joe,
> 
> thanks for your bug report. I looked through the current code base of ir-ctl
> and saw that Sean committed the following change to increase the limit from
> 1k to 8k:
> 
> > https://git.linuxtv.org/v4l-utils.git/commit/utils/ir-ctl/ir-ctl.c?id=1874b2d0dfbb8a38b0c8b75a23a4b9a60e52fd6a
> 
> Maybe that's already large enough for your use case, too?
> 
> But replacing fgets with getline should be a straight-forward fix to get rid
> of the limit once and for all.
> 
> Sean, what do you think about that replacement and do you have time to work
> on the change?

I did not know about getline(), it's a very nice interface! I've written
a patch for ir-ctl to use it. If you have a chance to test it, that would
be great. 

https://patchwork.linuxtv.org/project/linux-media/patch/20231204085620.81213-1-s...@mess.org/

Thanks,
Sean

Bug#1014887: ir-ctl: increase the size of the buffer used to read raw files

2023-12-03 Thread Gregor Jasny 

Hello Joe,

thanks for your bug report. I looked through the current code base of 
ir-ctl and saw that Sean committed the following change to increase the 
limit from 1k to 8k:



https://git.linuxtv.org/v4l-utils.git/commit/utils/ir-ctl/ir-ctl.c?id=1874b2d0dfbb8a38b0c8b75a23a4b9a60e52fd6a


Maybe that's already large enough for your use case, too?

But replacing fgets with getline should be a straight-forward fix to get 
rid of the limit once and for all.


Sean, what do you think about that replacement and do you have time to 
work on the change?


Thanks,
Gregor