Bug#1017375: liblexical-accessor-perl: test failure with Sub::HandlesVia 0.034

2022-08-17 Thread Damyan Ivanov 
-=| gregor herrmann, 17.08.2022 17:59:41 +0200 |=-
> This should be fixed with libsub-handlesvia-perl 0.035, judging from
> the following upstream commit:
> …
> Also Changes say:
>  - Sub::HandlesVia::CodeGenerator method_installer is now a rw attribute as
>Sub::Accessor::Small was relying on that.
> 
> 
> I'm going to upload libsub-handlesvia-perl now, then we can depend on
> the fixed version to close this bug, I guess?

build-time and run-time dependency version bumped, all tests pass, so 
uploaded.

Thank you for the investigation.


-- Damyan

Bug#1017375: liblexical-accessor-perl: test failure with Sub::HandlesVia 0.034

2022-08-17 Thread gregor herrmann 
On Mon, 15 Aug 2022 05:26:39 +, Damyan Ivanov wrote:

> t/30shv.t fails with:
> 
> Usage: Sub::HandlesVia::CodeGenerator::method_installer(self) at 
> .../lib/Sub/HandlesVia/Toolkit/SubAccessorSmall.pm line 58.
> 
> In version 0.034, Sub::HandlesVia::CodeGenerator's method_installer field 
> is read-only and the above line tries to modify it:
> 
>   $gen->method_installer( sub {
>   my ( $method_name, $coderef ) = @_;
>   my $real_destination = $handles_map->{$method_name};
>   $realattr->install_coderef( $real_destination, $coderef );
>   } );


This should be fixed with libsub-handlesvia-perl 0.035, judging from
the following upstream commit:


commit 8c5799169c61a4c7aec65df51997a42bbecb8bd5
Author: Toby Inkster 
Date:   Fri Aug 12 15:40:49 2022 +0100

Make the CodeGenerator's method_installer an rw attribute

diff --git a/lib/Sub/HandlesVia/CodeGenerator.pm 
b/lib/Sub/HandlesVia/CodeGenerator.pm
index c9d353b..586ca9b 100644
--- a/lib/Sub/HandlesVia/CodeGenerator.pm
+++ b/lib/Sub/HandlesVia/CodeGenerator.pm
@@ -156,7 +156,7 @@ has generator_for_type_assertion => (
 );
 
 has method_installer => (
-   is => ro,
+   is => rw,
isa => 'CodeRef',
 );
 

Also Changes say:
 - Sub::HandlesVia::CodeGenerator method_installer is now a rw attribute as
   Sub::Accessor::Small was relying on that.


I'm going to upload libsub-handlesvia-perl now, then we can depend on
the fixed version to close this bug, I guess?


Cheers,
gregor


-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   


signature.asc
Description: Digital Signature

Bug#1017375: liblexical-accessor-perl: test failure with Sub::HandlesVia 0.034

2022-08-14 Thread Damyan Ivanov 
Package: liblexical-accessor-perl
Version: 0.014-1
Severity: serious
Tags: upstream ftbfs
Justification: fails to build from source (but built successfully in the past)

t/30shv.t fails with:

Usage: Sub::HandlesVia::CodeGenerator::method_installer(self) at 
.../lib/Sub/HandlesVia/Toolkit/SubAccessorSmall.pm line 58.

In version 0.034, Sub::HandlesVia::CodeGenerator's method_installer field 
is read-only and the above line tries to modify it:

$gen->method_installer( sub {
my ( $method_name, $coderef ) = @_;
my $real_destination = $handles_map->{$method_name};
$realattr->install_coderef( $real_destination, $coderef );
} );



-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'stable'), 
(500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.18.0-4-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled