Bug#1019007: rfkill(8): List options for supported device types

2022-09-04 Thread debian
September 3, 2022, 8:05 PM, "Andreas Henriksson"  wrote:
> Your suggested patch changes upstream provided files. Could you please
> submit the patch directly to upstream for review/inclusion?

Thanks, I took it upstream: https://github.com/util-linux/util-linux/issues/1790

--
Tino



Bug#1019007: rfkill(8): List options for supported device types

2022-09-03 Thread Andreas Henriksson
Control: tags -1 + upstream

Hello Tino Schmidt,

On Sat, Sep 03, 2022 at 09:16:42AM +0200, Tino Schmidt wrote:
> Package: rfkill
> Version: 2.33.1-0.1
> Severity: minor
> Tags: patch
[...]

Your suggested patch changes upstream provided files. Could you please
submit the patch directly to upstream for review/inclusion?

Please see
https://github.com/util-linux/util-linux/blob/master/Documentation/howto-contribute.txt

Note: You want to use the correct path in your patch (including
sys-utils) and also use "Signed-off-by" according to
https://wiki.linuxfoundation.org/dco

Regards,
Andreas Henriksson



Bug#1019007: rfkill(8): List options for supported device types

2022-09-03 Thread Tino Schmidt
Package: rfkill
Version: 2.33.1-0.1
Severity: minor
Tags: patch

The manpage of rfkill doesn't list types of supported devices. This report is 
written against rfkill in buster but also affects all current versions included 
in Debian.
Only in EXAMPLES section of the manpage you can have a glance what types might 
be supported, not mentioned that there exist some aliases for wifi and uwb. I 
think the current manpage is therefore incomplete. As far as I've seen it, the 
files which are affected are rfkill.8 and rfkill.8.adoc, so my suggestion is to 
fix the documentation with the attached patch.

-- System Information:
Debian Release: 10.12
  APT prefers oldstable
  APT policy: (500, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-21-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_CRAP
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), 
LANGUAGE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages rfkill depends on:
ii  libc6  2.28-10+deb10u1
ii  libsmartcols1  2.33.1-0.1

rfkill recommends no packages.

rfkill suggests no packages.

-- no debconf information
diff --git a/rfkill.8 b/rfkill.8
index b42abdd..283334b 100644
--- a/rfkill.8
+++ b/rfkill.8
@@ -89,7 +89,7 @@ Listen for rfkill events and display them on stdout.
 .sp
 \fBlist\fP [\fIid\fP|\fItype\fP ...]
 .RS 4
-List the current state of all available devices. The command output format is 
deprecated, see the \fBDESCRIPTION\fP section. It is a good idea to check with 
\fBlist\fP command \fIid\fP or \fItype\fP scope is appropriate before setting 
\fBblock\fP or \fBunblock\fP. Special \fIall\fP type string will match 
everything. Use of multiple \fIID\fP or \fItype\fP arguments is supported.
+List the current state of all available devices. The command output format is 
deprecated, see the \fBDESCRIPTION\fP section. It is a good idea to check with 
\fBlist\fP command \fIid\fP or \fItype\fP scope is appropriate before setting 
\fBblock\fP or \fBunblock\fP. Special \fIall\fP type string will match 
everything. Use of multiple \fIID\fP or \fItype\fP arguments is supported. 
Possible types are all, {wlan | wifi}, bluetooth, {uwb | ultrawideband}, wimax, 
wwan, gps, fm, nfc.
 .RE
 .sp
 \fBblock\fP \fIid\fP|\fItype\fP [...]
diff --git a/rfkill.8.adoc b/rfkill.8.adoc
index d19c7ed..85bcf34 100644
--- a/rfkill.8.adoc
+++ b/rfkill.8.adoc
@@ -50,7 +50,7 @@ Display help text and exit.
 Listen for rfkill events and display them on stdout.
 
 *list* [__id__|__type__ ...]::
-List the current state of all available devices. The command output format is 
deprecated, see the *DESCRIPTION* section. It is a good idea to check with 
*list* command _id_ or _type_ scope is appropriate before setting *block* or 
*unblock*. Special _all_ type string will match everything. Use of multiple 
_ID_ or _type_ arguments is supported.
+List the current state of all available devices. The command output format is 
deprecated, see the *DESCRIPTION* section. It is a good idea to check with 
*list* command _id_ or _type_ scope is appropriate before setting *block* or 
*unblock*. Special _all_ type string will match everything. Use of multiple 
_ID_ or _type_ arguments is supported. Possible types are all, {wlan | wifi}, 
bluetooth, {uwb | ultrawideband}, wimax, wwan, gps, fm, nfc.
 
 **block** __id__|__type__ [...]::
 Disable the corresponding device.