Bug#1019526: gnome-control-center: color management broken after update, segfault

2023-01-03 Thread Mike Gerow
tags 1019526 patch
thanks

Looks like the issue has been addressed upstream
https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1640 with
2893f8e3f9cc94f969a7f2062585aef4161df235 which I'm guessing should
show up when 44 is released.

That said, the patch applies cleanly to 43, so this could be pulled
forward early to address the segfault. Patch attached.
From 2893f8e3f9cc94f969a7f2062585aef4161df235 Mon Sep 17 00:00:00 2001
From: Mohammed Sadiq 
Date: Tue, 15 Nov 2022 16:01:43 +0530
Subject: [PATCH] color: Select first device row only if non-NULL

Otherwise we might read some invalid memory resulting in a crash
---
 panels/color/cc-color-panel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/panels/color/cc-color-panel.c b/panels/color/cc-color-panel.c
index f55fcf93b..42820c798 100644
--- a/panels/color/cc-color-panel.c
+++ b/panels/color/cc-color-panel.c
@@ -1642,7 +1642,8 @@ gcm_prefs_update_device_list_extra_entry (CcColorPanel *prefs)
   gtk_widget_set_visible (prefs->box_devices, first_row != NULL);
 
   /* if we have only one device expand it by default */
-  if (gtk_list_box_get_row_at_index (prefs->list_box, 1) == NULL)
+  if (first_row != NULL &&
+  gtk_list_box_get_row_at_index (prefs->list_box, 1) == NULL)
 cc_color_device_set_expanded (CC_COLOR_DEVICE (first_row), TRUE);
 }
 
-- 
2.39.0.314.g84b9a713c41-goog



Bug#1019526: gnome-control-center: color management broken after update, segfault

2022-09-17 Thread Andrew Chadwick
Package: gnome-control-center
Version: 1:43.0-1
Followup-For: Bug #1019526
X-Debbugs-Cc: a.t.chadw...@gmail.com

Confirmed in 43.0 from sid. The Colour panel segfaults, and Night Light is 
also nonfunctional.


The control panel app is now “sticky”, so if you switch to a panel that 
segfaults and then try to start the app again, it will try to start with 
the panel you were on before. This makes it segfault again immediately, 
preventing access to other control panels.

From a user perspective, to recover from this situation enough to use other 
control panels, you can use the command line to start it on a different 
panel, e.g. Displays:

   $ gnome-control-center display

You can also choose “Display Settings” or “Change Background…” from the 
desktop right button/longpress menu. Those do the same thing 


The crash can be reproduced from the command line with the following.

The “--verbose” option is not necessary to reproduce, it’s just there to 
provide more context. Note the line about the missing NightLightSupported 
property, in passing. I don’t know if the broken night light functionality 
is related or a separate bug. The warning appears when switching to the 
Display panel too, before accessing the Night Light controls card (is that 
the right term?)

$ gnome-control-center --verbose color
01:07:27.0390(null):DEBUG: No extra argument
(gnome-control-center:17422): dconf-DEBUG: 01:07:27.390: change_fast
(gnome-control-center:17422): dconf-DEBUG: 01:07:27.390: change_notify: 
/org/gnome/control-center/last-panel
(gnome-control-center:17422): dconf-DEBUG: 01:07:27.396: watch_fast: 
"/org/freedesktop/color-helper/" (establishing: 0, active: 0)
(gnome-control-center:17422): dconf-DEBUG: 01:07:27.396: unwatch_fast: 
"/org/freedesktop/color-helper/" (active: 0, establishing: 1)
(gnome-control-center:17422): dconf-DEBUG: 01:07:27.396: watch_fast: 
"/org/gnome/settings-daemon/plugins/color/" (establishing: 0, active: 2)
(gnome-control-center:17422): dconf-DEBUG: 01:07:27.396: watch_fast: 
"/org/freedesktop/color-helper/" (establishing: 0, active: 0)
(gnome-control-center:17422): dconf-DEBUG: 01:07:27.397: watch_established: 
"/org/freedesktop/color-helper/" (establishing: 1)
(gnome-control-center:17422): dconf-DEBUG: 01:07:27.397: watch_established: 
"/org/freedesktop/color-helper/" (establishing: 0)
01:07:27.0398 cc-window:DEBUG: Time to open panel 
'Colour': 0.007625s
01:07:27.0398 cc-window:DEBUG: Added 'display' to the 
previous panels
01:07:27.0402  display-cc-panel:  WARNING: Missing property 
'NightLightSupported' on DisplayConfig API
01:07:27.0402 cc-object-storage:DEBUG: Finished creating D-Bus 
proxy for 
CcObjectStorage::dbus-proxy(org.gnome.SettingsDaemon.Color,/org/gnome/SettingsDaemon/Color,org.freedesktop.DBus.Properties)
01:07:27.0402 cc-object-storage:DEBUG: Adding object GDBusProxy 
(CcObjectStorage::dbus-proxy(org.gnome.SettingsDaemon.Color,/org/gnome/SettingsDaemon/Color,org.freedesktop.DBus.Properties)
 → 0x5573e60c44b0) to the storage
01:07:27.0402 cc-object-storage:DEBUG: Finished creating D-Bus 
proxy for 
CcObjectStorage::dbus-proxy(org.gnome.SettingsDaemon.Color,/org/gnome/SettingsDaemon/Color,org.gnome.SettingsDaemon.Color)
01:07:27.0402 cc-object-storage:DEBUG: Adding object GDBusProxy 
(CcObjectStorage::dbus-proxy(org.gnome.SettingsDaemon.Color,/org/gnome/SettingsDaemon/Color,org.gnome.SettingsDaemon.Color)
 → 0x5573e5f3bd10) to the storage
01:07:27.0402  display-cc-panel:DEBUG: setting adjustment 
22.000 to 22:00
01:07:27.0402  display-cc-panel:DEBUG: setting adjustment 7.000 
to 7:00
01:07:27.0402 cc-object-storage:DEBUG: Finished creating D-Bus 
proxy for 
CcObjectStorage::dbus-proxy(org.gnome.Shell,/org/gnome/Shell,org.gnome.Shell)
01:07:27.0403  diagnostics-cc-panel:DEBUG: ABRT vanished
01:07:27.0403  display-cc-panel:DEBUG: setting adjustment 
22.000 to 22:00
01:07:27.0403  display-cc-panel:DEBUG: setting adjustment 7.000 
to 7:00
Segmentation fault

-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (900, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (5, 'unstable'), (1, 'experimental-debug'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.19.0-1-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_USER
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages gnome-control-center depends on:
ii  accountsservice   22.08.8-1
ii  apg   2.2.3.dfsg.1-5+b2
ii  colord1.4.6-1
ii  desktop-base  

Bug#1019526: gnome-control-center: color management broken after update, segfault

2022-09-15 Thread Li ShXlin
On Sun, 11 Sep 2022 12:48:08 +0500 Alexandr Podgorniy
 wrote:
> Package: gnome-control-center
> Version: 1:43~rc-2
> Severity: normal
> X-Debbugs-Cc: sca...@scaledteam.ru
> 
> Color management menu in gnome-control-center led to segfault. Also,
color
> management broken in entire system, applications ignore color
profiles.
> 
> GDB says folowing:
> 
> Thread 1 "gnome-control-c" received signal SIGSEGV, Segmentation
fault.
> cc_color_device_set_expanded (color_device=0x0, expanded=1) at
> ../panels/color/cc-color-device.c:161
> warning: Source file is more recent than executable.
> 161   if (color_device->expanded == expanded)
> 
> 
> -- System Information:
> Debian Release: bookworm/sid
>   APT prefers testing
>   APT policy: (500, 'testing')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
> 
> Kernel: Linux 5.19.0-1-amd64 (SMP w/16 CPU threads; PREEMPT)
> Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_USER,
TAINT_OOT_MODULE
> Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8),
LANGUAGE not set
> Shell: /bin/sh linked to /usr/bin/dash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled
> 
> Versions of packages gnome-control-center depends on:
> ii  accountsservice   22.08.8-1
> ii  apg   2.2.3.dfsg.1-5+b2
> ii  colord    1.4.6-1
> ii  desktop-base  11.0.3
> ii  desktop-file-utils    0.26-1
> ii  gnome-control-center-data 1:43~rc-2
> ii  gnome-desktop3-data   43~alpha-3
> ii  gnome-settings-daemon 43~rc-1
> ii  gsettings-desktop-schemas 43~alpha-1
> ii  libaccountsservice0   22.08.8-1
> ii  libadwaita-1-0    1.2~beta-1
> ii  libc6 2.34-7
> ii  libcairo2 1.16.0-6
> ii  libcolord-gtk4-1  0.3.0-3
> ii  libcolord2    1.4.6-1
> ii  libcups2  2.4.2-1+b1
> ii  libepoxy0 1.5.10-1
> ii  libfontconfig1    2.13.1-4.4
> ii  libgcr-base-3-1   3.41.1-1
> ii  libgdk-pixbuf-2.0-0   2.42.9+dfsg-1
> ii  libglib2.0-0  2.73.3-3
> ii  libgnome-bg-4-2   43~alpha-3
> ii  libgnome-bluetooth-ui-3.0-13  42.3-3
> ii  libgnome-desktop-4-2  43~alpha-3
> ii  libgnome-rr-4-2   43~alpha-3
> ii  libgnutls30   3.7.7-2
> ii  libgoa-1.0-0b 3.45.2-2
> ii  libgoa-backend-1.0-1  3.45.2-2

I also lose the night light.
:(



Bug#1019526: gnome-control-center: color management broken after update, segfault

2022-09-11 Thread Jeremy Bicha
Control: severity -1 important

On Sun, Sep 11, 2022 at 3:51 AM Alexandr Podgorniy  wrote:
> Color management menu in gnome-control-center led to segfault. Also, color
> management broken in entire system, applications ignore color profiles.

This will be fixed when we update mutter and gnome-shell to 43~rc
which will likely happen soon.

Thank you,
Jeremy Bicha



Bug#1019526: gnome-control-center: color management broken after update, segfault

2022-09-11 Thread Alexandr Podgorniy
Package: gnome-control-center
Version: 1:43~rc-2
Severity: normal
X-Debbugs-Cc: sca...@scaledteam.ru

Color management menu in gnome-control-center led to segfault. Also, color
management broken in entire system, applications ignore color profiles.

GDB says folowing:

Thread 1 "gnome-control-c" received signal SIGSEGV, Segmentation fault.
cc_color_device_set_expanded (color_device=0x0, expanded=1) at
../panels/color/cc-color-device.c:161
warning: Source file is more recent than executable.
161   if (color_device->expanded == expanded)


-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.19.0-1-amd64 (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_USER, TAINT_OOT_MODULE
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages gnome-control-center depends on:
ii  accountsservice   22.08.8-1
ii  apg   2.2.3.dfsg.1-5+b2
ii  colord1.4.6-1
ii  desktop-base  11.0.3
ii  desktop-file-utils0.26-1
ii  gnome-control-center-data 1:43~rc-2
ii  gnome-desktop3-data   43~alpha-3
ii  gnome-settings-daemon 43~rc-1
ii  gsettings-desktop-schemas 43~alpha-1
ii  libaccountsservice0   22.08.8-1
ii  libadwaita-1-01.2~beta-1
ii  libc6 2.34-7
ii  libcairo2 1.16.0-6
ii  libcolord-gtk4-1  0.3.0-3
ii  libcolord21.4.6-1
ii  libcups2  2.4.2-1+b1
ii  libepoxy0 1.5.10-1
ii  libfontconfig12.13.1-4.4
ii  libgcr-base-3-1   3.41.1-1
ii  libgdk-pixbuf-2.0-0   2.42.9+dfsg-1
ii  libglib2.0-0  2.73.3-3
ii  libgnome-bg-4-2   43~alpha-3
ii  libgnome-bluetooth-ui-3.0-13  42.3-3
ii  libgnome-desktop-4-2  43~alpha-3
ii  libgnome-rr-4-2   43~alpha-3
ii  libgnutls30   3.7.7-2
ii  libgoa-1.0-0b 3.45.2-2
ii  libgoa-backend-1.0-1  3.45.2-2
ii  libgsound01.0.3-2
ii  libgtk-3-03.24.34-3
ii  libgtk-4-14.7.2+ds-3
ii  libgtop-2.0-112.40.0-2
ii  libgudev-1.0-0237-2
ii  libibus-1.0-5 1.5.27-2
ii  libkrb5-3 1.20-1
ii  libmalcontent-0-0 0.10.5-1
ii  libmm-glib0   1.18.10-1
ii  libnm01.40.0-1
ii  libnma-gtk4-0 1.8.40-1
ii  libpango-1.0-01.50.9+ds-1
ii  libpangocairo-1.0-0   1.50.9+ds-1
ii  libpolkit-gobject-1-0 0.105-33
ii  libpulse-mainloop-glib0   15.0+dfsg1-4+b1
ii  libpulse0 15.0+dfsg1-4+b1
ii  libpwquality1 1.4.4-1+b1
ii  libsecret-1-0 0.20.5-3
ii  libsmbclient  2:4.16.5+dfsg-1
ii  libsnapd-glib11.60-1
ii  libudisks2-0  2.9.4-3
ii  libupower-glib3   0.99.20-1
ii  libwacom9 2.4.0-3
ii  libx11-6  2:1.8.1-2
ii  libxi62:1.8-1
ii  libxml2   2.9.14+dfsg-1+b1
ii  webp-pixbuf-loader0.0.5-5

Versions of packages gnome-control-center recommends:
ii  cracklib-runtime  2.9.6-4+b1
ii  cups-pk-helper0.2.6-1+b1
ii  gkbd-capplet  3.28.0-1
ii  gnome-bluetooth-sendto42.3-3
ii  gnome-online-accounts 3.45.2-2
ii  gnome-remote-desktop  42.4-1
ii  gnome-user-docs   42.0-1
ii  gnome-user-share  43~alpha-1
ii  iso-codes 4.11.0-1
ii  libcanberra-pulse 0.30-10
ii  libnss-myhostname 251.4-3
ii  malcontent-gui0.10.5-1
ii  network-manager-gnome 1.28.0-1
ii  policykit-1   0.105-33
ii  power-profiles-daemon 0.12-1
ii  pulseaudio-module-bluetooth   15.0+dfsg1-4+b1
ii  realmd0.17.0-2
ii  rygel 0.40.4-1
ii  rygel-tracker 0.40.4-1
ii  system-config-printer-common  1.5.16-1

Versions of packages gnome-control-center suggests:
pn  gnome-software | gnome-packagekit  
ii  gstreamer1.0-pulseaudio1.20.3-1
ii  x11-xserver-utils  7.7+9

-- no debconf information