Bug#1020714: [pkg-cryptsetup-devel] Bug#1020714: cryptsetup: cryptroot-* autopkgtests fall-back to shell and hang on errors
Hi, On 01-10-2022 00:57, Guilhem Moulin wrote: Haven't uploaded 2:2.5.0-4 yet Oops. (Wanted to say "sorry for the noise", but you thanked for the reminder, so that would be silly.) Paul OpenPGP_signature Description: OpenPGP digital signature
Bug#1020714: [pkg-cryptsetup-devel] Bug#1020714: cryptsetup: cryptroot-* autopkgtests fall-back to shell and hang on errors
Hi elbrus, On Fri, 30 Sep 2022 at 21:38:50 +0200, Paul Gevers wrote: > On Mon, 26 Sep 2022 19:35:44 +0200 Paul Gevers wrote: >> Assuming it works as intended, that's exactly what I was looking for, yes. > > Seems it doesn't always work. Haven't uploaded 2:2.5.0-4 yet as I was traveling this week; will do that early next week. Thanks for the reminder :-) Cheers -- Guilhem. signature.asc Description: PGP signature
Bug#1020714: cryptsetup: cryptroot-* autopkgtests fall-back to shell and hang on errors
Hi, On Mon, 26 Sep 2022 19:35:44 +0200 Paul Gevers wrote: Assuming it works as intended, that's exactly what I was looking for, yes. Seems it doesn't always work. Paul cryptsetup 2:2.5.0-3: https://ci.debian.net/data/autopkgtest/testing/amd64/c/cryptsetup/26543429/log.gz The partition table has been altered. Calling ioctl() to re-read partition table. [1.624663] vda: vda1 vda2 vda3 vda4 vda5 Syncing disks. + echo -n topsecret + cryptsetup luksFormat --batch-mode --key-file=/rootfs.key --type=luks2 --pbkdf=argon2id --pbkdf-force-iterations=4 --pbkdf-memory=32 -- /dev/vda5 [1.628795] vda: vda1 vda2 vda3 vda4 vda5 Device /dev/vda5 does not exist or access denied. + echo ALERT! Couldn't setup system, dropping to a shell. ALERT! Couldn't setup system, dropping to a shell. + sh -i # autopkgtest [12:05:15]: ERROR: timed out on command [...] OpenPGP_signature Description: OpenPGP digital signature
Bug#1020714: cryptsetup: cryptroot-* autopkgtests fall-back to shell and hang on errors
Hi Guilhem, On 26-09-2022 16:58, Guilhem Moulin wrote: This is pretty bad for our infrastructure as normally your test is much faster and it shouldn't wait for the time out. Can you please fix that? Very sorry for that! Don't worry too much, those things happen. It's the fast response I appreciate. At https://salsa.debian.org/cryptsetup-team/cryptsetup/-/commit/cc175feed03319b2544382699e812fe7c67fd0ee I also added a timeout on each qemu command so failed setups won't wait for the global debci timeout. Hope this is an acceptable fix from your perspective :-) Assuming it works as intended, that's exactly what I was looking for, yes. Paul OpenPGP_signature Description: OpenPGP digital signature
Bug#1020714: cryptsetup: cryptroot-* autopkgtests fall-back to shell and hang on errors
Control: tag -1 pending Hi Paul, On Sun, 25 Sep 2022 at 20:09:09 +0200, Paul Gevers wrote: > However, the reason for that long run was not the failure itself, but > the fact that your tests drop to shell on error and apparently waits > for user input. One failure with 2:2.5.0-3 in unstable has the same > problem. > > This is pretty bad for our infrastructure as normally your test is > much faster and it shouldn't wait for the time out. Can you please fix > that? Very sorry for that! That specific error was caused by a race condition after partitioning (the test was trying to use the partition before the block device was created) and is fixed in https://salsa.debian.org/cryptsetup-team/cryptsetup/-/commit/39e9cb8baf69f1b126a636026883569317adf7fb . At https://salsa.debian.org/cryptsetup-team/cryptsetup/-/commit/cc175feed03319b2544382699e812fe7c67fd0ee I also added a timeout on each qemu command so failed setups won't wait for the global debci timeout. Hope this is an acceptable fix from your perspective :-) Cheers -- Guilhem. signature.asc Description: PGP signature
Bug#1020714: cryptsetup: cryptroot-* autopkgtests fall-back to shell and hang on errors
Source: cryptsetup Version: 2:2.5.0-2 Severity: serious Dear maintainer, I was starting at some 14 hour failures in testing [1] due to merged-/usr, which apparently you already fixed in unstable. However, the reason for that long run was not the failure itself, but the fact that your tests drop to shell on error and apparently waits for user input. One failure with 2:2.5.0-3 in unstable has the same problem. This is pretty bad for our infrastructure as normally your test is much faster and it shouldn't wait for the time out. Can you please fix that? Paul [1] https://ci.debian.net/packages/c/cryptsetup/testing/amd64/ https://ci.debian.net/data/autopkgtest/unstable/amd64/c/cryptsetup/26349209/log.gz The partition table has been altered. Calling ioctl() to re-read partition table. [1.904096] vda: vda1 vda2 vda3 vda4 vda5 Syncing disks. + echo -n topsec[1.908756] vda: vda1 vda2 vda3 vda4 vda5 ret + cryptsetup luksFormat --batch-mode --key-file=/rootfs.key --type=luks2 --pbkdf=argon2id --pbkdf-force-iterations=4 --pbkdf-memory=32 -- /dev/vda5 Device /dev/vda5 does not exist or access denied. + echo ALERT! Couldn't setup system, dropping to a shell. ALERT! Couldn't setup system, dropping to a shell. + sh -i # autopkgtest [19:14:06]: ERROR: timed out on command "su -s /bin/bash root -c set -e; export USER=`id -nu`; . /etc/profile >/dev/null 2>&1 || true; . ~/.profile >/dev/null 2>&1 || true; buildtree="/tmp/autopkgtest-lxc.6pwp9hgu/downtmp/build.q7w/src"; mkdir -p -m 1777 -- "/tmp/autopkgtest-lxc.6pwp9hgu/downtmp/cryptroot-sysvinit-artifacts"; export AUTOPKGTEST_ARTIFACTS="/tmp/autopkgtest-lxc.6pwp9hgu/downtmp/cryptroot-sysvinit-artifacts"; export ADT_ARTIFACTS="$AUTOPKGTEST_ARTIFACTS"; mkdir -p -m 755 "/tmp/autopkgtest-lxc.6pwp9hgu/downtmp/autopkgtest_tmp"; export AUTOPKGTEST_TMP="/tmp/autopkgtest-lxc.6pwp9hgu/downtmp/autopkgtest_tmp"; export ADTTMP="$AUTOPKGTEST_TMP"; export DEBIAN_FRONTEND=noninteractive; export LANG=C.UTF-8; export DEB_BUILD_OPTIONS=parallel=64; unset LANGUAGE LC_CTYPE LC_NUMERIC LC_TIME LC_COLLATE LC_MONETARY LC_MESSAGES LC_PAPER LC_NAME LC_ADDRESS LC_TELEPHONE LC_MEASUREMENT LC_IDENTIFICATION LC_ALL;rm -f /tmp/autopkgtest_script_pid; set -C; echo $$ > /tmp/autopkgtest_script_pid; set +C; trap "rm -f /tmp/autopkgtest_script_pid" EXIT INT QUIT PIPE; cd "$buildtree"; export AUTOPKGTEST_NORMAL_USER=debci; export ADT_NORMAL_USER=debci; chmod +x /tmp/autopkgtest-lxc.6pwp9hgu/downtmp/build.q7w/src/debian/tests/cryptroot-sysvinit; touch /tmp/autopkgtest-lxc.6pwp9hgu/downtmp/cryptroot-sysvinit-stdout /tmp/autopkgtest-lxc.6pwp9hgu/downtmp/cryptroot-sysvinit-stderr; /tmp/autopkgtest-lxc.6pwp9hgu/downtmp/build.q7w/src/debian/tests/cryptroot-sysvinit 2> >(tee -a /tmp/autopkgtest-lxc.6pwp9hgu/downtmp/cryptroot-sysvinit-stderr >&2) > >(tee -a /tmp/autopkgtest-lxc.6pwp9hgu/downtmp/cryptroot-sysvinit-stdout);" (kind: test)
