Bug#1021287: mk-origtargz: empty directories left when using Files-Included

2022-10-04 Thread Olek Wojnar
If it helps, the empty directory tag from lintian is: 
https://lintian.debian.org/tags/package-contains-empty-directory


I'm not sure how many, if any, of the packages currently triggering the 
tag are related to this bug in mk-origtargz.


OpenPGP_signature
Description: OpenPGP digital signature


Bug#1021287: mk-origtargz: empty directories left when using Files-Included

2022-10-04 Thread Olek Wojnar
Package: devscripts
Version: 2.22.2
Severity: normal

Dear Maintainer,

While using the Files-Included functionality for the first time, I noticed
that linitian was giving me errors about empty directories in my package.
Upon investigation, I realized that the Files-Included process was only
removing the *files* in Files-Excluded directories that had a nested
Files-Included stanza, but leaving the empty sub-directories in place.

For example, assume a d/copyright with:
Files-Excluded: removesome
Files-Included: removesome/keepme

and the following directory structure:
removesome/
removesome/file1
removesome/subdir/
removesome/subdir/file2
removesome/keepme/
removesome/keepme/file3

Currently, the following will be kept:
removesome/
removesome/subdir/
removesome/keepme/
removesome/keepme/file3

However, I believe that the expected behavior of the tool should result in
only the following kept:
removesome/
removesome/keepme/
removesome/keepme/file3

Looking into the relevant source code, I noticed that testGoVendorIncludeIgnore
was *expecting* the empty directory to be left behind. I believe this is an
error in the test. I suggested a fix [1] but, unfortunately, I don't know Perl
well enough to submit a fix to the root issue.

That being said, I'm happy to help in any other way. Thanks in advance for
looking into this issue!

-Olek

[1] https://salsa.debian.org/debian/devscripts/-/merge_requests/285