Bug#1021353: RFS: zvbi/0.2.37-1 -- Vertical Blanking Interval (VBI) utilities
Hi! > The symbols look wrong: > Defining and leaking basic syscall wrappers suggests something is pretty wrong. Running a readelf -s on libzvbi.so.0 does not show the exporting of these functions, but libzvbi-chains.so does export these functions. I looked into why this was and found the answer in src/chains.c and daemon/chains.c: "This is a small wrapper which executes the VBI application given on the command line while overloading several C library calls (such as open(2) and read(2)) so that the application can be forced to access VBI devices via the VBI proxy instead of device files directly." So, exporting these functions is required for the proxy to work with applications that do not implement zvbi's proxy interface. I can add these symbols to the libzvbi0.symbols file or suppress the dpkg-gensymbols warning, as these functions are not part of the main library's public interface. Note that this symbols issue has appeared in previous upstream releases as well. So I will suppress the dpkg-gensymbols diff to avoid future confusion. > Also: you may drop the lsb-base Depends altogether; lintian will complain > until its next release but if you know the future you can avoid changing the > same thing twice :) > An upstreamish issue but since you might have a way to contact upstream: > W: libzvbi-dev: national-encoding [usr/include/libzvbi.h] > As we don't even support ancient encodings anymore, everyone who reads the > header will get mojibake. Could you please convert everything to UTF-8? Thank you for the feedback and for sponsoring! I am the upstream maintainer so I just made both these changes and uploaded an updated package to mentors :) I should have noticed the encoding warning but only ran lintian on the source .deb package. Ileana Dumitrescu GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354
Bug#1021353: RFS: zvbi/0.2.37-1 -- Vertical Blanking Interval (VBI) utilities
On Thu, Oct 06, 2022 at 05:11:17PM +0300, Ileana Dumitrescu wrote: > * Package name : zvbi >Version : 0.2.37-1 >Upstream contact : Ileana Dumitrescu > zvbi (0.2.37-1) unstable; urgency=medium > . >[ Ileana Dumitrescu ] >* New upstream release. >* debian/control: updated maintainer email, project homepage > bumped Standards-Version to 4.6.1 (no changes) >* debian/copyright: updated debian copyright year, upstream contact, source >updated licensing >* debian/patches: removed all patches (fixed in upstream) >* debian/rules: README.md in override_dh_installdocs >override_dh_autoreconf to run autogen.sh >* debian/watch: switched to new upstream repo location > . >[ Debian Janitor ] >* debian/control: Use secure URI in Homepage field >- Remove constraints unnecessary since buster (oldstable): > + libzvbi-dev: Drop versioned constraint on libzvbi0 in Replaces. > + libzvbi-doc: Drop versioned constraint on libzvbi-dev in Replaces. > + zvbi: Drop versioned constraint on lsb-base in Depends. Hi! The symbols look wrong: dpkg-gensymbols: warning: some new symbols appeared in the symbols file: see diff output below dpkg-gensymbols: warning: debian/libzvbi0/DEBIAN/symbols doesn't match completely debian/libzvbi0.symbols --- debian/libzvbi0.symbols (libzvbi0_0.2.37_amd64) +++ dpkg-gensymbolsRQLkMF 2022-10-07 10:00:48.055446695 + @@ -12,13 +12,18 @@ _vbi_strndup@Base 0.2.35 _vbi_vasprintf@Base 0.2.35 _zvbi_intl_domainname@Base 0.2.35 + close@Base 0.2.37 device_close@Base 0.2.35 device_ioctl@Base 0.2.35 device_mmap@Base 0.2.35 device_munmap@Base 0.2.35 device_open@Base 0.2.35 + fcntl@Base 0.2.37 fprint_symbolic@Base 0.2.35 fprint_unknown_ioctl@Base 0.2.35 + ioctl@Base 0.2.37 + open@Base 0.2.37 + read@Base 0.2.37 vbi_capture_delete@Base 0.2.35 vbi_capture_fd@Base 0.2.35 vbi_capture_flush@Base 0.2.35 @@ -72,6 +77,7 @@ vbi_proxy_msg_stop_listen@Base 0.2.35 vbi_proxy_msg_write@Base 0.2.35 vbi_proxy_msg_write_idle@Base 0.2.35 + write@Base 0.2.37 libzvbi.so.0 libzvbi0 #MINVER# __vbi_event_handler_list_send@Base 0.2.35 _vbi3_bit_slicer_destroy@Base 0.2.35 Defining and leaking basic syscall wrappers suggests something is pretty wrong. Also: you may drop the lsb-base Depends altogether; lintian will complain until its next release but if you know the future you can avoid changing the same thing twice :) An upstreamish issue but since you might have a way to contact upstream: W: libzvbi-dev: national-encoding [usr/include/libzvbi.h] As we don't even support ancient encodings anymore, everyone who reads the header will get mojibake. Could you please convert everything to UTF-8? Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ ⢿⡄⠘⠷⠚⠋⠀ You're alive. But that's just a phase. ⠈⠳⣄
Bug#1021353: RFS: zvbi/0.2.37-1 -- Vertical Blanking Interval (VBI) utilities
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "zvbi": * Package name : zvbi Version : 0.2.37-1 Upstream contact : Ileana Dumitrescu * URL : https://github.com/zapping-vbi/zvbi * License : LGPL-2+, MIT, GPL-2+, LGPL-2.1+, GPL-2+ or BSD-3-Clause, GPL-2, BSD-2-Clause * Vcs : https://salsa.debian.org/debian/zvbi Section : devel The source builds the following binary packages: libzvbi0 - Vertical Blanking Interval decoder (VBI) - runtime files libzvbi-dev - Vertical Blanking Interval decoder (VBI) - development files libzvbi-common - Vertical Blanking Interval decoder (VBI) - common files libzvbi-doc - Vertical Blanking Interval decoder (VBI) - documentation files zvbi - Vertical Blanking Interval (VBI) utilities To access further information about this package, please visit the following URL: https://mentors.debian.net/package/zvbi/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/z/zvbi/zvbi_0.2.37-1.dsc Changes since the last upload: zvbi (0.2.37-1) unstable; urgency=medium . [ Ileana Dumitrescu ] * New upstream release. * debian/control: updated maintainer email, project homepage bumped Standards-Version to 4.6.1 (no changes) * debian/copyright: updated debian copyright year, upstream contact, source updated licensing * debian/patches: removed all patches (fixed in upstream) * debian/rules: README.md in override_dh_installdocs override_dh_autoreconf to run autogen.sh * debian/watch: switched to new upstream repo location . [ Debian Janitor ] * debian/control: Use secure URI in Homepage field - Remove constraints unnecessary since buster (oldstable): + libzvbi-dev: Drop versioned constraint on libzvbi0 in Replaces. + libzvbi-doc: Drop versioned constraint on libzvbi-dev in Replaces. + zvbi: Drop versioned constraint on lsb-base in Depends. Regards, -- Ileana Dumitrescu GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354
