Bug#1023143: RFS: xfce4-calculator-plugin/0.7.1-1 [ITP] -- calculator plugin for Xfce panel
On Tue, Nov 1, 2022 at 9:29 AM Wookey wrote: > You may feel that, but I disagree. Good descriptions, both long and > short, are important. Imagine somone reading through a list of our > thousands of packages (who maybe never have even _heard_ of XFCE) when > writing descriptions. The description needs to tell them enough to > decide whether or not they might want to install this thing. Hmm, I can see how a user running `apt search ...` could get a wrong impression after reading the long description if it's incomplete or poorly written. > I've been using XFCE daily for 20 years and I'm still asking for a > more useful description because I _don't_ know what this package > is/does. What you've said above is pretty good, and I've now actually > tried it, so I came up with this: > > "An XFCE desktop panel plugin, which provides a 'paper mode' style calculator > as a box in the panel." Woah, that sounds good. Apart from the 'paper mode'. Sorry but I have no idea what that's supposed to mean. Perhaps something like: "This plugin places a resizable text entry box, where you can enter mathematical operations to calculate, on the Xfce panel. Common operators (+, -, *, /, ^) with usual precedence rules and a number of functions, including but not limited to abs(x), sqrt(x), sin(x) and cos(x) are supported. An adjustable number of recent operations are saved in history and can be accessed in a drop-down list." could also work? Do you think it describes the package and its features reasonably well? In any case, thanks for the inspiration! > The important distinction here is between something that launches a > desktop calculator or something that provides a box in the panel that > will do calculations. It sounds from what you have said that it is the > latter (and I have just installed it to check that that is indeed the case). > I was actually a lot more excited about it when I thought it was a > quick way to keep something like galculator to hand. Well, it'd just be a launcher in that case and users can already add launchers to their panels. However, I can see how users unfamiliar with Xfce might get confused. > That'll be the best way to work out what was intended. Done. Let's wait for their answer. I'll update the package accordingly. Thanks.
Bug#1023143: RFS: xfce4-calculator-plugin/0.7.1-1 [ITP] -- calculator plugin for Xfce panel
On 2022-11-01 08:57 +0500, Akbarkhon Variskhanov wrote: > On Mon, Oct 31, 2022 at 7:02 PM Wookey wrote: > > The description could be more useful. > > "The plugin supports common mathematical operators (+, -, *, /, ^) with > > usual > > precedence rules, and some common functions such as abs(x), sqrt(x), sin(x) > > and cos(x)." > > If it were possible, I wouldn't even write a long description for this > package. I feel like repeating what's already there in the short > description is counter-productive, You may feel that, but I disagree. Good descriptions, both long and short, are important. Imagine somone reading through a list of our thousands of packages (who maybe never have even _heard_ of XFCE) when writing descriptions. The description needs to tell them enough to decide whether or not they might want to install this thing. > and Xfce panel plugins are Xfce > panel plugins. They depend on having xfce4-panel and anyone who's ever > used Xfce knows where their panel is, what their panel has. Besides, > I'm completely lost as to what else I can say here (aka lacking > creativity). It is an Xfce panel plugin (determined by its name > already), provides a calculator functionality on the Xfce panel > (again, it's in the name). Hence, I've been using XFCE daily for 20 years and I'm still asking for a more useful description because I _don't_ know what this package is/does. What you've said above is pretty good, and I've now actually tried it, so I came up with this: "An XFCE desktop panel plugin, which provides a 'paper mode' style calculator as a box in the panel." The important distinction here is between something that launches a desktop calculator or something that provides a box in the panel that will do calculations. It sounds from what you have said that it is the latter (and I have just installed it to check that that is indeed the case). I was actually a lot more excited about it when I thought it was a quick way to keep something like galculator to hand. > > It needs to say what this _is_. Perhaps something like > > "Provides on-screen calculator from toolbar", then details as above. > > would be wrong, and even with corrections, pointless and/or duplicated info. That fact that I got it wrong after reading your ITP and examining the packaging illustrates the need for the description to clarify what the package actually is/does. > Let me contact upstream for their explanation and rationale for > including LGPL in the source tree. That'll be the best way to work out what was intended. Wookey -- Principal hats: Debian, Wookware, ARM http://wookware.org/ signature.asc Description: PGP signature
Bug#1023143: RFS: xfce4-calculator-plugin/0.7.1-1 [ITP] -- calculator plugin for Xfce panel
Hi. Thanks a lot for your review and hints. On Mon, Oct 31, 2022 at 7:02 PM Wookey wrote: > The description could be more useful. > "The plugin supports common mathematical operators (+, -, *, /, ^) with usual > precedence rules, and some common functions such as abs(x), sqrt(x), sin(x) > and cos(x)." If it were possible, I wouldn't even write a long description for this package. I feel like repeating what's already there in the short description is counter-productive, and Xfce panel plugins are Xfce panel plugins. They depend on having xfce4-panel and anyone who's ever used Xfce knows where their panel is, what their panel has. Besides, I'm completely lost as to what else I can say here (aka lacking creativity). It is an Xfce panel plugin (determined by its name already), provides a calculator functionality on the Xfce panel (again, it's in the name). Hence, > It needs to say what this _is_. Perhaps something like > "Provides on-screen calculator from toolbar", then details as above. would be wrong, and even with corrections, pointless and/or duplicated info. > I'd add Adrian Dimitrov to the copyright list Nice catch! Surprisingly, neither `debmake` nor `licensecheck` listed Adrian Dimitrov. I'm not sure why, though. It looks like he's only involved in panel-plugins/calculator.c. Manual grepping doesn't reveal any more copyright holders, and unfortunately the test suite is also authorless. I also did a big whoopsie and forgot to include debian/* and myself in the copyright file. I'll fix these. > and the package includes the LGPL COPYING.LIB at top level, although it's not > obvious if that actually applies to any of the code. > If it does then the LGPL should be listed (maybe you already checked this?). To be honest, I struggle with such things a bit. Let me contact upstream for their explanation and rationale for including LGPL in the source tree. Cheers, Akbar.
Bug#1023143: RFS: xfce4-calculator-plugin/0.7.1-1 [ITP] -- calculator plugin for Xfce panel
On 2022-10-30 21:54 +0500, Akbarkhon Variskhanov wrote: > Package: sponsorship-requests > Severity: wishlist > > Dear mentors, > > I am looking for a sponsor for my package "xfce4-calculator-plugin": > > * Package name : xfce4-calculator-plugin >Version : 0.7.1-1 >Upstream contact : > https://gitlab.xfce.org/panel-plugins/xfce4-calculator-plugin/-/project_members > * URL : > https://docs.xfce.org/panel-plugins/xfce4-calculator-plugin/start > * License : GPL-2.0+ > * Vcs : [fill in URL of packaging vcs] >Section : xfce Thanks for packaging this. > The source builds the following binary packages: > > xfce4-calculator-plugin - calculator plugin for Xfce panel The description could be more useful. "The plugin supports common mathematical operators (+, -, *, /, ^) with usual precedence rules, and some common functions such as abs(x), sqrt(x), sin(x) and cos(x)." It needs to say what this _is_. Perhaps something like "Provides on-screen calculator from toolbar", then details as above. I'd add Adrian Dimitrov to the copyright list and the package includes the LGPL COPYING.LIB at top level, although it's not obvious if that actually applies to any of the code. If it does then the LGPL should be listed (maybe you already checked this?). Otherwise it looks fine. Wookey -- Principal hats: Debian, Wookware, ARM http://wookware.org/ signature.asc Description: PGP signature
Bug#1023143: RFS: xfce4-calculator-plugin/0.7.1-1 [ITP] -- calculator plugin for Xfce panel
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "xfce4-calculator-plugin": * Package name : xfce4-calculator-plugin Version : 0.7.1-1 Upstream contact : https://gitlab.xfce.org/panel-plugins/xfce4-calculator-plugin/-/project_members * URL : https://docs.xfce.org/panel-plugins/xfce4-calculator-plugin/start * License : GPL-2.0+ * Vcs : [fill in URL of packaging vcs] Section : xfce The source builds the following binary packages: xfce4-calculator-plugin - calculator plugin for Xfce panel To access further information about this package, please visit the following URL: https://mentors.debian.net/package/xfce4-calculator-plugin/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/x/xfce4-calculator-plugin/xfce4-calculator-plugin_0.7.1-1.dsc Changes for the initial release: xfce4-calculator-plugin (0.7.1-1) UNRELEASED; urgency=low . * Initial release. Closes: #850459 Regards,
