Bug#1023825: btrbk: don't put example config in /etc

2022-11-12 Thread Christoph Anton Mitterer
On Sat, 2022-11-12 at 16:38 +0100, Axel Burri wrote:

> Have a look at the deb package, and location looks fine for me:
> ./etc/btrbk/btrbk.conf.example

Well but my point is, that I think in Debian it shouldn't be there, but
rater in:
/usr/share/doc/examples/btrbk.conf  (no .example then).



> This is moved around by debhelper [1], the btrbk Makefile clearly
> moves 
> it to /etc/btrbk/btrbk.conf.example [2].

Yes, I think [2] is the reason why [1] puts it there, but it's not
really a configuration file, just an example for it.

Also it's registered as such:
# cat /var/lib/dpkg/info/btrbk.conffiles 
/etc/btrbk/btrbk.conf.example

However, the example itself is never a (dpkg-)conffile, if people copy
it to the real btrbk.conf than /etc/btrbk/btrbk.conf.example is still
none, and if they move it there it's even a missing (dpkg-)conffile.

I'm not a policy or debhelper expert (surely not), but I think this
should be installed via dh_installexamples(1).


If you should agree, be careful though, cause the file is now already
"registered" as (dpkg-)conffile (which means dpkg wants to handle it).

This often causes obsolete conffiles, when packages change from a
(dpkg-)conffile to a "normal" (non-dpkg-handled) configuration file (at
the same pathname).
But since this wouldn't be the case here, I guess no problems should
await.

Yet, it might be better if you'd test upgrading first on some test
system.



Thanks,
Chris.



Bug#1023825: btrbk: don't put example config in /etc

2022-11-12 Thread Axel Burri
This is moved around by debhelper [1], the btrbk Makefile clearly moves 
it to /etc/btrbk/btrbk.conf.example [2].


I'm a bit puzzeled here, so either this is the default/correct place to 
have it.


[1] https://github.com/digint/btrbk-packaging/blob/debian/debian/rules
[2] https://github.com/digint/btrbk/blob/v0.32.5/Makefile#L69


Have a look at the deb package, and location looks fine for me:

ar x btrbk_0.32.5-1_all.deb
root@debian:/tmp# tar --list -f data.tar.xz
./
./etc/
./etc/btrbk/
./etc/btrbk/btrbk.conf.example
[...]





On 10/11/2022 17.25, Christoph Anton Mitterer wrote:

Package: btrbk
Version: 0.32.5-1
Severity: wishlist


Hey.

Typically, most package seem to put example configuration
like /etc/btrbk/btrbk.conf.example rather into
/usr/share/doc//examples

Cheers,
Chris.




Bug#1023825: btrbk: don't put example config in /etc

2022-11-10 Thread Christoph Anton Mitterer
Package: btrbk
Version: 0.32.5-1
Severity: wishlist


Hey.

Typically, most package seem to put example configuration
like /etc/btrbk/btrbk.conf.example rather into
/usr/share/doc//examples

Cheers,
Chris.