Bug#1025779: onetbb: Please add patch to add support for ia64
[John Paul Adrian Glaubitz] > Ports architectures do not affect the propagation of packages to > testing. > > So, feel free to ignore the tests on ia64. Ah, good point. Part of the reason I do not want to introduce new architectures is that I am just a drive-by team member looking at the package for a brief moment in time, and believe such change, introducing debian-specific patches for extra architectures, is better left to someone looking after the package in the long run. I only look at onetbb to fix a freecad propagation issue. :) > FWIW, I have also a patch that I sent upstream that fixes powerpc, but > I need to clean it up again before upstream accepts it. I hope upstream fixes these issues. :) -- Happy hacking Petter Reinholdtsen
Bug#1025779: onetbb: Please add patch to add support for ia64
Hello Petter! On Thu, 2023-08-03 at 15:56 +0200, Petter Reinholdtsen wrote: > [John Paul Adrian Glaubitz] > > If you feel fixing this, you can use yttrium.debian.net. > > > > I don't have much time for ia64 at the moment. > > Thanks. I just wanted to check the status and hopefully reduce the > amount of open bugs. I do not plan to increase the number of > architectures provided at this time, in case it will make it harder for > the package to propagate into testing. Ports architectures do not affect the propagation of packages to testing. So, feel free to ignore the tests on ia64. FWIW, I have also a patch that I sent upstream that fixes powerpc, but I need to clean it up again before upstream accepts it. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Bug#1025779: onetbb: Please add patch to add support for ia64
[John Paul Adrian Glaubitz] > If you feel fixing this, you can use yttrium.debian.net. > > I don't have much time for ia64 at the moment. Thanks. I just wanted to check the status and hopefully reduce the amount of open bugs. I do not plan to increase the number of architectures provided at this time, in case it will make it harder for the package to propagate into testing. -- Happy hacking Petter Reinholdtsen
Bug#1025779: onetbb: Please add patch to add support for ia64
Hi Petter! On Thu, 2023-08-03 at 09:28 +0200, Petter Reinholdtsen wrote: > [Petter Reinholdtsen] > > Perhaps you can provide more information now the patched code is > > upstream? > > Note, the latest version fail during testing in > https://buildd.debian.org/status/fetch.php?pkg=onetbb=ia64=2021.9.0-2=1691031827=0 > >: > > > 87% tests passed, 18 tests failed out of 136 > > The failing tests segfaults. Could the issue be data type alignment? > ia64 will segfault on unaligned data access. If you feel fixing this, you can use yttrium.debian.net. I don't have much time for ia64 at the moment. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Bug#1025779: onetbb: Please add patch to add support for ia64
[Petter Reinholdtsen] > Perhaps you can provide more information now the patched code is > upstream? Note, the latest version fail during testing in https://buildd.debian.org/status/fetch.php?pkg=onetbb=ia64=2021.9.0-2=1691031827=0 >: > 87% tests passed, 18 tests failed out of 136 The failing tests segfaults. Could the issue be data type alignment? ia64 will segfault on unaligned data access. -- Happy hacking Petter Reinholdtsen
Bug#1025779: onetbb: Please add patch to add support for ia64
Control: forwarded -1 https://github.com/oneapi-src/oneTBB/pull/983 A fix for this was applied upstream in commit 55b8e1b1671dbc66f7d192e4163a3df2941c7efd 2023-01-09, according to the upstream pull request. [M. Zhou] > I'm not sure whether the latest assembly code in > https://github.com/oneapi-src/oneTBB/pull/983 > would avoid those segfaults, so tagging this bug > with moreinfo. Perhaps you can provide more information now the patched code is upstream? -- Happy hacking Petter Reinholdtsen
Bug#1025779: onetbb: Please add patch to add support for ia64
Control: tag -1 +moreinfo I have tried exactly the same patch half a year ago, which resulted a massive number of segmentation faults. Build log can be found in our buildd. See https://github.com/oneapi-src/oneTBB/issues/777 I'm not sure whether the latest assembly code in https://github.com/oneapi-src/oneTBB/pull/983 would avoid those segfaults, so tagging this bug with moreinfo.
Bug#1025779: onetbb: Please add patch to add support for ia64
Source: onetbb Version: 2021.7.0-1 Severity: normal Tags: patch User: debian-i...@lists.debian.org Usertags: ia64 X-Debbugs-Cc: debian-i...@lists.debian.org Hello! The attached patch defines fetchadd4() on ia64 where it's currently undefined which leads to the following build error: FAILED: src/tbbmalloc/CMakeFiles/tbbmalloc.dir/__/tbb/itt_notify.cpp.o /usr/bin/c++ -D__TBBMALLOC_BUILD -D__TBB_USE_ITT_NOTIFY -I/<>/src/tbbmalloc/../../include -g -O2 -ffile-prefix-map=/<>=. -specs=/usr/share/dpkg/pie-compile.specs -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -flto=auto -fno-fat-lto-objects -fPIC -flifetime-dse=1 -fno-rtti -fno-exceptions -std=c++11 -MD -MT src/tbbmalloc/CMakeFiles/tbbmalloc.dir/__/tbb/itt_notify.cpp.o -MF src/tbbmalloc/CMakeFiles/tbbmalloc.dir/__/tbb/itt_notify.cpp.o.d -o src/tbbmalloc/CMakeFiles/tbbmalloc.dir/__/tbb/itt_notify.cpp.o -c /<>/src/tbb/itt_notify.cpp In file included from /<>/src/tbb/tools_api/ittnotify_static.c:17, from /<>/src/tbb/itt_notify.cpp:43: /<>/src/tbb/tools_api/ittnotify_config.h: In function ‘long int __itt_interlocked_increment(volatile long int*)’: /<>/src/tbb/tools_api/ittnotify_config.h:370:12: error: ‘__TBB_machine_fetchadd4’ was not declared in this scope 370 | return __TBB_machine_fetchadd4(ptr, 1) + 1L; |^~~ Could you include the patch for the next upload? I've also opened a PR upstream [1]. Thanks, Adrian > [1] https://github.com/oneapi-src/oneTBB/pull/983 -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 --- onetbb-2021.7.0.orig/src/tbb/tools_api/ittnotify_config.h +++ onetbb-2021.7.0/src/tbb/tools_api/ittnotify_config.h @@ -345,7 +345,7 @@ ITT_INLINE long __itt_interlocked_increm #ifdef __INTEL_COMPILER #define __TBB_machine_fetchadd4(addr, val) __fetchadd4_acq((void *)addr, val) #else /* __INTEL_COMPILER */ -/* TODO: Add Support for not Intel compilers for IA-64 architecture */ +#define __TBB_machine_fetchadd4(addr, val) __sync_fetch_and_add(addr, val) #endif /* __INTEL_COMPILER */ #elif ITT_ARCH==ITT_ARCH_IA32 || ITT_ARCH==ITT_ARCH_IA32E /* ITT_ARCH!=ITT_ARCH_IA64 */ ITT_INLINE long
