Bug#1026639: rhino FTBFS

2023-02-13 Thread Markus Koschany
I believe I have corrected all regressions except of one in closure-compiler
which I will fix later today (renamed class). It turned out that I had to
update the Manifest file and include another META-INF file,
javax.script.ScriptEngineFactory, to solve some FTBFS in reverse-dependencies.
This is the downside of just using javahelper. You have to be extra careful to
include everything that ant or gradle will do "automagically" for you. I'm
going to upload rhino 1.7.14 now.


signature.asc
Description: This is a digitally signed message part


Bug#1026639: rhino FTBFS

2023-02-13 Thread Markus Koschany
Am Montag, dem 13.02.2023 um 11:04 +0100 schrieb Markus Koschany:
> preserve-backward-compatibility.patch

To answer my own question. Yes, this is still needed otherwise closure-compiler
starts to FTBFS



signature.asc
Description: This is a digitally signed message part


Bug#1026639: rhino FTBFS

2023-02-13 Thread Adrian Bunk
On Mon, Feb 13, 2023 at 11:04:38AM +0100, Markus Koschany wrote:
>...
> I don't really like to use gradle for a key package.
>...

FTR, gradle is already a key package:
libxi -> asciidoc -> fop -> mockito -> gradle

> Markus

cu
Adrian



Bug#1026639: rhino FTBFS

2023-02-13 Thread Markus Koschany
Am Montag, dem 13.02.2023 um 12:14 +0200 schrieb Adrian Bunk:
> On Mon, Feb 13, 2023 at 11:04:38AM +0100, Markus Koschany wrote:
> > ...
> > I don't really like to use gradle for a key package.
> > ...
> 
> FTR, gradle is already a key package:
> libxi -> asciidoc -> fop -> mockito -> gradle

I know. That's what I want to change in the future.


signature.asc
Description: This is a digitally signed message part


Bug#1026639: rhino FTBFS

2023-02-13 Thread Markus Koschany
Am Montag, dem 13.02.2023 um 09:33 +0100 schrieb Emmanuel Bourg:
> I don't think this should be assigned to rhino. ckeditor should
> open the internal packages it touches.

I'm currently working on rhino. I have packaged 1.7.14 now. I haven't looked
into ckeditor yet but it seems we have to upgrade rhino anyway. At least
openrefine fails with a silent error when rendering javascript in its webapp
and there may be other errors with OpenJDK 17. Fortunately rhino has no build
dependencies on other packages. However I had to change the way how we build
the package because upstream removed support for ant and I don't really like to
use gradle for a key package. Hence I am using just javahelper now which seems
to work fine. I'm a bit confused about all the old rhino patches. script-
engine.patch is included in the sources now, but I'm not not sure if we still
need the others like preserve-backward-compatibility. Right now I am rebuilding
everything with ratt. There is a build failure with libapache-poi-java. I'm
going to upload my current work to Git.

Markus


signature.asc
Description: This is a digitally signed message part


Bug#1026639: rhino FTBFS

2023-02-13 Thread Emmanuel Bourg

I don't think this should be assigned to rhino. ckeditor should
open the internal packages it touches.



Bug#1026639: rhino FTBFS

2023-02-12 Thread Markus Koschany
Control: owner -1 !




signature.asc
Description: This is a digitally signed message part