Bug#1028163: sshfs-fuse bug
El 7/2/23 a las 4:04, Steven Robbins escribió: On Sunday, February 5, 2023 7:04:26 P.M. CST Santiago Vila wrote: The tests do not even *run* on the buildds, because they are skipped. Indeed! I must have skipped over that output :-) But I think the larger point remains: there is no build failure in practice. What is different in your environment that makes it fail? The difference is that my environment is actually able to load the kernel modules required to run the tests. So, the ordinary user who wants to rebuild the package with or without changes will be able to run the tests and they will see that it does not work at all (command "ssh" is used for the tests and there is not even a build-depends on openssh-client!). My feeling is that the usual maintainers for this package have never built this correctly in a chroot using dpkg-buildpackage in a clean chroot, or maybe they have always used pbuilder and never noticed that the tests are skipped. I'm changing my suggestion to disable the tests which do not work using "@pytest.mark.skip", as there would still be the problem of using ssh and requiring a build-depends. The most simple and effective way to fix this (at this point of the release cycle) is to skip the tests altogether for everybody, as in the attached patch. Dear maintainers: Would be possible to apply the attached patch? (temporarily disable the tests until we find a way to do it right). (Cc: to all people who did an upload in the last two years). Thanks.--- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +sshfs-fuse (3.7.3-2) unstable; urgency=medium + + * Temporarily disable test suite until we can do it right. Closes: #1028163. + + -- Dmitry Smirnov Tue, 07 Feb 2023 11:00:00 +0100 + sshfs-fuse (3.7.3-1) unstable; urgency=medium * New upstream release. --- a/debian/rules +++ b/debian/rules @@ -10,6 +10,6 @@ override_dh_auto_clean: rm -rf test/__pycache__ test/.pytest_cache override_dh_auto_test: -ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) - python3 -m pytest test/ -endif +# ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) +# python3 -m pytest test/ +# endif
Bug#1028163: sshfs-fuse bug
On Sunday, February 5, 2023 7:04:26 P.M. CST Santiago Vila wrote: > El 5/2/23 a las 21:54, Steven Robbins escribió: > > the test manifestly runs fine on buildds > > Actually, that's not really true. > > The tests do not even *run* on the buildds, because they are skipped. Indeed! I must have skipped over that output :-) But I think the larger point remains: there is no build failure in practice. What is different in your environment that makes it fail? -Steve signature.asc Description: This is a digitally signed message part.
Bug#1028163: sshfs-fuse bug
El 5/2/23 a las 21:54, Steven Robbins escribió: the test manifestly runs fine on buildds Actually, that's not really true. The tests do not even *run* on the buildds, because they are skipped. Take this one for example: https://buildd.debian.org/status/fetch.php?pkg=sshfs-fuse=amd64=3.7.3-1=1670232073=0 test/test_sshfs.py::test_sshfs[True-True-0-False] SKIPPED (FUSE kern...) [ 6%] test/test_sshfs.py::test_sshfs[True-True-0-True] SKIPPED (FUSE kerne...) [ 12%] test/test_sshfs.py::test_sshfs[True-True-1-False] SKIPPED (FUSE kern...) [ 18%] test/test_sshfs.py::test_sshfs[True-True-1-True] SKIPPED (FUSE kerne...) [ 25%] test/test_sshfs.py::test_sshfs[True-False-0-False] SKIPPED (FUSE ker...) [ 31%] test/test_sshfs.py::test_sshfs[True-False-0-True] SKIPPED (FUSE kern...) [ 37%] test/test_sshfs.py::test_sshfs[True-False-1-False] SKIPPED (FUSE ker...) [ 43%] test/test_sshfs.py::test_sshfs[True-False-1-True] SKIPPED (FUSE kern...) [ 50%] test/test_sshfs.py::test_sshfs[False-True-0-False] SKIPPED (FUSE ker...) [ 56%] test/test_sshfs.py::test_sshfs[False-True-0-True] SKIPPED (FUSE kern...) [ 62%] test/test_sshfs.py::test_sshfs[False-True-1-False] SKIPPED (FUSE ker...) [ 68%] test/test_sshfs.py::test_sshfs[False-True-1-True] SKIPPED (FUSE kern...) [ 75%] test/test_sshfs.py::test_sshfs[False-False-0-False] SKIPPED (FUSE ke...) [ 81%] test/test_sshfs.py::test_sshfs[False-False-0-True] SKIPPED (FUSE ker...) [ 87%] test/test_sshfs.py::test_sshfs[False-False-1-False] SKIPPED (FUSE ke...) [ 93%] test/test_sshfs.py::test_sshfs[False-False-1-True] SKIPPED (FUSE ker...) [100%] and also: SKIPPED [16] test/test_sshfs.py:33: FUSE kernel module does not seem to be loaded Those tests are being skipped in the buildds at least since version 2.10+repack-2. Thanks.
Bug#1028163: sshfs-fuse bug
El 5/2/23 a las 21:54, Steven Robbins escribió: There are a couple of odd things about this bug. First: it doesn't seem like an RC bug because the test manifestly runs fine on buildds -- see https://buildd.debian.org/status/package.php?p=sshfs-fuse The package is trying to access the network. This is considered RC even if it works in the official buildds. Second: the bug log shows python 3.9.2 is used. That hasn't been the default python since 2021 -- so it's an unusual test environment. Maybe I was reporting the failure in bullseye (because packages in stable must build in stable). Here is a recent build log from January in bookworm. Thanks. sshfs-fuse_3.7.3-1_amd64-20230112T160950.844Z.gz Description: application/gzip
Bug#1028163: sshfs-fuse bug
There are a couple of odd things about this bug. First: it doesn't seem like an RC bug because the test manifestly runs fine on buildds -- see https://buildd.debian.org/status/package.php?p=sshfs-fuse I'd suggest to downgrade the bug on this basis. Second: the bug log shows python 3.9.2 is used. That hasn't been the default python since 2021 -- so it's an unusual test environment. -Steve signature.asc Description: This is a digitally signed message part.
