Bug#1028447: cdist: unusable with python 3.11

2023-01-15 Thread Steve Langasek
On Sun, Jan 15, 2023 at 09:09:05PM +0100, Axel Beckert wrote:
> Dear Steve,

> Steve Langasek wrote:
> > > [1] https://code.ungleich.ch/ungleich-public/cdist/commit/b974969f28f4

> > Well, that's not the upstream repo listed in debian/copyright,

> JFTR:
> https://salsa.debian.org/debian/cdist/-/blob/debian/7.0.0-1/debian/upstream/metadata
> already had the up to date upstream VCS repo at the time you wrote the
> bug report. And that's the _canonical_ (sic!) place to look for the
> upstream VCS repo.

It absolutely is not.  Many packages that declare a Vcs URI in
debian/control don't provide upstream branches at all; those that do, do not
generally have any jobs in place to automatically sync from upstream; and
it's the nature of git that in the absence of looking at the content of such
a job, you do not know where the actual upstream is or whether the branch is
up to date with respect to it.

The only standard way to declare a pointer to upstream is in
debian/copyright, and that pointer pointed at a repo that had not been
updated.

Y'all are free to do what you want with this package, but it's in no way my
obligation to go hunting around for upstream git repos declared elsewhere.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: PGP signature


Bug#1028447: cdist: unusable with python 3.11

2023-01-15 Thread Nico Schottelius


Good evening everyone,

Axel Beckert  writes:

> Hi,
>
> Steve Langasek wrote:
>> On Sun, Jan 15, 2023 at 10:10:54AM +0100, s3v wrote:
>> > > Anyway, this package has no maintainer and upstream has not fixed this, 
>> > > and
>> > > there are no reverse-dependencies, so I would suggest the package should
>> > > just be removed.
>
> That's IMHO way too harsh given that the package is uptodate with the
> current upstream release despite being orphaned and the issue is
> easily fixable.

I agree and it has been fixed some weeks ago.

>> > Unless I missed something, upstream fixed this issue in [1]
>> > After applying this commit, I was able to build cdist in a sid
>> > chroot environment.
>>
>> > [1] https://code.ungleich.ch/ungleich-public/cdist/commit/b974969f28f4
>>
>> Well, that's not the upstream repo listed in debian/copyright, so if someone
>> wants to fix this bug perhaps they also want to fix the upstream pointer.
>
> Ack, https://github.com/telmich/cdist redirects to
> https://github.com/ungleich/cdist, but last commit there is from
> November 2021 and there's no note that it's no more updated.

So, that's a funky problem, I know. We moved away from github, long,
long time ago (probably 2021, that's why you see the last commit there).

However some in the cdist community wanted to keep the git repo on
github alive to allow easier contributions. As this did not really
materialise, we might actually delete and/or redirect that repo to
code.ungleich.ch, too.

> Funnily https://code.ungleich.ch/ungleich-public/cdist/#contributing
> refers to https://github.com/ungleich/cdist/pulls

Yes, it says "both" for contributing, but it does not say "we keep the
github repo updated". But yes, I can see how this might be confusing.

Again, the proper upstream URL is
https://code.ungleich.ch/ungleich-public/cdist/
and actually we also have a shiny website on...

https://www.cdi.st/

which references only the upstream repo.

> I'll take upstream into Cc so they're aware of these upstream
> infrastructure issues misleading users into thinking that upstream's
> development has stalled.

Much appreciated. I added to my todo list to replace the master branch
on github with a pointer to code.ungleich.ch, referencing this thread.

> I might also do a QA upload fixing these issues. No promises though,
> as I'm a bit out of time these days.

Thanks a lot Axel, much appreciated.

Best regards from Paris,

Nico

--
Sustainable and modern Infrastructures by ungleich.ch



Bug#1028447: cdist: unusable with python 3.11

2023-01-15 Thread Axel Beckert
Dear Steve,

Steve Langasek wrote:
> > [1] https://code.ungleich.ch/ungleich-public/cdist/commit/b974969f28f4
> 
> Well, that's not the upstream repo listed in debian/copyright,

JFTR:
https://salsa.debian.org/debian/cdist/-/blob/debian/7.0.0-1/debian/upstream/metadata
already had the up to date upstream VCS repo at the time you wrote the
bug report. And that's the _canonical_ (sic!) place to look for the
upstream VCS repo.

> so if someone wants to fix this bug perhaps they also want to fix
> the upstream pointer.

Will update the URL in debian/copyright, too, yes.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE



Bug#1028447: cdist: unusable with python 3.11

2023-01-15 Thread Axel Beckert
Hi,

Steve Langasek wrote:
> On Sun, Jan 15, 2023 at 10:10:54AM +0100, s3v wrote:
> > > Anyway, this package has no maintainer and upstream has not fixed this, 
> > > and
> > > there are no reverse-dependencies, so I would suggest the package should
> > > just be removed.

That's IMHO way too harsh given that the package is uptodate with the
current upstream release despite being orphaned and the issue is
easily fixable.

> > Unless I missed something, upstream fixed this issue in [1]
> > After applying this commit, I was able to build cdist in a sid
> > chroot environment.
> 
> > [1] https://code.ungleich.ch/ungleich-public/cdist/commit/b974969f28f4
> 
> Well, that's not the upstream repo listed in debian/copyright, so if someone
> wants to fix this bug perhaps they also want to fix the upstream pointer.

Ack, https://github.com/telmich/cdist redirects to
https://github.com/ungleich/cdist, but last commit there is from
November 2021 and there's no note that it's no more updated.

Funnily https://code.ungleich.ch/ungleich-public/cdist/#contributing
refers to https://github.com/ungleich/cdist/pulls

I'll take upstream into Cc so they're aware of these upstream
infrastructure issues misleading users into thinking that upstream's
development has stalled.

I might also do a QA upload fixing these issues. No promises though,
as I'm a bit out of time these days.

Regards, Axel (original author of Debian's cdist package)
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE



Bug#1028447: cdist: unusable with python 3.11

2023-01-15 Thread Steve Langasek
On Sun, Jan 15, 2023 at 10:10:54AM +0100, s3v wrote:
> > It looks like this is easily fixable without regression by removing the
> > first assignment to parser['scan'], but this seems like such an obvious bug
> > that I don't know if I'm missing something with historical behavior of
> > argparse handling multiple assignments?

> > Anyway, this package has no maintainer and upstream has not fixed this, and
> > there are no reverse-dependencies, so I would suggest the package should
> > just be removed.

> Unless I missed something, upstream fixed this issue in [1]
> After applying this commit, I was able to build cdist in a sid
> chroot environment.

> [1] https://code.ungleich.ch/ungleich-public/cdist/commit/b974969f28f4

Well, that's not the upstream repo listed in debian/copyright, so if someone
wants to fix this bug perhaps they also want to fix the upstream pointer.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: PGP signature


Bug#1028447: cdist: unusable with python 3.11

2023-01-15 Thread s3v
Dear Maintainer,

On Tue, 10 Jan 2023 21:45:19 -0800 Steve Langasek 
 wrote:

> It looks like this is easily fixable without regression by removing the
> first assignment to parser['scan'], but this seems like such an obvious bug
> that I don't know if I'm missing something with historical behavior of
> argparse handling multiple assignments?
>
> Anyway, this package has no maintainer and upstream has not fixed this, and
> there are no reverse-dependencies, so I would suggest the package should
> just be removed.
 
Unless I missed something, upstream fixed this issue in [1]
After applying this commit, I was able to build cdist in a sid
chroot environment.

Kind Regards

[1] https://code.ungleich.ch/ungleich-public/cdist/commit/b974969f28f4



Bug#1028447: cdist: unusable with python 3.11

2023-01-10 Thread Steve Langasek
Package: cdist
Version: 7.0.0-1
Severity: grave
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu lunar

The cdist package is broken with python 3.11, as detected by the
autopkgtest:

$ cdist 
Traceback (most recent call last):
  File "/usr/bin/cdist", line 93, in 
commandline()
  File "/usr/bin/cdist", line 53, in commandline
parser, cfg = cdist.argparse.parse_and_configure(sys.argv[1:])
  
  File "/usr/lib/python3/dist-packages/cdist/argparse.py", line 534, in 
parse_and_configure
parser = get_parsers()
 ^
  File "/usr/lib/python3/dist-packages/cdist/argparse.py", line 478, in 
get_parsers
parser['scan'] = parser['sub'].add_parser(
 ^
  File "/usr/lib/python3.11/argparse.py", line 1197, in add_parser
raise ArgumentError(self, _('conflicting subparser: %s') % name)
argparse.ArgumentError: argument command: conflicting subparser: scan
$

It looks like this is easily fixable without regression by removing the
first assignment to parser['scan'], but this seems like such an obvious bug
that I don't know if I'm missing something with historical behavior of
argparse handling multiple assignments?

Anyway, this package has no maintainer and upstream has not fixed this, and
there are no reverse-dependencies, so I would suggest the package should
just be removed.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: PGP signature