Bug#1029084: closed by Debian FTP Masters (reply to Bdale Garbee ) (Bug#1029084: fixed in cpmtools 2.23-1)
Control: reopen -1 On Sun, Jan 29, 2023 at 09:31:02AM -0700, Bdale Garbee wrote: > Hrm. As I DH'ified the package, I really thought that part of your > patch would no longer be relevant. What I didn't realize is that your > bug about not stripping in dh_auto_install wasn't implemented until > compat 11, and the source package was still declaring 10. So .. I've It actually is more nuanced. compat > 10 is part of the story, but the other part is using the makefile buildsystem directly rather than using it via autoconf. We expected autoconf to not strip and rather be well-behaved. In order to limit possible breakage, we limited the INSTALL override to direct makefile builds. > moved the package to debhelper compat level 13, and hope that's > sufficient to resolve the problem. However, I do note that > /usr/bin/install still seems to be getting called with -s on my amd64 > local build? Hoping it does the right thing now on cross builds. > Please let me know if there's more I need to do! The -s flag will persist in any case. It just happens that the program used for stripping should be replaced with /bin/true, which doesn't strip that much, so the -s flag isn't that relevant. The -s flag is not just about cross builds. It also is about generating -dbgsym packages and implementing DEB_BUILD_OPTIONS=nostrip. So while the change was motivated in the cross build context, it is helpful beyond. And yeah, there is more to do. I fear you really need the override. Helmut
Bug#1029084: closed by Debian FTP Masters (reply to Bdale Garbee ) (Bug#1029084: fixed in cpmtools 2.23-1)
Helmut Grohne writes: > Control: reopen -1 > > On Tue, Jan 24, 2023 at 11:21:09PM +, Debian Bug Tracking System wrote: >> #1029084: cpmtools FTCBFS: multiple reasons >> >> It has been closed by Debian FTP Masters >> (reply to Bdale Garbee ). > > | * cross-building should be fixed by repackaging, closes: #1029084 > > Sorry, no. The stripping issue persists. Hrm. As I DH'ified the package, I really thought that part of your patch would no longer be relevant. What I didn't realize is that your bug about not stripping in dh_auto_install wasn't implemented until compat 11, and the source package was still declaring 10. So .. I've moved the package to debhelper compat level 13, and hope that's sufficient to resolve the problem. However, I do note that /usr/bin/install still seems to be getting called with -s on my amd64 local build? Hoping it does the right thing now on cross builds. Please let me know if there's more I need to do! Regards, Bdale signature.asc Description: PGP signature
Bug#1029084: closed by Debian FTP Masters (reply to Bdale Garbee ) (Bug#1029084: fixed in cpmtools 2.23-1)
Control: reopen -1 On Tue, Jan 24, 2023 at 11:21:09PM +, Debian Bug Tracking System wrote: > #1029084: cpmtools FTCBFS: multiple reasons > > It has been closed by Debian FTP Masters > (reply to Bdale Garbee ). | * cross-building should be fixed by repackaging, closes: #1029084 Sorry, no. The stripping issue persists. Helmut
