Bug#1029101: Acknowledgement (fontconfig-config: 2.14.1 upload breaks testSimpleText of libreoffice)

2023-01-19 Thread Rene Engelhard

Hi,

Am 19.01.23 um 12:46 schrieb Andreas Henriksson:

I'd like to explicitly ask if you still want me to upload any
fontconfig change ASAP or if downgrading severity means you think
it can/should wait until after release?


worked around it in libreoffice for now, so your decision in the end.


As I understand the situation something related to subpixel rendering
has changed between 2.13.x and 2.14.1.
Debian offers debconf choices "Automatic", "Always" and "Never" for
which settings to use in /etc/fonts/conf.d/$SYMLINK which are related
to the problem you're reporting.
Fedora on the other hand seems to use "always/only on KDE" (with no
alternatives) as far as I understand the commit you pointed out.

Does that mean we should:
- offer an additional alternative /or/ patch "Always"?
- make then new/patched alternative the default?
- get rid of debconf alternatives and provide one consistent
   configuration for all users?
I'd vote for the latter, the deconf thingy is confusing and leads to 
problems like this if stuff assumes behaviour

Unless we do the last option, wouldn't it mean any (test) failures
still happen if the user uses any of the other options? (Which would
suggest this is not actually a bug on the fontconfig side to me.)


Probably. Maybe just do what upstreams default is? (Whatever that is).

Or sync with other distros which so far had no problems (aka the patch I 
linked), so it's at least consistent between distros.


Fedora actually (as one can see in the linked RH bug) did an update to 
released Fedora versions to add that ... and TTBOMK Abira 
TAGOH is also fontconfig upstream?




In the mail where you tagged this patch you suggested to edit the
subpixel config file which makes me think you're using the Always
alternative, but as I understand the debconf code Automatic is
the (current) default...


Can't be. The buildds (and also my buildd chroot) does not get any 
debconf prompt (noninteractive frontend) so default is what I pasted


- without the 



If you think you have a clear picture of exactly what should happen
(on the fontconfig side) then I would very much appreciate if you
could either send a salsa MR or just NMU (and I'll make sure to import
the NMU-diff into the fontconfig packaging repo).


Unfortunately not, I just try to fix the FTBFS ;)


Regards,


Rene



Bug#1029101: Acknowledgement (fontconfig-config: 2.14.1 upload breaks testSimpleText of libreoffice)

2023-01-19 Thread Andreas Henriksson
Hello Rene Engelhard,

On Tue, Jan 17, 2023 at 07:23:17PM +0100, Rene Engelhard wrote:
> severity 1029101 important
> retitle 1029101 please Enable RGB stripes layout for sub-pixel rendering on
> KDE only
> thanks
> 
> [ sorry for "spamming" ]
[...]

Thanks for taking the time to report and follow up on this!
Sorry for the wall of text below.

I have to admit I'm having a bit of trouble following everything,
possibly because of my lack of knowledge in several areas.

I'd like to explicitly ask if you still want me to upload any
fontconfig change ASAP or if downgrading severity means you think
it can/should wait until after release?

As I understand the situation something related to subpixel rendering
has changed between 2.13.x and 2.14.1.
Debian offers debconf choices "Automatic", "Always" and "Never" for
which settings to use in /etc/fonts/conf.d/$SYMLINK which are related
to the problem you're reporting.
Fedora on the other hand seems to use "always/only on KDE" (with no
alternatives) as far as I understand the commit you pointed out.

Does that mean we should:
- offer an additional alternative /or/ patch "Always"?
- make then new/patched alternative the default?
- get rid of debconf alternatives and provide one consistent
  configuration for all users?

Unless we do the last option, wouldn't it mean any (test) failures
still happen if the user uses any of the other options? (Which would
suggest this is not actually a bug on the fontconfig side to me.)

In the mail where you tagged this patch you suggested to edit the
subpixel config file which makes me think you're using the Always
alternative, but as I understand the debconf code Automatic is
the (current) default...

If you think you have a clear picture of exactly what should happen
(on the fontconfig side) then I would very much appreciate if you
could either send a salsa MR or just NMU (and I'll make sure to import
the NMU-diff into the fontconfig packaging repo).

As of right now I'm considering removing the patch tag as the exact
change needed here is still unclear to me. (but thanks alot for
pin-pointing the problematic area!)

Regards,
Andreas Henriksson



Bug#1029101: Acknowledgement (fontconfig-config: 2.14.1 upload breaks testSimpleText of libreoffice)

2023-01-17 Thread Rene Engelhard

severity 1029101 important
retitle 1029101 please Enable RGB stripes layout for sub-pixel rendering 
on KDE only

thanks

[ sorry for "spamming" ]

Hi,

Am 17.01.23 um 19:04 schrieb Rene Engelhard:
it still fails. Probably it ignores it since it's already set in /etc 
and that already matches?


OK, got it. I need to "delete" it.

  

mode="delete">rgb

  


Then it passes and it shouldn't  break with 2.13 either since deleting 
somethng non-existing works ;-)


Will reassign a clone to libreoffice to fix that test failure.

Regards,


Rene



Bug#1029101: Acknowledgement (fontconfig-config: 2.14.1 upload breaks testSimpleText of libreoffice)

2023-01-17 Thread Rene Engelhard

Hi again,

Am 17.01.23 um 18:28 schrieb Rene Engelhard:
I tried to adapt the test to expected values but failed. When I adapt 
some values stuff even further breaks, and at the 50% test I then had no 
idea what to do.)


LO has already a fc_local.conf:

./instdir/share/fonts/truetype/fc_local.conf

but when I add the stuff from the patch  there

rene@frodo:~/Debian/Pakete/LibreOffice/libreoffice/libreoffice-7.4.4.2$ 
cat ./instdir/share/fonts/truetype/fc_local.conf





  Symbol
  
OpenSymbol
  

  


  KDE

mode="append">rgb

  


it still fails. Probably it ignores it since it's already set in /etc 
and that already matches?


Regards,


Rene



Bug#1029101: Acknowledgement (fontconfig-config: 2.14.1 upload breaks testSimpleText of libreoffice)

2023-01-17 Thread Rene Engelhard

Hi,

addendum:

I tried to adapt the test to expected values but failed. When I adapt 
some values stuff even further breaks, and at the 50% test I then had no 
idea what to do.)


For reference,  this is the test:

https://cgit.freedesktop.org/libreoffice/core/tree/vcl/qa/cppunit/text.cxx?h=libreoffice-7.4.4.2#n164 
ff.



Regards,


Rene