Bug#1029206: [pre-approval] unblock: webkit2gtk 2.40.0-2

2023-03-23 Thread Alberto Garcia
On Wed, Mar 08, 2023 at 09:36:23PM +, Alberto Garcia wrote:
> Upstream has just confirmed that the new WebKit API for GTK4 is
> final[1] so this is effectively a release candidate for WebKitGTK
> 2.40.0, to be released in ~10 days.

2.40.0-2 has been in unstable for a while, I had to upload 2.40.0-3
because of a missing dependency in arm that was causing an autopkgtest
to fail, all tests run fine now (mipsel is still missing but it worked
fine in 2.40.0-2 with no changes affecting mipsel since then).

This is tagged as 'moreinfo', is there anything else that I can
provide?

Berto
diff -Nru webkit2gtk-2.40.0/debian/changelog webkit2gtk-2.40.0/debian/changelog
--- webkit2gtk-2.40.0/debian/changelog	2023-03-18 11:41:32.0 +0100
+++ webkit2gtk-2.40.0/debian/changelog	2023-03-21 18:11:48.0 +0100
@@ -1,3 +1,10 @@
+webkit2gtk (2.40.0-3) unstable; urgency=medium
+
+  * debian/{rules,control.in}:
+- Add dependency on libgles2 on arm (Closes: #1033230).
+
+ -- Alberto Garcia   Tue, 21 Mar 2023 18:11:48 +0100
+
 webkit2gtk (2.40.0-2) unstable; urgency=medium
 
   * debian/patches/fix-script-message-received-marshaller.patch:
diff -Nru webkit2gtk-2.40.0/debian/control webkit2gtk-2.40.0/debian/control
--- webkit2gtk-2.40.0/debian/control	2023-03-18 11:41:32.0 +0100
+++ webkit2gtk-2.40.0/debian/control	2023-03-21 18:11:48.0 +0100
@@ -180,6 +180,7 @@
  gstreamer1.0-plugins-good,
  ${bwrap:Depends},
  ${shlibs:Depends},
+ ${gles:Depends},
  ${misc:Depends}
 Recommends: gstreamer1.0-gl,
 libgl1-mesa-dri,
@@ -311,6 +312,7 @@
  gstreamer1.0-plugins-good,
  ${bwrap:Depends},
  ${shlibs:Depends},
+ ${gles:Depends},
  ${misc:Depends}
 Recommends: gstreamer1.0-gl,
 libgl1-mesa-dri,
@@ -442,6 +444,7 @@
  gstreamer1.0-plugins-good,
  ${bwrap:Depends},
  ${shlibs:Depends},
+ ${gles:Depends},
  ${misc:Depends}
 Recommends: gstreamer1.0-gl,
 libgl1-mesa-dri,
diff -Nru webkit2gtk-2.40.0/debian/control-common.in webkit2gtk-2.40.0/debian/control-common.in
--- webkit2gtk-2.40.0/debian/control-common.in	2023-03-18 11:41:32.0 +0100
+++ webkit2gtk-2.40.0/debian/control-common.in	2023-03-21 18:11:48.0 +0100
@@ -61,6 +61,7 @@
  gstreamer1.0-plugins-good,
  ${bwrap:Depends},
  ${shlibs:Depends},
+ ${gles:Depends},
  ${misc:Depends}
 Recommends: gstreamer1.0-gl,
 libgl1-mesa-dri,
diff -Nru webkit2gtk-2.40.0/debian/rules webkit2gtk-2.40.0/debian/rules
--- webkit2gtk-2.40.0/debian/rules	2023-03-18 11:41:32.0 +0100
+++ webkit2gtk-2.40.0/debian/rules	2023-03-21 18:11:48.0 +0100
@@ -148,6 +148,11 @@
 	DH_GENCONTROL_ARGS += -Vgst:Recommends="gstreamer1.0-libav, gstreamer1.0-plugins-bad"
 endif
 
+# This is loaded at runtime using libepoxy so add an explicit dependency (#1033230)
+ifneq (,$(filter $(DEB_HOST_ARCH),arm64 armel armhf))
+	DH_GENCONTROL_ARGS += -Vgles:Depends="libgles2"
+endif
+
 CXXFLAGS=$(CFLAGS)
 
 # Disable commands and binary packages of the builds that we don't want


Bug#1029206: [pre-approval] unblock: webkit2gtk 2.40.0-2

2023-03-08 Thread Alberto Garcia
I have a slightly related question for the release team, and apologies
in advance if I'm hijacking this thread.

WPE WebKit, the other major port of WebKit in Debian is also
introducing a new API in 2.40.0, although in this case the old API
will still be available (but deprecated) for a time.

Unlike WebKitGTK, WPE WebKit only has two reverse dependencies: cog
(a mini browser developed by the same upstream team) and a GStreamer
plugin (gstreamer1.0-wpe, part of the -plugins-bad set). None of these
packages plays a prominent role in the distribution so I think a
transition could be handled with very low risk.

However I also realize that we're quite late in the freeze period,
so I would like to ask: is it a good idea that I try to handle
a transition for WPE WebKit? I will understand if the answer is
negative.

Thanks!

Berto



Bug#1029206: [pre-approval] unblock: webkit2gtk 2.40.0-2

2023-03-08 Thread Alberto Garcia
Upstream has just confirmed that the new WebKit API for GTK4 is
final[1] so this is effectively a release candidate for WebKitGTK
2.40.0, to be released in ~10 days.

I just uploaded the packages, the GTK4 ones are in the NEW queue.

Jeremy, you can start testing the reverse dependencies whenever you
want.

Berto

[1] https://discourse.gnome.org/t/webkitgtk-for-gtk-4-is-now-api-stable/14378



Bug#1029206: [pre-approval] unblock: webkit2gtk 2.40.0-2

2023-03-08 Thread Alberto Garcia
On Mon, Mar 06, 2023 at 12:29:05PM +, Alberto Garcia wrote:
> > It's been a while. Any progress? It's getting late in the freeze
> > already.
> upstream confirmed that there are some last minutes changes to
> the API so the final soname will happen with the official 2.40.0
> release, which is planned on the weekend of the 18th of March:

Update: 2.39.91 has just been published, and upstream told me that no
more API changes are expected before 2.40.0, so I'll enable the gtk4
packages and upload them to experimental now.

Berto



Bug#1029206: [pre-approval] unblock: webkit2gtk 2.40.0-2

2023-03-06 Thread Alberto Garcia
On Sat, Mar 04, 2023 at 05:24:04PM +0100, Paul Gevers wrote:
> > All build scripts are ready and the new GTK4 packages can
> > already be enabled by simply flipping the value of a variable in
> > debian/rules. We are just waiting to know the final SONAME.
> 
> It's been a while. Any progress? It's getting late in the freeze
> already.

Hi,

upstream confirmed that there are some last minutes changes to the
API so the final soname will happen with the official 2.40.0 release,
which is planned on the weekend of the 18th of March:

   https://wiki.gnome.org/FortyFour

Berto



Bug#1029206: [pre-approval] unblock: webkit2gtk 2.40.0-2

2023-03-04 Thread Alberto Garcia
On Sat, Mar 04, 2023 at 05:24:04PM +0100, Paul Gevers wrote:
> > All build scripts are ready and the new GTK4 packages can
> > already be enabled by simply flipping the value of a variable in
> > debian/rules. We are just waiting to know the final SONAME.
> 
> It's been a while. Any progress? It's getting late in the freeze
> already.

I just contacted upstream to ask about this, I'll give you an answer
asap.

Berto



Bug#1029206: [pre-approval] unblock: webkit2gtk 2.40.0-2

2023-03-04 Thread Paul Gevers

Hi Alberto,

On 24-01-2023 11:39, Alberto Garcia wrote:

On Sat, Jan 21, 2023 at 05:43:11PM +0100, Sebastian Ramacher wrote:

As soon as the new SONAME is known, an upload to experimental would
be appreciated to go through NEW. Please let us know once it's
available in experimental and the test builds have been performed.


Yes, that's the plan.

All build scripts are ready and the new GTK4 packages can already be
enabled by simply flipping the value of a variable in debian/rules. We
are just waiting to know the final SONAME.


It's been a while. Any progress? It's getting late in the freeze already.

Paul


OpenPGP_signature
Description: OpenPGP digital signature


Bug#1029206: [pre-approval] unblock: webkit2gtk 2.40.0-2

2023-01-24 Thread Alberto Garcia
On Sat, Jan 21, 2023 at 05:43:11PM +0100, Sebastian Ramacher wrote:
> > [ Other Info ]
> > webkit2gtk generally follows the GNOME release schedule. [5] A beta
> > (2.39.90) is expected in February. A release candidate (2.39.91)
> > around March 6, and the first stable release (2.40.0) around March 20.
> > We intend to do a test build in experimental first. I think it makes
> > the most sense to wait for the 2.40.0 release and not push a prelease
> > to Unstable/Testing.
> > 
> > Ubuntu 23.04 will also switch to the 2.40 series by February or early
> > March. Ubuntu 22.10 will need to do this transition as stable release
> > updates.
> > 
> > I don't have a ben file since the final soname isn't known yet.
> 
> As soon as the new SONAME is known, an upload to experimental would
> be appreciated to go through NEW. Please let us know once it's
> available in experimental and the test builds have been performed.

Yes, that's the plan.

All build scripts are ready and the new GTK4 packages can already be
enabled by simply flipping the value of a variable in debian/rules. We
are just waiting to know the final SONAME.

Berto



Bug#1029206: [pre-approval] unblock: webkit2gtk 2.40.0-2

2023-01-21 Thread Sebastian Ramacher
Control: tags -1 moreinfo

Hi Jeremy, Security team

On 2023-01-19 12:02:38 -0500, Jeremy Bicha wrote:
> Package: release.debian.org
> User: release.debian@packages.debian.org
> Usertags: unblock transition moreinfo
> Tags: security
> X-Debbugs-CC: webkit2...@packages.debian.org
> 
> I am filing this bug early so that the Release Team is aware early.
> 
> [ Reason ]
> webkit2gtk only provides security support for one stable series at a
> time. A new series is released each March and September. The Debian
> Security Team backports these new release as security updates [1] [2]
> 
> The upcoming 2.40.0 is more disruptive than usual as it makes a major
> API break for the new GTK4 library, bumping the API series from 5 to 6
> [3]. This causes a small transition: gnome-builder 43 and
> gnome-initial-setup 43 are the only two packages that use the gtk4
> library. They will both need sourceful uploads. Patches will be ready
> for both since the upstream webkitgtk team works closely with the
> GNOME project.
> 
> [ Impact ]
> Because the 2.38 series will be End of Life before Debian 12 is
> released, I believe the Security Team wants 2.40 to make it to Testing

Security team, what's your take on this?

> [ Tests ]
> There are no automated tests (!)
> The person who uploads gnome-builder and gnome-initial-setup (likely
> me) will make sure those 2 apps still run well with the new webkit2gtk
> version.
> 
> [ Risks ]
> The code changes in a new major webkit2gtk release are too large to
> manually review.
> webkit2gtk is a key package.
> Besides gnome-builder and gnome-initial-setup, webkit2gtk is used by
> many packages. [4]
> 
> [ Checklist ]
>   [ ] all changes are documented in the d/changelog
>   [ ] I reviewed all changes and I approve them
>   [ ] attach debdiff against the package in testing
> 
> [ Other Info ]
> webkit2gtk generally follows the GNOME release schedule. [5] A beta
> (2.39.90) is expected in February. A release candidate (2.39.91)
> around March 6, and the first stable release (2.40.0) around March 20.
> We intend to do a test build in experimental first. I think it makes
> the most sense to wait for the 2.40.0 release and not push a prelease
> to Unstable/Testing.
> 
> Ubuntu 23.04 will also switch to the 2.40 series by February or early
> March. Ubuntu 22.10 will need to do this transition as stable release
> updates.
> 
> I don't have a ben file since the final soname isn't known yet.

As soon as the new SONAME is known, an upload to experimental would be
appreciated to go through NEW. Please let us know once it's available in
experimental and the test builds have been performed.

Cheers

> 
> [1]
> https://www.debian.org/releases/stable/amd64/release-notes/ch-information.en.html#limited-security-support
> 
> [2] https://tracker.debian.org/pkg/webkit2gtk
> 
> [3] 
> https://discourse.gnome.org/t/webkitgtk-for-gtk-4-status-update-and-api-changes/11033
> 
> [4] https://release.debian.org/transitions/html/webkit2gtk-4.0.html
> 
> [5] https://wiki.gnome.org/FortyFour
> 
> Thank you,
> Jeremy Bicha
> 

-- 
Sebastian Ramacher



Bug#1029206: [pre-approval] unblock: webkit2gtk 2.40.0-2

2023-01-19 Thread Jeremy Bicha
Package: release.debian.org
User: release.debian@packages.debian.org
Usertags: unblock transition moreinfo
Tags: security
X-Debbugs-CC: webkit2...@packages.debian.org

I am filing this bug early so that the Release Team is aware early.

[ Reason ]
webkit2gtk only provides security support for one stable series at a
time. A new series is released each March and September. The Debian
Security Team backports these new release as security updates [1] [2]

The upcoming 2.40.0 is more disruptive than usual as it makes a major
API break for the new GTK4 library, bumping the API series from 5 to 6
[3]. This causes a small transition: gnome-builder 43 and
gnome-initial-setup 43 are the only two packages that use the gtk4
library. They will both need sourceful uploads. Patches will be ready
for both since the upstream webkitgtk team works closely with the
GNOME project.

[ Impact ]
Because the 2.38 series will be End of Life before Debian 12 is
released, I believe the Security Team wants 2.40 to make it to Testing

[ Tests ]
There are no automated tests (!)
The person who uploads gnome-builder and gnome-initial-setup (likely
me) will make sure those 2 apps still run well with the new webkit2gtk
version.

[ Risks ]
The code changes in a new major webkit2gtk release are too large to
manually review.
webkit2gtk is a key package.
Besides gnome-builder and gnome-initial-setup, webkit2gtk is used by
many packages. [4]

[ Checklist ]
  [ ] all changes are documented in the d/changelog
  [ ] I reviewed all changes and I approve them
  [ ] attach debdiff against the package in testing

[ Other Info ]
webkit2gtk generally follows the GNOME release schedule. [5] A beta
(2.39.90) is expected in February. A release candidate (2.39.91)
around March 6, and the first stable release (2.40.0) around March 20.
We intend to do a test build in experimental first. I think it makes
the most sense to wait for the 2.40.0 release and not push a prelease
to Unstable/Testing.

Ubuntu 23.04 will also switch to the 2.40 series by February or early
March. Ubuntu 22.10 will need to do this transition as stable release
updates.

I don't have a ben file since the final soname isn't known yet.

[1]
https://www.debian.org/releases/stable/amd64/release-notes/ch-information.en.html#limited-security-support

[2] https://tracker.debian.org/pkg/webkit2gtk

[3] 
https://discourse.gnome.org/t/webkitgtk-for-gtk-4-status-update-and-api-changes/11033

[4] https://release.debian.org/transitions/html/webkit2gtk-4.0.html

[5] https://wiki.gnome.org/FortyFour

Thank you,
Jeremy Bicha