Bug#1030955: golang-github-hhatto-gorst: autopkgtest failure
On Thu, 13 Jul 2023 21:24:53 +0530 Nilesh Patra wrote: > Control: tags -1 patch > > On Thu, Jul 13, 2023 at 03:10:40PM +0530, Pirate Praveen wrote: > > On Fri, 10 Feb 2023 00:07:51 +0200 Adrian Bunk wrote: > > > The Ubuntu diff contains a patch that looks like a workaround (untested). > > > > This patch says data directory is reserved for golang autopkgtest in Ubuntu. > > Is this the same on debian too? If yes, that looks like a bad idea to me. > > AFAIK, it uses the standard AUTOPKGTEST_TMP directory which is the > standard across debian. I got the same impression on skimming through > dh-golang code. > > As far as fix for your package is concerned, it is as simple as avoiding > to remove entire data directory (which is just 28K in size). I'm able to get > autopkgtests passing locally. Patch pasted > inline. Thanks. I guess I was over enthusiastic to suppress I: golang-github-hhatto-gorst-dev: package-contains-documentation-outside-usr-share-doc [usr/share/gocode/src/github.com/hhatto/gorst/data/autopep8.readme.rst] and did not notice the autopkgtest failure then. I'm uploading the fix you suggested.
Bug#1030955: golang-github-hhatto-gorst: autopkgtest failure
Control: tags -1 patch On Thu, Jul 13, 2023 at 03:10:40PM +0530, Pirate Praveen wrote: > On Fri, 10 Feb 2023 00:07:51 +0200 Adrian Bunk wrote: > > The Ubuntu diff contains a patch that looks like a workaround (untested). > > This patch says data directory is reserved for golang autopkgtest in Ubuntu. > Is this the same on debian too? If yes, that looks like a bad idea to me. AFAIK, it uses the standard AUTOPKGTEST_TMP directory which is the standard across debian. I got the same impression on skimming through dh-golang code. As far as fix for your package is concerned, it is as simple as avoiding to remove entire data directory (which is just 28K in size). I'm able to get autopkgtests passing locally. Patch pasted inline. From 7aa6fc7ccf9bb7b938d290bc1e2eab2b324fb7ff Mon Sep 17 00:00:00 2001 From: Nilesh Patra Date: Thu, 13 Jul 2023 21:22:59 +0530 Subject: [PATCH] Avoid removing entire data dir during dh_install step --- debian/rules | 1 - 1 file changed, 1 deletion(-) diff --git a/debian/rules b/debian/rules index c858f56..28c01cd 100755 --- a/debian/rules +++ b/debian/rules @@ -7,5 +7,4 @@ export DH_GOLANG_INSTALL_EXTRA := data override_dh_install: dh_install -O--builddirectory=_build -O--buildsystem=golang -O--with=golang - rm -rf debian/golang-github-hhatto-gorst-dev/usr/share/gocode/src/github.com/hhatto/gorst/data rm -rf debian/golang-github-hhatto-gorst-dev/usr/share/gocode/src/github.com/hhatto/gorst/*.html -- 2.39.2 signature.asc Description: PGP signature
Bug#1030955: golang-github-hhatto-gorst: autopkgtest failure
On Fri, 10 Feb 2023 00:07:51 +0200 Adrian Bunk wrote: > The Ubuntu diff contains a patch that looks like a workaround (untested). This patch says data directory is reserved for golang autopkgtest in Ubuntu. Is this the same on debian too? If yes, that looks like a bad idea to me.
Bug#1030955: golang-github-hhatto-gorst: autopkgtest failure
Source: golang-github-hhatto-gorst Version: 0.0~git20181029.ca9f730-2 Severity: serious https://ci.debian.net/data/autopkgtest/testing/amd64/g/golang-github-hhatto-gorst/31199561/log.gz ... dh_auto_test -O--builddirectory=_build -O--buildsystem=golang cd _build && go test -vet=off -v -p 64 github.com/hhatto/gorst github.com/hhatto/gorst/cmd/gorst === RUN TestExampleOfSimpleText 2023/02/09 22:05:24 open data/simple.rst: no such file or directory --- PASS: TestExampleOfSimpleText (0.00s) === RUN TestExampleOfPydebsignReadme 2023/02/09 22:05:24 open data/pydebsign.readme.rst: no such file or directory rst_test.go:46: invalid convert --- FAIL: TestExampleOfPydebsignReadme (0.00s) === RUN TestExampleOfMeowReadme 2023/02/09 22:05:24 open data/meow.readme.rst: no such file or directory --- PASS: TestExampleOfMeowReadme (0.00s) === RUN TestExampleOfAutopep8Readme 2023/02/09 22:05:24 open data/autopep8.readme.rst: no such file or directory rst_test.go:61: contain heading in autopep8 rst_test.go:64: para in autopep8 --- FAIL: TestExampleOfAutopep8Readme (0.00s) === RUN TestExampleOfHeadingTitle --- PASS: TestExampleOfHeadingTitle (0.00s) === RUN TestExampleOfHeading --- PASS: TestExampleOfHeading (0.00s) === RUN TestAutoLink --- PASS: TestAutoLink (0.00s) === RUN TestLinkContainsUnderbar --- PASS: TestLinkContainsUnderbar (0.00s) === RUN TestLinkComplexCases --- PASS: TestLinkComplexCases (0.00s) === RUN TestUnquotedRefLinkUnderbarWithDot --- PASS: TestUnquotedRefLinkUnderbarWithDot (0.00s) === RUN TestUnquotedRefLinkUnderbarWithDotAndList --- PASS: TestUnquotedRefLinkUnderbarWithDotAndList (0.00s) === RUN TestSimpleLinkRef --- PASS: TestSimpleLinkRef (0.00s) === RUN TestNotLinkRef --- PASS: TestNotLinkRef (0.00s) === RUN TestEmbeddedURI --- PASS: TestEmbeddedURI (0.00s) === RUN TestEmbeddedURIwithNewline --- PASS: TestEmbeddedURIwithNewline (0.00s) === RUN TestEmbeddedAnonymouseURI --- PASS: TestEmbeddedAnonymouseURI (0.00s) === RUN TestImage --- PASS: TestImage (0.00s) === RUN TestImageWithAlt --- PASS: TestImageWithAlt (0.00s) === RUN TestImageWithTarget --- PASS: TestImageWithTarget (0.00s) === RUN TestImageWithAltAndTarget --- PASS: TestImageWithAltAndTarget (0.00s) === RUN TestGridTable --- PASS: TestGridTable (0.00s) === RUN TestHeaderLessGridTable --- PASS: TestHeaderLessGridTable (0.00s) === RUN TestApplicationDepent --- PASS: TestApplicationDepent (0.00s) FAIL FAILgithub.com/hhatto/gorst 0.006s ? github.com/hhatto/gorst/cmd/gorst [no test files] FAIL dh_auto_test: error: cd _build && go test -vet=off -v -p 64 github.com/hhatto/gorst github.com/hhatto/gorst/cmd/gorst returned exit code 1 make: *** [debian/rules:6: build] Error 25 The Ubuntu diff contains a patch that looks like a workaround (untested).
