Bug#1031698: RFS: dhcpdump/1.8-5 [QA] -- Parse DHCP packets from tcpdump
Thank you for the considerations made in my review and excellent work with your review. I learned a lot from your work. waiting for a sponsor to upload. On Tue, Feb 21, 2023 at 2:22 AM Boian Bonev wrote: > Hi, > > First thing to change (after the missing binary) is the description - the > tool > no longer executes and parses tcpdump's output, instead it uses libpcap > directly to get the packets. The man page needs the same correction. > > The build completely ignores the default hardening and optimization flags. > This > breaks both cross and reproducible builds. > > tcpdump should be removed from Depends. > > Isn't it better to depend on libpcap-dev? (libpcap0.7-dev isn't in any > supported release) > > Current standards are 4.6.2. > > d/copyright may benefit from a DEP5 conversion. > > Now I see that there are 3 open bugs, maybe at least two or even all can be > fixed by this upload? > > I have several patches for this tool hanging around since 2013, I did try > to > send them to upstream back then but they either got lost or ignored. All of > them are fixing behavioral bugs. > > I think it is a good idea to add these patches while doing the QA upload. I > need to add the proper headers and will post after an ACK. > > -- > With best regards, > b. >
Bug#1031698: RFS: dhcpdump/1.8-5 [QA] -- Parse DHCP packets from tcpdump
Hi, While testing my old patches I needed a clean build and ended fixing most of the problems. Not sharing the result feels like a waste and because there is no git repo to file a PR, I uploaded the whole result on mentors. Take it as a PR and feel free to change the stuff that you don't like. My main objective was to contribute the old patches I made 10 years back but it seems that I overdid it a little bit... ;) -- With best regards, b. signature.asc Description: This is a digitally signed message part
Bug#1031698: RFS: dhcpdump/1.8-5 [QA] -- Parse DHCP packets from tcpdump
Hi, First thing to change (after the missing binary) is the description - the tool no longer executes and parses tcpdump's output, instead it uses libpcap directly to get the packets. The man page needs the same correction. The build completely ignores the default hardening and optimization flags. This breaks both cross and reproducible builds. tcpdump should be removed from Depends. Isn't it better to depend on libpcap-dev? (libpcap0.7-dev isn't in any supported release) Current standards are 4.6.2. d/copyright may benefit from a DEP5 conversion. Now I see that there are 3 open bugs, maybe at least two or even all can be fixed by this upload? I have several patches for this tool hanging around since 2013, I did try to send them to upstream back then but they either got lost or ignored. All of them are fixing behavioral bugs. I think it is a good idea to add these patches while doing the QA upload. I need to add the proper headers and will post after an ACK. -- With best regards, b. signature.asc Description: This is a digitally signed message part
Bug#1031698: RFS: dhcpdump/1.8-5 [QA] -- Parse DHCP packets from tcpdump
On Mon, Feb 20, 2023 at 05:10:34PM -0300, Jpaulo wrote:
> dhcpdump (1.8-5) experimental; urgency=medium
> .
>* QA upload.
>* debian/control:
>- Set Rules-Requires-Root:no.
>- Set homepage-field.
>- Bumped Standards-Version to 4.6.1.
>- Set debhelper-compat version in Build-Depends.
>- Added Depends ${shlibs:Depends} in Depends fields.
>* debian/rules:
>- Rewrite to use dh-sequencer.
>* debian/metadata:
>- Added missing upstream metadata.
>- Added upstream's key.
>* debian/watch:
>- Add watch file.
Hi!
I believe it's better if packages carry some non-metadata contents, which
the new version currently lacks...
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Q: Is it ok to combine wired, wifi, and/or bluetooth connections
⢿⡄⠘⠷⠚⠋⠀in wearable computing?
⠈⠳⣄ A: No, that would be mixed fabric, which Lev19:19 forbids.
Bug#1031698: RFS: dhcpdump/1.8-5 [QA] -- Parse DHCP packets from tcpdump
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package "dhcpdump":
* Package name : dhcpdump
Version : 1.8-5
* URL : http://www.mavetju.org/download/
* License : BSD-2-clause
Section : admin
The source builds the following binary packages:
dhcpdump - Parse DHCP packets from tcpdump
To access further information about this package, please visit the
following URL:
https://mentors.debian.net/package/dhcpdump/
Alternatively, you can download the package with 'dget' using this command:
dget -x
https://mentors.debian.net/debian/pool/main/d/dhcpdump/dhcpdump_1.8-5.dsc
Changes since the last upload:
dhcpdump (1.8-5) experimental; urgency=medium
.
* QA upload.
* debian/control:
- Set Rules-Requires-Root:no.
- Set homepage-field.
- Bumped Standards-Version to 4.6.1.
- Set debhelper-compat version in Build-Depends.
- Added Depends ${shlibs:Depends} in Depends fields.
* debian/rules:
- Rewrite to use dh-sequencer.
* debian/metadata:
- Added missing upstream metadata.
- Added upstream's key.
* debian/watch:
- Add watch file.
Regards,
--
Joao Paulo
