Bug#1033042: webkit2gtk: Please disable ccache on m68k

[Alberto Garcia]

Control: tags -1 pending

On Thu, Mar 16, 2023 at 10:21:21AM +0100, John Paul Adrian Glaubitz wrote:
> On m68k, the build currently fails with ccache enabled

Thanks, applied to the 2.40.x branch:

   
https://salsa.debian.org/webkit-team/webkit/-/commit/3b82c5ced3fa8a7446899712a0caa03f7f34ec96

One of these days I think I'll probably re-evaluate how much good
ccache is doing in the recent builds.

Berto

Bug#1033042: webkit2gtk: Please disable ccache on m68k

[John Paul Adrian Glaubitz]

Source: webkit2gtk
Version: 2.38.5-1
Severity: normal
Tags: patch
User: debian-...@lists.debian.org
Usertags: m68k
X-Debbugs-Cc: debian-...@lists.debian.org

Hi!

On m68k, the build currently fails with ccache enabled due to a bug in 
qemu-user:

FAILED: 
Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/heap/StructureAlignedMemoryAllocator.cpp.o
 
/usr/bin/ccache /usr/bin/c++ -DBUILDING_GTK__=1 -DBUILDING_JavaScriptCore 
-DBUILDING_WITH_CMAKE=1 \
(...)
-o 
Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/heap/StructureAlignedMemoryAllocator.cpp.o
 \
-c 
/<>/Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp
ccache: pthread_mutex_lock.c:94: ___pthread_mutex_lock: Assertion 
`mutex->__data.__owner == 0' failed.
qemu: uncaught target signal 6 (Aborted) - core dumped
Aborted

This issue can be worked around by disabling ccache which will prolong the 
build times, of course, but
at least the package gets built.

Thus, could you disable ccache on m68k with the following change to 
debian/control{,.in}:

--- old/webkit2gtk-2.38.5/debian/control.in 2023-02-15 18:10:55.0 
+0100
+++ new/webkit2gtk-2.38.5/debian/control.in 2023-03-11 10:42:47.033477170 
+0100
@@ -7,7 +7,7 @@
Alberto Garcia 
 X-Ubuntu-Use-Langpack: no
 Build-Depends: debhelper-compat (= 12),
-   ccache [!i386],
+   ccache [!i386 !m68k],
bubblewrap (>= 0.3.1) [!alpha !ia64 !m68k !riscv64 !sh4 
!sparc64 !hurd-any !kfreebsd-any],
xdg-dbus-proxy [!alpha !ia64 !m68k !riscv64 !sh4 !sparc64 
!hurd-any !kfreebsd-any],
libseccomp-dev [!alpha !ia64 !m68k !riscv64 !sh4 !sparc64 
!hurd-any !kfreebsd-any],

Thanks,
Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
--- old/webkit2gtk-2.38.5/debian/control.in 2023-02-15 18:10:55.0 
+0100
+++ new/webkit2gtk-2.38.5/debian/control.in 2023-03-11 10:42:47.033477170 
+0100
@@ -7,7 +7,7 @@
Alberto Garcia 
 X-Ubuntu-Use-Langpack: no
 Build-Depends: debhelper-compat (= 12),
-   ccache [!i386],
+   ccache [!i386 !m68k],
bubblewrap (>= 0.3.1) [!alpha !ia64 !m68k !riscv64 !sh4 
!sparc64 !hurd-any !kfreebsd-any],
xdg-dbus-proxy [!alpha !ia64 !m68k !riscv64 !sh4 !sparc64 
!hurd-any !kfreebsd-any],
libseccomp-dev [!alpha !ia64 !m68k !riscv64 !sh4 !sparc64 
!hurd-any !kfreebsd-any],