Bug#1034076: unblock: spf-engine/3.0.4-1
On Sunday, April 9, 2023 4:11:30 AM EDT Sebastian Ramacher wrote: > Please go ahead and remove the moreinfo tag once the package is in > unstable. Thanks. Uploaded and tag removed. Scott K signature.asc Description: This is a digitally signed message part.
Bug#1034076: unblock: spf-engine/3.0.4-1
Control: tags -1 confirmed moreinfo
On 2023-04-08 00:17:24 -0400, Scott Kitterman wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
>
> Please unblock package spf-engine
>
> (Please provide enough (but not too much) information to help
> the release team to judge the request efficiently. E.g. by
> filling in the sections below.)
>
> [ Reason ]
> Fixes a bug that will cause mail processing to stop for systems which
> send mail to/from local users that doesn't have a fully qualified domain
> name. This a regression from Bullseye.
>
> [ Impact ]
> For most users, none, but for users sending to local addresses, mail
> will stop flowing after upgrade from Bullseye to Bookworm.
>
> [ Tests ]
> The affected code was tested by the original bug reporter and they
> verified that the fix worked without unwanted side effects.
>
> [Risks ]
> Risk is negligible. Very small code change that's been tested. There
> is not autopkgtest as the upstream test suite (such as it is, I'm not
> proud of it) isn't suitable. This is a leaf package, so there's no risk
> of negative effects on other packages.
>
> [ Checklist ]
> [*] all changes are documented in the d/changelog
> [*] I reviewed all changes and I approve them
> [*] attach debdiff against the package in testing
>
> [ Other info ]
> I haven't uploaded this yet, but it's prepared in git locally for upload
> if approved. The only thing I have to do relative to what's in the
> debdiff is dch -r to mark it released.
Please go ahead and remove the moreinfo tag once the package is in
unstable.
Cheers
>
> This is something I would ask for a post-release update to fix if I
> didn't find out about until after Bookworm's release.
>
> unblock spf-engine/3.0.4-1
> diff -Nru spf-engine-3.0.3/CHANGES spf-engine-3.0.4/CHANGES
> --- spf-engine-3.0.3/CHANGES 2023-02-19 19:30:05.819651600 -0500
> +++ spf-engine-3.0.4/CHANGES 2023-04-07 20:46:47.963843000 -0400
> @@ -4,6 +4,10 @@
> # ! = Changed something significant, or removed a feature
> # * = Fixed a bug, or made a minor improvement
>
> +--- 3.0.4 (2023-04-07)
> + * Fix recipient logging to not cause an error for local (not fully
> +qualified) email addresses (LP: #2015609)
> +
> --- 3.0.3 (2023-02-19)
>* Fix reference to QueueID in policydspfsupp.py (LP: #2007123), thanks to
> Wolfgang Karall-Ahlborn for the bug and the fix
> diff -Nru spf-engine-3.0.3/debian/changelog spf-engine-3.0.4/debian/changelog
> --- spf-engine-3.0.3/debian/changelog 2023-02-19 20:13:27.0 -0500
> +++ spf-engine-3.0.4/debian/changelog 2023-04-08 00:06:57.0 -0400
> @@ -1,3 +1,9 @@
> +spf-engine (3.0.4-1) UNRELEASED; urgency=medium
> +
> + * New upstream release
> +
> + -- Scott Kitterman Sat, 08 Apr 2023 00:06:57 -0400
> +
> spf-engine (3.0.3-1) unstable; urgency=medium
>
>* New upstream release
> diff -Nru spf-engine-3.0.3/PKG-INFO spf-engine-3.0.4/PKG-INFO
> --- spf-engine-3.0.3/PKG-INFO 1969-12-31 19:00:00.0 -0500
> +++ spf-engine-3.0.4/PKG-INFO 1969-12-31 19:00:00.0 -0500
> @@ -1,6 +1,6 @@
> Metadata-Version: 2.1
> Name: spf-engine
> -Version: 3.0.3
> +Version: 3.0.4
> Summary: SPF (Sender Policy Framework) processing engine for Postfix policy
> server and Milter implemented in Python.
> Keywords: Postfix,Sendmail,milter,spf,email
> Author-email: Scott Kitterman
> diff -Nru spf-engine-3.0.3/spf_engine/__init__.py
> spf-engine-3.0.4/spf_engine/__init__.py
> --- spf-engine-3.0.3/spf_engine/__init__.py 2023-02-19 19:30:53.016298500
> -0500
> +++ spf-engine-3.0.4/spf_engine/__init__.py 2023-04-07 22:36:19.567618000
> -0400
> @@ -40,7 +40,7 @@
> 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> '''
>
> -__version__ = "3.0.3"
> +__version__ = "3.0.4"
>
> import syslog
> import os
> diff -Nru spf-engine-3.0.3/spf_engine/policyd_spf.py
> spf-engine-3.0.4/spf_engine/policyd_spf.py
> --- spf-engine-3.0.3/spf_engine/policyd_spf.py2022-12-01
> 21:07:37.670749200 -0500
> +++ spf-engine-3.0.4/spf_engine/policyd_spf.py2023-04-07
> 20:44:54.125643300 -0400
> @@ -94,7 +94,10 @@
> elif configData.get('Hide_Receiver') != 'No':
> data['recipient'] = ''
> elif data.get('recipient') != 'none':
> -data['recipient'] = data.get('recipient').split('@')[1]
> +try:
> +data['recipient'] = data.get('recipient').split('@')[1]
> +except IndexError:
> +pass # local recipients may not be fully qualified, so
> no "@".
> if debugLevel >= 3: syslog.syslog('Config: %s' % str(configData))
> # run the checkers {{{3
> checkerValue = None
--
Sebastian Ramacher
Bug#1034076: unblock: spf-engine/3.0.4-1
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package spf-engine
(Please provide enough (but not too much) information to help
the release team to judge the request efficiently. E.g. by
filling in the sections below.)
[ Reason ]
Fixes a bug that will cause mail processing to stop for systems which
send mail to/from local users that doesn't have a fully qualified domain
name. This a regression from Bullseye.
[ Impact ]
For most users, none, but for users sending to local addresses, mail
will stop flowing after upgrade from Bullseye to Bookworm.
[ Tests ]
The affected code was tested by the original bug reporter and they
verified that the fix worked without unwanted side effects.
[Risks ]
Risk is negligible. Very small code change that's been tested. There
is not autopkgtest as the upstream test suite (such as it is, I'm not
proud of it) isn't suitable. This is a leaf package, so there's no risk
of negative effects on other packages.
[ Checklist ]
[*] all changes are documented in the d/changelog
[*] I reviewed all changes and I approve them
[*] attach debdiff against the package in testing
[ Other info ]
I haven't uploaded this yet, but it's prepared in git locally for upload
if approved. The only thing I have to do relative to what's in the
debdiff is dch -r to mark it released.
This is something I would ask for a post-release update to fix if I
didn't find out about until after Bookworm's release.
unblock spf-engine/3.0.4-1
diff -Nru spf-engine-3.0.3/CHANGES spf-engine-3.0.4/CHANGES
--- spf-engine-3.0.3/CHANGES2023-02-19 19:30:05.819651600 -0500
+++ spf-engine-3.0.4/CHANGES2023-04-07 20:46:47.963843000 -0400
@@ -4,6 +4,10 @@
# ! = Changed something significant, or removed a feature
# * = Fixed a bug, or made a minor improvement
+--- 3.0.4 (2023-04-07)
+ * Fix recipient logging to not cause an error for local (not fully
+qualified) email addresses (LP: #2015609)
+
--- 3.0.3 (2023-02-19)
* Fix reference to QueueID in policydspfsupp.py (LP: #2007123), thanks to
Wolfgang Karall-Ahlborn for the bug and the fix
diff -Nru spf-engine-3.0.3/debian/changelog spf-engine-3.0.4/debian/changelog
--- spf-engine-3.0.3/debian/changelog 2023-02-19 20:13:27.0 -0500
+++ spf-engine-3.0.4/debian/changelog 2023-04-08 00:06:57.0 -0400
@@ -1,3 +1,9 @@
+spf-engine (3.0.4-1) UNRELEASED; urgency=medium
+
+ * New upstream release
+
+ -- Scott Kitterman Sat, 08 Apr 2023 00:06:57 -0400
+
spf-engine (3.0.3-1) unstable; urgency=medium
* New upstream release
diff -Nru spf-engine-3.0.3/PKG-INFO spf-engine-3.0.4/PKG-INFO
--- spf-engine-3.0.3/PKG-INFO 1969-12-31 19:00:00.0 -0500
+++ spf-engine-3.0.4/PKG-INFO 1969-12-31 19:00:00.0 -0500
@@ -1,6 +1,6 @@
Metadata-Version: 2.1
Name: spf-engine
-Version: 3.0.3
+Version: 3.0.4
Summary: SPF (Sender Policy Framework) processing engine for Postfix policy
server and Milter implemented in Python.
Keywords: Postfix,Sendmail,milter,spf,email
Author-email: Scott Kitterman
diff -Nru spf-engine-3.0.3/spf_engine/__init__.py
spf-engine-3.0.4/spf_engine/__init__.py
--- spf-engine-3.0.3/spf_engine/__init__.py 2023-02-19 19:30:53.016298500
-0500
+++ spf-engine-3.0.4/spf_engine/__init__.py 2023-04-07 22:36:19.567618000
-0400
@@ -40,7 +40,7 @@
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
'''
-__version__ = "3.0.3"
+__version__ = "3.0.4"
import syslog
import os
diff -Nru spf-engine-3.0.3/spf_engine/policyd_spf.py
spf-engine-3.0.4/spf_engine/policyd_spf.py
--- spf-engine-3.0.3/spf_engine/policyd_spf.py 2022-12-01 21:07:37.670749200
-0500
+++ spf-engine-3.0.4/spf_engine/policyd_spf.py 2023-04-07 20:44:54.125643300
-0400
@@ -94,7 +94,10 @@
elif configData.get('Hide_Receiver') != 'No':
data['recipient'] = ''
elif data.get('recipient') != 'none':
-data['recipient'] = data.get('recipient').split('@')[1]
+try:
+data['recipient'] = data.get('recipient').split('@')[1]
+except IndexError:
+pass # local recipients may not be fully qualified, so no
"@".
if debugLevel >= 3: syslog.syslog('Config: %s' % str(configData))
# run the checkers {{{3
checkerValue = None
