Bug#1034081: openbgpd: FTBFS twice in a row: src/bgpd/parse.c cannot be regenerated

2023-04-16 Thread Marco d'Itri
On Apr 08, Andreas Beckmann  wrote:

> Justification: fails to build from source twice in a row
This can be fixed by adding a build-dependency on yacc.

> openbgpd/experimental fails to build twice in a row. (I haven't checked
> whether the version in sid has the same problem.)
It does: should I bother requesting a freeze exception for this?

> The first build succeeds, a subsequent make distclean deletes
> src/bgpd/parse.c:
Indeed. The openbgpd upstream source packages are inconvenient because 
they contain generated files, but then distclean deletes them.
I would like to delete the generated files at build time to make sure 
that I do not make this mistake again, but it is not trivial since the 
Makefile does not exist until configure is run.
Is there an established design pattern for this situation?

-- 
ciao,
Marco


signature.asc
Description: PGP signature


Bug#1034081: openbgpd: FTBFS twice in a row: src/bgpd/parse.c cannot be regenerated

2023-04-08 Thread Andreas Beckmann
Source: openbgpd
Version: 7.9-1
Severity: serious
Tags: ftbfs
Justification: fails to build from source twice in a row

Hi,

openbgpd/experimental fails to build twice in a row. (I haven't checked
whether the version in sid has the same problem.)

The first build succeeds, a subsequent make distclean deletes
src/bgpd/parse.c:

...
Making distclean in src/bgpd
make[2]: Entering directory '/build/openbgpd-7.9/src/bgpd'
test -z "bgpd.8 bgpd.conf.5 parse.c" || rm -f bgpd.8 bgpd.conf.5 parse.c
...

the following dpkg-source reports the file as missing :

 dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: verifying ./openbgpd_7.9.orig.tar.gz.asc
dpkg-source: info: building openbgpd using existing ./openbgpd_7.9.orig.tar.gz
dpkg-source: info: building openbgpd using existing 
./openbgpd_7.9.orig.tar.gz.asc
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: warning: ignoring deletion of file ltmain.sh, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file Makefile.in, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file aclocal.m4, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file configure, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file src/bgplgd/Makefile.in, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file src/bgpctl/Makefile.in, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file src/bgpd/parse.c, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file src/bgpd/Makefile.in, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file compat/Makefile.in, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file include/Makefile.in, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file m4/lt~obsolete.m4, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file m4/ltversion.m4, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file m4/ltsugar.m4, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file m4/ltoptions.m4, use 
--include-removal to override
dpkg-source: warning: ignoring deletion of file m4/libtool.m4, use 
--include-removal to override
dpkg-source: info: building openbgpd in openbgpd_7.9-1.debian.tar.xz
dpkg-source: info: building openbgpd in openbgpd_7.9-1.dsc

but the second build fails:

...
/bin/bash ../../ylwrap parse.y y.tab.c parse.c y.tab.h `echo parse.c | sed -e 
s/cc$/hh/ -e s/cpp$/hpp/ -e s/cxx$/hxx/ -e s/c++$/h++/ -e s/c$/h/` y.output 
parse.output -- yacc
../../ylwrap: line 175: yacc: command not found
make[2]: *** [Makefile:1148: parse.c] Error 127
make[2]: *** Waiting for unfinished jobs
make[2]: Leaving directory '/build/openbgpd-7.9/src/bgpd'
make[1]: *** [Makefile:401: all-recursive] Error 1
make[1]: Leaving directory '/build/openbgpd-7.9'
dh_auto_build: error: make -j3 returned exit code 2


Shouldn't that file be deleted and regenerated during a regular build,
too?


Andreas


openbgpd_7.9-1_twice.log.gz
Description: application/gzip