Bug#1034511: apt-cacher-ng: Cron job does not delete old log.html.xz files

[richardn]

Package: apt-cacher-ng
Version: 3.7.4-1+b2
Severity: normal
X-Debbugs-Cc: richard...@gmail.com

This line in the apt-cacher-ng daily cron job does not actually delete any 
'maint_*.log.html.xz' files

        find /var/log/apt-cacher-ng -maxdepth 1 -name 'maint_*.log.html.xz' -or 
-name 'maint_*.log.html' -type f -user apt-cacher-ng -mtime +10 -delete

The find manpage under NON-BUGS "Operator precedence surprises" explains why 
this does not work.

Brackets with quotes are needed e.g.

        find /var/log/apt-cacher-ng -maxdepth 1 \( -name 'maint_*.log.html.xz' 
-or -name 'maint_*.log.html' \) -type f -user apt-cacher-ng -mtime +10 -delete

Alternatively the " -or -name 'maint_*.log.html'" can be completely omitted, 
leaving

        find /var/log/apt-cacher-ng -maxdepth 1 -name 'maint_*.log.html.xz' 
-type f -user apt-cacher-ng -mtime +10 -delete

as the next line in the cron job compresses all 'maint_*.log.html' files older 
than 5 days anyway


-- Package-specific info:

-- System Information:
Debian Release: 12.0
  APT prefers stable-security
  APT policy: (500, 'stable-security'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-7-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages apt-cacher-ng depends on:
ii  adduser                    3.132
ii  debconf [debconf-2.0]      1.5.82
ii  dpkg                       1.21.21
ii  libbz2-1.0                 1.0.8-5+b1
ii  libc-ares2                 1.18.1-2
ii  libc6                      2.36-8
ii  libevent-2.1-7             2.1.12-stable-8
ii  libevent-pthreads-2.1-7    2.1.12-stable-8
ii  libfuse2                   2.9.9-6+b1
ii  libgcc-s1                  12.2.0-14
ii  liblzma5                   5.4.1-0.2
ii  libssl3                    3.0.8-1
ii  libstdc++6                 12.2.0-14
ii  libsystemd0                252.6-1
ii  libwrap0                   7.6.q-32
ii  lsb-base                   11.6
ii  sysvinit-utils [lsb-base]  3.06-4
ii  zlib1g                     1:1.2.13.dfsg-1

Versions of packages apt-cacher-ng recommends:
ii  ca-certificates  20230311

Versions of packages apt-cacher-ng suggests:
ii  avahi-daemon  0.8-9
pn  doc-base      <none>

-- Configuration Files:
/etc/apt-cacher-ng/security.conf [Errno 13] Permission denied: 
'/etc/apt-cacher-ng/security.conf'

-- debconf information:
  apt-cacher-ng/port: keep
  apt-cacher-ng/proxy: keep
  apt-cacher-ng/bindaddress: keep
  apt-cacher-ng/gentargetmode: No automated setup
* apt-cacher-ng/tunnelenable: false
  apt-cacher-ng/cachedir: keep