severity 1035947 normal
thanks
This would be serious if it failed to build with the sources in the
Debian archive, which is what counts.
Note that using uscan doesn't get you all the sources.
On Thu, May 11, 2023 at 10:32:40AM -0400, Antoine Beaupre wrote:
> Source: firefox
> Severity: serious
> Tags: patch ftbfs
> Justification: fails to build from source (but built successfully in the past)
>
> I'm trying to build Firefox 113 from the git repository. I have pulled
> the package with:
>
> debcheckout firefox
>
> Then tried to download the latest tarballs with:
>
> uscan --download-current
>
> This crashes with a Python exception:
>
> anarcat@angela:firefox$ uscan --download-current
> Newest version of firefox on remote site is 113.0, specified download version
> is 113.0
> uscan warn: Possible OpenPGP signature found at:
>
> https://archive.mozilla.org/pub/firefox/releases/113.0/source/firefox-113.0.source.tar.xz.asc
> * Add opts=pgpsigurlmangle=s/$/.asc/ or opts=pgpmode=auto to debian/watch
> * Add debian/upstream/signing-key.asc.
> See uscan(1) for more details
> Successfully symlinked ../firefox-113.0.source.tar.xz to
> ../firefox_113.0.orig.tar.xz.
> Traceback (most recent call last):
> File "/home/anarcat/dist/firefox/debian/repack.py", line 217, in
> main()
> File "/home/anarcat/dist/firefox/debian/repack.py", line 205, in main
> if not new_file:
>
> UnboundLocalError: cannot access local variable 'new_file' where it is not
> associated with a value
> uscan: error: python3 debian/repack.py --upstream-version 113.0
> ../firefox_113.0.orig.tar.xz subprocess returned exit status 1
> anarcat@angela:firefox[1]$
>
> I believe the following patch fixes the issue somehow:
>
> diff --git i/debian/repack.py w/debian/repack.py
> index 00d20928f6e..4f04ea200fb 100755
> --- i/debian/repack.py
> +++ w/debian/repack.py
> @@ -199,6 +199,8 @@ def main():
>
> if options.new_file:
> new_file = options.new_file
> +else:
> +new_file = None
>
> if os.path.islink(args[0]):
> orig = os.path.realpath(args[0])
>
> a.
>
> -- Package-specific info:
>
>
> -- Addons package information
>
> -- System Information:
> Debian Release: 12.0
> APT prefers testing-security
> APT policy: (500, 'testing-security'), (500, 'testing-debug'), (500,
> 'stable-security'), (500, 'testing'), (500, 'stable'), (1, 'experimental'),
> (1, 'unstable')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 6.1.0-8-amd64 (SMP w/16 CPU threads; PREEMPT)
> Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8), LANGUAGE not
> set
> Shell: /bin/sh linked to /usr/bin/dash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled
>
> -- no debconf information
>
